GitLab

This reverts commit 269e59a8.

Reason for revert: Failures on Debug build try jobs:
https://ci.chromium.org/p/chromium/builders/try/android-pie-arm64-dbg

Original change's description:
> Android: Add Monochrome32 and Trichrome32 build targets
>
> This change adds a pure 32-bit version of Monochrome and Trichrome to
> the 64-bit build configuration. Building these targets generates a
> product equivalent to building the targets on a 32-bit config. However,
> by adding these, we have the option of building all Monochrome and
> Trichrome products on a single 64-bit builder, and, we share the
> compilation work (as opposed to the obsolete process of "APK merging"
> parts from a 32-bit build into 64-bit products).
>
> The targets added here are the public versions.
>
> Bug: 1027573
> Change-Id: Id5ffd698721077e8fffb1f8206adc0b7b1fce212
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960575
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Commit-Queue: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#723897}

TBR=torne@chromium.org,cjgrant@chromium.org,estevenson@chromium.org

Bug: 1027573
Change-Id: I192ff6511e17c745ecadcf4a8ecfdddf40967bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974000Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726117}

Change-Id: Ia1f87b0479a92d9f57d4261379044baa13f574b6
Bug: 1035171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974530Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Amy Huang <akhuang@google.com>
Cr-Commit-Position: refs/heads/master@{#726116}

https://skia.googlesource.com/skia.git/+log/0d7e2f158e9b..f64e958e897a

git log 0d7e2f158e9b..f64e958e897a --date=short --first-parent --format='%ad %ae %s'
2019-12-18 kjlubick@google.com Properly free bytes in SkDescriptor fuzzer
2019-12-18 bsalomon@google.com Make sure random unit test processors use an alpha type compatible with
2019-12-18 mtklein@google.com disable warnings in ANGLE
2019-12-18 mtklein@google.com Revert "roll clang_win"

Created with:
  gclient setdep -r src/third_party/skia@f64e958e897a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC borenet@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: borenet@google.com
Change-Id: Ia47b6ac174befcef3ac9bfb5038ade27fcc7b58b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974635Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726115}

A follow-up cl will pipe this information through to NavigationHandle.

Bug: 1016325
Change-Id: Ie82abc6ca072a0354f06dddb5dbf04715599cf21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953511Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#726114}

We accidentally broke altgr for rule-based inputs in [1] because we
looked at the "altgr" attribute of the keypress info, which is only
filled by the VK and not the PK.

For the PK, AltRight is always treated as AltGr, so we add that logic
back in.

We add a test to prevent this from happening again.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1837312

Bug: 1035145
Change-Id: I64d3d56b08c8cd2a82c4617f63a3c6f34444f36a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971638Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726113}

This allows us to remove some redeclared classes like TabGroupMetadata. It also gives greater flexibility and readability when creating more Tab Group types (such as TabGroupColor in the followup change).

Change-Id: I5767f6868c202c37550fa2a9e62e565a87ea5686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967128Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726112}

BUG=787254
R=guidou@chromium.org

Change-Id: I642e78ab921ab119b9cb6f4643b03aea00ee975f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969691Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#726111}

Apply an app:tint to the icons in the sharing hub, so they correctly
change color when the system is in dark mode.

screenshot: http://screen/zsopm5J1Tg1.png

Bug: 1009124
Change-Id: I4fbf93959829ca570aa5c0b33837ab017e5744a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974694Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726110}

The modification timestamp ensures files can't be read after they are
modified, so make sure it is actually passed along and used when uploading
a file. On its own this change doesn't actually fix anything, since the
timestamp that is passed around isn't always set yet, so for nearly most
cases this CL will have no immediate effect. Separate
CLs will make sure the timestamp is set properly in the first place.

Note that even then, we still trust the renderer process to decide if it
should be allowed to upload a file after the file was modified; ideally we'd
further refactor the network side code to instead check the snapshot state
in the browser process, but that is a much more involved change.

Bug: 844874, 818327
Change-Id: I838d0b6996857ee691fee5b9162c75f8b2ca99c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968113Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726109}

|verified_sync_tokens_required| was set false as a performance
optimization when the display compositor and browser UI shared a command
buffer. This never happens anymore outside of tests so it can be
removed.

TBR=liberato@chromium.org

Bug: 869250
Change-Id: I0d9ae641d3d201061d6326982af04f4fb5262a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972780
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726108}

This covers removal of deprecated base::Bind, base::Callback,
base::Closure, base::Passed across the following components/
subdirectories:

- components/sync_sessions/
- components/translate/
- components/update_client/

Fixed: 1007743,1007746,1007748
Change-Id: Ie8d5c8267ac125b903ba04443d031e8134122dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970293Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#726107}

This CL also updates a number of existing tests to re-enable FTP via
explicitly enabling the kFtpProtocol feature. Unrelated tests will
continue to be run with FTP disabled.

Affected tests are exercising FTP specific functionality which will also
go away when FTP is deprecated.

Bug: 333943
Change-Id: I8dea73bc825011bff1d3fef46194b8ca43e2fc27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966279
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726106}

This reverts commit 630672d6.

Reason for revert: attempts to extract linux build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/20794

Original change's description:
> Make Mac10.X Tests builders into thin testers
> 
> This will free up a small amount of Mac hardware which can be
> used elsewhere. It also creates a template for other OSes with
> builder/tester splits to follow.
> 
> We know that this works because the mac-osxbeta-rel CI builder
> already does this (as can be seen by the smaller diff in its
> generated config).
> 
> Bug: 1003062
> Change-Id: Iecdb68404dd3ae16eabfc657981f0e82478a040a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974510
> Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#726077}

TBR=agable@chromium.org,martiniss@chromium.org,gbeaty@chromium.org

Change-Id: Ide3b7335f67e1b48cbaf0cb1a9c69ce4211c0f33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1003062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974614Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726105}

No logic changes.

Change-Id: I3f35d7e149f6ffef9cc561c57250eeeacdf603f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973193
Commit-Queue: Stefan Zager <szager@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726104}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99420bb95152..bd51b1d1e98f

git log 99420bb95152..bd51b1d1e98f --date=short --first-parent --format='%ad %ae %s'
2019-12-18 brgoddar@microsoft.com Coverage: Update URL cell in datagrid screen reader label to full url

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@bd51b1d1e98f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:963183
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I26fddc6979b83be637e560f5b3627388f2c8fb41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974633Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726103}

BUG=963574
R=guidou@chromium.org

Change-Id: Ie7e76a2fc0e65ddeb53b6af5b12883a4f2994aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969690
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726102}

Test is flaky on Mac and Windows. Disable it on those platforms.

Bug: 1035062
Tbr: dbertoni@chromium.org
Notry: True
Change-Id: Id556b0cde7e9ca26a3b4b3e0fac244f794427010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974577Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726101}

Bug: 1026455
Change-Id: I2475481ecc6d0b93c614cb53413534ea38dc1267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974536
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726100}

The new test expectations format only allows one space between
the specifier list and the test name. It also allows only one space
between the test name and the expectations list.

Bug: 986447
Change-Id: Iced71e58de9d8ad8df2d4b29466a03516c93443d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974752Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726099}

Nothing in production should rely on InProcessCommandBuffer creating its
own SharedContextState. If one is required, it must be obtained from the
task executor and thus shared with other contexts.

Just remove the code and fail init if SharedContextState is null when it
is required.

Change-Id: I7de905182c8127d17907caff4bfd005182037b15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970135Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726098}

Using a shared, per-StoragePartition URLLoaderFactory is incompatible
with the desire to have per-factory control of CORB and CORS exceptions
(tracked by https://crbug.com/936310).  In particular, without the
current CL, the WorkerTest.WorkerInBackgroundPage from browser_tests
would fail after a follow-up https://crrev.com/c/1925354.

The problem is that content::WorkerScriptFetchInitiator::Start sets
mode = network::mojom::RequestMode::kSameOrigin and expects that
extension permissions will relax CORS/same-origin requirements.
To ensure that extension permissions are still taken into account after
removing global OriginAccessList, we need to make sure that
WorkerScriptFetchInitiator uses an origin-specific URLLoaderFactory
(rather than a shared, per-StoragePartition factory).  This is exactly
what this CL does.

Bug: 936310
Change-Id: I79c8d0d54404cb8b572b4c1a1195fa88333f0590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962599
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726097}

Bug: 1032236
Change-Id: I5f80fb7c33158e39b17ff0947f1fa239929815b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958808
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ender <ender@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726096}

Bug: 1009124
Change-Id: I083464bcae4f431bcb094aed4d9e4edc0d670eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959398Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726095}

https://android.googlesource.com/platform/external/perfetto.git/+log/5bddc336299d..61e3d1746f00

git log 5bddc336299d..61e3d1746f00 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 treehugger-gerrit@google.com Merge "perfetto-ui: Open HTML traces with legacy viewer"

Created with:
  gclient setdep -r src/third_party/perfetto@61e3d1746f00

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I804fbbcb5d1526aad02b5566a19d137cfe4fd15e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974474Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726094}

Using wpt-import in Chromium 25abdbcd.
With Chromium commits locally applied on WPT:
c15c1083 "Add test that datachannels close when connection does."
fadf6027 "[css-pseudo] Recalculate viewport units in ::marker"
044ad8ad "[OT-PW] Make it work with OOP-R"
2ad15546 "Make interpolation-testcommon.js support composition"
9899425d "[css-layout-api] IntrinsicSizes Implementation"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ie31543516d0c08fe3915334961382cc967447615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973996Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726093}

Conflicting CLs landed around the same time causing the
ChromeOS build breakage.

Notry: True
Bug: None
Change-Id: If5b733792bdce60fca7de10e150dee7d1aa29ee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974702
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726092}

This reverts commit f64bee44.

Reason for revert: Breaks OOBE in chrome-linux build and introduces
delay on device.

Original change's description:
> Apply preserve-focus to network-list.
>
> This is a more robust method of re-applying focus to an
> iron-list after the underlying data changes.   The current
> method breaks during oobe and updates the list more often
> than needed.
>
> Bug: 1031994, 1032265
> Change-Id: Ibc115fa099f80c1da0fd872f00a84472b9ff8c20
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966581
> Commit-Queue: Jon Mann <jonmann@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#725421}

TBR=khorimoto@chromium.org,jonmann@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1031994, 1032265
Change-Id: Ic019bcedd5fbea0478203dc12edd4e10e9e57dd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974533
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726091}

Caption buttons on most platforms stay on the leading edge of the
tabstrip in RTL mode, which effectively means they switch sides.

This is not true on Mac 10.10 and 10.11, however. Unfortunately, this
change is not reflected in the logic, which means the tabstrip still
renders in RTL on those platforms as if the caption buttons are on the
right (leading) side rather than the left (where they actually are).

This change makes the following functions behave correctly on MacOS
10.10 and 10.11:
 - BrowserNonClientFrameViewMac::CaptionButtonsOnLeadingEdge()
 - BrowserNonClientFrameViewMac::GetBoundsForTabStripRegion()

Bug: 891311
Change-Id: I3ad3d190cab805b3960a4920b48069f3d4e782c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972930Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726090}

https://swiftshader.googlesource.com/SwiftShader.git/+log/ff3d55c60356..e82d88538072

git log ff3d55c60356..e82d88538072 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 sugoi@google.com Allow 32F texture to use linear filtering
2019-12-18 capn@google.com Remove sw::Vector, Point, and Matrix

Created with:
  gclient setdep -r src/third_party/swiftshader@e82d88538072

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ib868e209706e157299f769a20de656702632595a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974472Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726089}

To be just "android_manifest", in order to match the name used
for this in other templates.

Change-Id: I6f7a5bf74c8257d82bc94da3622f1588d0769962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974471
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726088}

This specific hack, which forces a WindowServer shadow update by
resizing a window briefly, is the current leading suspect in issue
899286.

Here are the hard facts we have:
1) 899286 is a WindowServer crash caused by software-compositing of
   layers for window shadows in response to a window resize
2) This hack is forcing WindowServer to rebuild shadows when it
   ordinarily wouldn't by synthesizing a window resize

The coincidence is pretty strong here, so let's speculatively disable
this hack when running headless (i.e. under test).

Bug: 899286
Change-Id: I26c9cbddef08d7213a3f545de5e666cd2307d93d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974513Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726087}

Apply gn format to all *.gn and *.gni files in //chrome.

This version of gn now automatically sorts all lists with variable
names ending in the suffix "sources" or "deps".

Bug: 1033668
Change-Id: I01dd27153eddaa4e88257f4c4d0225a3c2a7f56f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970281Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726086}

With deferral enabled a canvas rendering context can create an
unlimited amount of GPU resources between frames. This class allows us
to track how much memory is being pinned and to flush the recording
after we pass a certain threshold.

Bug: 1016727, 1015729
Change-Id: I3a64dc07cc0239447aa721ea2a7cc808541a0a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960469Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726085}

In this CL, cache_manager is introduced to safe_browsing_url_check via
chrome_content_browser_client. It must be not null when real time url
check is enabled and the profile is not deleted.

Cache is checked and stored on UI thread. url_checker doesn't own
cache_manager, so it uses a weak pointer to access it. Weak pointers
can only be accessed from the same thread it is created.

If cache_manager is able to get a valid matching verdict from the url,
regardless of whether the verdict type is safe or dangerous, it will
skip sending pings and use that verdict type as the check result.

More information can be found in go/chrome-protego-cache.

Bug: 1030989
Change-Id: I1195c4777a10de5356078746dc07119f1b0e04c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963409
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726084}

The surface aggregator when computing the damage rect for a surface
tree, computes a bounding box of all the render pass with backdrop
moving filter. It then uses this bounding box to increase the damage
rect of the root render pass. This causes a larger than needed damage
rect to be set. This patch changes the bounding box logic to that of a
list of rects. The damage rect is then expanded based on if it
intersects with a rect in that list.

      Also added unittests.

Bug: 1031914
Test: Manually tested that partial swap now gives correct damage rect.
Change-Id: I4eb8ff29170ddebfa8be79e9fd885551828af0e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965475
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726083}

Bug was caused by us correctly adding the aspect ratio clipping, but
after a reposition of the windows, the clipping required for windows
with top insets would be set and override the aspect ratio clipping.

This patch adds a boolean so the overriding does not happen. A follow
up fix will be sent out later to address the specific workflow in the
bug, but this fixes a lot of other issues for now.

Test: added
Change-Id: I142c2f5530d06a47839ee36a65bf77684d3940b1
Bug: 1035186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972298Reviewed-by: Avery Musbach <amusbach@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726082}

Bug: 1030840
Change-Id: I5cc64282e9405935686cbb9b6d249fd4d3d462e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974393
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726081}

Bug: None
Change-Id: I09cf3cf2c5137d39616f2c42480a8df700385db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956238
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dan S <danan@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726080}

Restore the recent printer prefetching behavior that was removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1607133 :
don't display printers in the dropdown until their capabilities have
successfully been retrieved from the backend.

Also adds a test to verify that if a recent printer's capabilities are
not fetched successfully, the printer does not appear in the dropdown.

Note that printers will still be cached in the recent destinations
until the user selects new recent printers that override them, but
will not be displayed unless they are actually available. This so that
if a frequently used printer is temporarily unavailable, it will
still re-appear in the dropdown in future Print Preview sessions when
it becomes available again.

Bug: 1007614
Change-Id: Ia7eca78631094ca29bb1e9b43998fe8a6d35966e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966585Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726079}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a02676614519..b65f3282baa9


Created with:
  gclient setdep -r src-internal@b65f3282baa9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1030991
Tbr: jbudorick@google.com
Change-Id: I622b6002e9fb663bc939dc72b6211b60c1ab84ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974473Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#726078}