- 16 Sep, 2020 40 commits
-
-
Seokho Song authored
Currently, PaintPropertyTreeBuilder makes an issue about z-order with 3D transform operations such as trasnalteZ(). So we need to check this issue on the tests whether wrong results or not. In this patch, a test will check if rendered correctly. Now it would be expected '[Failure]' It will remove the expectation when we fix the issue Bug: 1116358 Change-Id: I8f5be9e1ed186df1e779cf9e8a7f0462e079232b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409476 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807332}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e4642dac6c25..b10d4a612b87 2020-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 235f7418..dfb9023b (807145:807259) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9ea7ad06d2bc6d1c154d7422513a07bc7a28f541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807331}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60b89e50eba2..d1be45d6b6ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yoichio@google.com Change-Id: Id530ec4c9fa15ac97373c0a86de96c8107505ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413296Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807330}
-
tby authored
Add the skeleton for a new Drive zero-state provider, to eventually replace the existing DriveQuickAccessProvider once it's finished. Currently this does nothing and is unused, but will be expanded in follow-up CLs. The skeleton includes some bits of logic we'll need copied over from the DriveQuickAccessProvider, including a check for the suggested files flag and two weak pointer factories. Bug: 1034842 Change-Id: Idc0883bcf5456cb2e0c1df2e838d6991eb43e458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410142 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#807329}
-
Kent Tamura authored
This directory has no errors now. This CL has no behavior changes. Bug: 800764 Change-Id: I84ec665b1e48e416ace523ac88b788cc1900b4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412114 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#807328}
-
Darren Shen authored
Add a new method to determine whether a feature flag is enabled or not. Unfortunately, Chrome doesn't allow us to query feature flags by raw name, only by base::Feature values. Hence, the API must use an enum instead to represent the feature, and the implementation needs to map the enum to a base::Feature value. Add a feature to the enum as an example. Bug: 1019541 Change-Id: I7e6274b70e7ba13c9bcc9dd0ee1fe3117614d06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397304 Commit-Queue: Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#807327}
-
Lingqi Chi authored
ExecutionContent-scoped BIB Migrated PeriodicBackgroundSyncService interface; let it be obtained via an ExecutionContent-scoped BrowserInterfaceBroker instead of a Process-wide one. Then it can be controllable when prerendering a page. Bug: 1126758 Change-Id: I8749d3bc6874ba5c04eb984642f9f1734dc8048f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412055 Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#807326}
-
Avi Drissman authored
The stack sampler is broken for now on Arm Macs, so disable a failing v8_unwinder unit test too. Bug: 1102197, 1128464 Change-Id: Ie0091eb8efc7a96d4f917ed394585e1b6595c7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413023Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807325}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0063ad80f210..511a82c95fc7 2020-09-16 heiserya@google.com Improve debugability of WPR when running record_wpr or run_benchmark. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: zhanliang@google.com Change-Id: I69e0d50f311d7db35fe417731d46b6c6f04b647c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412766Reviewed-by:
-
Minoru Chikamune authored
Send message through AgentSchedulingGroup instead of RenderProcessHost. Bug: 1111231 Change-Id: I24bc55d05a18da9e3f1d7eef64f593cb2b7c0e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409394Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#807323}
-
Risan authored
Adapted from youkichi@'s prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2275514/14 The change is simpler now after we split removable watchers to per media watcher. BUG=b:163951541 TEST=The images are indexed with UUID in Photos. Change-Id: I42873445e9fb71947d029140fa9bcc4b512e8995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409724Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807322}
-
Glen Robertson authored
Changes are: - adding deps when missing. - adding "nogncheck" when needed (see below explanation). - deleting nonexistent files from sources. - new target :net_dns_access for files that depend on //net/dns:host_resolver (which has restricted visibility). Alternative: could open visibility to all of //chrome/browser instead of adding a new target that has visibility. - moving //c/b:test_support sources to //c/b/chromeos:test_support or //c/test:test_support when they depended on headers there (cannot add a dependency, there is a cycle). - moving includes to conditional sections when they are used only in conditional sections (where it caused deps issues). - removing unused includes of test code from non-test code. - merging sections in //c/b/BUILD.gn that had the same if() conditions. Alternative: revert these changes, they are cosmetic. - adding some asserts/conditional blocks in build files that only work under those conditions. "gn check" does not understand #if statements in cc/h files so it complains about missing deps in configurations where those deps were never actually included. "nogncheck" has been added to the include lines to suppress these spurious errors where necessary (sometimes it is not necessary because the include is used outside of #if statements in other files). Bug: 898837, 1125897 Change-Id: I77e7dd3780fb93edb2b555a82b681a870990b496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383400Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#807321}
-
about://flagsCharlene Yan authored
Bug: 1128703 Change-Id: I2769ea96b8982fdb3b777eebc97b558217fa7ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413109 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#807320}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/53747dfe65ea..97356acb50e2 $ git log 53747dfe6..97356acb5 --date=short --no-merges --format='%ad %ae %s' 2020-09-13 joelaf vp8: Remove sched_yield on POSIX systems 2020-09-10 sarahparker googletest: enable failure on uninstantiated tests 2020-09-09 sarahparker Upstream GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST 2020-05-11 marpan vp9-rtc: Add control to disable maxq on overshoot 2020-08-17 dcsommer Escape number sign in Makefiles 2020-08-15 jinbo-hf Refine MMI & MSA detection for mips Created with: roll-dep src/third_party/libvpx/source/libvpx R=jzern@google.com Bug: b/168205004 Change-Id: I60a8471b89aea1c8e6ab63354f75b5dc9f10f4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410644 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#807319}
-
Sammie Quon authored
See screen cast in bug comment 1 for a video of what is included and not included in this CL. Included: - Dragging to select a region - After first drag, fine tuning via affordance circles - Button to capture region (can be reused for fullscreen and window capture) - Switching to and from capture region source Not included: - Nudge for tablet mode (see specs) - Motion/animations - Styling for buttons - Drop shadow for border and affordance circles - Partial magnifier for affordance circle presses - Cursor changes The basics of this CL is to provide a UI to select a region. The selection has two phases, a quick selection phase to quickly grab a region, then a fine tuning phase where users can resize/reposition the region with some drag affordances. For a capture region session, we add two widgets to have supporting text and buttons, and a struct that holds data needed to draw the rest of the UI onto the layer. The layer is updated when the selection region has been updated from drag events. For phase two, we use a simple formula to determine which affordance has been pressed down on, if any. If an affordance was pressed on, we allow resizing, but one or two points stay the same. These are stored in the struct as anchor points, and used to compute the new selection region when there is a drag event. Test: manual Bug: 1120132 Change-Id: If9c461d82306666cbfa9be7fcd521bd6caeec331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404945Reviewed-by:Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#807318}
-
Lingqi Chi authored
ExecutionContent-scoped BIB Migrated OneShotBackgroundSyncService interface; let it be obtained via an ExecutionContent-scoped BrowserInterfaceBroker instead of a Process-wide one. Then it can be controllable when prerendering a page. Also fixed an error in webtest comments to make it be in accordance with the error message. Change-Id: I94ccdc65586b895f52f02972971338926e3b63a0 Bug: 1126758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395995Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I98043309b61ae24020ae796aff44c724474fb786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413024Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807316}
-
Thomas Lukaszewicz authored
This CL removes logic that updated bubble visibility based on generic RenderFrameHost update notifications. Instead the UI will be shown when the Tab Search WebUI has notified us that the UI is ready to be shown. This eliminates stuttering caused by the bubble being shown when the initial DOM was ready, but the tab list was still loading in. Bug: 1099917 Change-Id: I40b592adcae38d6f21a60d79a0beab2d08970b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386426 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#807315}
-
Gyuyoung Kim authored
As content::WebPreferences was moved to Blink, we don't need to keep AutoplayPolicy enum in WebSettings because we can use it from WebPreferences directly. Bug: 919392, 1097943 Change-Id: Ied0db3fa771416fcc5ce35f5c0a14889dcfa0866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409690Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Id950215e11501e726bfd7578f49203fdac70481f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413113Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807313}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I7a90b696047bb1a94bfcbcc868941a1341afbe55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412764Reviewed-by:
-
Mason Freed authored
Per the spec issue [1], this change disallows the use of ElementInternals.shadowRoot for shadow roots created prior to the custom element constructor being run. This protects potentially-closed shadow roots, created outside of the custom element, from being revealed to the custom element itself. (Use case unclear, but this was the request.) [1] https://github.com/w3c/webcomponents/issues/871 Bug: 1042130 Change-Id: I25192256e8b1334d09ea587f29d64f35d4f5f949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412470 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600148958-91c0cd454c0f8748eee83f19943ecba0f6b92ac0.profdata to chrome-win64-master-1600192792-f4ca908cacd319b04516240c34a315b960a046b2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1debf74aef82c162c05a6885ec49ffb71db21a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412787Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9791e50e3da4..d9c55ce8edbb 2020-09-16 mtklein@google.com disable show-your-work bit of test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I41bd80f4666ac6468e45cfa6979f306539057ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412765Reviewed-by:
-
Sammie Quon authored
Both creaters of desk animations have a guard to stop creation of a new animation. For enhanced desk animations, we will append to an existing animation, so a vector is not needed anymore. Test: manual Bug: 1111445 Change-Id: Ic615e73cc28ac9bb1e7746782a1455c90e11a2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412687Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a follow-up CL of converting PrintHostMsg_DidGetPrintedPagesCount to mojo [1] and it updates the type for the page number and counts with uint32_t as it couldn't have a negative value. It keeps using int for JNI and dictionary values and uses 'base::checked_cast<int>' to convert uint to int. In order to make sure that the value is in the range to cast, this change also adds the maximum limit for the page number and counts and checks the value before passing it to JNI or dictionary. Given that the previous type is int, the maximum limit is std::numeric_limits<int>::max(). [1] https://crrev.com/c/2326857 Bug: 1008939 Change-Id: I5c86514be4e7d549f888c9623136078a3b0c88c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351580Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#807307}
-
Fabrice de Gans-Riberi authored
The target is missing a dependency and cannot be built in isolation. Bug: 1127044 Change-Id: I80b53f0d499e999182a2fc4daf6e24dac721b6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404741 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#807306}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b189aac83132..d48ef5f7ddc8 2020-09-16 treehugger-gerrit@google.com Merge "require_root for perfetto_integrationtests." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I233027b329a9d45839f8871a049834978e65b04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413171Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c52a95b75bb2..60b89e50eba2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1126981,chromium:1128306 Tbr: yoichio@google.com Change-Id: I517c5b7b926fa8aba7e36236b0e2cf3ea60445a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413170Reviewed-by:
-
John Lee authored
This CL adds a context menu item labeled 'Copy link to text'. The menu is behind a flag, is currently disabled and currently does nothing. This CL is to mainly get the string in first, and will be completed soon. Bug: 1105862 Change-Id: I467786eabf878165c7c9f1aab9b2eac8b6e81068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410814Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#807303}
-
Liquan (Max) Gu authored
Change: * Move part of PRImpl#initAndValidate() into CPRImpl#initAndValidate() * Since the move of initAndValidate() involves Delegate.getInvalidSslCertificateErrorMessage(), PRImpl.Delegate is moved into CPRImpl becoming CPRImpl.Delegate. * Since the move of initAndValidate() involves mPaymentOptions and mRequestShipping, etc., they are duplicated in ComponentPaymentRequestImpl. This duplication is necessary because PRImpl and CPRImpl may lose access to each other, and is without the out-of-sync issue because mPaymentOptions is final. * Since the Delegate depends on ChromeActivity, the ChromeActivity dependencies is refactored to WebContents dependencies. * Simplifies Delegate#isOffTheRecord(), Delegate#isWebContentsActive(), Delegate#getTwaPackageName() because they don't need to rely on a WebContents/ChromeActivity parameter. Bug: 1102522 Change-Id: I62bb66ff7c799020c973394102f57c33c3d0392a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401783 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#807302}
-
Antonio Gomes authored
This CL moves audio_renderer_sink_cache.h temporarily to third_party/blink/public/web/modules/media/. The declaration of its ObserveFrame() static method is also temporarily moved to audio_renderer_sink_cache_impl.h. This step corresponds to phase 2.2 in the design doc [1]. [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80/ BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: I0757c99a4c30e792ca61c9d1c8a3f8acc01aea26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412133 Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#807301}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/377e748714bf..1520b4d0fe34 2020-09-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f8a5602c5560 to 9eaa69c21c45 (3 revisions) 2020-09-15 timvp@google.com Android: Set angle_enable_commit_id=false in roll_aosp.sh If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Test: Test: Manual verification in AOSP checkout Change-Id: I226c0888fc80cd6355fda2c3711a423d8b5e7127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412954 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Juanmi Huertas authored
Temporarily disabling canvas fuzzer to further investigate some false positives and a time out. Bug: 1124824, 1128300, 1124812 Change-Id: Ib3a186f3695fedf86bed9f57b77c2dcd583c7e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410287 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#807299}
-
Russell Davis authored
This fixes a couple things: 1) Ensures that match counts and highlighting always appear (see https://crbug.com/1124605). Another manifestation of this issue: if you search for something, then hit ESC, then click on the page to clear the selection, then hit Cmd-F, none of the search results will be highlighted, and the text in the search bar will still indicate the previous state (e.g. "3/8"). 2) Prevents the page from scrolling if there are off-screen matches. Simply opening the find bar should never cause the page to scroll — that can be confusing and disorienting, especially when you don't want to search for whatever is prefilled (e.g. the selection, or the global pasteboard on macs). With this change, the |find_next_if_selection_matches| option added at https://chromium-review.googlesource.com/c/chromium/src/+/2181570 is no longer needed, because we no long jump to the first match when opening the find bar with a selection. But it will still be highlighted, and find-next / find-previous work just like before, so there's no loss of functionality. Bug: 1124605 Change-Id: Ib82f9103cefb84c511b9fe2e4406e97256ed5564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404277 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807298}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I717b1cb5328dc4790dd1206d8aeb5ca2c5621e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413169Reviewed-by:
-
Robert Ma authored
so that FindIt can route the bugs correctly. Change-Id: If722f7ecd78b9eb918d2a79253e9b0d4df6be06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398723 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#807296}
-
Matt Wolenetz authored
The upcoming CrossThreadMediaSourceAttachment's implementation for attachment start will not return a MediaSourceTracer, since making that work in a Member<> in multiple Oilpan heaps is incompatible with the existing synchronous behavior for StartAttachingToMediaElement(). This change instead allows the resulting tracer to be nullptr even if there was a successful attachment start. HTMLMediaElement and the underlying attachment implementation are updated to use/implement this updated method, respectively. BUG=878133 Change-Id: Iedaf0b57a08b4437f3a34279b8e9d3c1c78262a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406956 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#807295}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ae073e44336f..e4642dac6c25 2020-09-15 joedow@google.com Updating the OWNERS file for desktop capture 2020-09-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5aa7e239..235f7418 (807011:807145) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3de759a72ac182acb9e0ba284bcac1c543b4046a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412966Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I9ca8d0969017148f574fe3adcb4dcc7aa3da7b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413168Reviewed-by:
-
