- 12 Dec, 2017 39 commits
-
-
Mehran Mahmoudi authored
Per UI Review's comment, this CL removes the use of BarBanner for an In-Product Help for Contextual Search scenario, and replaces it with the more familiar TextBubble. Discussion: https://groups.google.com/a/google.com/d/msg/chrome-ui-review/2_I2G2yqLUI/s2AnV5WABwAJ Bug: 794013 Change-Id: I3b76aadac1dbe5981fb5b3d5fca989ca11157a21 Reviewed-on: https://chromium-review.googlesource.com/821411Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523299}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/2326177e3499..5ca9413b9bc1 $ git log 2326177e3..5ca9413b9 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 rmistry [Bookmaker bot] Output fiddleout.json earlier and do not send to CQ for now 2017-12-08 halcanary resources: optionally link them into our binary 2017-12-11 bsalomon Rename GrGLAssembleFooInterface to GrGLMakeAssembledFooInterface. 2017-12-11 caryclark working on image and nightly housekeeping bot 2017-12-11 fmalita Fix fuzzer crash in SkReadBuffer::readTypeface() 2017-12-11 angle-deps-roller Roll skia/third_party/externals/angle2/ 9b88991c7..c7abc0803 (1 commit) 2017-12-11 bsalomon Fix Google3 link errors(?) 2017-12-11 brianosman Filter Windows SDK and Compiler directories 2017-12-11 benjaminwagner Re-add '--gpuThreads 0' tests. 2017-12-11 liyuqian Use first/second instead of min/max in 2pt conical gradient 2017-12-11 reed read signed 32 if we want to treat it as signed 2017-12-11 zhizhouy Turn on PGO for Skia on Android 2017-12-11 reed add virtual to confirm flattenable type 2017-12-11 borenet bin/try: No prompt for a single matching job 2017-12-11 stani Implement a fast path for solid color lattice rectangle 2017-12-11 ethannicholas fixed SkSL optimizing away side effects 2017-12-11 benjaminwagner Remove PixelC CPU jobs. 2017-12-11 bsalomon Add GrGLMakeNativeInterface factory that returns sk_sp<const GrGLInterface>. 2017-12-08 brianosman Move ImGui support code to ImGuiLayer Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I21726e20109fb8be502e9f6d812198e2b707e986 Reviewed-on: https://chromium-review.googlesource.com/820720Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523298}
-
Ovidio Henriquez authored
This change updates the discovery-succeeds.html test to use the Web Bluetooth Test interface. This will help us migrate the test to the wpt/ directory, since testRunner is not going to be used anymore. BUG=509038 Change-Id: Id5d7d72e100c2d477d4690090b715eb549dfad99 Reviewed-on: https://chromium-review.googlesource.com/817754Reviewed-by:
Conley Owens <cco3@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#523297}
-
Joel Einbinder authored
This removes and re-adds a filesystem if it was already added instead of throwing an error. It makes it easier to work with overrides if you are coming from an old version of overrides or add the folder to the wrong type of persistence. Bug: 760316 Change-Id: I8578fef29eba2529ded714cf8bf8582d616c439d Reviewed-on: https://chromium-review.googlesource.com/820569Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#523296}
-
Eric Karl authored
This reverts commit a569f96f. Reason for revert: This CL was designed to detect a potential clean-up race. Race not detected, so reverting. Original change's description: > Logging to ensure that non-offscreen surfaces are destroyed as expected > > We're hitting scenarios where it appears that we may be creating an > EGL window surface for a given window before destroying the previous. > This leads to errors on Android, and shouldn't be possible. We're > suspecting that someone may be taking a reference on the glSurface, > extending the lifetime beyond the expected range. This CL adds logging > to catch this scenario. > > Bug: 787086 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I31bb0c55fb393a0719486f32f885273ee81ab9f8 > Reviewed-on: https://chromium-review.googlesource.com/802186 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522293} TBR=boliu@chromium.org,piman@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 787086 Change-Id: Ib921aa04c7a3589b514b4b14091989d368cf2202 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/820111Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#523295}
-
Tom Anderson authored
BUG=793797 R=thestig@chromium.org,yyanagisawa@chromium.org CC=milko.leporis@mips.com Change-Id: I04180e7a59f02b7492cc63159ecf17b7b87cf7f0 Reviewed-on: https://chromium-review.googlesource.com/820293Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523294}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/92c8b1a07b01..c00226132679 $ git log 92c8b1a07..c00226132 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 dsinclair [xfa] Move CJX code into fxjs/xfa 2017-12-11 thestig Remove default arguments to CPDF_StreamAcc::LoadAllData(). 2017-12-11 thestig Slightly simplify CPDF_StreamAcc::LoadAllData(). 2017-12-11 dsinclair [xfa] Refactor CJX method signatures. 2017-12-11 thestig Move some GetDict() calls out of header files. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1d7b3e10ca2453bc41043e3e6eabf809771ecf78 Reviewed-on: https://chromium-review.googlesource.com/820950 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523293}
-
Hector Carmona authored
Bug: 789897 Change-Id: Idcc3453f2355b1d7506fdc24a833819358902ee8 Reviewed-on: https://chromium-review.googlesource.com/803630 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523292}
-
Sunny Sachanandani authored
Null dereference in CDXGISwapChain::FlipPresentToDWM during Present is strongly correlated with the presence of MCTUX.dll or MCTU.dll. These are described as "LDDM User Mode Driver" for Magic Control Technology Corporation's display adapters. We use flip model swap chains with direct composition only so blacklisting it might prevent these crashes. R=piman,brucedawson BUG=776403 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8ec6664cad44036646475d48acb3c93c5dbcf220 Reviewed-on: https://chromium-review.googlesource.com/820646Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
Dave Schuyler authored
This CL removes a couple instance of I18nBehavior being declared by not being used. (code health) Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic779231d1cd33d02216a8c7b4bf48e9de33cb62d Reviewed-on: https://chromium-review.googlesource.com/820457Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#523290}
-
rnephew authored
Bug: 781409 Change-Id: I7d41a7ef52df506c6cb11f8c19051a0f5c63f500 Reviewed-on: https://chromium-review.googlesource.com/820812 Commit-Queue: rnephew <rnephew@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#523289}
-
Ryan Landay authored
After https://chromium-review.googlesource.com/c/chromium/src/+/801979, we no longer need the select_inserted_text functionality on either InsertTextCommand or InsertIncrementalTextCommand, so we can remove the parameter. Bug: 784039 Change-Id: Icfb2688a83383cea9e295186f351b6f43ffadf6c Reviewed-on: https://chromium-review.googlesource.com/807286 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523288}
-
src-internal-roller@chromium.org authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d638a44a623a..0bf4fdf50244 $ git log d638a44a6..0bf4fdf50 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I252673f1d5ab2230c7ed37b45698b25be16ea914 Reviewed-on: https://chromium-review.googlesource.com/820896Reviewed-by:
src-internal-roller . <src-internal-roller@chromium.org> Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523287}
-
Sammie Quon authored
Window selector item indicator and drag indicators share some design so created split_view_constants.h to share constants. Animate the selector item indicator label, and the drag indicator widget opacity so they fade in. Change phantom windows to when selector item dragged over to drag indicator. mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQc4sf-S_quE/files/MCEpUArMVI4QsSaRnFNKc4g8wMSJbxAVNpw screenshots: https://screenshot.googleplex.com/D6yHyySYLhb https://screenshot.googleplex.com/zWwVzisZuPC https://screenshot.googleplex.com/ZiYRYhM6i62 Test: manual, ash_unittests SplitViewWindowSelectorTest Bug: 786119 Change-Id: Iedd5e9193e73c16f2d0b0c494a86e626b32705f6 Reviewed-on: https://chromium-review.googlesource.com/779940Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#523286}
-
Tim Brown authored
Gconf has been deprecated for several years, with none of the supported distros even assigning values to the gconf settings. This is part of an effort to move from using gconf to gsettings. Bug: 768027 Change-Id: Ifa1a668364e39c05270999c9eea801a2593011f3 Reviewed-on: https://chromium-review.googlesource.com/817759Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#523285}
-
Scott Chen authored
Bug: 781335 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id8bd8fca8d4adea95561d454783c45d40872edbb Reviewed-on: https://chromium-review.googlesource.com/816059 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Kevin Bailey authored
This makes a tiny fix to the previous change, which was failing on Win 7 debug. There is a line in ScoredHistoryMatch::ScoredHistoryMatch(...) which dereferences a string's rbegin() iterator. (Searching for 'rbegin' will find the only occurrence.) Thus the code expects a non-empty string. I'm guessing it passed the other platforms because they store a '\0' there, while a debug build might be more diligent. This change simply changes history_quick_provider_unittest.cc to pass a non-empty string to that parameter. Revert: 817298 Original CL: 794432 When the option hide-suggestion-url-scheme is enabled, Omnibox suggestions exclude the scheme in some cases where they would be inconsistent with other suggestions. This change preserves schemes when the user specified one. This change asserts 'preserve_scheme' to GetFormatTypes() now if alternatively the input, interpretted as a URL, has a scheme. This changes the treatment of http (and https when certain flags are set.) Previously it was only asserted if there was a match in the scheme. Added many tests as well. Bug: 761505 Change-Id: I417448ffbb370d86c794309520083cff10ea5957 Reviewed-on: https://chromium-review.googlesource.com/820354 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523283}
-
Pawel Osciak authored
To reflect reviewer specialization/code familiarity per OWNERS file/reviewer choice guidelines. BUG=None TEST=None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0a3bb4cee242c9a3e59bb451ea697889d1679856 Reviewed-on: https://chromium-review.googlesource.com/821150Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#523282}
-
Fredrik Hubinette authored
Bug: 788984 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I75a199398befeca552449cedd8f66fa175c3043d Reviewed-on: https://chromium-review.googlesource.com/810093 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
-
Peter Collingbourne authored
With this we should hopefully get more useful stack traces on ToT bots. Bug: Change-Id: I6d9f36564d1f2edee3032b55a4f34429d302612d Reviewed-on: https://chromium-review.googlesource.com/820620Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523280}
-
Nate Chapin authored
Bug: 793028 Change-Id: Icff8fce73e745969e4022329a7cb0374ce43698c Reviewed-on: https://chromium-review.googlesource.com/818197Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#523279}
-
Morten Stenshorne authored
The fragmentation spec says that fragmentainer heights should never be shorter than 1px [1], so that we don't get stuck without content progress. This means that if the multicol container's content box height is 0, fragmentainers inside it will still be 1px. The ref depended on incorrect behavior in Presto, where floats would never be fragmented. [1] https://www.w3.org/TR/css-break-3/#breaking-rules Bug: 788337 Change-Id: I96338070458a9df518d1b4bb70eee399bfde48ab Reviewed-on: https://chromium-review.googlesource.com/821010 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#523278}
-
Andrey Lushnikov authored
This patch teaches global search to search in sourcemap sources as well. BUG=763701 Change-Id: I3062e21cf0a589d02f6926b8ec3785eca15b879a Reviewed-on: https://chromium-review.googlesource.com/820653Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523277}
-
Erik Luo authored
This prevents the 'show more' chevron from overlapping with the split widget's 'hide debugger' button. Screenshot: https://imgur.com/a/5ByuK Bug: 767330 Change-Id: I77212e20d2e85605c168e4e5845dccd2efa1399a Reviewed-on: https://chromium-review.googlesource.com/815903Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#523276}
-
erikchen authored
kAllRenderers will profile all renderers. This allows a user to easily debug renderer-based memory issues. Adding this mode also allows the removal of some testing code that had the same effect. kManual allows the user to manually specify the processes to profile via chrome://memory-internals. If the user starts profiling a process while in another mode, the mode will change to kManual for simplicity. This CL renames the function ShouldProfileProcessType to ShouldProfileNonRendererProcessType. This CL fixes a bug in BackgroundProfilingTrigger whereby renderers would never be profiled, since ShouldProfileProcessType() was incorrectly being used. This logic is no longer necessary since BackgroundProfilingTrigger queries for all profiled processes by pid. Bug: Change-Id: Ibeca2346f1629292ca17678081cf0aec68a85ab3 Reviewed-on: https://chromium-review.googlesource.com/818181 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#523275}
-
Eric Roman authored
The default is VS 2017 as of 7295a84e. Bug: 683729 Change-Id: I795011162e0a9f6c39af799b50d32587b0baed76 Reviewed-on: https://chromium-review.googlesource.com/821211Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523274}
-
Lei Zhang authored
Change-Id: I69bbbfa9d4c317a522a39e097b478d0f80e61fad Reviewed-on: https://chromium-review.googlesource.com/818606Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#523273}
-
Renjie Liu authored
Move the language code locator util from components/language => components/language/content/browser as it will only used by the GeoLanguageProvider. Bug: 76915 Change-Id: I45695bf2c1149f89e7f6d13a41a5f80ea0084ba8 Reviewed-on: https://chromium-review.googlesource.com/818596 Commit-Queue: Renjie Liu <renjieliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#523272}
-
Theresa Wellington authored
Allow zero-query omnibox suggestions to show on the Chrome Home NTP. This allows the "Link you copied" feature to work in Chrome Home. BUG=762038 Change-Id: I4c6cc0c1305dea95e7dd3c5c6ba5cc36abd48a36 Reviewed-on: https://chromium-review.googlesource.com/820096Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#523271}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3477c932..6c68f62d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I667b3a3114df6241df69aa63df38164750900277 Reviewed-on: https://chromium-review.googlesource.com/820198Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523270}
-
Andrey Lushnikov authored
This patch changes StylesSidebarPane autocomplete for property names in the following maner: - for regular nodes, only regular CSS properties are autocompleted - for SVG nodes, both CSS and SVG properties are autocompleted BUG=721998 R=dgozman Change-Id: Ie06307d62a1b9685f0bf998b5b2714c47e3d5ee8 Reviewed-on: https://chromium-review.googlesource.com/820647Reviewed-by:
-
Jaebaek Seo authored
As shown in crbug.com/786852/#c9, the current select popup in Android WebView is not correctly located. The main reason is that the left margin for the anchor rectangle of the popup is added by x value of scroll manager. This CL adds y value of scroll manager to the left margin instead. Bug: 786852 Change-Id: I8ebf983de64eea3c89d8fc7d2063962a7f1c7bb1 Reviewed-on: https://chromium-review.googlesource.com/818679Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523268}
-
Xiyuan Xia authored
- No "Servers" and "Authorities" tab; - No "Import" as in previous non-MD impl; Bug: 719907 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie6fc8e7b257937b4e0607e426d9b0550dc2ddd4b Reviewed-on: https://chromium-review.googlesource.com/820638Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#523267}
-
Mitsuru Oshima authored
Modified ClientControlledStateSurface so that - State change are first sent to client (Android) except for PIN/TRUSTED_PIN - PIN/TRUSTED_PIN are still handled on server side per security requirement. It may leave the the state inconsistent and the same thing can happen in the old implmenetation. - the bounds change request from chrome side is ignored for now and only the geometry change from client is applied. * Emulate the state change by client in ShellSurface unit tests. Animation isn't enabled yet in this CL. It'll be addressed in a separate CL. BUG=762816 TEST=manually tested on device (maximize/fullscreen/minimix/pin/unpin etc) Existing test should pass with new implementation (with test impl). Change-Id: Idc8001876f4b1c50d375b1090ce63516f3998ab0 Reviewed-on: https://chromium-review.googlesource.com/809488 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#523266}
-
Devlin Cronin authored
An (illegal) include was commented out. Remove it. Bug: None Change-Id: Ief2da1cb5a3f381aeff1589f055fd12158bda1fc Reviewed-on: https://chromium-review.googlesource.com/821110Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523265}
-
John Abd-El-Malek authored
When there's an ongoing navigation, if the app loada a JavaScript URL we create a temporary NavigationRequest in NavigatorImpl::RequestNavigation. However the call to RenderFrameHostManager::GetFrameHostForNavigation was resetting the speculative RFH of the original NavigationRequest since the site instance of a JavaScript load is always the same as the existing frame. Bug: 793432 Change-Id: I5a25eea9a8733cd5cebe71f700b30ebb4c0b1710 Reviewed-on: https://chromium-review.googlesource.com/820453 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#523264}
-
Yoichi Osato authored
This patch is a part of crrev.com/c/813336 ([LayoutNG] Paint text selection on load.) LayoutSelection.cpp: - This converts legacy offset to NG offset if LayoutObject has enclosing NGBlockFlowlayout before paint phase. - LayoutSelectionStartEndForNG() returns start/end offsets that the NGPhysicalTextFragment is selected. LayoutSelectionTest.cpp: - This patch adds NGLayoutSelectionTest to confirm/demonstrate how we use the function. Also you can refer my following painting patch(crrev.com/c/818884). Bug: 708452 Change-Id: Ic9fc6822f83e0821c5f2f4917d4ac316543702e2 Reviewed-on: https://chromium-review.googlesource.com/818864Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#523263}
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: 727984 Change-Id: Ic1993cce55beed9e00512f6fe4b001fc5ec4c591 Reviewed-on: https://chromium-review.googlesource.com/818746 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#523262}
-
Hector Carmona authored
Bug: 789897 Change-Id: Id16a994fda31d9a294444cf56ceab646548cb29d Reviewed-on: https://chromium-review.googlesource.com/803623 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
- 11 Dec, 2017 1 commit
-
-
Andrey Kosyakov authored
Bug: 726381 Change-Id: I76fb27d4eb50730ff85fdf39895859db4e343bc8 Reviewed-on: https://chromium-review.googlesource.com/811526 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
