GitLab

BUG=52957
TEST=none (ran 3D CSS demos with --enable-accelerated-compositing)

Review URL: http://codereview.chromium.org/3150030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57130 0039d316-1c4b-4281-b951-d872f2087c98

* Properly enable and disable the Edit and Remove buttons based on select
control state.
* Modify the title of the address/CC overlays when pressing the
'Add address/CC' buttons.
* Remove the ability to select multiple options.

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3125039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57129 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rsesek

Review URL: http://codereview.chromium.org/3163035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52781
TEST=see bug

Review URL: http://codereview.chromium.org/3106033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57126 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53141
TEST=none
Review URL: http://codereview.chromium.org/3136029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57125 0039d316-1c4b-4281-b951-d872f2087c98

Making window.focus()/blur() work only when there is a user gesture.

Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).

TBR=darin,sky
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.

Review URL: http://codereview.chromium.org/3174030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57124 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3184018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57123 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:5828
TEST=make sure browser_tests pass on chrome os

Review URL: http://codereview.chromium.org/3204001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57122 0039d316-1c4b-4281-b951-d872f2087c98

Save the information that the setup of remoting has completed.

After setup has been completed we start and stop service process when
--enable-remoting presents when browser starts.

Also save the information in the service process that host is registered
and ready to be used. Again start chromoting host automatically once
the host registration is done.

BUG=50244, 50242, 50243, 50249

Review URL: http://codereview.chromium.org/3153029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57120 0039d316-1c4b-4281-b951-d872f2087c98

This removes copy-pasted code in each platform implementation.

BUG=47320
TEST=compiles

Review URL: http://codereview.chromium.org/3163023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57119 0039d316-1c4b-4281-b951-d872f2087c98

When I run them on OSX, I get a gtest warning about multiple threads:
"Death tests use fork(), which is unsafe particularly in a threaded context.
For this test, Google Test detected 2 threads."

This patch fixes the warnings.

BUG=43165
TEST=base_unittest --gtest_filter=OutOfMemoryDeathTest.*

Review URL: http://codereview.chromium.org/3201009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57118 0039d316-1c4b-4281-b951-d872f2087c98

to the host browser. We no longer have a counter which tracks the last page id.

Top level navigations are reported back if the current frame does not have an opener
or if the origins don't match. The other conditions remain the same i.e reloads/back forwards
and posts don't make it to the host browser and are treated as internal navigations.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=52931

Disabled the navigate out chrome frame test as this needs to be fixed to propertly detect
navigations coming out of chrome frame.

Bug=52931

Review URL: http://codereview.chromium.org/3174027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57117 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=52097

Review URL: http://codereview.chromium.org/3191015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57116 0039d316-1c4b-4281-b951-d872f2087c98

Rename HostMessage and ClientMessage to Chromoting{Host|Client}Message to
avoid conflicts with messages in X11.

Actually, only ClientMessage needs to be changed due to conflict, but HostMessage is changed to keep the names consistent.

BUG=none
TEST=remoting unittests

Review URL: http://codereview.chromium.org/3161034

TBR=garykac@chromium.org
Review URL: http://codereview.chromium.org/3141036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57115 0039d316-1c4b-4281-b951-d872f2087c98

BUG=38475
TEST=Not fully testable yet (but the test is
  unit_test --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled

Review URL: http://codereview.chromium.org/3117034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52621
TEST=unit_tests

Review URL: http://codereview.chromium.org/3135035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57113 0039d316-1c4b-4281-b951-d872f2087c98

Rename HostMessage and ClientMessage to Chromoting{Host|Client}Message to
avoid conflicts with messages in X11.

Actually, only ClientMessage needs to be changed due to conflict, but HostMessage is changed to keep the names consistent.

BUG=none
TEST=remoting unittests

Review URL: http://codereview.chromium.org/3161034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57112 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compile
TBR=thestig

Review URL: http://codereview.chromium.org/3141035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57111 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3174028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57110 0039d316-1c4b-4281-b951-d872f2087c98

We first show a search engine choice dialog (basically matches windows) but also (in the google chrome case) show a second dialog with the "make chrome the default browser" and "report crashes?" checkboxes. In the chromium case, we don't show the second dialog because it would have a single checkbox (no crash reporting in chromium), and that checkbox is covered by an infobar anyway.

In Chrome, the search engines have image logos. In chromium, they only have plain text logos.

We also no longer show the first run bubble.

BUG=49705
TEST=manual (Chrome and Chromium)

TODO:
- skip the search engine choice when there are no suggested search engines
- show the default search if it's not in the first 3 search engines list
- randomize the search engines list (sometimes)
- remove first run bubble code

Review URL: http://codereview.chromium.org/3106031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57109 0039d316-1c4b-4281-b951-d872f2087c98

This reduces the unnecessary NetLog spam, since we would log to the NetLog everytime we created the backup ConnectJob, even though we usually wouldn't actually call Connect() on it.  Now, we only create the backup ConnectJob when we intend to call Connect() on it.
Includes some various cleanup necessary for this:
  * struct Group => class Group
  * method_factory moves from CSP to Group

Review URL: http://codereview.chromium.org/3171017

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3198009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57107 0039d316-1c4b-4281-b951-d872f2087c98

Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).

BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.

Review URL: http://codereview.chromium.org/3156016

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3201008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57105 0039d316-1c4b-4281-b951-d872f2087c98

This reduces the unnecessary NetLog spam, since we would log to the NetLog everytime we created the backup ConnectJob, even though we usually wouldn't actually call Connect() on it.  Now, we only create the backup ConnectJob when we intend to call Connect() on it.
Includes some various cleanup necessary for this:
  * struct Group => class Group
  * method_factory moves from CSP to Group

Review URL: http://codereview.chromium.org/3171017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57100 0039d316-1c4b-4281-b951-d872f2087c98

Reworked Avi's patch for master prefs implemented on mac (http://codereview.chromium.org/2903014/show), so that it will work with new first run sequence on Windows and Mac.

BUG=44901
TEST=in bug

Review URL: http://codereview.chromium.org/3148001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57099 0039d316-1c4b-4281-b951-d872f2087c98

I am concerned about the possibility that other users of the
files in Chrome's base/ directory (e.g. Chrome OS) may build
a library from these files with NDEBUG defined and then link
it into a binary that includes the headers without defining
NDEBUG, or vice versa.

This change mangles InitLogging()'s name in logging.h based
on whether NDEBUG is defined so that linking will fail if
there's a mismatch (Evan provided useful advice here).

BUG=chromium-os:1124
TEST=built Debug and Release Chrome, built all Chrome OS packages, and then changed a Chrome OS package that links against libbase.a to define NDEBUG and checked that it failed to link

Review URL: http://codereview.chromium.org/3106032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3190004

TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3119038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57096 0039d316-1c4b-4281-b951-d872f2087c98

Expands size of labels in AutoFillCreditCardSheet.xib to accommodate for longer Japanese localized strings.  Shifts text entry boxes to the right accordingly.

BUG=52767
TEST=none

Review URL: http://codereview.chromium.org/3164030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57095 0039d316-1c4b-4281-b951-d872f2087c98

Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).

BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.

Review URL: http://codereview.chromium.org/3156016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3190004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57093 0039d316-1c4b-4281-b951-d872f2087c98

This looks like a local system change after a reboot
since t_ref changed, too.

BUG=none
TEST=xpdual/moz is green
TBR=nsylvain@chromium.org

Review URL: http://codereview.chromium.org/3190015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57091 0039d316-1c4b-4281-b951-d872f2087c98

ShowSingletonTab considers only base URL's as unique; adding a /path opens another tab despite one being present at the base URL; changing the path to a ref fixes it.

Review URL: http://codereview.chromium.org/3155038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52858
TEST=greener tree
Review URL: http://codereview.chromium.org/3201007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57089 0039d316-1c4b-4281-b951-d872f2087c98

This change should be reverted as soon as we figure out what's going wrong.

BUG=52918
TEST=None
Review URL: http://codereview.chromium.org/3197012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20868
TEST=manual

Review: http://codereview.chromium.org/3158026

Review URL: http://codereview.chromium.org/3158026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=34644
TEST=Open options window, move and close the window, re-open and ensure position is saved. 
Contributed by Steven Pennington <spenn@engr.uvic.ca>

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57086 0039d316-1c4b-4281-b951-d872f2087c98

Code implements UI for downloading and burning Chrome OS images on SSD card and USB key. Actual burning is not included in the change list.

BUG=chromium-os:5346

TEST=type in  chrome://imagebuner in browser. UI lists all media that image can be burnt to. After selecting burning target by clicking an image right to the target name, image download should start, and download progress should be displayed. After download ends alert should pop up asking user to confirm that he wants to burn image to selected device. Clicking both ok or cancel shouldn't do anything, since actual burning isn't stil included in CL.
Image should be downloaded to chrome_image folder in users Downloads directory. 
this folder is deleted during shutdown.
This is only visible in ChromeOS...

Review URL: http://codereview.chromium.org/2808100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57085 0039d316-1c4b-4281-b951-d872f2087c98

The source files live in chrome/common, and they're there because
we need to get at version infomation all over the product (not
just from the exe, like the gyp files are currently written).

This refactoring is necessary for a follow-up change.

TEST=compiles

Review URL: http://codereview.chromium.org/3113026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57084 0039d316-1c4b-4281-b951-d872f2087c98

to cover external files.

We now keep a variable-size buffer and use it even after we
know that the data is not going to be stored by a block-file.
The backend keeps track of the total memory used by all entries
and prevents that value from going over a max value that
depends on the total memory available.

This CL removes the tests that were checking the synchronous
operation of sparse IO because that model is no longer supported
by the public API, and this CL would add complexity to them
(they fail due to thread safety concerns).

BUG=6626
TEST=net_unittests

Review URL: http://codereview.chromium.org/3167020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57082 0039d316-1c4b-4281-b951-d872f2087c98

I probably need more tests but in order to test
I need to figure out how to init the system
with different caps enabled from the unit tests
and that's probably not a small amount of work
so leaving that till later.

TEST=some unit tests, ran conformance tests
BUG=none

Review URL: http://codereview.chromium.org/3122033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Load DOMUI options, go to another page, load DOMUI options again, and manage search engines; the table should not be empty.

Review URL: http://codereview.chromium.org/3116023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57077 0039d316-1c4b-4281-b951-d872f2087c98