GitLab

See here for context:

  https://docs.google.com/document/d/1GTQ3vvrszK4I1pDzmTFb6krmUzAXox0V9ZIqIi_GH1E/edit?usp=sharing

We are expanding Roselle to re-rank the results returned when the user enters
a query. However, these results include Arc app shortcuts as well as apps
themselves, so they need to be ranked. This CL adds the training support for
Arc App Shortcuts and use Roselle score to update current relevance score.

Bug: 931149
Change-Id: I979ebd500504681c9b0c0e59aa0412b4cbd47315
Reviewed-on: https://chromium-review.googlesource.com/c/1481176
Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634881}

ui::DisplayManager can be the single interface for ozone-gbm
clients by moving DisplayConfigurator under DisplayManager
which can simplify the relationship between CrOS shell and
ui/Display/Manager.

In addition, this change will allow ui::DisplayManager to
directly use ui::DisplayConfigurator without
ash::WindowTreeHostManager.

For more details, see the design document at http://bit.ly/2FBXL2c
Bug: 922182

Change-Id: I0e1284024cf89b8369bd8c322473a61a9d9fe07e
Reviewed-on: https://chromium-review.googlesource.com/c/1418315Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Joone Hur <joone.hur@intel.com>
Cr-Commit-Position: refs/heads/master@{#634880}

* Modify the stream-merging code to output to a pipe instead of a
  Python generator, so that the "symbolize" tool can read both app
  and kernel logs.
* Rename "build_manifest.py" to "prepare_package_inputs.py" to better
  capture the broader scope of that script.
* Add ids.txt generation logic to prepare_package_inputs.py.
* Remove dead codepath for disabling symbolization. Symbolization has
  been forced-on by the build scripts with no issues so far, so having
  an opt-out is unnecessary.


Bug: 772252
Change-Id: I4e01d0fc5ce96521efa6d0d394e629cb5c7985ff
Reviewed-on: https://chromium-review.googlesource.com/c/1474032
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634879}

This reverts commit 703661c8.

Reason for revert: Suspect for failing unit_tests, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20473

Original change's description:
> Add flag for #omnibox-deduplicate-drive-urls
> 
> Change-Id: I48b82707892caa2ed85ab776b6cae73274382fde
> Reviewed-on: https://chromium-review.googlesource.com/c/1481121
> Commit-Queue: Travis Skare <skare@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634850}

TBR=jdonnelly@chromium.org,skare@chromium.org

Change-Id: I2b663fc6154ef05e860913f3023e86fc3ed16ca4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1484578Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634878}

This reverts commit aef5c1f5 now that we
don't need to work around the VC++ bug.

Only the removal of const to work around the VC++ bug was reverted. The
additions of const to move data to the const data segment were retained.

Bug: 934323
Change-Id: I833f62b4b832cdbb2d07436800bc28145c388f86
Reviewed-on: https://chromium-review.googlesource.com/c/1483948Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634877}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing @Orientation interface in the form common with Chrome @IntDef:

1. with @IntDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface

BUG=919666

Change-Id: I6e96496eedf82253687c287ea7a70b3c92f63ace
Reviewed-on: https://chromium-review.googlesource.com/c/1480450Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#634876}

This CL adds a flag that enables listing all display
modes in the display settings for external displays,
which can be very useful for debugging and development
purposes.

BUG=927848
TEST=Added tests, tested on device with 4k display

Change-Id: I748f2c2b645071723b94a37f759528b6437558aa
Reviewed-on: https://chromium-review.googlesource.com/c/1465682
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634875}

Revert "Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled."

This reverts commit 5b911be8.

Reason for revert: broke linux_optional_gpu_tests_rel trybot per Issue 935033

Original change's description:
> Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled.
> 
> Only enables the warning for chromium_code.n
> 
> Also fix the last few -Wextra-semi instances in sanitizer and linux/ozone builds.
> 
> Getting to this state required fixing > 3000 unique warnings in 15+ different
> repositories.  If this breaks some internal-only build somewhere, either consider
> using no_chromium_code for your internal code, or fix the warnings -- it's
> pretty easy. (Build with treat_warnings_as_errors=false, then open the error log
> in vim, run `:%g/warning:/t$` to copy the warnings to the end of the buffer,
> remove all but just those lines, run `:sort u` to get uniques, then save as
> `tmp.txt` and run `:cf %` and then use something like `:map m :w<cr>:cn<cr>`
> to go through them quickly.)
> 
> TBR=rsesek
> 
> Bug: 926235
> Change-Id: Ica629737523ff6bbd756edc44d182f35ff6cf8ac
> Reviewed-on: https://chromium-review.googlesource.com/c/1483396
> Reviewed-by: Scott Violet <sky@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634826}

TBR=sky@chromium.org,thakis@chromium.org,rsesek@chromium.org

Change-Id: I3fbcb763dbe448619b55f6dbb0cd1bf6d4eebc03
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 926235, 935033
Reviewed-on: https://chromium-review.googlesource.com/c/1484509Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634874}

Change-Id: I433b70e353291c952c315e0ab2805298e27840dd
Reviewed-on: https://chromium-review.googlesource.com/c/1483945Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634873}

This is a reland of 8f219b08 and
9de3faa3 merged into a single change,
with test fixes.

* Changes ModuleCache::Module from a value type to a reference type,
  with ModuleCache maintaining ownership of the Module. ModuleCache
  needs to own its Modules to properly support Windows, which reference
  counts its modules. ModuleCache is retained as a struct to minimize
  the size of this change, but will be changed to a class in a later CL.

* Moves the parallel module caching implementation for Windows into
  ModuleCache. This is required to ensure the referenced modules outlive
  the references to them.  The parallel implementation will be merged
  with the existing module caching implementation over the course of
  later refactoring CLs.

Bug: 931418
Change-Id: Ic58afbf4f7bd48a91d0191a37b623b63501c8fa7
Reviewed-on: https://chromium-review.googlesource.com/c/1483393Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634872}

The secondary display's shelf is not visible.

Bug: 934990
Change-Id: Ida72e29d3be57f0408bc3d0928bb934762bc3476
Reviewed-on: https://chromium-review.googlesource.com/c/1483939Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634871}

This was a recent regression due to the view not being attach to the
parent anymore. This is for a feature behind a flag and disabled by
default.

TBR=tedchoc@chromium.org

Change-Id: I3091765cb7a254fc489240e7b60779e5ccfa32cf
Reviewed-on: https://chromium-review.googlesource.com/c/1484511Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634870}

These will be used by test code to trigger events based on dragging.  Tests
can't reliably e.g. "queue event to trigger a drag and then call a particular
callback" due to the nested, filtered message loop on Windows.  Using drag
observer methods is reliable, and clearer as well.

Bug: 923188
Change-Id: Id24b8150d04dc878dce543fe469994aba29694e4
Reviewed-on: https://chromium-review.googlesource.com/c/1483931
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634869}

Previously, test placeholders were extracted from test_locations_, a std::map,
which implicitly deduplicated the keys. After creating test_placeholders_, I
stored them in a vector. Unfortunately, this causes duplicate entries to occur
when iterations > 1. Storing them in a set returns the previous behavior.

Bug: 934996
Change-Id: I81825b1f95064ac59594b3531cfd8409c631e8f8
Reviewed-on: https://chromium-review.googlesource.com/c/1484074Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634868}

This is a reland of 8af85474

The original author is rmcelrath@chromium.org, yhirano replaced DISABLE_ with
DISABLED_.

Original change's description:
> Disable NetworkChangeManagerClientBrowserTest.ReconnectToNetworkService
>
> This test is flaky on ChromeOS when the network service is enabled.
>
> Bug: 934583
> Change-Id: Ib0a37e995a69555b5a5381bdef24f92fd19c12d9
> Reviewed-on: https://chromium-review.googlesource.com/c/1482005
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634467}

Bug: 934583
Tbr: jam@chromium.org
Change-Id: I87dc76c9e36f25d78279105b03ea9b3340e47718
Reviewed-on: https://chromium-review.googlesource.com/c/1482278
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634867}

Always use uint64_t to serialize size_t since serialization and
deserialization can occur in processes with different bitness on android
webview.

TBR=enne@chromium.org

Bug: 924042
Change-Id: I54945b0eb1a60910cb9c92e25b6d57388c4aaa85
Reviewed-on: https://chromium-review.googlesource.com/c/1475047
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634866}

We do not show the answer card when we are showing the embedded
Assistant UI.

Bug: 924624
Test: manual
Change-Id: I08fe6bcfd9e3d4e6bee2fb5236a7246405ecb53f
Reviewed-on: https://chromium-review.googlesource.com/c/1481994
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634865}

This is necessary for creating modified DropTargetEvents (e.g. if you need to
make a provided const event& relative to a new parent).

The primary concern here is |data_|, which is a reference member.  Copying a
DropTargetEvent shallow-copies this reference rather than deep-copying it, so
the lifetime of the copied event must not extend past that of the data that was
used to construct the original event.  I'm concerned that this change makes it
easier for people to cause UAFs; however, that concern already existed with the
original object, and the right fix is probably not to prevent copying but to
make DropTargetEvent not keep |data_| by reference to begin with.  That's a more
involved change than I have the scope to do for now.

Bug: 923188
Change-Id: I35d475081584577cc0217f672a45b5a9e5a60a4e
Reviewed-on: https://chromium-review.googlesource.com/c/1483673
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634864}

This reverts commit 1bc0f674.

Reason for revert: causing crashes & flakiness.
Bug: 934640, 934790

Original change's description:
> [IndexedDB] Moving IDBDatabase's PendingConnection to use ScopesLockManager
> 
> This allows scopes to be used in the DeleteDatabase call, and cleans up
> some code in the IndexedDBDatabase class.
> 
> The last part of the codebase that doesn't have locks before being used
> is the IndexedDBBackingStore::Initialize call. Since this happens on the
> opening of the database, this can probably use just the raw database +
> a WriteBatch.
> 
> Bug: 862456
> Change-Id: I89c79ec89a4450e21f1ee700b007ec867b3a4f48
> Reviewed-on: https://chromium-review.googlesource.com/c/1478391
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: Chase Phillips <cmp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634358}

TBR=cmp@chromium.org,dmurph@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 862456
Change-Id: I30cf895d9846308c26191984f75039306acc86e4
Reviewed-on: https://chromium-review.googlesource.com/c/1484076Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634863}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/151c3484da58..298f2cf820df


git log 151c3484da58..298f2cf820df --date=short --no-merges --format='%ad %ae %s'
2019-02-22 ehmaldonado@chromium.org git cl: Print a clear error message when we fail to find the remote url.
2019-02-22 jophba@chromium.org CppLint changes for VSCode cpplint plugin
2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-02-22 qyearsley@chromium.org [cpplint] Ignore fn_size check for macros with digits


Created with:
  gclient setdep -r src/third_party/depot_tools@298f2cf820df

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:914655,chromium:83036
TBR=agable@chromium.org

Change-Id: Id13e16f7ca19ec6dde3638cf336030aecf7cb111
Reviewed-on: https://chromium-review.googlesource.com/c/1483746Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634862}

When navigating to a previews URL directly, the preview code (V1) falls
back to the original URL. In this case, it should not report any
pingback metrics. It is currently DCHECKing, but in release builds it
does report the pingback.

Bug: 934865
Change-Id: I4f1749d9ddeef49e98d3d2ee041669bdce232480
Reviewed-on: https://chromium-review.googlesource.com/c/1483941
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634861}

Using wpt-import in Chromium 109f1025.
With Chromium commits locally applied on WPT:
14c11107 "Implement `Sec-CH-Lang`"
df760ab0 "Don't skip past auto-height flexboxes in quirks mode."
cd40220a "Fix as=fetch preload where preload is used before response arrives"
1d89521e "[LayoutNG] Force relayout when constraint spaces change."
98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests"
f82f5505 "[LayoutNG] Fix inline-level OOFs inside a block-level context."
1a46f4bb "v8binding: Make PaintWorkletGlobalScope use IDL callback function"
68d5240e "[ChromeDriver] Set key modifiers with mouse actions"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ie2c5645fb11da0174a692dfd8d4b5560e0646f60
Reviewed-on: https://chromium-review.googlesource.com/c/1483731Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634860}

Using unsigned long instead of ptrdiff_t results in non-zero
pointer deltas being stored as zero delta, giving incorrect offsets
into arrays and hence out of bounds reads.

This patch fixes the issue in all places in parser.c and adds a macro
to reduce the chances of cut-and-paste errors. A chromium patch for
the libxml roll is added to apply the change to future versions.

The issue has been reported upstream to libxml2 because there are
likely other places in the code where this fails.

R=dcheng@chromium.org,palmer@chromium.org
BUG=894933

Change-Id: I13687c386231374653e499e0557838ed0ddea6af
Reviewed-on: https://chromium-review.googlesource.com/c/1483252
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634859}

The test started flaking after an unrelated CL caused a slight change to the
sharding of tests. This implies that the test has previously relied on state
carried over from previous tests to function correctly.

Bug: 934900
Change-Id: Iee0208c99751362a3c5dcf36f70a1625e3ebd6a3
Reviewed-on: https://chromium-review.googlesource.com/c/1483940Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634858}

Bug: none
Change-Id: I4a5cffd410d1f87431b7705a6ef5bb94955f6813
Reviewed-on: https://chromium-review.googlesource.com/c/1483830
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634857}

Bug: 862461
Change-Id: I624d39293e50754629b3b30990828af73f57f0b3
Reviewed-on: https://chromium-review.googlesource.com/c/1482281Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634856}

Currently Chromevox will not treat image annotation separately
from the name field, but this gives us the flexibility to add
separate Chromevox logic for annotation later.

Bug: 905419
Change-Id: I65c964dec3c869319a51f164b6c245057a362410
Reviewed-on: https://chromium-review.googlesource.com/c/1480542Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634855}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6be20565150..d2b61f7238c1


Created with:
  gclient setdep -r src-internal@d2b61f7238c1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ia035961fd860d004053dc7f02a7bb89beff44019
Reviewed-on: https://chromium-review.googlesource.com/c/1483827Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634854}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0d90920be7af..c08d404a452b


git log 0d90920be7af..c08d404a452b --date=short --no-merges --format='%ad %ae %s'
2019-02-22 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@c08d404a452b

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I6e6a0f86ae426cadeaf79bb3e0aad5569934efa9
Reviewed-on: https://chromium-review.googlesource.com/c/1483741Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634853}

Gzip has a maximum compression ratio of 1032x. While, strictly speaking,
linear, this means the fuzzer will often get stuck. Stop reading at a
more modest compression ratio of 10x, or 2 MiB, whichever is larger.

Bug: 921075
Change-Id: I529632762b66e4fae0bbdce8ea6d746d98cc2d99
Reviewed-on: https://chromium-review.googlesource.com/c/1483873
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634852}

RTCVideoDecoderAdapter::Release() is called on the DecoderThread when
InitDecode() fails.

Bug: 934798
Change-Id: I8157d73511db0639d2013e2f4d62293a47ceaf5c
Reviewed-on: https://chromium-review.googlesource.com/c/1483683Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634851}

Change-Id: I48b82707892caa2ed85ab776b6cae73274382fde
Reviewed-on: https://chromium-review.googlesource.com/c/1481121
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634850}

Create a cups_printing watchlist to watch the CUPS related chromium files

Bug: None.
Change-Id: I48846d834983c51d4780f4b89962a000f12cfaea
Reviewed-on: https://chromium-review.googlesource.com/c/1483944
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634849}

This reverts commit 90ffaeaa.

Reason for revert: Breaks Win x64 Builder. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20x64%20Builder/63687

Original change's description:
> Add the win::WMIRefresher class and use it in SystemMonitor
> 
> This class will be used to retrieve the disk idle time on Windows (some
> other performance counters will probably be added in the future).
> 
> The metric will initially be used in the tracing infra to make it
> easier to analyze the I/O activity in the slow reports we're getting
> from the wild.
> 
> The Windows specific code has been review by rogerta@ and forschaw@ in https://chromium-review.googlesource.com/c/chromium/src/+/1340373
> 
> Bug: 771478
> Change-Id: Ie1988818f521097d6078ce67e597ec02115f4c07
> Reviewed-on: https://chromium-review.googlesource.com/c/1349670
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634843}

TBR=jwd@chromium.org,fdoray@chromium.org,oysteine@chromium.org,sebmarchand@chromium.org

Change-Id: I857594acf56af3f050c1559a72269579f467a326
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771478
Reviewed-on: https://chromium-review.googlesource.com/c/1484088Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634848}

https://pdfium.googlesource.com/pdfium.git/+log/1aecf87b9620..36e541ccbf9f


git log 1aecf87b9620..36e541ccbf9f --date=short --no-merges --format='%ad %ae %s'
2019-02-22 thestig@chromium.org Add more tests for AFPercent_Format().
2019-02-22 thakis@chromium.org Another whitespace change to trigger bots.


Created with:
  gclient setdep -r src/third_party/pdfium@36e541ccbf9f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:934825
TBR=dsinclair@chromium.org

Change-Id: Icf5b3dd16e4050c17706185fe0239a09dc11ae09
Reviewed-on: https://chromium-review.googlesource.com/c/1483826Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634847}

Create two studies since the two features have two different chrome
flags. Using one study would cause DCHECK failure (Feature has conflicting
field trial overrides) in Chromium debug mode.

Bug: 897998
Change-Id: Icf093329e30f660ce7697241f5fbcd0604a1f9ac
Reviewed-on: https://chromium-review.googlesource.com/c/1474277Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634846}

ErrorUtils.FormatErrorMessage_Death fails on official builds because
failure messages aren't passed to CHECK in official builds. Modify the death
regex for the test in official builds and fix the test.

BUG=934831

Change-Id: I4b301410ce990e3ced014c5fa82c42d1fea98cce
Reviewed-on: https://chromium-review.googlesource.com/c/1483938
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634845}

Change-Id: I81252edcac31490248001c59623b1da220136451
Reviewed-on: https://chromium-review.googlesource.com/c/1480455
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634844}

This class will be used to retrieve the disk idle time on Windows (some
other performance counters will probably be added in the future).

The metric will initially be used in the tracing infra to make it
easier to analyze the I/O activity in the slow reports we're getting
from the wild.

The Windows specific code has been review by rogerta@ and forschaw@ in https://chromium-review.googlesource.com/c/chromium/src/+/1340373

Bug: 771478
Change-Id: Ie1988818f521097d6078ce67e597ec02115f4c07
Reviewed-on: https://chromium-review.googlesource.com/c/1349670
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634843}

The value of these policies is written to cache.dat so IE knows how to
open a URL in Chrome.

Bug: 909878
Change-Id: I0410e9022b96f35354666946a19fa6492afc7963
Reviewed-on: https://chromium-review.googlesource.com/c/1476062
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634842}