GitLab

The histograms were added to Chrome in:
https://codereview.chromium.org/23181006/

Review URL: https://chromiumcodereview.appspot.com/23983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221496 0039d316-1c4b-4281-b951-d872f2087c98

When raising a set of windows in response to a dock icon click, only raise the
ones on the currently active space. We currently raise all of them and switch
spaces haphazardly.

Also tidy up the applicationShouldHandleReopen:hasVisibileWindows: callback. We
should return NO since we've reacted and don't need AppKit to deminiaturize for
us. (Although it seems to not make much difference, probably because we've
already picked a window to deminiaturize, so AppKit won't pick a second.) Also
remove the tabbed/popup check. As of r192264, those are the only browser window
types.

BUG=281674
TEST=Open a browser window in Desktop 1 and one in Desktop 2.
Switch to Desktop 2.
Open another application in Desktop 2 and make it foreground.
Click the dock icon for Chrome. Should remain on Desktop 2.

Review URL: https://chromiumcodereview.appspot.com/23737003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221495 0039d316-1c4b-4281-b951-d872f2087c98

Looks like it was originally a copy/paste error.

BUG=284895

Review URL: https://chromiumcodereview.appspot.com/23654010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221494 0039d316-1c4b-4281-b951-d872f2087c98

When the LayerTreeHostImpl drops RenderPasses from its output, it does
not also drop the RenderPassDrawQuads that point to them. The direct
renderers ignore these quads, so this has never been a problem. However
the DelegatedRendererLayerImpl was not able to deal with this correctly
and would crash. More problematic is that a compromised renderer could
send invalid RenderPassDrawQuads, which the DelegatedRendererLayerImpl
must be able to handle gracefully.

So, for both cases, we here make the DelegatedRendererLayerImpl ignore
invalid RenderPassDrawQuads, and just drop the from its own output.

Tests:
DelegatedRendererLayerImplTest.InvalidRenderPassDrawQuad

R=piman
BUG=283630

Review URL: https://chromiumcodereview.appspot.com/23891003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221493 0039d316-1c4b-4281-b951-d872f2087c98

This *reverts* the parts of high-res timing that was moved out from simple cache
in attempt to have it in base/, here:
http://src.chromium.org/viewvc/chrome?view=revision&revision=216478

The changes in base/ are untouched today. This partial revert should be safe
because this change just adds (un-removes) a different implementation and
switches simple cache to using it.

The bug being blocked by this deficiency is in the BUG field, we do not have a
specific bug for the problem, it would have required age restriction on the
audience.

BUG=261618

Review URL: https://chromiumcodereview.appspot.com/23819025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221492 0039d316-1c4b-4281-b951-d872f2087c98

Shill does not send the passphrase to Chrome for security reasons, so
show ****** in the passphrase field when configuring wifi if the service
is Connectable. (Sometimes when a connection fails we do not know why
it failed and so we show the configure dialog in case it is an error in
the configuration).

BUG=264819

Review URL: https://chromiumcodereview.appspot.com/23522013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221491 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221490 0039d316-1c4b-4281-b951-d872f2087c98

TBR=verwaest@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23872006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221489 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=264886
TBR=zhaoqin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23719014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221488 0039d316-1c4b-4281-b951-d872f2087c98

This avoids a doomed connect attempt for unconfigured networks.

BUG=280242

Review URL: https://chromiumcodereview.appspot.com/23583018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221487 0039d316-1c4b-4281-b951-d872f2087c98

Add synchronous and asynchronous methods to ManagedUserSyncService to get the list of managed users.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23910002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221486 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vrk@chromium.org
BUG=276894

Review URL: https://chromiumcodereview.appspot.com/23453022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221484 0039d316-1c4b-4281-b951-d872f2087c98

Implement additional tests covering most of the functionality of
WebContentsModalDialogManager. Refactor common setup into the test
fixture.

BUG=157161
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23475022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221483 0039d316-1c4b-4281-b951-d872f2087c98

Brings the onFocusChanged handling exactly inline between ContentView and
AwContents.

NOTRY=true
BUG=285582

Review URL: https://chromiumcodereview.appspot.com/23623020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221482 0039d316-1c4b-4281-b951-d872f2087c98

When pushing data files avoids matching files whose relative paths do not match a file being pushed from the host.

BUG=284906
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23513019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221477 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221475 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157170:157296&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/23819022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221473 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23532033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280550
TEST=PipelineIntegrationTest.MediaSource_MP3

Review URL: https://chromiumcodereview.appspot.com/23454006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221471 0039d316-1c4b-4281-b951-d872f2087c98

Also, add NDEBUG to CFLAGS by default so that asserts not
compiled into release builds, and fix resulting unused
variable warnings by making KernelProxy::Init do more
error checking and return a result.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/22842011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221470 0039d316-1c4b-4281-b951-d872f2087c98

responses with no addresses.

> [net/dns] Perform A/AAAA queries for AF_UNSPEC resolutions in parallel. 
> 
> The second DnsTransaction is scheduled as a second job on the resolver's
> PrioritizedDispatcher, at the beginning of its priority queue. The two
> DnsTransactions run independently of each other, although if one of them
> finishes with an error, the other one will be scrapped immediately, and
> the Job will fall back to ProcTask. 
> 
> BUG=174992
> 
> Original Review URL: https://chromiumcodereview.appspot.com/19498003
Revert URL: https://codereview.chromium.org/23102009

BUG=174992,277625

Review URL: https://chromiumcodereview.appspot.com/22909037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221469 0039d316-1c4b-4281-b951-d872f2087c98

Disable actual http://groupcloned.com and add test page
http://groupcloned.com/test/list-images-variable/index.html instead.

The actual groupcloned page keeps failing in the key_mobile_sites page set.
It seems to behave non-deterministically, i.e. it's trying to load different
items on different invocations. This is despite Telemetry trying to get rid
of all randomness. The problem with the non-determinism is that the page often
tries to load resources that haven't been loaded during recording.

BUG=238864
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/23500008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221468 0039d316-1c4b-4281-b951-d872f2087c98

TEST=tools/perf/run_measurement page_cycler_bloat --v8-object-stats

Review URL: https://chromiumcodereview.appspot.com/23963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221467 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221466 0039d316-1c4b-4281-b951-d872f2087c98

1715: Tests: Try to set +x bot on new change.sh file, try 2.
1716: ninja&make/mac: Give loadable_modules type MH_BUNDLE.

BUG=280718
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/23457004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221465 0039d316-1c4b-4281-b951-d872f2087c98

Note that the new code is still behind a runtime flag
(--brave-new-test-launcher), but compiling tests with support for it
will make further testing possible.

BUG=236893, 79359
R=akalin@chromium.org, enne@chromium.org, erikwright@chromium.org, joi@chromium.org, keybuk@chromium.org, sky@chromium.org, thestig@chromium.org, tommi@chromium.org, wtc@chromium.org, xhwang@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/23442019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221464 0039d316-1c4b-4281-b951-d872f2087c98

Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the preferred one.

TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23874005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221463 0039d316-1c4b-4281-b951-d872f2087c98

* The bounds obtained from GetBoundsOverrideAsh is ignored
  (overridden) by the following logic if it returns false,
  so skip early for the condition that returns false.
* Removed the code for non tabbed case in GetBoundsOverrideAsh as it won't be used.

* removed fullscreen controller check because it seems to be
  redundant with window->IsFullscreen() check. (IsFullscerenForBrowser() is always false if window->IsFullscreen() is false)

BUG=272460
R=skuhne@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/23567007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221461 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221460 0039d316-1c4b-4281-b951-d872f2087c98

Also add a little extra flair.

BUG=278904
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23611006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221458 0039d316-1c4b-4281-b951-d872f2087c98

Merges them to a single 'variations' target to simplify things.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23604034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221457 0039d316-1c4b-4281-b951-d872f2087c98

Apparently under windows requesting focus can trigger capture lost,
which caused all sorts of problems with tab dragging. When you've
dragged enough to initiate a real tab drag we save focus. The code
never expected saving focus to trigger a capture lost (which stops tab
dragging), which triggered the crash. The fix is to make the code
allow for saving focus to delete the TabDragController.

I'm also converting from storing a raw View* for the previously focused view to a ViewStorage id. This way if the previously focused view is deleted no crashes.

I had to add a bit of infrastructure for the test.

BUG=275931
TEST=covered by test now.
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23523018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=273137
TBR=lambroslambros@chromium.org

Review URL: https://codereview.chromium.org/23596010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221455 0039d316-1c4b-4281-b951-d872f2087c98

> Remove compositing blacklisting of 10.7 and 10.6.
> 
> Also disable vsync to see if this improves performance.
> 
> BUG=266186
> TBR=kbr@chromium.org, zmo@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/23477037

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/23537025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221446 0039d316-1c4b-4281-b951-d872f2087c98

This patch moves the test for valid handle to a more appropriate place. Currently the expectation itself in the test can cause a race condition because it implicitly looks up a shared mem pointer from a different thread.

BUG=284959
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23986002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221444 0039d316-1c4b-4281-b951-d872f2087c98

When a cancel is requested for in-flight Truncate operation,
we don't (can't) stop running the Truncate, let it run until
the end, but then return following values:
- ABORT error for Truncate (while it hasn't been really aborted)
- OK for the cancel operation (while the operation hasn't been really canceled)

This feels weird since the cancel wasn't actually processed.

Instead this CL changes the return values:
- The original status code for Truncate
- INVALID_OPERATION for the cancel operation unles the original status code is ABORT

I verified that this doesn't break existing JS behavior.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23537020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221443 0039d316-1c4b-4281-b951-d872f2087c98

Watch for filtering pref changes in ManagedModeInterstitial and unblock requests if they become allowed.

BUG=283379

Review URL: https://chromiumcodereview.appspot.com/23533014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221442 0039d316-1c4b-4281-b951-d872f2087c98

Header: (80%) #333
Message: (80%) #333
Context Message: (50%) #7f7f7f

BUG=276004

Review URL: https://chromiumcodereview.appspot.com/23530018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221441 0039d316-1c4b-4281-b951-d872f2087c98

Map glDiscardFramebufferEXT to glInvalidateFramebuffer on OpenGL ES
3.0. Both entry points have the same functionality; just the name was
changed between EXT_framebuffer_discard and ES 3.0.

BUG=274334

Review URL: https://chromiumcodereview.appspot.com/23855003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221440 0039d316-1c4b-4281-b951-d872f2087c98

For discussion, see:
https://chromereviews.googleplex.com/9784017/

BUG=255157
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23690004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221439 0039d316-1c4b-4281-b951-d872f2087c98