GitLab

Move the fake mounting logic from CrosDisksClientStubImpl
to FakeCrosDsisksClient, with some simplification.

The fake behaviors are used in FileManagerBrowserTest's
OpenZipFiles test. The test is currently disabled for
a performance reason, but I've confirmed that the test
passes with --gtest_also_run_disabled_tests.

TEST=out/Release/browser_tests --gtest_filter='*OpenZipFiles*' --gtest_also_run_disabled_tests
BUG=309506

Review URL: https://codereview.chromium.org/676423004

Cr-Commit-Position: refs/heads/master@{#302053}

Cr-Commit-Position: refs/heads/master@{#302052}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=nona@chromium.org

Review URL: https://codereview.chromium.org/648393006

Cr-Commit-Position: refs/heads/master@{#302051}

[1] Chromium-side: THIS PATCH
[2] Blink-side: https://codereview.chromium.org/686353003

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/688803002

Cr-Commit-Position: refs/heads/master@{#302050}

shishir@ and dominich@ no longer work on Chrome and are not responsive
to review requests.

Remove them from OWNERS files.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/688793002

Cr-Commit-Position: refs/heads/master@{#302049}

Review URL: https://codereview.chromium.org/680313004

Cr-Commit-Position: refs/heads/master@{#302048}

If keysym is ASCII control or space keys, directly map to keycode instead of go through the fallback maps.

A real case is de(neo) layout, AltGr+V maps to Enter key, so it should map to VKEY_ENTER instead of VKEY_V.

BUG=420544
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/664893004

Cr-Commit-Position: refs/heads/master@{#302047}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=tapted@chromium.org

Review URL: https://codereview.chromium.org/684563002

Cr-Commit-Position: refs/heads/master@{#302046}

Cr-Commit-Position: refs/heads/master@{#302045}

This change splits the WebRtc observer functionality of RtcDataChannelHandler
from the WebKit related functionality. The former belongs with libjingle's
signaling thread and the latter with the main thread. As is, these threads
are one and the same, but this will change later this week.

This is a re-land of: https://codereview.chromium.org/643693007

BUG=369796
TBR=perkj

Review URL: https://codereview.chromium.org/689783002

Cr-Commit-Position: refs/heads/master@{#302044}

TBR=isherman

Review URL: https://codereview.chromium.org/551403003

Cr-Commit-Position: refs/heads/master@{#302043}

chrome://imageburner was replaced by the new recovery tool
http://google.com/chromeos/recovery.

With this change, chrome://imageburner just redirects to
the new recovery tool page.

Note that the D-Bus client code (ImageBurnerClient) is not removed
because it's used in imageWriterPrivate API, used in the new
recovery tool.

BUG=344279
TEST=open chrome://imageburner and you are redirected to http://google.com/chromeos/recovery

Review URL: https://codereview.chromium.org/679633002

Cr-Commit-Position: refs/heads/master@{#302042}

This CL breaks out the command handling (command creation and session information restore) from |SessionService| into |SessionServiceCommands|, which does have no dependencies on Browser or Content.

Furthermore it breaks out the command handling from |BaseSessionService| into |BaseSessionServiceCommands|. This way the |PersistentTabRestoreService| and the |SessionService| can keep using the base command set which is used by both users.

BUG=424679
TEST=covered by existing tests

Review URL: https://codereview.chromium.org/672083002

Cr-Commit-Position: refs/heads/master@{#302041}

This is applying r301168 to the app-list item in addition to
TileItemView.

BUG=425724
R=calamity@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/686363003

Cr-Commit-Position: refs/heads/master@{#302040}

BUG=412078

Review URL: https://codereview.chromium.org/693453002

Cr-Commit-Position: refs/heads/master@{#302039}

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/683583002

Cr-Commit-Position: refs/heads/master@{#302038}

When an HTTPS and/or HTTP proxy was manually configured, WebSocket
connections were mistakenly going direct to the origin server.

According to RFC6455, WebSocket connections should prefer SOCKS proxies,
then HTTPS, then HTTP proxies in that order. Fix the behaviour when
proxies are manually selected to match.

BUG=426736
TEST=net_unittests, manual

Review URL: https://codereview.chromium.org/678003002

Cr-Commit-Position: refs/heads/master@{#302037}

Revert of Remote assistance on Chrome OS Part IV - It2MeHost (patchset #12 id:700001 of https://codereview.chromium.org/639233002/)

Reason for revert:
Reverting due to build failure on Linux Ozone builder.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/6011

Original issue's description:
> Remote assistance on Chrome OS Part IV - It2MeHost
>
> This CL links the it2me host to the Chrome binary on ChromeOS
> behind a flag.
> The following changes are made to the it2me host so that it can be run in the browser process.
> 1. Initializes SSL server sockets and specific CPU media features on ChromeOS startup.
> 2. Fixes a crash in it2me shutdown by making It2meHost owns the ChromotingHostContext.
> 3. Replace the blocking shutdown wait on PolicyWatcher with a callback.
>    Implements policy_watcher on ChromeOS using policy services.
> 4. Re-use existing threads, url request context getters and policy service on ChromeOS.
> 5. Fixed a incorrect DCHECK regarding the color format of the frames captured on ChromeOS.
>
> BUG=334087
>
> Committed: https://crrev.com/54dde6f02d121ff745e66b57205583087ff720ec
> Cr-Commit-Position: refs/heads/master@{#302034}

TBR=jochen@chromium.org,dpolukhin@chromium.org,jamiewalch@chromium.org,kalman@chromium.org,rmsousa@chromium.org,rockot@chromium.org,wez@chromium.org,agl@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=334087

Review URL: https://codereview.chromium.org/686373002

Cr-Commit-Position: refs/heads/master@{#302036}

Namely, -Winconsistent-missing-override. While here, also
remove "virtual" from overridden methods, as per new style.
No behavior change.

BUG=428099

Review URL: https://codereview.chromium.org/692713002

Cr-Commit-Position: refs/heads/master@{#302035}

This CL links the it2me host to the Chrome binary on ChromeOS
behind a flag.
The following changes are made to the it2me host so that it can be run in the browser process.
1. Initializes SSL server sockets and specific CPU media features on ChromeOS startup.
2. Fixes a crash in it2me shutdown by making It2meHost owns the ChromotingHostContext.
3. Replace the blocking shutdown wait on PolicyWatcher with a callback.
   Implements policy_watcher on ChromeOS using policy services.
4. Re-use existing threads, url request context getters and policy service on ChromeOS.
5. Fixed a incorrect DCHECK regarding the color format of the frames captured on ChromeOS.

BUG=334087

Review URL: https://codereview.chromium.org/639233002

Cr-Commit-Position: refs/heads/master@{#302034}

Also unforks some code and does a TODO(estade).

R=alekseys@chromium.org
TBR=vitalybuka@chromium.org
BUG=383955

Review URL: https://codereview.chromium.org/682863004

Cr-Commit-Position: refs/heads/master@{#302033}

R=alekseys@chromium.org
TBR=vitalybuka@chromium.org
BUG=383955

Review URL: https://codereview.chromium.org/677983007

Cr-Commit-Position: refs/heads/master@{#302032}

BUG=341353

Review URL: https://codereview.chromium.org/687413002

Cr-Commit-Position: refs/heads/master@{#302031}

Not actually visible to the user. It is not supposed to regenerate the
icon if the fifth or greater item changed. Due to an off-by-one error,
it would still regenerate the icon if the fifth item changed (which is
unnecessary).

NB: Tests are incoming (which would have caught this error).

Also harden a DCHECK (fixing a similar off-by-one error, and making it
into a CHECK because it would be a security issue if it failed).

BUG=425444

Review URL: https://codereview.chromium.org/681373004

Cr-Commit-Position: refs/heads/master@{#302030}

This should be useful when debugging resource management.

BUG=None
TBR=sky@chromium.org as an owner of new DEPS dependency ui/wm/public

Review URL: https://codereview.chromium.org/687533002

Cr-Commit-Position: refs/heads/master@{#302029}

To call GetWindow(), make overridden methods of AppActivityProxy public.
(this should be OK as AppActivity is doing the same thing and these methods become public with static_cast<Activity*>).

BUG=None

Review URL: https://codereview.chromium.org/659493007

Cr-Commit-Position: refs/heads/master@{#302028}

TBR=arv@chromium.org
BUG=427867

Review URL: https://codereview.chromium.org/684143005

Cr-Commit-Position: refs/heads/master@{#302027}

BUG=428571
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/652263003

Cr-Commit-Position: refs/heads/master@{#302026}

BUG=428568
TEST=manual

Review URL: https://codereview.chromium.org/691673002

Cr-Commit-Position: refs/heads/master@{#302025}

This isn't expected to be reached but would help diagnose failures.

BUG=424024
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/690753003

Cr-Commit-Position: refs/heads/master@{#302024}

R=dfalcantara@chromium.org, nyquist@chromium.org
TBR=sky

Review URL: https://codereview.chromium.org/687393002

Cr-Commit-Position: refs/heads/master@{#302023}

Review URL: https://codereview.chromium.org/681163002

Cr-Commit-Position: refs/heads/master@{#302022}

BUG=412156

Review URL: https://codereview.chromium.org/687733006

Cr-Commit-Position: refs/heads/master@{#302021}

BUG=None

Review URL: https://codereview.chromium.org/689803002

Cr-Commit-Position: refs/heads/master@{#302020}

Enhanced bookmarks should be calling the the EnhancedBookmarkModel
to do create/modify actions rather than the regular BookmarkModel
so that we are sure that fields get populated stars-related
metadata.

BUG=415817

Review URL: https://codereview.chromium.org/685953002

Cr-Commit-Position: refs/heads/master@{#302019}

Namely, -Winconsistent-missing-override. While here, also remove "virtual"
from the functions I'm marking override, like our new override style dictates.
No behavior change.

BUG=428099,417463

Review URL: https://codereview.chromium.org/690613005

Cr-Commit-Position: refs/heads/master@{#302018}

TBR=yurys
BUG=

Review URL: https://codereview.chromium.org/690863002

Cr-Commit-Position: refs/heads/master@{#302017}

This pulls in the following changes, including Windows build fixes. It
also gets Win32 assembly working.

03a739d Build Win32 with Yasm rather than MASM.
3e700bb Get MASM output working on Win32.
2a0f342 Fix standalone bio_test and v3name_test on Win64.
5f51c25 Add -cipher option to bssl client.
8f1ef1d Fix double-frees on malloc failure in ssl3_get_client_key_exchange.
93d67d3 Refactor ssl3_send_client_key_exchange slightly.
2af684f Add tests for ECDHE_PSK.
491956c Fix ECDHE_PSK key exchange.
48cae08 Add tests for PSK cipher suites.
b06711c Move the X509_NAME typedef into x509.h.
e167976 Make EVP_DigestVerifyFinal return only zero or one.
3cac450 Add SSL_SESSION_to_bytes to replace i2d_SSL_SESSION.
773bb55 Fix build (broken by removal of key_arg from SSL_SESSION parsing).
eb380a4 Fix build on Windows.
aeb8d00 Add less dangerous versions of SRTP functions.
7001a7f Don't bother accepting key_arg when parsing SSL_SESSION.
3b73c18 Fix "integer constant is too large for 'long' type" errors.
7571292 Extended master secret support.
89abaea Reimplement i2d_SSL_SESSION using CBB.
83fd6b6 Reimplement d2i_SSL_SESSION with CBS.
fbe6f49 The empty contents are not a valid ASN.1 INTEGER.
b5b6854 Add CBB_add_asn1_uint64.
9f2c0d7 Remove T** parameter to ssl_bytes_to_cipher_list.
2a39eae Don't condition on another header's #include guard.

BUG=338884, 418820

Review URL: https://codereview.chromium.org/664663004

Cr-Commit-Position: refs/heads/master@{#302016}

This CL builds the ppapi_proxy, ppapi_shared and ppapi_ipc libraries
for nacl_helper_nonsfi.
It is now for just making sure it is built properly. It will be actually used
from nacl_helper_nonsfi in a following CL.

BUG=358465
TEST=Ran trybot. Built nacl_helper_nonsfi on top of this CL, and made sure some browser tests actually work well locally.

Review URL: https://codereview.chromium.org/652393003

Cr-Commit-Position: refs/heads/master@{#302015}

Refactor Cubic congestion control to separate out PRR into a distinct
class.

Merge internal change: 78703144
https://codereview.chromium.org/688593002/

Move receive_window_ from BbrTcpSender and TcpCubicSender to
QuicSentPacketManager, since it's not specific to a congestion
algorithm.

Merge internal change: 78692549
https://codereview.chromium.org/687093002/

Gathering ClientConnectionStats at suitable times (near the end of
request handling and after receiving final ACK).

Exported kNumberOfNacksBeforeRetransmission for gathering
ClientConnectionStats.

Merge internal change: 78688302
https://codereview.chromium.org/687083002/

Deprecate rolled out flag FLAGS_close_quic_connection_unfinished_streams_2

Merge internal change: 78683497
https://codereview.chromium.org/639823010/

Close the QUIC connection if too many sent or received packets are
outstanding.

Protected by FLAGS_quic_too_many_outstanding_packets.

Merge internal change: 78666674
https://codereview.chromium.org/682413002/

Remove QUIC_VERSION_21 from supported versions.

Will remove it entirely later, after QUIC_VERSION_19 is removed.

Merge internal change: 78604601
https://codereview.chromium.org/682383003/

Turning off CID truncation for proxied connections.
Turning on CID truncation by default, since chrome will do it by
default.

Turning off CID truncation for proxied connections for QUIC.

Merge internal change: 78599095
https://codereview.chromium.org/683263003/

Protect UpdateRTT from negative send deltas

Prevent negative send_deltas from being incorporated into the various
RTT calculations.  AFAIK, it's not happening now, but it doesn't hurt to
be vigilant against future bugs.

If we're getting such RTTs, it's due to some pathological error that
we'd like to know about.

Added a unittest for these corner cases.

Low-impact. Don't use negative samples in QUIC rtt calculation.

Merge internal change: 78580114
https://codereview.chromium.org/687883002/

Protect against the divide by zero error in QuicBandwidth::TransferTime.
Currently some send algorithms may return QuicBandwidth::Zero.

Merge internal change: 78578198
https://codereview.chromium.org/684043002/

Add a QUIC connection option, 'NTLP', to disable tail loss probes by
setting max_tail_loss_probes_ to 0, in order to evaluate it's
performance benefit.

Merge internal change: 78465187
https://codereview.chromium.org/682283003/

Adding an option for peers to negotiate the length of the QUIC
connection ID sent to them.     This is a functional no-op until Chrome
starts sending this configuration option, at which point it can still be
turned off via FLAGS_allow_truncated_connection_ids_for_quic

Also fixing quic config to not have protected member variables while I'm
in there, because it was irritating me.

Allowing truncated QUIC connection IDs.   Off by default.

Merge internal change: 78462599
https://codereview.chromium.org/687033002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/691483003

Cr-Commit-Position: refs/heads/master@{#302014}