- 02 Oct, 2020 40 commits
-
-
Ioana Pandele authored
This requires changing the end margin to ensure that the text is spaced 16dp from the end when there is no button icon. Screenshot on the bug. Bug: 1134164 Change-Id: I2c24a3a2be80ed555761fcee5dc6e25e46fca286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443251Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#813171}
-
Mark Mentovai authored
In Xcode 12.2b2, strip and some other tools depend on a new library, libcodedirectory.dylib. It needs to be included in the hermetic toolchain packages, otherwise, links that request stripping will produce errors such as: [9770/76120] LINK clang_x64/symupload FAILED: clang_x64/symupload clang_x64/symupload.dSYM/Contents/Info.plist clang_x64/symupload.dSYM/Contents/Resources/DWARF/symupload TOOL_VERSION=1601523428 ../../build/toolchain/mac/linker_driver.py -Wcrl,strippath,../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip ../../third_party/llvm-build/Release+Asserts/bin/clang++ -B ../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ -Wcrl,dsym,clang_x64 -Wcrl,dsymutilpath,../../tools/clang/dsymutil/bin/dsymutil -Wl,-fatal_warnings -stdlib=libc++ -arch x86_64 -Wl,-dead_strip -Wl,-no_data_in_code_info -Wl,-no_function_starts -nostdlib++ -isysroot ../../build/mac_files/xcode_binaries/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.10.0 -Wl,-ObjC -Wcrl,strip,-x,-S -Werror -o "clang_x64/symupload" -Wl,-filelist,"clang_x64/symupload.rsp" -framework Foundation dyld: Library not loaded: @rpath/libcodedirectory.dylib Referenced from: /opt/s/w/ir/cache/builder/src/out/Release/../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip Reason: image not found Traceback (most recent call last): File "../../build/toolchain/mac/linker_driver.py", line 287, in <module> Main(sys.argv) File "../../build/toolchain/mac/linker_driver.py", line 103, in Main linker_driver_outputs += linker_driver_actions[name](args) File "../../build/toolchain/mac/linker_driver.py", line 137, in <lambda> lambda full_args: action(sub_arg[len(name):], full_args)) File "../../build/toolchain/mac/linker_driver.py", line 223, in RunStrip subprocess.check_call(strip_command) File "/opt/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/subprocess.py", line 190, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['../../build/mac_files/xcode_binaries/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip', '-x', '-S', 'clang_x64/symupload']' returned non-zero exit status -6 This is relevant to the mac-arm64 official build. Bug: 1134565 Change-Id: I9b20dd6b740117056739065d35c5016567af0935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445909 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813170}
-
Greg Thompson authored
Flakes. BUG=1134562 TBR=jophba@chromium.org Change-Id: I012988badf77fb9c22f36569e447a029c3be5bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445869Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#813169}
-
Manu Cornet authored
This works with more flavors / installs of Python without affecting existing ones. Change-Id: Ia3766d7e1c1359a25fd3b1ce91a740e658339480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443621 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Andrew Shulaev authored
base::BindOnce can't be used, because SetGdbDebugStubPortListenerForTest expects RepeatingCallback to be passed. Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit# Bug: 1007635 Change-Id: I5e9966e86618b1953d19c80b053227cdcb712e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440618 Commit-Queue: Andrew Shulaev <ddrone@google.com> Auto-Submit: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813167}
-
Nicolas Ouellet-Payeur authored
Previously, IPH code would listen to other profiles' events, for the "reopen tab" feature. This is overkill, since events from a second profile shouldn't trigger IPH in the first profile. Bug: 1134314 Change-Id: I95cf63ab90949d03532f951c29b4db17f34cd654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443756Reviewed-by:
Collin Baker <collinbaker@google.com> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#813166}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5b5abd79106a..3b7b4f25ef29 2020-10-02 ilnik@webrtc.org Fix libyuv includes for libyuv roll 2020-10-02 auorion@microsoft.com Reland "Begin implementing WGC CaptureFrame" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1d634103f73b63b36f7edd45edd43c428fd48d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445294Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813165}
-
Claude van der Merwe authored
The true state of the back-end cannot be determined at the time of success callbacks to cryptauth through DeviceSyncClient because the remote device cache is not yet updated. This caused a second unnecessary network request to be sent out when the success callback was triggered because the back-end state could not be verified. This CL fixes the duplicate network request by changing the success callback function to infer the state of the back-end based on whether the network request attempted to enable or disable wifi sync. Bug: 1117619 Change-Id: Icec19d21954c60a6d90603f346f7136bfd5b3d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439518Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#813164}
-
Andrei-Laurențiu Olteanu authored
Add not null annotation to all types. Change indentation to accommodate change. Bug: b:162051831 Change-Id: I6c4ddc44733b46e5d09526eb073a41d3acab28b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350422Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#813163}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df861c520636..935a915963e1 2020-10-02 taylori@google.com Merge "perfetto-ui: Fix details panel height" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I556a3d0bf54c129a3777d6970083f31dcaa5546a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445291Reviewed-by:
-
Lalit Maganti authored
This CL adds the include_imports flag to protoc when generating descriptors. This flag is necessary to support any sort of imports in proto files as GN does not have support for transitively listing all the source files in a target and its deps. Since now include_imports silently looks at other source files other than the ones listed in the target, this means we need a depfile to allow ninja to pick up if changes are made in transitive dep source files. Unfortunately, protoc's depfile generation is broken out of the box and does not work with ninja. Add support in the wrapper script to correct this mirror what we do in Perfetto to achieve the same thing (see [1]) [1] https://cs.android.com/android/platform/superproject/+/master:external/perfetto/tools/protoc_helper.py Change-Id: Ib330520232280b3a8a9eb80a397fac2f3cd1e076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440887Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Lalit Maganti <lalitm@chromium.org> Cr-Commit-Position: refs/heads/master@{#813161}
-
Paula Vidas authored
When Sync starts, interested data types and the FCM token are written to device info, and RefreshLocalDeviceInfo() is triggered. That can happen before the device info provider gets initialized, which then causes the check in SendLocalDataWithBatch() to fail. Since local device info is sent when everything is initialized, we can just ignore the request to refresh if the initialization is not finished. Bug: 1082115 Change-Id: I884e31853c3f9160ef960c01081b7c69aa9ce578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445169Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Paula Vidas <paulavidas@google.com> Cr-Commit-Position: refs/heads/master@{#813160}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601326576-88be268f41c8e627e3f353defda83bb3fe16d327.profdata to chrome-win32-master-1601451302-334bfff7bf6218115c999c2dee8e0af417339490.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9f77cceb382f9f04d1a02f6e0c881772ab7ebf31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440458Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I574d638fc2c32556fc53cf3d7d00258247cc97b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443013Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813158}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I37d6a625c366cbe94f16be2816fc51862efd90f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442541Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813157}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I911b1aa65b22ad2b2db8059b39feee9479ab003d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440608Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813156}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: If211f5339a4d621243704a946f06b884bd7e6a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442832Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813155}
-
Takuto Ikuta authored
Change-Id: I750c4bd9c159957d7b2f0cfff3d2f6118599f7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444615 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#813154}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9cecd7b60ead..89a7ef9f2dd9 2020-10-02 jobay@google.com Typecheck quick_open/QuickInput.js with TypeScript 2020-10-02 changhaohan@chromium.org TypeScriptify elements/ElementsTreeElement.js 2020-10-02 wolfi@chromium.org Fix double scrollbar when using huge fonts 2020-10-02 alexrudenko@chromium.org Fix heap snapshot saving 2020-10-02 tvanderlippe@chromium.org Typecheck sources/CSSPlugin.js with TypeScript 2020-10-02 alexrudenko@chromium.org Reland "Convert inspector_overlay to TypeScript" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296,chromium:1131801 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I619ad048c52fa23f4937e2f1fd466581315525fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445065Reviewed-by:
-
Chong Gu authored
Make fuchsia-ssh-port flag optional. Pass on ssh config file directly to gpu tests Bug: 1133039 Change-Id: Iefdf83760965d140463d14d7c083d3d2276c6411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436519 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#813152}
-
Jan Wilken Dörrie authored
This change drops remaining usages of autofill::PasswordForm in the password_manager component in favor of password_manager::PasswordForm. The usages in components/password_manager/core/common/ have been inlined at the call sites, which live in //c/p_m/core/browser. Bug: 1067347 Change-Id: I4902283af38b9b16589541c70d05b06ea26dfb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436529 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#813151}
-
Paula Vidas authored
Deregistration from old invalidations is moved from the constructor to the Initialize() method. The change is needed because invalidator_->RegisterInvalidationHandler() calls OnInvalidatorClientIdChange(), which cannot be called before the SyncEngineImpl is initialized, since it uses the sync_task_runner_. CreateBacked() helper is removed from the tests because it's not needed anymore. Bug: 1082115 Change-Id: I2846acf63eb0d245576b5ec65a435b522db05a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442969 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
-
Jan Wilken Dörrie authored
This change drops usages of autofill::PasswordForm in //c/b/android in favor of password_manager::PasswordForm. TBR=mamir Bug: 1067347 Change-Id: I76d503a30aac561a633f17c2925c56335abd1df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445269 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I804134a7a0042fb2c1172e4d5163f760178a8ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442737Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813148}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ic2936815867eb60aae58f59e1b6ff229ebd8e112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443134 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813147}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I966303321f4d8f90504d11d9f42b0eab3cfce0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440846Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813146}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ided224b9b9eb717dd63589500816322af1574e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443014Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813145}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I3103d4651d05671a5b795a39cb2c052ae3d7abcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443149 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813144}
-
Yunke Zhou authored
Bug: 1134052 Change-Id: Ia6dcf95339d38029b1de4fa9234d1bc7910ba932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440532Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#813143}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Icfd0d38fc491303aaec2a9249843c117e164c005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440845Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813142}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1fd3e5d89a8f..7530bab30c12 2020-10-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5efa84e2 to 7b91afe9 (507 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I85c54b1a4566c2fc0308bd56ecf899fefdb23db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445055Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbeee8fe0c0b..686769e47bba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC grt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1098447,chromium:1128767,chromium:1130058,chromium:1133956,chromium:1134287 Tbr: grt@google.com Change-Id: I2a02d7a7b2f2312be7509a13a8eb7d159880902a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444830Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813140}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I9a5412ea3b92fd3322bb26b062b829a457dba7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443249Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813139}
-
Greg Thompson authored
This reverts commit f533db5c. Reason for revert: Breaks sequential running of PRE_ tests. See, for example, ChromeTracingDelegateBrowserTestOnStartup.StartupTracingThrottle failures in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20(1)/82236. Each PRE_* test must run to completion before the next one is started. Original change's description: > [Jobs]: Convert test launcher to using jobs. > > Test launcher relies on the fact that TaskScheduler won't have more > concurrency than max_tasks to control |num_parallel_jobs|. The > TaskScheduler is allowed to run more tasks concurrently than > |max_tasks| when some of these tasks are blocked. > This CL converts Test launcher to using Jobs and ensures that > |runner_count_| concurrency is respected. > > Bug: 905788 > Change-Id: Ia090271e11b322140da1bf7e1526f4ba16bfb524 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414556 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812145} TBR=fdoray@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 905788 Change-Id: I82463e729c7be1bd7dc5d73ba90b1715f7d9bba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445013Reviewed-by:
-
Josh Simmons authored
Any app may initiate this outside of Stable, but Stable builds require the app to be signed by the same cert (as is case with AGSA/Assistant). This is controlled by the "TranslateIntent" Feature and is off by default. With this change, the translate backend can now change the target language (on the Android platform only). Previously this was only initiated via the UI. A new method, OnTargetLanguageChanged(), has been added to TranslateInfoBarDelegate to notify the UI when the translate target has changed. This method can be a no-op on iOS and WebLayer because neither of those platforms will experience these backend language changes. Test with: adb shell am start -a org.chromium.chrome.browser.translate.TRANSLATE_TAB -e "com.android.chrome.translate.target_language_code" "de" -e "com.android.chrome.translate.expected_url" "current url" org.chromium.chrome or without a target language: adb shell am start -a org.chromium.chrome.browser.translate.TRANSLATE_TAB -e "com.android.chrome.translate.expected_url" "current url" org.chromium.chrome Design doc here: https://docs.google.com/document/d/1xZR09XTTGgY0F00_lFOEX7nUc0oqgSrCs5lZFU9INA0/edit Change-Id: I8f08e849778e3fed97a61b499e2baa6569ea5385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215254 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#813137}
-
Matthias Körber authored
This CL adds the new address types to the histogram enum definitions to allow recording user-changed-after-autofill events. Change-Id: Idb2cfe178571dfab74e4a2907184e1f0eb3fdf0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445011 Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#813136}
-
George Burgess IV authored
Unless it's guaranteed that `std::forward` always turns into an rvalue ref, using `std::move(x)`, where `x`'s type is a universal reference, is generally unsafe. `std::forward` is preferred for these cases. Bug: 1134310 Change-Id: I834deb0fe22dea2c9907f8596a5f32ae8810e10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443245 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#813135}
-
Robbie Gibson authored
The experiment has performed well at 50%, and we are ready to ramp to 100%. Bug: 1056781 Change-Id: I17ff0d44e3b5a8ba5dcc54d7b520e7484890a1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380656 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#813134}
-
Jazz Xu authored
This CL fix the drop down icon layout bug: the title view should not take all the empty spaces. Bug: 1133026 Change-Id: I1b6f85c84d03fd06bd219fef06ca49319d700408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442089 Auto-Submit: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#813133}
-
Christian Biesinger authored
Specifically for orthogonal flows. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010 Change-Id: I0c686ab34071d15bce3b6dbf5b870b6abacbf201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441481 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#813132}
-
