- 07 Jan, 2020 4 commits
-
-
Avery Musbach authored
Consistent with UpdateDropTargetBackgroundVisibility, RearrangeDuringDrag shall have a dragged item parameter rather than a dragged window parameter. OverviewWindowDragController has the item which is what RearrangeDuringDrag really needs in the first place, meaning it is unnecessary that OverviewWindowDragController gets the window from the item and then RearrangeDuringDrag gets back the item from the window. Also, when RearrangeDuringDrag calls SetBoundsAndUpdatePositions, for dragging from the top or from the shelf, ignored_items shall be {} instead of the confusing {nullptr}. Bug: None Change-Id: Ia724128f6dcaf0adc71fa69f4501309e3994c398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987827Reviewed-by:Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#728708}
-
Pavel Yatsuk authored
- A few SearchEngineStatusIcon related values are passed through and shouldn't be retained - mVoiceRecognitionHandler made private and checks for null are removed as it is created in ctor. - LocationBarTablet uses cached mVoiceSearchEnabled instead of calling mVoiceRecognitionHandler - mUrlFocusChangeInProgress made private - SearchActivityLocationBarLayout explicitly sets the property to display mic button even when location bar is not focused instead of manipulating visibility through focus change percent R=pnoland@chromium.org BUG=1035210 Change-Id: I38435e0d7b5363e7ae05cb58f257af800a6ca0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972785 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#728707}
-
Dave Tapuska authored
There is a downcast in resizing the segmented buffer into a single buffer. If it exceeds wtf_size_t it shouldn't be truncated but crash. BUG=1034491 Change-Id: I877b314277fb2b219ff59b11ea043da743948139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988512Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#728706}
-
Carlos IL authored
MixedContentSiteSetting will launch to stable, this CL enables the feature by default and removes it from the fieldtrials_testing_config. Bug: 987294 Change-Id: I7967b5be2cb3abab712693f0d95881b36aa35784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967885 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#728705}
-
- 06 Jan, 2020 36 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a46886a357c..8ccbcf70c079 Created with: gclient setdep -r src-internal@8ccbcf70c079 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1037892,chromium:790886,chromium:972084 Tbr: jbudorick@google.com Change-Id: Iffba2bda383a1bc8f24205c22ceb728b2d32d49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988696Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728704}
-
Christopher Thompson authored
Bug: 1039339, 1037656, 1037558, 1037551, 1037544, 1037263 Change-Id: Ib882922e81418ee02262c496e0dedb5d0fcb4dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988686 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#728703}
-
Istiaque Ahmed authored
It currently uses param_type::StrongAlias(..) to construct the type, which seems wrong as param_type = util::StrongAlias<TagType, UnderlyingType>. Which causes following compile error: In file included from ../../ipc/ipc_message_utils_unittest.cc:5: ../../ipc/ipc_message_utils.h:1075:10: error: missing 'typename' prior to dependent type name 'param_type::StrongAlias' *r = param_type::StrongAlias(value); ^~~~~~~~~~~~~~~~~~~~~~~ Call StrongAlias constructor directly to fix this. Add a regression unit test to fix the regression. Bug: None Change-Id: If172c83abd22498117c47a8721b7d9057c18a1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983570Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728702}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I13975f359746cbe1bb4ddd7f8c7b64387fdd1a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987704Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#728701}
-
Benjamin Beaudry authored
We had this bug with UIA that was preventing us of navigating with word or character inside of empty objects devoid of a static text child. e.g. <div> <label for="input1">Some text </label> <input id="input1"> </div> In this case, when reading by word/character using UIA, we would never jump inside the empty input since it doesn't have a text child in the AXTree. The same would happen with any object embedded in text that is devoid of static text child, such as images and text areas. While I investigated this issue, I stumbled upon the concept of "embedded object characters" which is used for IA2 and ATK. I couldn't use it the same way it is used in those other accessibility APIs, but the idea behind this CL is the same. This CL introduces the concept of empty object replacement characters. When an empty object is replaced (only with UIA), the character is treated the exact same way as an ordinary character in a text node would be. The expectations are the same as if there really was an "empty object replacement character" (the character used for empty object, U+FFFC) inside this node. For now, all leaf nodes that aren't text are considered as empty objects expect the document node and ignored nodes. I don't think this will be causing issues, but I can be wrong. If it is, we'll scope down the condition inside of IsEmptyObjectReplacedByCharacter(). Known issue: crbug.com/1028843 Bug: 928948 Change-Id: Ic2e7d37495615dce19258630a39aaa2f5b7c88f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937858 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728700}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4ada619d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6070533875b12057ede2af9282d0f6f83a749d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988681Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728699}
-
Peter Kasting authored
This isn't actually used except by tests, which can be rewritten to not need it. Bug: none Change-Id: Ia9f5957f161aea8bb57625729a14e1d214660ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982623Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728698}
-
meacer authored
This CL adds a list of Greek characters that look like Latin characters. A domain consisting only of these characters and not having a .gr ccTLD or other Greek TLDs such as .ελ will be converted to punycode, as is done for other whole-script-confusables such as Cyrillic and Hebrew. Bug: 722167 Change-Id: Id0157503c605a6a73eb49147c26b48d5995d1ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986209 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#728697}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1ca8124e..fcd83e09 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I67867d71115b2a60146664a01a795273aa85ba3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988680Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728696}
-
kjd564 authored
Recent changes to the scheduler have revealed a race condition with this benchmark. This benchmark is triggered when we do a frame and DidUpdateLayers is called. After the benchmark completes, the impl will schedule a NotifyDone task on the main thread and the results will be recorded when that task is run. The change made in the scheduler will prioritize BeginMainFrame at set intervals. What was happening in the regression was a race condition between NotifyDone and the next frame. If a frame was run before NotifyDone, it would trigger DidUpdateLayers and the benchmark would run a second time, adding its results to the previous runs results, effectively doubling them and causing the benchmark results to oscillate between two ranges of timing. This change fixes this by checking a boolean that tells us whether the benchmark has already been run before running it. Bug: 1030954 Change-Id: Iade1bc20c0cc43e643293f23a631c11c3ff9653e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986970Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#728695}
-
Dave Tapuska authored
Reland 547be407. It was previously reverted because CFI bot started to fail. That was fixed here: crrev.com/2708646c Since the class is no longer memcopied between processes we can use virtuals. - Add virtual destructor - Add pure virtual cloning - Remove memset - Remove size attribute BUG=836826 TBR=nasko@chromium.org,bokan@chromium.org,jbroman@chromium.org Change-Id: I091683184ada8d693c11f8cb7aff9dae3eaf93e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988849Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#728694}
-
Tarun Bansal authored
Add a new field trial param to the config. The param was added to Chromium in M-80. Change-Id: I2532c680e24456cda42a10ee2e0cde3df6dc6a92 Bug: 983721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988207 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728693}
-
jongdeok.kim authored
This CL makes omnibox clear input text while reloading current page by context menu. Bug: 583241 Change-Id: I8e14a781bf03e239913aac7c3d9b85a71e50fa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984788Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers: - components/metrics/ - components/metrics_services_manager/ as well as the minimal set of dependent client code to keep everything compiling. Fixed: 1007701, 1007702 Change-Id: I42231f52b33478d4e874b0ecd96d1a4ccab5313f Tbr: siggi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977854 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#728691}
-
Sophie Chang authored
Code to even log this from Previews land was removed in M79 Change-Id: I649467f73f909f73cba940f32710196ab2807023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988852Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Connie Wan authored
Remove the ShouldPaint logic in TabGroupView because it's already handled in TabStrip::PaintChildren(): https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip.cc?l=2088&rcl=2170efeafe8ee9cafa678d8d1bae67f8182798a8 Also simplify TabStrip::StoppedDraggingView(), which was handling group headers in a hacky way. The group header handling is now more explicit and separate from the deleted-tab logic. Bug: 1034169 Change-Id: I7e87387e6cb89863cb6a0d4b5b706c3ef14d780e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988678 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728689}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/87d31381588b..96f79f6db56b git log 87d31381588b..96f79f6db56b --date=short --first-parent --format='%ad %ae %s' 2020-01-06 cwallez@chromium.org Validate SetVertexBuffers' slot is less than kMaxVertexBuffers Created with: gclient setdep -r src/third_party/dawn@96f79f6db56b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1034808 Tbr: cwallez@google.com Change-Id: I8ba4473774276100387884943231025378eb17dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728688}
-
Emily Stark authored
This CL short-circuits OmniboxViewViews::UpdateSchemeStyle() for non-https/https URLs. Before a recent change (https://chromium-review.googlesource.com/c/chromium/src/+/1986189), this would have been a no-op. UpdateSchemeStyle() already short-circuits when the security level is NONE or WARNING, and non-http/https URLs are set to NONE or WARNING by GetSecurityLevel() in the security_state component. As of https://chromium-review.googlesource.com/c/chromium/src/+/1986189, there's a rare case in which a non-http/https scheme can be mapped to DANGEROUS. This case is as follows. When the user allows a page to run active mixed content (by manually allowing the mixed content in content settings), the page gets marked as DANGEROUS, and every other same-origin tab gets marked as DANGEROUS as well. Before https://chromium-review.googlesource.com/c/chromium/src/+/1986189, same-origin tabs with weird URLs (about:blank or blob:, in particular) would not get marked as DANGEROUS, even though they were same-origin. Now they do get marked as DANGEROUS. Styling the scheme in this case ends up looking odd; for example, we don't want the "about" in "about:blank" to get crossed-out. Bug: 609527 Change-Id: Ief3f7d4d679059c8aa540826096ec623293ff0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987084Reviewed-by:
-
David Grogan authored
Change-Id: I0c3edddaad5ccf8522c40a8e1572ae3d3b448c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987283Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728686}
-
Austin Eng authored
These tests were disabled because uploads were hanging. The tests have now been switched to histograms and should no longer fail to upload. Bug: chromium:1035590 Change-Id: I16289ffff0ec7e2f1dcca95f9fcac014ef50531e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988909 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#728685}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/19b43a602225..a57e2eca02d1 git log 19b43a602225..a57e2eca02d1 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 capn@google.com Limit Vulkan memory allocation size to 1 GiB Created with: gclient setdep -r src/third_party/swiftshader@a57e2eca02d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0b9de7e1631af0341a079a7e2a744abc07a55468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988808Reviewed-by:
-
Thomas Guilbert authored
It appears that a merge error in 555ef226... undid the roll in 252792a1ff65deadc4e627e59ce80b... This is a reland. https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/68b4dfdbd607..252792a1ff65 $ git log 68b4dfdbd..252792a1f --date=short --no-merges --format='%ad %ae %s' 2019-12-09 tguilbert Fix null pointer addition error 2019-12-06 tguilbert Fix null pointer arithmetic Created with: roll-dep src/third_party/ffmpeg TBR: tmathmeyer Bug: 1031252 Change-Id: I4b25092bbc7681578cd0bb6f447788f2936d5a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988726 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#728683}
-
Samuel Huang authored
Courgette's algorithm allow removal for underused labels. However, this was only used by ARM, whose support is recently removed. This CL is a follow-up to remove more dead code. * Remove AssemblyProgram::TrimLabels() * Remove LabelManager::RemoveUnderusedLabels() and usage in test. Bug: 1012592 Change-Id: Ia50ee2ec9f90e35ce123463e06edc9bfb5a868af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987863Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#728682}
-
Vlad Tsyrklevich authored
Change-Id: I40ced1a170eeb5164c79f38d304f03b1319bab14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986369 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#728681}
-
Allen Webb authored
Bug: 874630 Change-Id: I248999003b3881dfc9bc941573b78fac84765fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987068 Auto-Submit: Allen Webb <allenwebb@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
-
Rodney Ding authored
- add execution context to cssPropertyID() - Design doc https://docs.google.com/document/d/1Lc3U2WV38GZ3ShTAm3-p6fbZeGJGkxL-KZfWIQ-p8GU/edit?usp=sharing Bug: 775189 Change-Id: Iaf59eba6a12158398bd976fdb74a7800afd0228d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965998 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#728679}
-
Stephen Martinis authored
This CL modifies the sorting and duplicate checks in the *.pyl files in //testing/buildbot. It adds more checks for subsections of the files; for example, each entry inside of test_suite_exceptions.pyl will now be checked, rather than just checking that the top level list of tests is sorted. A few duplicates have been removed; these won't cause any meaningful behavior change, since python ignores duplicates in dictionaries. Change-Id: I314338c904080b463ac6859011a538987a862530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986241 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728678}
-
rbpotter authored
The destinations iron-list in Print Preview has an initial height of 0, since it is sized based on its contents. This results in iron-list setting an optimal physical size of Infinity and rendering a list with length equal to the number of destinations that have been retrieved initially. This causes the dialog to be extremely slow in cases where there are many printers. Instead, set the height of the iron-list in JS before updating the list of printers it displays, and merge this logic with the logic to update the throbber (since it is performing similar compuations). Also removing unused listName property. Bug: 1038434 Change-Id: Id38ccc6252bb2bbbb2f99b67504328f17ccdff64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984717Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#728677}
-
Nina Satragno authored
Add support for the UV tokens to webauthn. When getting an assertion, if UV=true and the authenticator supports UV token, get a token and use it for subsequent operations. This allows silent credential discovery for credProtect=UVRequired credentials. Fixed: 1033225 Change-Id: I4537e76ef4803910d19d9bdc06bb920b4df6f525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975013 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#728676}
-
Peter Kasting authored
* Fixes some (but not all) "Could not delete temp dir" warnings by adding a new ThemeScoper object. This is the bulk of this change. * Fixes some tests that failed on sytems with dark mode on by default. * Cleans up some tests by removing unnecessary bits (e.g. UseDefaultTheme()/RunUntilIdle() calls on test start) and refactoring (e.g. adding a |theme_service_| convenience member alongside the existing |registry_|). Bug: none Change-Id: Ie5c3fcccda294a863c6a598a0513f076788b314d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986284 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#728675}
-
Taylor Bergquist authored
This also adjusts the internal View hierarchy for the tab counter; this will be important when the animation is changed to move the border and the text separately. Bug: 999557 Change-Id: I1f9f7d8544ca87e6ec463b29ce2370f1f88bedfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982722 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728674}
-
Mei Liang authored
This CL is the final CL that integrates all components in order to serve the CloseTabSuggestion to GTS. component that was previously landed and stripped out by Pro-guard. Binary-Size: Enables the feature by introducing a code path which used a Change-Id: If0fc9e2593fc2422494490b470a0c1b4464af65b Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959783 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
-
Jack Lynch authored
This CL adds an axe accessibility test for the Sources panel Scope pane. Bug: 963183 Change-Id: Icb24c0ae8312d38fe26eaa78903472128a01e7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668238Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728672}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3311ef65680e..f8ae5dc6d791 git log 3311ef65680e..f8ae5dc6d791 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 syoussefi@chromium.org GL: Enable EXT_gpu_shader5 2020-01-06 flibitijibibo@gmail.com Fix UWP build 2020-01-06 ericbinet@google.com Add missing steps in DevSetup 2020-01-06 flibitijibibo@gmail.com Fix GGP build 2020-01-06 lehoangq@gmail.com Metal: fix vertex attribute's conversion lost after changing buffer binding. Created with: gclient setdep -r src/third_party/angle@f8ae5dc6d791 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I08608142faf6ee51f0fdc49d0d9ce6fe74141bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988518Reviewed-by:
-
Chris Mumford authored
CrossThreadBindRepeating::MakeCrossThreadFunction was calling base::Bind to create callback. Switching to base::BindRepeating. Also modified comment in worker_thread.cc to refer to WTF::Bind so as to not encourage the use of the banned base::Bind* methods in Blink. Bug: 1007835 Change-Id: Ib880897af9f78dc5684a7c7b4cd5be557ed5563d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988507Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#728670}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed0cc5f6fd8e..a81450253f88 git log ed0cc5f6fd8e..a81450253f88 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 ehmaldonado@google.com depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock Created with: gclient setdep -r src/third_party/depot_tools@a81450253f88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I92eb147981445f3e0aa15fe5bc820d1365750e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988260Reviewed-by:
-
