GitLab

- Remove some calls to base::CreateStringValue
- pass some things by const ref instead of copying or scoped_ptr

BUG=160586

Review URL: https://codereview.chromium.org/377723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281873 0039d316-1c4b-4281-b951-d872f2087c98

This change enables running the JavaScript unit test on try bots and build bots using the browser test infrastructure. 

To run a QUnit test suite as a browser test. 
1. include third_party/qunit/src/browser_test_harness.js in your qunit test suite. 
2. Derive your browser test from QUnitBrowserTestRunner, and call RunTest with the URL of the test suite. 
3. modify chrome_tests.gypi to add the c++ source of your browser test and add your test suite as a run time dependency of the browser_tests executable 

Summary of changes: 
1. QUnit_browser_test_runner.h serves as a base class for a QUnit browser test. It navigates the browser to the QUnit test suite, calls browserTestHarness.run() and listens for the test results. 

2. browser_test_harness.js serves as a test took on the QUnit test suite. Using the window.domAutomationController, browser_test_harness.js detects whether it is running under the browser test infrastructure to auto-enable itself and report results back to the browser test.

3. Updates browser_tests.isolate so that the test can run in an isolated test environment.  See http://www.chromium.org/developers/testing/isolated-testing.

Review URL: https://codereview.chromium.org/376803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281872 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/372473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281871 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Possibly-uninitialized local variable

This also contains one cleanup change (to remove an extra set of parens).

BUG=81439
TEST=none
R=rch@chromium.org

Review URL: https://codereview.chromium.org/371213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/373233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281869 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281868 0039d316-1c4b-4281-b951-d872f2087c98

Includes a fix to shaders that affect Earth View in Maps.

BUG=391697

Review URL: https://codereview.chromium.org/378503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281867 0039d316-1c4b-4281-b951-d872f2087c98

Add helpers to RenderWidgetHelper to associate a NSView with
a given RenderWidgetHelper (process and widget routing id), so
that browser compositor swaps can be received while pausing
waiting for correctly sized frames.

BUG=388005
TBR=cevans

Review URL: https://codereview.chromium.org/370513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281866 0039d316-1c4b-4281-b951-d872f2087c98

Since g_browser_process can only be accessed by ui thread, and GoogleUpdateSettings::GetCollectStatsConsent should be called by FILE thread, it doesn't make sense to put them in the same function, which is executed through posttask on FILE thread. 

Schedules only GoogleUpdateSettings::GetCollectStatsConsent on FILE thread, and does everything else on IO thread in ShowForReal()

BUG=

Review URL: https://codereview.chromium.org/369933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281865 0039d316-1c4b-4281-b951-d872f2087c98

See the bug for a more detailed discussion of the problem when we don't make
this accessible through ADL.

BUG=391117

Review URL: https://codereview.chromium.org/367063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375538

Review URL: https://codereview.chromium.org/293253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281863 0039d316-1c4b-4281-b951-d872f2087c98

This makes GPU rasterization on Android 4.4.4 dependent on the device
whitelist, rather than being enabled for all devices.

BUG=391750

Review URL: https://codereview.chromium.org/375823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281862 0039d316-1c4b-4281-b951-d872f2087c98

Add a probability to Alternate-Protocol support. Can be enabled either via a field trial or a command line flag.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281777

Review URL: https://codereview.chromium.org/339663010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168658

Review URL: https://codereview.chromium.org/332243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281860 0039d316-1c4b-4281-b951-d872f2087c98

In M35 release, we had a lot of user feedbacks of Chrome native crash.
We had great difficulty to investigate these native crashes
because user feedbacks don't have minidumps.
    
By keeping the CHECK error message in logcat, it'd be a lot easier
to investigate these user reports of Chrome crashes.

The binary size increase: ~0.5% (188k out of 34.4M).

BUG=378974

Review URL: https://codereview.chromium.org/336413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392194

Review URL: https://codereview.chromium.org/372283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281858 0039d316-1c4b-4281-b951-d872f2087c98

This will be useful for Contextual Search to determine when to trigger.

BUG=391973

Review URL: https://codereview.chromium.org/371133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281857 0039d316-1c4b-4281-b951-d872f2087c98

Also require the list of values to be nonempty and add tests.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/375993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281856 0039d316-1c4b-4281-b951-d872f2087c98

Also add tests.

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/365993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390820
TEST=Start chrome with --new-profile-management. Choose "Not <profile>" from
the avatar bubble. In the User Manager, press 'tab' until focus reaches the
drop down arrow of a user pod. Press 'enter', whcih should show you the delete
button. Press the down arrow to focus the delete button, and press 'Enter'. This
should show the warning view, with the big red button focused, and pressing
'Enter' again should delete the pod. Yay!

Review URL: https://codereview.chromium.org/373813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281852 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281851 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13442: (dyen) Added support for log uploading for commands in toolchain_build.
r13443: (noelallen) Rolls DEPS file to get deps aware toolchains.
r13445: (dyen) Added a log_url field to package archs and recalculated revision hashes.
r13446: (ncbray) Factor arg parsing in sel_ldr into its own function.
r13447: (ncbray) Add my chromium account to OWNERS with my google account.
r13448: (dyen) Fixed repo_tools invalid reference to pynacl.
r13449: (thakis) Undo cros-specific hack now that r13435 seems to have stuck.
r13450: (ncbray) Consolidate sel_ldr's configuration logic.
r13451: (dyen) Package Version script now supports downloading build logs.
r13452: (hamaji) Non-SFI Mode: Add isatty interface

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/371413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391953
TEST=webgl conformance on gpu bots
TBR=kbr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/376703008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281848 0039d316-1c4b-4281-b951-d872f2087c98

This test skips the managed_node because it's not synced. The test
assumed that the managed_node always comes next to the mobile_node but
this is not true on iOS.

This fix changes the test to look for the managed node via
BookmarkClient::CanSyncNode, which is the correct check in the first
place.

BUG=383398

Review URL: https://codereview.chromium.org/376993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281847 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391756
TBR=craigdh@chromium.org

Review URL: https://codereview.chromium.org/375603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281845 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fixed use-after-free in LoadCallback in bookmark_storage.cc (https://codereview.chromium.org/373153002/)

Reason for revert:
Causing memory leaks:

Indirect leak of 328 byte(s) in 1 object(s) allocated from:
    #0 0x515feb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0xc334cfb in BookmarkModel::CreatePermanentNode(BookmarkNode::Type) components/bookmarks/browser/bookmark_model.cc:910
    #2 0xc326772 in BookmarkModel::CreateLoadDetails(std::string const&) components/bookmarks/browser/bookmark_model.cc:1006
    #3 0xc326553 in BookmarkModel::Load(PrefService*, std::string const&, base::FilePath const&, scoped_refptr\u003Cbase::SequencedTaskRunner> const&, scoped_refptr\u003Cbase::SequencedTaskRunner> const&) components/bookmarks/browser/bookmark_model.cc:151
    #4 0x232a4d7 in BookmarkModelFactory::BuildServiceInstanceFor(content::BrowserContext*) const chrome/browser/bookmarks/bookmark_model_factory.cc:65
    #5 0xc0bc85f in BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) components/keyed_service/content/browser_context_keyed_service_factory.cc:91
    #6 0x260de89 in ProfileImpl::DoFinalInit() chrome/browser/profiles/profile_impl.cc:657
    #7 0x260beb5 in ProfileImpl::OnPrefsLoaded(bool) chrome/browser/profiles/profile_impl.cc:881
    #8 0x260ae3e in ProfileImpl::ProfileImpl(base::FilePath const&, Profile::Delegate*, Profile::CreateMode, base::SequencedTaskRunner*) chrome/browser/profiles/profile_impl.cc:492
    #9 0x2608ddb in Profile::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) chrome/browser/profiles/profile_impl.cc:297
    #10 0x18de165 in ProfileBrowserTest::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) chrome/browser/profiles/profile_browsertest.cc:106
    #11 0x18df8f8 in ProfileBrowserTest_CreateOldProfileSynchronous_Test::RunTestOnMainThread() chrome/browser/profiles/profile_browsertest.cc:153
    #12 0x33f5434 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:427
    #13 0x2e6ca18 in Run base/callback.h:401
    #14 0x2e6ca18 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1548
    #15 0x2e69666 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:975
    #16 0x59381d7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:694
    #17 0x5c8f207 in Run base/callback.h:401
    #18 0x5c8f207 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45
    #19 0x59342e0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:594
    #20 0x5e8a153 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106
    #21 0xf0228a0 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22
    #22 0xef6cbc4 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:763
    #23 0xef69d3f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19
    #24 0xcf5b57f in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:253
    #25 0x33f2563 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:210
    #26 0x3e81941 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #27 0x3e81941 in testing::Test::Run() testing/gtest/src/gtest.cc:2057
    #28 0x3e83cd9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #29 0x3e84a66 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #30 0x3e97b7a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #31 0x3e971b0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #32 0x3e971b0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #33 0x359557c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #34 0x359557c in base::TestSuite::Run() base/test/test_suite.cc:227



Original issue's description:
> Fixed use-after-free in LoadCallback in bookmark_storage.cc
> 
> BookmarkStorage isn't ref counted anymore since
> https://codereview.chromium.org/370323002, and the LoadCallback() task
> now gets a WeakPtr to the owning BookmarkStorage. However, it gets a
> raw pointer to the BookmarkLoadDetails object, which is still owned
> by BookmarkStorage and may have been destroyed when the background
> task runs.
> 
> This happened on iOS tests after a recent merge.
> 
> TBR=sky@chromium.org
> BUG=165760
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281830

TBR=siggi@chromium.org,gab@chromium.org,sky@chromium.org,joaodasilva@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=165760

Review URL: https://codereview.chromium.org/379643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281843 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/379603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281841 0039d316-1c4b-4281-b951-d872f2087c98

Disable smoothness.tough_webgl_cases on Mac since it is failing: http://build.chromium.org/p/chromium.perf/builders/Mac%2010.6%20Perf%20%285%29

BUG=373812
NOTRY=True

Review URL: https://codereview.chromium.org/373173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392147
TEST=Start Chrome with --new-profile-manager, and click on "Not <name>"
from the avatar bubble. In the User Mnaager, press tab until you get
to the Guest/Add user buttons. They should be underlined, and pressing
Enter should perform the correct action

Review URL: https://codereview.chromium.org/373163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281839 0039d316-1c4b-4281-b951-d872f2087c98

onCloudDeviceStateChanged will now notify users when the state of an mDNS device
has changed.

This is a modified reland of http://crrev.com/280932 that should fix the test issues.

BUG=383167

Review URL: https://codereview.chromium.org/333243006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391302

Review URL: https://codereview.chromium.org/373033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281837 0039d316-1c4b-4281-b951-d872f2087c98

Ownership of the bookmark node is temporarily passed to the task to avoid leaking it if the task never runs. This fixes a leak that occurs in Profile browser tests.

R=gab@chromium.org,joaodasilva@chromium.org
TBR=brettw@chromium.org
BUG=391508

Review URL: https://codereview.chromium.org/372663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281836 0039d316-1c4b-4281-b951-d872f2087c98

from lazy_background_page_apitest.cc

BUG=354046
TEST=browser_tests --gtest_filter=LazyBackgroundPageApiTest.*

Review URL: https://codereview.chromium.org/366253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281835 0039d316-1c4b-4281-b951-d872f2087c98

Addresses crash in M37 since multi-profiles are turned on by
default and user_id hash should be present at all times.

BUG=316985

Review URL: https://codereview.chromium.org/374913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281834 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/371363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281832 0039d316-1c4b-4281-b951-d872f2087c98

detect_host_arch.py already knows how to figure this out, so reuse it.
(It could probably be used in the darwin and maybe even in the windows
branch too.)

BUG=368384
TEST=nacl_integration on http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/ goes green
TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/373253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281831 0039d316-1c4b-4281-b951-d872f2087c98

BookmarkStorage isn't ref counted anymore since
https://codereview.chromium.org/370323002, and the LoadCallback() task
now gets a WeakPtr to the owning BookmarkStorage. However, it gets a
raw pointer to the BookmarkLoadDetails object, which is still owned
by BookmarkStorage and may have been destroyed when the background
task runs.

This happened on iOS tests after a recent merge.

TBR=sky@chromium.org
BUG=165760

Review URL: https://codereview.chromium.org/373153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281830 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334602

Review URL: https://codereview.chromium.org/357413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281829 0039d316-1c4b-4281-b951-d872f2087c98

This is a split of https://codereview.chromium.org/315323002/ after patchset #3.

There's more optimization done on a PGO build than on a regular one, this results in some "Unreachable code" warnings that we don't see normally. Currently this warning is disabled for the PGO builds because it triggers on some places like this one.

BUG=380175

Review URL: https://codereview.chromium.org/321273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281828 0039d316-1c4b-4281-b951-d872f2087c98

Just as the title says. The only bot crashing was the GN which is stuck on J.

BUG=363783

Review URL: https://codereview.chromium.org/379503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281827 0039d316-1c4b-4281-b951-d872f2087c98