- 10 Dec, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f013e8b39651..e0582c36727b Created with: gclient setdep -r src-internal@e0582c36727b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1032272,chromium:1032343 Tbr: jbudorick@google.com Change-Id: Ieb93e5b3f78af7e5b75ed05db323911a01cc6449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960774Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723538}
-
Toni Barzic authored
Shelf orientation changes also change the space available for app list layout, and may cause app list layout/config changes. Generally, when not in tablet mode, this is addressed by dismissing app list when the shelf orientation changes (and updating layout when the app list is shown again). This cl adds similar handling for the case when tablet mode is started (which is expected to cause shelf orientation change for side-shelf) - the app list is dismissed, and then reshown again (with proper is_side_shelf() value). BUG=1031681 Change-Id: Ic7f1c442362e3aab6f544768d2cddaa8e042294e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955923Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#723537}
-
Liquan (Max) Gu authored
Why: Currently, PageInfo shows the page-info dialog for Tab only. Since we would like the dialog works for WebContents in general. We want to refactor PageInfoController to depend on WebContents rather than Tab. This patch is part of the effort. Change: * getOfflinePage() depends on Tab -> WebContents * isShowingTrustedOfflinePage() depends on Tab -> WebContents * TabImpl.getProfile() -> Profile.fromWebContents() * Activity -> ChromeActivity, because ConnectionInfoPopup.show() depends on ChromeActivity. Bug: 999196 Change-Id: Idb432edbbdb839d1b3cae2bfced6a4343861e7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960565Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#723536}
-
chrome://conflictsDemetrios Papadopoulos authored
Also adding JS type checking. Bug: 1028829 Change-Id: Ib8b6c924a74495bde4b649a1bc10f308a717bebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957901Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#723535}
-
Becca Hughes authored
This reverts commit d4147193. Reason for revert: Suspect CL for tree closure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/150698 Original change's description: > Add presubmit check to ensure histograms do not have both units and enum > > Bug: 1004564 > Change-Id: I6b013baa1deae61956daf0675e8ebd4e8ffb66cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959414 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Tina Lu <ltina@google.com> > Cr-Commit-Position: refs/heads/master@{#723528} TBR=mpearson@chromium.org,isherman@chromium.org,ltina@google.com Change-Id: I7634c47832c9fdea5d1b557ba223273d8744f594 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960895Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#723534}
-
Maksym Onufriienko authored
Parent cl - http://crrev/c/1940752 Bug: 1940752, 1032184 Change-Id: Ie22a25dcc9c5fd318f522326fd0bc6acfb817c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949291Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#723533}
-
Trevor Perrier authored
This CL uses the refactor in two previous CLs [1][2] to add "af" as a as a locale to Android bundles (trichrome). This is the first step in testing if locales can be added just to Android bundles. This is done by: 1) adding "af" to locales when compiled on Android 2) adding "af" .xml and .pak exports to all .grd files used by Android. It also refactors many hardcoded grit output lists in BUILD files so that future language changes do not need to edit as many files. Note on size increase: SystemWebView does not support bundles so languages can not be split. This means that even in APK builds that do not use the new locales have a size increase. Since SystemWebView should support all languages that Android does this size increase is unavoidable. [1] https://crrev.com/c/1939962 [2] https://crrev.com/c/1940949 Bug: 812837 Change-Id: Id0143cc39bb08715b9b8036c56409b58623eeea1 Binary-Size: Size increase is unavoidable (see above). Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941058 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#723532}
-
Lily Chen authored
This adds the domain and path of the cookie (in addition to the name which is already logged) to the NetLog entries for COOKIE_INCLUSION_STATUS. Since the name, domain, and path of a cookie uniquely identify the cookie, this information is helpful for debugging. Bug: 1005217 Change-Id: I74d1a77212c40a096ea76ff0b041bdab0fb31f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959659Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#723531}
-
David Benjamin authored
If c.example has HSTS with includeSubDomains and b.c.example has HSTS *without* includeSubDomains, we currently treat a.b.c.example as *not* HSTS. The b.c.example masks off the c.example entry. This behavior was, at one point, relied on by a corporate deployment per https://crbug.com/469957. However, the analysis in the bug that it matches the spec was incorrect. RFC 6797 sections 8.2 and 8.3 spell out the matching rules explicitly and they do not include the shadowing behavior. The analysis that it matches all other browsers was also incorrect. Chrome and Firefox have the shadowing behavior while Edge and Safari do not. This behavior is also surprising and increases the risk of a misconfigured site losing HSTS's security properties, particularly around cookie injection. As the first step towards fixing this, measure how often this makes a difference, Bug: 469957, 821811 Change-Id: I22cb443cd1f1a378ec1794575b9082905f74150c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955334 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#723530}
-
Peter Wen authored
Now that we have migrated to using the javac binary in third_party/jdk and only turning on the errorprone plugin when it is enabled, we no longer need this comment. Bug: 1030676 Change-Id: I27a3d8ea19da698fa74e869fdcd878ca922956c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959901 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#723529}
-
Tina Lu authored
Bug: 1004564 Change-Id: I6b013baa1deae61956daf0675e8ebd4e8ffb66cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959414Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tina Lu <ltina@google.com> Cr-Commit-Position: refs/heads/master@{#723528}
-
delima02 authored
Add method to all implementing classes. See go/hotrodsethome for more details. Bug: b:139706624 Change-Id: I7d884e259135b46715e1dbceda6e8aa85a7c32fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917970 Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Cr-Commit-Position: refs/heads/master@{#723527}
-
Victor Hsieh authored
Test: build Bug: N/A Change-Id: I7818335d0245bfdab391d1c9384e58a25a40a79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960573 Auto-Submit: Victor Hsieh <victorhsieh@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#723526}
-
Dave Tapuska authored
Move FrameMsg_SetHasReceivedUserGestureBeforeNavigation and FrameHostMsg_SetHasReceivedUserGestureBeforeNavigation to RemoteFrame and LocalFrameHost mojo interfaces respectively. BUG=1008432 Change-Id: I7dd476bd5b9475f82497c722f26d1176353cfac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957833Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#723525}
-
David Bienvenu authored
Bug: 960245 Change-Id: Ied12e6e129388e4c7a342a8ea84f163970ef8741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838212Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#723524}
-
Brian Salomon authored
Previously this was tested using SkSLCompiler. However, that type should remain private to Skia. SkRuntimeColorFilterFactory is quasi-public. ("Public" to Chrome but eventually to all). Change-Id: I9b523001c7bfce9660f86e0430e164b883e07b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958785Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#723523}
-
Matt Reynolds authored
This CL updates the expiry dates for two Gamepad API histograms: Gamepad.KnownGamepadConnectedWithId Gamepad.UnknownGamepadConnected These histograms are used to measure gamepad device compatibility with Chrome and are actively in use. I've updated the expiry dates to a year from now per the advice here: https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Expired-Histogramshttps://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Histogram-Expiryhttps://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#how-to-choose-expiry-for-histograms BUG=1018792 Change-Id: Ie675be6f54981e1ee0bb291224a0d32372a80051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958421Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#723522}
-
Michael Thiessen authored
Just added all of the src paths I could find with: find -wholename "*/java/src" -type d find -wholename "*/javatests/src" -type d find -wholename "*/junit/src" -type d And sorted the list (thanks sortmylist.com). Change-Id: I2532b28bea42c149e75bd614818e5d689b6e00f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959660 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#723521}
-
Clark DuVall authored
This change makes it so we no longer need to add asset paths to the applications context, and instead we wrap the context in a ContextWrapper which overrides getAssets() and getResources() to directly return the implementation assets and resources. This means we can no longer use WebViewFactory.getProviderClass(), since it adds asset paths internally. Instead we load the context from the WebView provider using WVF.getWebViewContextAndSetProvider() on N+, which takes care of signature verification, and load manually using createPackageContext() below N. We also need to make sure the native library is loaded so we can use the WebView shared relro implementation. Change-Id: I082107a71d1bf71069e498843a9ecc00470e6cb8 Bug: 1032662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931617Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#723520}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4c855c79362924fb96e04ef171c61f7363a82909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960178Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#723519}
-
Kevin Qin authored
Current OpenXr implementation has DXGI_FORMAT_R8G8B8A8_UNORM format, but DXGI_FORMAT_R8G8B8A8_UNORM_SRGB should be used. OpenXR's swapchain format expects to describe the texture content. The result of a swapchain image created from OpenXR API always contains a typeless texture. On the other hand, WebGL API uses CSS color convention that's sRGB. The RGBA typelss texture from OpenXR swapchain image leads to a linear format render target view (reference to function D3D11TextureHelper::EnsureRenderTargetView in d3d11_texture_helper.cc). Therefore, the content in this openxr swapchain image is in sRGB format. Fixed: 1020392 Change-Id: Id1526e4b3061c81dfb48b5b9fd4bdced7831fd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894049 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#723518}
-
Scott Haseley authored
This CL removes the priority-based anti-starvation logic from TaskQueueSelector. Anti-starvation has been disabled both in the browser and for the main thread in Blink, so this CL should not result in any additional behavior changes. This CL also replaces the backing data structure (SmallPriorityQueue) with a simplified ActivePriorityTracker, which is a wrapper around an integer representing which priorities are active. This also cleans up various unit tests: - Remove parameterized tests (with/without anti-starvation) - Fix PrioritizeCompositingAndLoadingInUseCaseLoadingTest in main thread scheduler unit tests. This was not running because it was missing an INSTANTIATE_TEST_SUITE_P, and the test was missing a comma causing it to fail. - Replace the TaskQueueSelector starvation unit tests and test for different orders of posted tasks. These were modified to be a bit more future proof/general and to test all priorities. - Remove the unit tests that test the starvation score logic. Bug: 1031336 Change-Id: I1ff8d83617d33c7510c33c08b78b1abc1a148683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954760 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#723517}
-
shrekshao authored
TBR=kbr@chromium.org Bug: 1027776 Change-Id: I5c3b6003187fcebc8e32c9d1a3d760b8d4091353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959934Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#723516}
-
Erik Chen authored
memlog_browsertests is now run as part of android_browsertests. There is no need to run these same tests in chrome_public_test_apk. Change-Id: Id058589bb87d0acf2d121f66f27b3f090b67a945 Bug: 970205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959052 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#723515}
-
Danan S authored
This is needed in order to include the view of extension permissions in other dialogs, for example the upcoming parent-permission dialog for child extension installation. Bug: 1019908 Change-Id: I82bbf76cb8622fa555c968fd2e6a1f473033c534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952525 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#723514}
-
Sergey Ulanov authored
GPU process was crashing due to NOTREACHED() being reacheable when playing video on Fuchsia. Removed NOTREACHED(). Bug: 1031793 Change-Id: I7b8e5ab9b155fe3661276871c658ec335a121960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957903 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#723513}
-
Peter Kotwicz authored
BUG=1032377 Change-Id: I54750edf0b3884cb7fde57e50c4670be6c8d2e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959416 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#723512}
-
Kevin Qin authored
Convert OpenXR test static variables to constexpr according to the code style guide. Bug: 1027794 Change-Id: Ic915a14d85df8f65baba3e363a9827b28f14bb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957130Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Zheng Qin <zheqi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#723511}
-
Dana Fried authored
GetAvailableSize() is now present on View and LayoutManager. Followup CLs will implement and add support for all LayoutManagerBase layouts including having AnimatingLayoutManager use this information to correctly plan animations. Bug: 995448 Change-Id: Iaf50c9816af1b830e348f5019f30309147cd2c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958589 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#723510}
-
Bettina authored
Previously we used to not differentiate between first sign-in and password change events for signed-in non-syncing cases because password protection only worked for Sync users. Since we're expanding it to signed-in users, differentiating them would allow us to read metrics better. Bug: 1032683 Change-Id: I801087383416e8f2d823da7c01850f8d27701098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958652Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#723509}
-
Bettina authored
Previously, SaveProtectedPasswordHash did not log a metric when a password is saved into the hash manager on first signed in. Bug: 1032322 Change-Id: I66fca65496ccd5866536d954f60e4773d66d3a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959046Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#723508}
-
Chris Mumford authored
Bug: 1007835 Change-Id: I3594e8a89bc8d424c708f54393797c3d77e9451e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951064Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#723507}
-
danakj authored
Also the derivative DownloadTargetDeterminer::CompletionCallback. R=avi@chromium.org Bug: 1007763 Change-Id: I8b943005e144826311e3d1b3c339c424f0cc1584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958895Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#723506}
-
Jérôme Lebel authored
Bug: 987646 Change-Id: I2ca468c58553ce7008467cacb36a26536986bdbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959028 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#723505}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f60da87424a4..351307eba332 git log f60da87424a4..351307eba332 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 davidben@chromium.org Fix potential indexing into an empty vector in ANGLE tests 2019-12-10 b.schade@samsung.com Vulkan: Add options to select more device types Created with: gclient setdep -r src/third_party/angle@351307eba332 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1032552,chromium:923166 Tbr: ianelliot@google.com Change-Id: If3998989530ca1091006abc1f27f14dffe7c6ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960399Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723504}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/39a8168c4ee5..be497359b6c9 git log 39a8168c4ee5..be497359b6c9 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 chiur@google.com Merge "Reland: Add proto for recording VkDebugMarkerSetObjectNameEXT" Created with: gclient setdep -r src/third_party/perfetto@be497359b6c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I615aa361326aa04dae2439231f287b0eff3f3b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960765Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723503}
-
Francois Beaufort authored
This CL makes sure "infrared" is included in the Camera2 device name to help differentiate facing front cameras with the same name. Screenshot: https://photos.app.goo.gl/qDSaDc91LfTq9Z4W9 Test: https://webrtc.github.io/samples/src/content/devices/multi/ Change-Id: Ie5569c8d4e4f93de2e0f16c462465abfa5a7810d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960152Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#723502}
-
Istiaque Ahmed authored
Calling StopAllServiceWorkersForOrigin and DeleteForOrigin on a SW context can result in ServiceWorkerRegisterJob::OnStartWorkerFinished for a job that is already in COMPLETE phase. This CL bails out setting phase in this case. Bug: 1031764 Change-Id: I863320d4dbf8606c52d8e55af017dae05d011d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959525 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#723501}
-
Lambros Lambrou authored
The launchd helper tool shows the permission wizard for all non-root users, even if the host was disabled. This CL fixes this, so that the launchd service exits immediately if the host is not set up. So the wizard is no longer shown during first installation, and will first appear when the user sets up a host. The wizard is still shown during upgrade if the host was enabled but permission was not granted. This may be harder to fix, because the helper tool (launchd service) cannot easily tell whether it was started by the installer or some other cause. Bug: 1032164 Change-Id: I3e8c742f4caf5520cc494b0322bd0f084d5fa881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960582 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#723500}
-
Raphael Kubo da Costa authored
IWYU. Follow up to commit 2b2ea3c0 ("[cros search service] Move shared string matching functions to //chrome"), which broke the libstdc++ build: ../../chrome/common/string_matching/fuzzy_tokenized_string_match.cc:199:14: error: no member named 'pow' in namespace 'std' std::pow(partial_match_penalty_rate, long_start - current - 1); ~~~~~^ Bug: 957519 Change-Id: I66f61cb4f93cfa0bfa3d1b00ba391ddd8f31a7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960310 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#723499}
-