- 29 Jan, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/190713c7cd0f..3d02384487f8 git log 190713c7cd0f..3d02384487f8 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 steveanton@webrtc.org Fix inverted DCHECK conditional 2019-01-29 steveanton@webrtc.org Use Abseil container algorithms in media/ 2019-01-29 steveanton@webrtc.org Use Abseil container algorithms in pc/ 2019-01-29 amithi@webrtc.org Removing receive RIDs and Simulcast Layers. 2019-01-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fa9574f1..ed7fd9b7 (626644:626752) 2019-01-28 terelius@webrtc.org Ignore duplicated incoming RTCP packets in RTC event log parser. 2019-01-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0a788fba..fa9574f1 (626455:626644) 2019-01-28 amithi@webrtc.org Creating Simulcast offer and answer in Peer Connection. 2019-01-28 steveanton@webrtc.org Allow use of functions in absl/algorithms 2019-01-28 Peter) Slatala Add 'UpdateAllocationLimits' in media transport. 2019-01-28 nisse@webrtc.org Add is_fec property to RtpPacketToSend 2019-01-28 titovartem@webrtc.org Add static factory method from FrameGenerator for FrameGeneratorCapturer. 2019-01-28 mbonadei@webrtc.org [clang-tidy] Apply performance-faster-string-find fixes. Created with: gclient setdep -r src/third_party/webrtc@3d02384487f8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I38967aaf2893afb73c1aaf912d894fcbff457682 Reviewed-on: https://chromium-review.googlesource.com/c/1441537Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626964}
-
jdoerrie authored
This is a reland of 8f8d11a2 Original change's description: > [base] Cleanup base::win::i18n and prepare for string16 Switch > > This change prepares base::win::i18n for the base::string16 switch and > cleans up LanguageSelectors' interface and implementation by e.g. > replacing a pair of pointers with a base::span. > > Bug: 911896 > Change-Id: If02538532908c1ea1e92044fc9f37176c085f3f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1437210 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Roger Tawa <rogerta@chromium.org> > Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626663} TBR=rogerta@chromium.org Bug: 911896 Change-Id: Ide5358f2a9e29a9f27082033614643c87cf50fc2 Reviewed-on: https://chromium-review.googlesource.com/c/1440422 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#626963}
-
Mikel Astiz authored
This reverts commit a0a86f28. Reason for revert: no flakes observed recently. Original change's description: > Mark UkmTest#singleDisableHistorySyncCheck as flaky > > Bug: 879248 > Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5 > > TBR=mastiz@chromium.org > > Change-Id: Ib2ac501729e0376eb17dc467df5be849ebf416f5 > Reviewed-on: https://chromium-review.googlesource.com/1199696 > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588157} TBR=mastiz@chromium.org,oksamyt@chromium.org Bug: 879248 Change-Id: If583a1642571675130fb2638bb8ebab2ad7a7a4f Reviewed-on: https://chromium-review.googlesource.com/c/1442253Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#626962}
-
Donna Wu authored
Bug: 908833 Change-Id: I45fac73b7ed4db17d1d8b2605c715aac977c98bc Reviewed-on: https://chromium-review.googlesource.com/c/1395963 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#626961}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/950cb58638ea..3c93600f78b3 Created with: gclient setdep -r src-internal@3c93600f78b3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3c1db355a9d4ba0ae266ab357448e98a55c59506 Reviewed-on: https://chromium-review.googlesource.com/c/1442451Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626960}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/70041cf243b8..be6549a59d50 git log 70041cf243b8..be6549a59d50 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0f073667daf0..4b2e00f4d180 (3 commits) Created with: gclient setdep -r src/third_party/skia@be6549a59d50 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: If3129e497829ddd6d432c71132372c2db40b873a Reviewed-on: https://chromium-review.googlesource.com/c/1442452Reviewed-by:
-
Jasmine Chen authored
This CL removes the arc_support note on VideoCaptureAllowed. Android P added external camera support which allows this policy to be enforced on external USB cameras as well. Bug: 914526 Change-Id: Ifa253ff7d8ffe546ded6ad88b7b6c6008c1a5408 Reviewed-on: https://chromium-review.googlesource.com/c/1433254 Auto-Submit: Jasmine Chen <lnishan@google.com> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#626958}
-
Yue Li authored
Bug: 925166 Test: Manual test Change-Id: I4e3a24023e711ed8888d8c0a9e8e6734424db8ef Reviewed-on: https://chromium-review.googlesource.com/c/1439459Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#626957}
-
Matt Falkenhagen authored
Previously, we only checked CSP upon navigation commit. That was sufficient to respect CSP when applied via <iframe sandbox>, but not sufficient to respect CSP when applied via HTTP response header, since it's before the CSP header is parsed and applied to the frame This created two bugs: - clients.get() or clients.openWindow() could resolve to a client that was really cross-origin, because it was sandboxed to a unique origin. - A service worker could control a cross-origin client. The solution is to recheck CSP after the Document is loaded, and then tear down service worker state if it's for a unique origin, as we wouldn't create that state for <iframe sandbox> in the first place. Bug: 924959, 771815 Change-Id: I291a71468fdbfc8bd38531f2d49578c458b32e85 Reviewed-on: https://chromium-review.googlesource.com/c/1438775 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Bo Liu authored
Change it to isTabbedModeComponentName which also allows <package name>.Main pattern. See internal bug b/122899279 Change-Id: Iee3f920a59101ffda334f83f286c7b2320508598 Reviewed-on: https://chromium-review.googlesource.com/c/1441647 Auto-Submit: Bo <boliu@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#626955}
-
Dominik Röttsches authored
Blink text segmentation works on UChar* buffers. Define an adapter class that can iterate over the Blink UTF-16 buffers returning character classes that are compatible with the Ragel grammar that we will be using for scanning text runs for text presentation or emoji presentation. The Ragel grammar and generated code can be found here. https://github.com/googlei18n/emoji-segmenter Integration to a Chromium mirror is tracked in https://crbug.com/925792. Bug: 892589 Change-Id: I76c9a4e4aa63eaf8bcd4b3d4e8a8111bb5244a4a Reviewed-on: https://chromium-review.googlesource.com/c/1439298 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#626954}
-
Guido Urdaneta authored
This is required for Onion Souping the MediaStream module. Bug: 921006 Change-Id: I2ce54d8a3d49d95b6e9954483cc5ec7e75c06b11 TBR: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1437625 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#626953}
-
chrome://invalidationsTanja Gornak authored
The following timestamps are collected: * When the active account has loged in * When the token was updated for the active account * When the active account has loged out. * When instance id was requested and recieved * When service was started and stopped Bug: 924957 Change-Id: I2f6839a9dd2858342372977d34ae35cfb59639f8 Reviewed-on: https://chromium-review.googlesource.com/c/1439076 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
Bug: 924864 Change-Id: Iefbd3a429f8e76c0c91c3ef15caba042a3366b0e Tbr: fdoray@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1442341Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#626951}
-
Yuta Kitamura authored
Bug: v8:8319,926016 Change-Id: Id4e9751bbad3bf769608905acc704d22907b69b4 Tbr: dmurph@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1442344Reviewed-by:
-
Lutz Justen authored
Right now, cryptohome has its own copy of the file. The goal is to get rid of that. Therefore, this CL adds the version field used by cryptohome. However, it changes it to optional since Chrome unit tests don't set it (and 'required' is not recommended, anyway). The file is mirrored to Chrome OS with the protofiles ebuild. BUG=chromium:775087 TEST=Tryjobs Change-Id: I0852f5f96d4d012f3e44f3f7d7560817c670e14e Reviewed-on: https://chromium-review.googlesource.com/c/1436367 Auto-Submit: Lutz Justen <ljusten@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#626949}
-
Julie Jeongeun Kim authored
This CL moves account_consistency_method.cc/h from the signin component's 'internals' GN target to its 'shared' GN target as it has only an enum. Bug: 925345 Change-Id: I10873fba052a879d53f373b7b905c0aa4d472bc2 Reviewed-on: https://chromium-review.googlesource.com/c/1442039Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#626948}
-
Dominick Ng authored
The use of this member was removed as a part of addressing crbug.com/904566. This CL completes the clean up. TBR=rbyers@chromium.org BUG=904566 Change-Id: Iba297c9c623ad33005d2f868eddfa4401abc819c Reviewed-on: https://chromium-review.googlesource.com/c/1442078 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#626947}
-
Dominick Ng authored
BUG=None Change-Id: Iaa8eebeef8cb9169255918bf299562fa83926d4f Reviewed-on: https://chromium-review.googlesource.com/c/1440802Reviewed-by:
-
Pavol Marko authored
As a preparation for CL:1404078, where CertificatesHandler::HandleDeleteCertificte will access a CertInfo field. Bug: 872785 Change-Id: Iff4428f03d7b22be9fa2cef34c6f20b76af5fb7e Reviewed-on: https://chromium-review.googlesource.com/c/1436360Reviewed-by:
-
Yutaka Hirano authored
Bug: 894819 Change-Id: I9d1af51eff828564aa748742355e84695b6a1de7 Reviewed-on: https://chromium-review.googlesource.com/c/1442340 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#626944}
-
Stephane Zermatten authored
Before this patch, buttons were always displayed on prompt. That was incomplete: it did not allow reproducing the behavior we currently have between scripts where button appear as a result of DOM changes. With this patch, prompt button reproduce the between-script behavior, allowing buttons to be shown only conditionally. Bug: 122825639 Change-Id: I53eee48156cac1f2e5f1b81dd86a48bb25566a0c Reviewed-on: https://chromium-review.googlesource.com/c/1437084 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#626943}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7d49c734..4a58fb5f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7df0d92af7aaa3c854d36960d95b4c4df43037f8 Reviewed-on: https://chromium-review.googlesource.com/c/1442171Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626942}
-
Makoto Shimazu authored
Bug: 894819 Change-Id: Iae4624aeddfe755ce7fd34ce797d89fc0dfad039 Reviewed-on: https://chromium-review.googlesource.com/c/1428626 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
tzik authored
This test has been disabled for rebaselining for a V8 change. Bug: v8:8124 Change-Id: Ica0becc9069be89a723b7a26a3d5aafd4fd1a415 Reviewed-on: https://chromium-review.googlesource.com/c/1441972Reviewed-by:
-
Lei Zhang authored
Change-Id: I64b2f250e6d7573a9b3a5145d1a4f4f530b813a3 Reviewed-on: https://chromium-review.googlesource.com/c/1441958Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#626939}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I041eaaba3eb8fe88f0e5513761f1d0d069ba32e6 Reviewed-on: https://chromium-review.googlesource.com/c/1442453Reviewed-by:
-
Stephane Zermatten authored
Before this patch, there were cases where the controller would enter graceful shutdown because of a script, with a successful message, and then notice an error, and change that message to an error. The error was usually caused by DidStartNavigation noticing an unexpected navigation event, triggered by an action run at the end of the last script. This patch attempts to avoid such case by: - only checking for unexpected navigation events in the PROMPT state. This specifically excludes the STOPPED and RUNNING states. - not reporting errors or accepting script updates (OnGetScript) in the STOPPED state - stopping script checks when entering the fatal error state Bug: 806868 Change-Id: I408d2652257d9524740e44c79b7fa5201ef7cc17 Reviewed-on: https://chromium-review.googlesource.com/c/1436047 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
In the previous change, I forgot to add DISALLOW_COPY_AND_ASSIGN macro to the SharedCorsOriginAccessList. Bug: N/A Change-Id: Ib23a0d04392c76eca5865632e616ff3aaf3b671e Reviewed-on: https://chromium-review.googlesource.com/c/1438779Reviewed-by:
-
Hirokazu Honda authored
crrev.com/c/1437036 makes GbmWrapper create GbmPixmap which has one file descriptor for each plane. This CL follows the change in chrome os capture stack. Bug: 911370 Test: capture_unittests Change-Id: Ia498f36d9f4edd074cba4dc8ea5bc863364297c1 Reviewed-on: https://chromium-review.googlesource.com/c/1438858 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#626935}
-
Mohamed Amir Yosef authored
This CL updates ShouldGetAllDataForDebuggingWithHiddenPassword test in PasswordSyncBridgeTest to make sure it doesn't pass if the bridge returns an empty batch. Bug: 902349 Change-Id: I089c2e6a7be3487c9b19d39896fcea5503ab74f6 Reviewed-on: https://chromium-review.googlesource.com/c/1439539Reviewed-by:
-
David Staessens authored
This CL moves code to load and manage test image files to a dedicated class. Image metadata (such as image size, checksum,...) is stored in json files accompanying the test files, so it doesn't need to be hardcoded in every test anymore. TEST=ran image_processor_test on nocturne BUG=925223 Change-Id: I94d827be438e691f8c18307227bcd86a767e24a5 Reviewed-on: https://chromium-review.googlesource.com/c/1436278 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#626933}
-
Michael Giuffrida authored
Use EXTERNAL_POLICY[_DOWNLOAD] for the manifest locations so Chrome apps are allowed to install. Bug: 925419 Change-Id: Ie65c76a28d8ebe5c63ee4d54cd2449b8759f9e18 Reviewed-on: https://chromium-review.googlesource.com/c/1437543 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
-
Tanya Gupta authored
Previously the only requirements for whether to display the option was that the feature was enabled and the user was not currently on an incognito web page. This CL adds the following requirements: - The sync type SEND_TAB_TO_SELF must be enabled. - The number of devices the user uses with sync must be >= 2. - The user must currently be on an HTTP or HTTPS page. - The user is not on an Android native page. - Active tab is not in inCognito mode Bug: 921767 Change-Id: Ifab23067d34b97f5ef1026bf906a8b6fc656176f Reviewed-on: https://chromium-review.googlesource.com/c/1399446 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#626931}
-
Makoto Shimazu authored
Previously it's marked as flaky on Linux, Windows, Mac10.10/11/12. However, even in other platforms the test looks failing sometimes, so probably it's caused by some timing issues and just fortunately it happens less frequently in some platforms. This patch marges the TestExpectations entries for the test into one entry. Flakiness dashboard for reference: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fcss%2Fvendor-imports%2Fmozilla%2Fmozilla-central-reftests%2Fflexbox%2Fflexbox-intrinsic-ratio-003v.html TBR=cbiesinger@chromium.org No-Try: true Bug: 898186,919736,879336,878316,813602 Change-Id: Id184bf7dd4d66e96b41e2872574ea10ceb9fbd46 Reviewed-on: https://chromium-review.googlesource.com/c/1442393 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1441657. This enables the queue when onmessage is assigned to. It adheres to the specification at https://w3c.github.io/ServiceWorker/#dom-serviceworkercontainer-onmessage: "The first time the context object’s onmessage IDL attribute is set, its client message queue must be enabled." This makes the test cases about "setting onmessage" in the WPT postmessage-to-client-message-queue.https.html pass, but the test file will still time out until startMessages() is implemented. Bug: 915685 Change-Id: I4c4930b48df68ee351676e5c3edfb28969fe3610 Reviewed-on: https://chromium-review.googlesource.com/c/1441734 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#626929}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8922ac230f33..4b2e00f4d180 git log 8922ac230f33..4b2e00f4d180 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 jmadill@chromium.org Suppress EmptyBuffer test on Android GLES. 2019-01-29 jmadill@chromium.org Vulkan: Use glslang's internal BUILD.gn. Created with: gclient setdep -r src/third_party/angle@4b2e00f4d180 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I954ab10a52c3bfe23656f30241e7407d98ee59c0 Reviewed-on: https://chromium-review.googlesource.com/c/1441536Reviewed-by:
-
Hirokazu Honda authored
Original change's description: > Revert "ozone: Remove mesa i965 same-fd workaround restriction" > > This reverts commit 46eb9e27. > > Reason for revert: causing tast failures on amd64-generic VM bot > > See https://bugs.chromium.org/p/chromium/issues/detail?id=923061#c2 > > Original change's description: > > ozone: Remove mesa i965 same-fd workaround restriction > > > > NOTE: This is based on crrev.com/c/549576. > > > > After Mesa same-fd for eglCreateImageKHR restriction was relaxed in > > crrev.com/c/378198/, it is now possible to remove the workaround in chromium. > > > > The changes are as follows: > > 1. ClientNativePixmapDmaBuf can map multiple plane using multiple FDs. > > 2. GLImageNativePixmap can create EGLImage using multiple FDs. > > 3. GbmBuffer/GbmPixmap manages multiple FDs. > > > > BUG=642410, 911370 > > TEST=VDA unittest and VEA unittest > > TEST=Playback with Chrome ARC++ and ARC++ DRM L1 on kevin, hana, eve > > TEST=Playback with Chrome on peach_pit and nyan_big > > > > Change-Id: I23848b8bcd0e240307633a5201b4b8e58b374282 > > Reviewed-on: https://chromium-review.googlesource.com/c/1362777 > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > > Reviewed-by: Pawel Osciak <posciak@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#623686} > > TBR=rjkroege@chromium.org,posciak@chromium.org,dcheng@chromium.org,dcastagna@chromium.org,hiroh@chromium.org > > Change-Id: Ie9620b2022ec37ca5e55613d4fbe63247d357862 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 642410, 911370, 923061 > Reviewed-on: https://chromium-review.googlesource.com/c/1418124 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#623761} TBR=rjkroege@chromium.org,posciak@chromium.org,dcheng@chromium.org,dcastagna@chromium.org,bpastene@chromium.org,hiroh@chromium.org Bug: 642410, 911370, 923061 Change-Id: I2dff0f134380be418d21ac7dc90e49f802f11b90 Reviewed-on: https://chromium-review.googlesource.com/c/1437036Reviewed-by:
-
Matt Falkenhagen authored
The spec has a concept of execution ready, defined (for documents) to be when a Document is created and assigned to a Window: https://html.spec.whatwg.org/multipage/webappapis.html#concept-environment-execution-ready-flag Clients that are not execution ready should never be exposed to JavaScript as a Client object. In particular, Clients API like clients.get() and clients.openWindow() should not resolve to a non-execution-ready client. Before this CL, we considered a client to be execution ready upon navigation commit. This was too early, as the document might not yet be created. There are two motivations for fixing this timing: 1. (https://crbug.com/915685) Client.postMessage() is supposed to queue the message until the Document reached DOMContentLoaded. It's difficult to implement that correctly if postMessage can be posted on a non-execution ready client, since by the time the message arrives, we might look at the Document and see it is not parsing (HasFinishedParsing() returns true), therefore conclude it reached DOMContentLoaded. In fact, the Document might have just been created and not started parsing yet. 2. (https://crbug.com/924959) It's incorrect to expose Clients that are sandboxed to a unique origin via CSP HTTP response header. By waiting until Document creation, we can detect this sandboxing and not resolve the client. This CL splits the concept of "execution ready" into "execution ready" as in the spec, and "response committed" as in commit navigation. This unblocks, but does not fix, the bugs listed above. Bug: 924958, 924959, 915685 Change-Id: Ic4b515aa24057cce3d5961a88ca0de0b789390dd Reviewed-on: https://chromium-review.googlesource.com/c/1438678Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#626926}
-
Vikas Soni authored
Supress Pixel_BackgroundImage test which is flaky on Nexus 5X(android-marshmallow-arm64-rel trybot). Bug: 883500 Change-Id: I54412764b19e8cea273f98594cc8c6ad2ba1507b Reviewed-on: https://chromium-review.googlesource.com/c/1441312 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626925}
-
