GitLab

BUG=252425
R=cpu@chromium.org
TEST=Dr. Memory no longer reports the mismatch

Review URL: https://codereview.chromium.org/16983011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207829 0039d316-1c4b-4281-b951-d872f2087c98

BUG=247212

Review URL: https://chromiumcodereview.appspot.com/17167006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207827 0039d316-1c4b-4281-b951-d872f2087c98

Previously, it was not possible to produce unofficial builds without
DCHECKS and DLOGS.

Review URL: https://chromiumcodereview.appspot.com/17165003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207826 0039d316-1c4b-4281-b951-d872f2087c98

This is continuation of the original CL (https://codereview.chromium.org/16223006/), which didn't account for Blink tests using WebTestProxy.

BUG=245126

Review URL: https://chromiumcodereview.appspot.com/17114006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207825 0039d316-1c4b-4281-b951-d872f2087c98

BUG=251116

Review URL: https://chromiumcodereview.appspot.com/17101020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207824 0039d316-1c4b-4281-b951-d872f2087c98

Unit tests fail on Mac Dbg with this patch:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%284%29&number=29470
and
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%284%29&number=12750

> Differential updates for components. We are adding support for delivering delta updates for Chrome components. Initial platform support for the patcher is Windows only. The update response includes both the full update and, if available, the differential update. The differential update is tried first, then the full update, if needed.
> 
> BUG=245318
> 
> Review URL: https://chromiumcodereview.appspot.com/15908002

TBR=sorin@chromium.org

Review URL: https://codereview.chromium.org/17551004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207823 0039d316-1c4b-4281-b951-d872f2087c98

> Turn on touch drag and drop and touch editing by default on chromeos.
> 
> BUG=168162
> 
> Review URL: https://chromiumcodereview.appspot.com/16268020

TBR=varunjain@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/17068008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207820 0039d316-1c4b-4281-b951-d872f2087c98

Also, adds #endif comments to make the tests more readable.

Review URL: https://chromiumcodereview.appspot.com/17198011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207817 0039d316-1c4b-4281-b951-d872f2087c98

When the flag --enable-translate-settings is on, the user can configure which language should be translated.  When so, even though the page is written in the user's locale language, the infobar should appear.

TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/17157015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163552

Review URL: https://chromiumcodereview.appspot.com/17101027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207815 0039d316-1c4b-4281-b951-d872f2087c98

This element caused an assertion failure in libjingle at xmpp/xmppengineimpl.cc:367 when used from the client-side code.

Review URL: https://chromiumcodereview.appspot.com/16975019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207814 0039d316-1c4b-4281-b951-d872f2087c98

The crash on startup in the referenced bug is very bad in part because
the corrupt index which caused it is left on disk, so all startups
until user data is cleared will crash. For maximum safety, we should
unlink the index file ASAP after finding it is corrupt.

R=rdsmith@chromium.org
BUG=251465

Review URL: https://codereview.chromium.org/17265007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207813 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51644
TEST=none
R=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17052008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207812 0039d316-1c4b-4281-b951-d872f2087c98

Revert a workaround commit r20158 for a Use-After-Free issue (http://crbug.com/244746) because a cleaner CL r207218 is landed.
URLRequestContext does not inherit SupportsWeakPtr now.

R=mmenke
BUG=244746

Review URL: https://chromiumcodereview.appspot.com/16870008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133742

Review URL: https://chromiumcodereview.appspot.com/16516003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207810 0039d316-1c4b-4281-b951-d872f2087c98

* Remove Solo card support, as Solo cards have been decommissioned permanently since March 31, 2011.
* Update the BIN range for DiscoverCard to include 644-649.
* Correct the BIN ranges for Diner's Club and JCB cards.
* Add test coverage

BUG=246497
TEST=CreditCardTest.GetCreditCardType
R=estade@chromium.org
TBR=joi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16254010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207809 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/16472007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207808 0039d316-1c4b-4281-b951-d872f2087c98

When adding response to the cache, it removes "http://",
but when getting response from the cache, it does not.
As a result, no content is fetched out from the cache
even for urls in the cache.

BUG=

Review URL: https://chromiumcodereview.appspot.com/16354006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207807 0039d316-1c4b-4281-b951-d872f2087c98

This is part of an effort to componentize NaCl code.
BUG=244791

Review URL: https://chromiumcodereview.appspot.com/16154005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207806 0039d316-1c4b-4281-b951-d872f2087c98

Differential updates for components. We are adding support for delivering delta updates for Chrome components. Initial platform support for the patcher is Windows only. The update response includes both the full update and, if available, the differential update. The differential update is tried first, then the full update, if needed.

BUG=245318

Review URL: https://chromiumcodereview.appspot.com/15908002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207805 0039d316-1c4b-4281-b951-d872f2087c98

> bookmarks: Convert "Remove" link into a LabelButton.
> 
> This also tweaked all the paddings/spacings all around to make the bubble really closer to the mocks.
> 
> BUG=231694
> TEST=ctrl+D or press the star button in the omnibox, observe the Bookmark Bubble,
> there should be a "Remove" Button in the left side of "Edit.." button.
> R=msw@chromium.org, sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/16279002

TBR=tfarina@chromium.org

Review URL: https://codereview.chromium.org/17413014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207804 0039d316-1c4b-4281-b951-d872f2087c98

The URL was incorrectly wrapped in LTR / RTL formatting
characters.

BUG=249497

Review URL: https://chromiumcodereview.appspot.com/17151013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207803 0039d316-1c4b-4281-b951-d872f2087c98

This also tweaked all the paddings/spacings all around to make the bubble really closer to the mocks.

BUG=231694
TEST=ctrl+D or press the star button in the omnibox, observe the Bookmark Bubble,
there should be a "Remove" Button in the left side of "Edit.." button.
R=msw@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/16279002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207802 0039d316-1c4b-4281-b951-d872f2087c98

Seem to broke chromium.chrome runhooks.
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/30753

> Use new logos in requestAutocomplete splash page.
> 
> BUG=243555
> 
> Review URL: https://chromiumcodereview.appspot.com/17472002

TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/17553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207801 0039d316-1c4b-4281-b951-d872f2087c98

The win_aura builder appeared to have trouble running
animations in
DesktopBackgroundControllerTest.SetDefaultWallpaper; this
version of the change splits that test into several smaller
tests so that animations can be avoided.

Original change:

ash: Add flags for specifying default wallpaper.

This adds new command-line flags for specifying image files
that will be used as default wallpaper:

  --ash-default-guest-wallpaper-large
  --ash-default-guest-wallpaper-small
  --ash-default-wallpaper-large
  --ash-default-wallpaper-small

This makes it easier for Chrome OS to have per-device custom
wallpaper. (We previously loaded the default wallpaper from
a resource file, but that prevents the same build of Chrome
from being used on different devices.)

BUG=248764

Review URL: https://chromiumcodereview.appspot.com/17502005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=252670
TBR=bartfab@chromium.org

> Add device policies to control accessibility settings on the login screen
> 
> This CL adds device policies that provide control over the default state
> of the following four accessibility settings on the login screen:
> * Large cursor
> * Spoken feedback
> * High contrast mode
> * Screen magnifier type
> 
> The User can temporarily override the settings but the defaults are
> restored whenever the login screen is shown anew or the user remains idle
> on the login screen for one minute.
> 
> BUG=225955, 225956, 243350, 247298
> TEST=New unittests + new browsertests + manual in VM
> 
> Review URL: https://chromiumcodereview.appspot.com/16658015

TBR=bartfab@chromium.org

Review URL: https://codereview.chromium.org/17068004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207799 0039d316-1c4b-4281-b951-d872f2087c98

Flaky tests were restored without removing flakiness.

> InstantExtended: Don't create overlay, again.
> 
> Also, re-enable 25 of our tests that were randomly commented out.
> Several don't work anymore.
> 
> BUG=247717
> TEST=Yes.
> TBR=samarth@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/17523002

TBR=jered@chromium.org

Review URL: https://codereview.chromium.org/17444007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207798 0039d316-1c4b-4281-b951-d872f2087c98

This change effectively revert essential part of https://chromiumcodereview.appspot.com/16770002
It is at least second regression introduced by this changes.

BUG=252442,251261
TEST=manual
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/17526006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207797 0039d316-1c4b-4281-b951-d872f2087c98

TBR=robertphillips
BUG=250525

Review URL: https://codereview.chromium.org/17231005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207796 0039d316-1c4b-4281-b951-d872f2087c98

The NativeTextfieldViews cursor color is hard-coded black.
Instead, set the cursor color to Textfield::GetTextColor.
This supports more Windows high-contrast black themes, etc.
However, if Windows has red text, they'll get red cursors.
(I think accessibility trumps that questionable coloring)
(also, the native behavior is worse in my ugly test theme)

BUG=252385,131660
TEST=Views Textfields cursors match their overall text color; meets accessibility requirements without other seriously negative effects.
R=oshima@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17517005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207795 0039d316-1c4b-4281-b951-d872f2087c98

BUG=248508

Review URL: https://chromiumcodereview.appspot.com/17511006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207794 0039d316-1c4b-4281-b951-d872f2087c98

BUG=251685
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/17457002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207792 0039d316-1c4b-4281-b951-d872f2087c98

R=isherman@chromium.org
BUG=168967

Review URL: https://chromiumcodereview.appspot.com/17391012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207791 0039d316-1c4b-4281-b951-d872f2087c98

Also, re-enable 25 of our tests that were randomly commented out.
Several don't work anymore.

BUG=247717
TEST=Yes.
TBR=samarth@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207790 0039d316-1c4b-4281-b951-d872f2087c98

If the host passes the desktop shape region in a VideoPacket the client will use it to draw transparent regions. The client also informs the web-app of the desktop shape changes, so it can set the input passthrough region correctly.

Review URL: https://chromiumcodereview.appspot.com/17511004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=251905

Review URL: https://chromiumcodereview.appspot.com/17503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243555

Review URL: https://chromiumcodereview.appspot.com/17472002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207787 0039d316-1c4b-4281-b951-d872f2087c98

It seems that when waking from sleep we may miss device change
notifications and end up in a perpetually silent state.

Try to avoid this by posting a task if we get into this state.  Only
do this once.  AudioManagerMac will ignore the request if no change
has taken place.

BUG=160920, 249830
TEST=no crashes. audio plays, device changes work.

Review URL: https://chromiumcodereview.appspot.com/17463009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207786 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergiu@chromium.org

BUG=248859
TEST=compile works

Review URL: https://codereview.chromium.org/17548002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207785 0039d316-1c4b-4281-b951-d872f2087c98

Issue 252615: leak in DisplayControllerTest.XWidowNameForRootWindow
Issue 252641: using uninitialized memory in LevelDBDatabaseTest.CorruptionTest
Issue 247685: disabled the failing ScreenCaptureDeviceTest.Capture

BUG=252641,252615,247685
TBR=eugenis@chromium.org

Review URL: https://codereview.chromium.org/17231003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207784 0039d316-1c4b-4281-b951-d872f2087c98