- 14 Nov, 2019 40 commits
-
-
Elly Fong-Jones authored
This change begins breaking dependencies outside //ui/views on DialogClientView. The overarching goal here is to make DialogClientView private to //ui/views, with DialogDelegate presenting the only interface for clients of Views to manage/interact with dialogs. This will also make it easier to move some logic (ie: the AcceptDialog/CancelDialog wrappers this change adds) entirely into DialogDelegate later on. Bug: 1011446 Change-Id: I49c1b435ff57faf41beae7b51c6a5f430f0631cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912805Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715269}
-
Xiyuan Xia authored
Update autotestPrivate.getAppWindowList to carry relevant overview item info under overview mode. It would be used to check whether an item is being dragged, whether a window is closed as expected, and whether a window snapped. Bug: 1007060 Change-Id: If7fdbcb77fa327d268f9edbfec7986cae0c52f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914599Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715268}
-
Elly Fong-Jones authored
These two items are now in the Tab menu, reusing the existing strings and machinery from the context menu. I considered adding separate descriptor strings but it seemed like extra work for no particular gain. This is the design we settled on during our offline discussion :) Bug: 1017344 Change-Id: I5fe6798d4bf0f217e3065373d43d0ec217a4bcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913974Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715267}
-
Alex Clarke authored
This will help us diagnose any client related performance issues from traces. Change-Id: Iafe9ac796aca317d8eaee9a9bf10890ba719a1df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900993 Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#715266}
-
Luke Zielinski authored
This roll is mainly triggered by staleness rather than pulling in a key feature. The main changes contained in this version are: - new lint rules (Ahem system font, missing deps) - new commands (./wpt testpaths) - mobile browser support ..and various bug fixes, tweaks etc. Change-Id: I6a8e82ba20cc0462fc63d520e8b9389d0faba182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914964 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#715265}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf04d632. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." 85e02f50 "[Trusted Types] Test that a policy rejection blocks eval." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I2c98983f24d5f414e4fe4806e9571abd2fbe0d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917039Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715264}
-
Ankit Kumar 🌪️ authored
With the introduction of PP_PrivateAccessibilityPageObjects two members link_count and image_count of PP_PrivateAccessibilityPageInfo are unused. This CL removes both the members from the struct. Bug: 1020097 Change-Id: I74d0d8914a98cca12879bf53a59260209f65ab1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892637 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#715263}
-
Mugdha Lakhani authored
Before this chance, we were calculating the soonest wakeup_delta across all storage partitions every time there was a change in state of any storage partition, to schedule a wakeup task with this delta. This change builds on the fact that we have running timers representing delays for each of the storage partitions with active registrations in the scheduler. I've changed scheduling the wakeup task to a push system. Each storage partition informs the scheduler of its soonest delay after there's any change in state. If this requested delay is the smallest of all the current delays of the timers the scheduler has, it schedules a wakeup task. Canceling delayed scheduling causes cancellation of the wakeup task if none of the storage partitions need it. The change also removes now unnecessary code. Unit tests are also added, and integration tests updated. Bug: 996166 Change-Id: I1e6216ecc7085535a8e0ca0075ddad05085df763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834086 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#715262}
-
Dominik Röttsches authored
When document.fonts.load() is called with font specification such as '1px ""' (containing two quotes) as the argument, CSS font property parsing parses this successfully as the empty string. FontFaceCache was not prepared to handle that correctly. Fix FontFaceCache to guard against that. Add test to actually ensure that this font specification's load promise resolves successfully. In parallel, raised https://github.com/w3c/csswg-drafts/issues/4510 in CSS WG to discuss whether it would make sense to reject such a font specification at the parsing stage already. Bug: 1023206 Change-Id: If46aef0c7fcd2e06bc657480b9189857438d8cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914392Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#715261}
-
Aaron Leventhal authored
Proposal here: https://github.com/aleventhal/aria-annotations The experimental roles are now: comment, commentsection, mark, revision, suggestion. Also changed the name of the feature flag from kARIAAnnotationRoles to kARIAAnnotations, to make it more general, so that it can be used for any of the upcoming markup changes for ARIA annotations, like aria-description. Bug: 1006767 Change-Id: I3f2580b501050228c4f654e77024f89c9c13dd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907074Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#715260}
-
Lukasz Anforowicz authored
After r694827 and r710554, request_initiator is not set to the extension origin in requests initiated from content scripts. This means that the ExcludeSchemeFromRequestInitiatorSiteLockChecks exclusion (introduced in r691013) will never kick-in and can therefore be removed. For more details please also see https://crbug.com/1023442#c5 and #c6. Bug: 1023442, 940068 Change-Id: I2814ef4f9626f910f9b325a7ad5a3b54a650535b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911221Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#715259}
-
David Jean authored
Bug: 987646 Change-Id: I9e21ec812293136797b80af8c4b189331941a111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903363Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#715258}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4636c1f0..14dea250 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I712992127fd7c5a83a4f22d1bb1471ad8aa39267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916639Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715257}
-
Alex Chau authored
- Add sharing_fcm_token to SharingSpecificFields and rename current fcm_token field to vapid_fcm_token - GetToken with both VAPID authorized_entity and sender ID - Introduced SharingTargetInfo struct for sending messages - Replaced GetSharingInfo in SharingSyncPreference with more efficient methods to only read required information from preferences Bug: 1018145 Change-Id: Iab01f3866124d13fea10d70bec4faa6150ce6377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904167Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#715256}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/chrome_content_browser_client_unittest.cc This CL was uploaded by git cl split. Bug: 1018667 Change-Id: I08e044ff1aac9d05677a3041f5f757dca61124ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916870 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#715255}
-
Marc Treib authored
It didn't actually initialize anything, it was just used to pass in the user agent string. Might as well pass that into the ctor, and remove some plumbing. The original reason for this two-step initialization was apparently to move construction of the Sync user agent string off the UI thread. However, (a) even before this CL, the user agent string was in fact constructed on the UI thread, and (b) nothing in MakeUserAgentForSync looks like it could actually block. Bug: 951350 Change-Id: I691f85468988d27187dbfc9088020e10a875fd79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913258 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Alex Chau authored
- Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1905946 - Was reverted due to a flaky test, test is now disabled: https://crbug.com/1023950 - Disabled ClickToCall/SharedClipboard SyncTurnedOff browser test when UnidoOnSignIn is on as it no longer applies - Disabled Sharing registration when device is in local sync mode if deriving VAPID key as derived key is not available in local sync mode - Add DeviceInfo to allowed type in transport mode in sync_integration_tests when UnidoOnSignIn is on TBR=holte@chromium.org Bug: 1009516 Change-Id: Ia9be25489dd2e874754f3eb4527321f757468e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913403 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
-
Sam Zackrisson authored
This improves the WebRTC audio processing module adaptation on mono signals even when being played out on more than one speaker. Tested: made appr.tc calls with all combinations of mono/stereo audio, multi-channel feature flag on/off, APM in audio service enabled/disabled: verified that (locally modified) log statement for entering multi-channel is printed, verified that aecdump recordings have the right content, verified that not too much processing happens before stereo is detected Bug: chromium:1016708, chromium:1023337 Change-Id: Ia6827f26e01dba6779ab356687f7920ce9fa8703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906210Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#715252}
-
Gauthier Ambard authored
This CL makes sure that the SectionInfo variable isn't store in the "more" callback on the NTP. This is because the SectionInfo can be recreated for example when disabling/enabling the content suggestions. Bug: 1023793, 1024172 Change-Id: I8edb799baedb3d1dd811a57db77d07298d97533e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913257Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#715251}
-
Sylvain Defresne authored
With https://crrev.com/c/1912239, //third_party/breakpad no longer has any dependency on //third_party/google_toolbox_for_mac (it no longer uses GTMLogger), so remove the deps. Add missing reference to "sqlite3" on //ios/third_party/firebase that was previously pulled transitively via google_toolbox_for_mac. Bug: 1012115, 1024322 Change-Id: I963470cd5a327edb2562a873fcc283eb46b2af6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913414 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#715250}
-
Dominique Fauteux-Chapleau authored
Since testing special DM token values like INVALID_DM_TOKEN may require manually setting the DM token this makes it safer, otherwise the editor might add extra useless whitespace and mess with testing. Change-Id: I50ceafe7fa03d39c0ea8e24f80418805f3d8639a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913871Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#715249}
-
Gauthier Ambard authored
Bug: 991608 Change-Id: I7f5c8481309bf2f3be8d98586746d7db1e43f4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914387 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ae55a94ff52c..515f9bebd1f8 git log ae55a94ff52c..515f9bebd1f8 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src ab3cdcaef56e..3da910d55f20 (3 commits) Created with: gclient setdep -r src/third_party/angle@515f9bebd1f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: Ic93e03b0559a1bf5d701b1ffd94e99379e9e8d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715247}
-
Asanka Herath authored
This CL inches closer to merging the NTLM and Negotiate handlers which basically implement the same logic under different names. Servicification of Negotiate handling will then not have to deal with NTLM and Negotiate authentication schemes separately. R=mmenke@chromium.org Bug: 991265 Change-Id: I167d4fb5856f65319fe7c21636e6e4db61aa46a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907151 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/06d9a50ca1e5..9129fad98516 git log 06d9a50ca1e5..9129fad98516 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 lalitm@google.com trace_processor: add special handling of constraints on sorted cols Created with: gclient setdep -r src/third_party/perfetto@9129fad98516 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I68c7b2bb65dc934da9f4dd40ea0ae5493ebf4aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916625Reviewed-by:
-
Gauthier Ambard authored
Those tests should follow the style guide. Bug: 1023877 Change-Id: I81ba3f106426fd04d0ad256cc90b7c2dc8325d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916859 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e7498a38. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8d04fb94f036de323034ca3859ac0f4712704505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916640Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dda10ea5191d..c49e3c72fe42 Created with: gclient setdep -r src-internal@c49e3c72fe42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic681dd18ae25c3dbd24f03049aceee61886baf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916624Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715242}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/00fc2231f697..f6fc149b0b16 git log 00fc2231f697..f6fc149b0b16 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 khokhlov@google.com Reland "Remove had_failures from benchmark metadata" Created with: gclient setdep -r src/third_party/catapult@f6fc149b0b16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:990304 Change-Id: Ib92d5b9838eafa38065661b6be9ab6138d96f7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916621Reviewed-by:
-
Mathias Carlen authored
Before this patch, empty strings would be filtered before sent to the UI. The result of that was some tell_actions with single space ' ' messages to clear the status bar. This patch removes that constraint and empty strings will just remove the status message shown. As I drive by there's now a unittest for the tell action, even if that's going the wrong way in the stack ... R=arbesser@google.com Bug: b/143757287 Change-Id: I843a0cf36e246c4480de4ffa8fe59709ef576bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911211 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#715240}
-
Robbie Gibson authored
When the animation is on, there is a bug where if the user swipes left-to-right to go to the next Voiceover view during the animation, the Voiceover cursor ends up on view from the previous tab grid page, instead of the next tab grid page. This happens because the previous tab grid page's views are still accessible during the animation. To prevent this, the animation can be turned off when Voiceover is enabled. This means that when the user selects a new tab, the views immediately update. Bug: 978673 Change-Id: Id4b64f391614b8719e3f5d5d2e924df7d8983123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906348 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715239}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I21a695d9ca8a5cf376d14e10165c29dcd50fc1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916622Reviewed-by:
-
Martin Robinson authored
Instead of returning the previous text selection extents for unfocused text inputs in the ATK API, return an empty selection which matches what the visual selection shows. Bug: 1015354 Change-Id: I767f44dc52df3e4de579f6c4e6a027d72630d60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886811 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
-
Shivani Sharma authored
To experiment split cache/network stack using etld+1 this CL adds support to the Network Isolation Key to replace origins with scheme://registrable-domain. It also adds a new feature which controls whether etld+1 will be used or not. Added browser and unit tests. Bug: 1018718 Change-Id: I02adf6bbb679154c99cf4b7a1ae10ba46da00067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913062Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#715236}
-
Mike West authored
This reverts commit f5946a0a. Reason for revert: `LocalNTPJavascriptTest.RealboxTests` has failed every ChromeOS ASAN run (https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29) since this patch landed, starting in https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36112. Original change's description: > Local NTP, Realbox: fix navigation to chrome:// URLs > > Partially borrowed from https://crrev.com/c/1836021 by Archana Simha <archanasihma@chromium.org> > > Bug: 1020025 > Change-Id: I7de22a41d872ec624f25d1633782d27448988c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893824 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715106} TBR=dcheng@chromium.org,nasko@chromium.org,dbeam@chromium.org,bokan@chromium.org,mahmadi@chromium.org Change-Id: I7552853a29abc63c667e949f9147bd76ad4e9d69 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916861Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#715235}
-
Rune Lillesveen authored
We would like to return empty styles for elements which are connected but not part of the flat tree. That is, shadow host children which are not slotted or any nodes in its flat subtree. Bug: 831568 Change-Id: Ifd6ab89196a83571044ca995198e3e31c904304e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916460 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#715234}
-
nancy authored
Use the unified time format function to show the time limit in the app pause dialog. For example, hour = 1 minute = 1 Show: You can use it for 1 hour and 1 minute tomorrow. hour = 11 minute = 59 Show: You can use it for 11 hours and 59 minutes tomorrow. hour = 10 minute = 0 Show: You can use it for 10 hours tomorrow. hour = 0 minute = 10 Show: You can use it for 10 minutes tomorrow. hour = 0 minute = 0 Show: You can use it for 0 seconds tomorrow. BUG=1011235 Change-Id: I27619b2b7f999c68eabff6a337e9d54eb661db86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913360 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#715233}
-
Trent Apted authored
This is a better fit for layering/encapsulation/ownership. The tradeoff is some "slippage" in resource_ids. Bug: 996088 Change-Id: I6b5f03460c01e979da018dec757f88452a42adbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913284Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#715232}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0cbfc427a7df..06d9a50ca1e5 git log 0cbfc427a7df..06d9a50ca1e5 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 lalitm@google.com trace_processor: fix sort setting flags on correct columns 2019-11-13 treehugger-gerrit@google.com Merge "processor: Ignore track events with absolute 0 timestamp" 2019-11-13 lalitm@google.com trace_processor: add benchmarks for sorted columns Created with: gclient setdep -r src/third_party/perfetto@06d9a50ca1e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627,chromium:135177627 Change-Id: I734f1e09c24e18070eb74246507e28290370a18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916620Reviewed-by:
-
Stefano Sanfilippo authored
Change-Id: I20ce9961645deb44bab857d69a1c641600646d65 Bug: 940927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911206 Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Auto-Submit: Stefano Sanfilippo <ssanfilippo@chromium.org> Cr-Commit-Position: refs/heads/master@{#715230}
-
