- 11 May, 2019 9 commits
-
-
Daniel McArdle authored
We cannot delete the base::MD5 implementation until NaCl is removed. However, this CL effectively unships the code from binaries where NaCl is not enabled. Bug: 755368 Change-Id: I1a0b3a1f71a2798af26d2819a7112e01fb8f5781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596358 Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Auto-Submit: Daniel McArdle <dmcardle@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#658833}
-
Adam Langley authored
This change is the result of UI review for resident keys: • Update privacy string. • Update account selection title and remove description. • Merge missing capability messages for user-verification and resident keys into a single, generic message. • Tweak “storage full” message. Change-Id: Id3614020ff691c74f56118476fcb5fdb898ff44d Bug: 941120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606243 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#658832}
-
Dan Sanders authored
This CL adds two new features (both enabled by default) for testing HLS configuration: - CanPlayHls: Enables CanPlayType() and other queries for HLS MIME types. Note that disabling this feature also disables playback by navigating to .m3u8 files. - HlsPlayer: Enables WebMediaPlayerImpl to use MediaPlayerRenderer to play HLS manifests. These features can be disabled to test site behavior when HLS is not supported. Change-Id: Iba16d8d60a991ba36d88c0f5188c6189308ab5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601973Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#658831}
-
Sebastien Marchand authored
Bug: 961336 Change-Id: Ib6d553da8733e54eabf98049be85812a10cdc83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602596Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Chisoon Jeong authored
Reduce copies of PipelineMetada (which contains AudioDecoderConfig and VideoDecoderConfig) by using pass by reference. This was originally authored by Andre Rosa<andre.rosa@lge.com> Change-Id: I9ddf137d5d35154862501edcbbfe5b26c1dacbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601613 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#658829}
-
Ahmed Mehfooz authored
Will be used to display small buttons below feature pods to indicate current page. Can be clicked to switch to corresponding page. Bug: 914077 Change-Id: Ida92a7bd7ddb0cf8601e468500155822fc6f1424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576005Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658828}
-
Kristi Park authored
Hide the new shortcut layout behind a flag and re-add the old flexbox layout. Bug: 851335 Change-Id: Ic10b20f5a77874138cbd356aac98f55aa7109c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606583 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658827}
-
Alexei Filippov authored
BUG=961938 TBR=msw@chromium.org,etienneb@chromium.org Change-Id: Ic4ed7e67cdee714b46c06b913e1fee28fc2985e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606773Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#658826}
-
Kevin Babbitt authored
The omnibox sets up a "Controls" relationship with its popup. Our UIA implementation maps this to the ControllerFor property. The OS would discover this relationship and ask for the popup's fragment root. But when the popup is closed, it has no associated AcceleratedWidget, which is the key we use to look up the fragment root. The fix is in two parts. First, for UIA properties that return one or more related elements, we validate that those related elements will not immediately fail when queried by the OS for additional information. Even with that validation, it's still possible for us to return a related element that's valid at the time we check but later becomes invalid due to the widget being closed. Thus the second part of the fix is to convert the DCHECK that was hitting to an `if`. Bug: 959033 Change-Id: Ic8cf47229e45cfe1650806e6365b17aa67a614c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600408Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#658825}
-
- 10 May, 2019 31 commits
-
-
Felicia Lim authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/90cf969d61d6..68f1932090d5 $ git log 90cf969d6..68f193209 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 flim Revert "Revert "libopus: Add channel mapping 2 support in libopusdec"" 2019-05-06 msalama Default stack frames are needed on Android for the Orderfile. Created with: roll-dep src/third_party/ffmpeg Bug: chromium:958645 Change-Id: I1e59b53c569de513cd2b097021e69937aba41924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607081Reviewed-by:
-
John Budorick authored
Bug: 861983 Change-Id: Ic78e461b1ec9b7d7d66f1c87e4c7842fab77f915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606767 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#658823}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2568cf76ee2c..8ab4053f00b0 git log 2568cf76ee2c..8ab4053f00b0 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 bclayton@google.com Implement Float16 formats and additional blend modes. Created with: gclient setdep -r src/third_party/swiftshader@8ab4053f00b0 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132434966,chromium:b/132433217 TBR=swiftshader-team+autoroll@google.com Change-Id: I1c157e2d1e1daf72ba68a348dde50b75a2765998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658822}
-
Yue Ru Sun authored
Bug: 959378 Change-Id: I727cd1464c8e4c72461184871e989eec299729d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598337Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#658821}
-
Yining Wang authored
Toolbar is not showing correct content for Focus Mode Window when the site is not secure. This cl resolve this issue by processing an UI update after tab inserted to browser. Change-Id: I35c4baf20ba6c90c85a03f471c51356853e8f165 Bug: 961820 Change-Id: I35c4baf20ba6c90c85a03f471c51356853e8f165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603768 Commit-Queue: Yining Wang <yiningwang@google.com> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#658820}
-
Matt Wolenetz authored
MseBufferByPts was enabled by default in M75. This series of changes (in M76) removes: 1) (previous CL) the tests for the old "LegacyByDts" MSE buffering logic, and 2) (this change) the old "LegacyByDts" MSE buffering logic, the templating of SourceBufferStream by the buffering implementation, and the associated feature gating Later changes will remove residual complications such as the split SourceBufferRange and SourceBufferRangeByPts types and clean up confusing usage of DecodeTimestamp where it really contains a presentation timestamp within and below FrameProcessor. BUG=771349,760264,718641,398141 Change-Id: I93491bd47e8cd498b4452f9e5109eb9a7c7b9852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586461Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658819}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ab32f656538d..5c7b54112bca git log ab32f656538d..5c7b54112bca --date=short --no-merges --format='%ad %ae %s' 2019-05-10 egdaniel@google.com Fix compatible format check for vkCmdCopyImage. 2019-05-10 bungeman@google.com Remove SK_IGNORE_LINEAR_METRICS_FIX. 2019-05-10 bsalomon@google.com Fix build for GCC. Cast enum to int when using with %d format specifier Created with: gclient setdep -r src/third_party/skia@5c7b54112bca The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Change-Id: I5810257ced8af126bc92def20a970746cc716a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606983Reviewed-by:
-
Sammie Quon authored
This is a reland of 09566165. Fixed and ran locally. TBR=oshima@chromium.org Original change's description: > Reland "cros: Add tablet <-> clamshell performance test." > > This is a reland of 963bfd6e > > Could not reproduce locally with the new changes. Suspected causes for > flakiness before. > 1) Rounding down because of int means we never waited for browser to > startup. > 2) Disabling animations too early means the creation of the browser window > has an animation which may have interfered with the tablet window animation. > > Original change's description: > > cros: Add tablet <-> clamshell performance test. > > > > Test: interactive_ui_tests TabletModeTransitionTest.EnterExit > > Bug: 953896 > > Change-Id: Ie2332df2bea2f7d2a63b39d8b390fcf4b28999f8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580583 > > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#656911} > > Bug: 953896 > Change-Id: I214d12fc24f16423f323c87fa7a182eebb0ee745 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598784 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Mitsuru Oshima (slow - gardening) <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658294} Bug: 953896 Change-Id: Ifce43db563c6901a7095d4b8137e041f74cca8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606761Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#658817}
-
Alexei Filippov authored
This reverts commit d7e1ad36. Reason for revert: Likely the cause of a broken headless_browsertests https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/42776 The crash callstack mentions pdf. Original change's description: > Roll src/third_party/pdfium 3fa919347bc7..6f8388801226 (2 commits) > > https://pdfium.googlesource.com/pdfium.git/+log/3fa919347bc7..6f8388801226 > > > git log 3fa919347bc7..6f8388801226 --date=short --no-merges --format='%ad %ae %s' > 2019-05-10 thestig@chromium.org Remove impossible code related to CPDF_Type3Font. > 2019-05-10 thestig@chromium.org Fix nits in CPDF_Pattern and related code. > > > Created with: > gclient setdep -r src/third_party/pdfium@6f8388801226 > > The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=pdfium-deps-rolls@chromium.org > > Change-Id: I5a98794e854c9082d9ddecd36f0ce6ce29193eb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606621 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#658792} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,pdfium-deps-rolls@chromium.org Change-Id: I0a97472a23ee78d4faa959658176425c05b4dc8b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607146Reviewed-by:
-
Dale Curtis authored
1ad19fb1 continued the trend of incorrect statements about dav1d thread counts :/ The actual total is (t + 1) * f when configuring tilethreads=t and framethreads=f. I've triple checked this, so this will hopefully be the last update to the calculations and comments. If a system has the cores for it, we'll end up using the following: <300p: 2 tile threads, 2 frame threads = 2 * 2 + 2 = 6 total threads. <700p: 3 tile threads, 2 frame threads = 3 * 2 + 2 = 8 total threads. For higher resolutions we hit limits::kMaxVideoThreads (16): >700p: 4 tile threads, 3 frame threads = 4 * 3 + 3 = 15 total threads. Because of this correct total exceeds limits::kMaxVideoFrames for 720p content we've had to reduce the tile thread count to 4 to ensure smooth playback. Otherwise 5 tile threads and 2 frame threads is insufficient for smooth playback on my Z840. This is handled by a new combined GetDecoderThreadCounts() which outputs both tile and frame thread counts concurrently for clarity. BUG=954659,957511 TEST=printf() on pthread_create, python test program to be sure: def count_threads(f,t): threads = 0 for i in xrange(0, f): for j in xrange(0, t): if t > 1: threads += 1 if f > 1: threads += 1 return threads R=chcunningham Change-Id: Ifcf1069ee9b1a8cede82c102fddbc3c57c2036f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606192 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#658815}
-
Brad Hall authored
Tests are consistently timing out and the low shard timeout of 960 isn't helping here Bug: 957194 Change-Id: Ibacccb7b82a2d139747e9288ff2078810024c4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603493Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Brad Hall <bradhall@google.com> Cr-Commit-Position: refs/heads/master@{#658814}
-
Kenneth Russell authored
It's been promoted to community approved in Khronos' repo. Bug: 849576 Change-Id: I4212df3f5ae226fdb363882aaf1bc70089ccd983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606584 Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#658813}
-
Daniel Libby authored
In order to quantify the impact of moving scrollbar scrolls to the compositor thread, we want end to end latency metrics that we can look at during experimentation. Add a new SCROLLBAR type to LatencyInfo to facilitate this, this new type will be set on scrollbar-generated gestures so that they'll flow to the end of the latency pipeline and be logged separately, instead of as MOUSE latency as they are today. The Scrollbar latency metrics are the same as the ones that are currently gathered for wheel and touch scrolling, both for ScrollBegin (the first scroll update in a scroll gesture sequence) and for ScrollUpdate. Bug: 954007 Change-Id: I362486be76a4427df271f1cf31e4d23c12857b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595296 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#658812}
-
Kenneth Russell authored
Firefox already allows Uint8ClampedArray in the texImage entry points, so this is a behavioral difference that needs to be clarified. Tested with new WebGL conformance test in https://github.com/KhronosGroup/WebGL/pull/2887 . Bug: 961658 Change-Id: I5e2b1591b7994a3271ead7dda2ca0aebd9364526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606249Reviewed-by:
-
Karandeep Bhatia authored
This CL ensures that multiple calls to EvaluateRequest for the same request does not lead to multiple computations. To do this, the computed action is cached on WebRequestInfo. This CL was reverted since its parent CL broke Msan tests. BUG=696822, 960323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583342 Change-Id: I04d0f4cef5dea6d115fd8d353ebc4ff96dccab3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600714Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#658810}
-
Manuel Rego Casasnovas authored
When available size is indefinite we should use max size to compute the number of auto repeat tracks. The spec text is very clear (https://drafts.csswg.org/css-grid/#auto-repeat): > When auto-fill is given as the repetition number, > if the grid container has a definite size or **max size** > in the relevant axis... So far we were not doing that for widths, in this patch we modify LayoutGrid::ComputeAutoRepeatTracksCount() to do the same than for heights. We also take advantage to fix problems related to min|max sizes and box-sizing property, that were inconsistent for columns and rows. BUG=957932 TEST=external/wpt/css/css-grid/grid-definition/grid-auto-repeat-max-size-001.html TEST=external/wpt/css/css-grid/grid-definition/grid-auto-repeat-max-size-002.html TEST=external/wpt/css/css-grid/grid-definition/grid-auto-repeat-min-size-001.html TEST=external/wpt/css/css-grid/grid-definition/grid-auto-repeat-min-size-002.html TEST=external/wpt/css/css-grid/grid-definition/grid-auto-repeat-min-max-size-001.html Change-Id: I9cce24d38f1a00bea8fa04e42645c777c57e486e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588388Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#658809}
-
Toni Barzic authored
This is a reland of d80f755b TBR=antrim@chromium.org TBR=alemate@chromium.org Original change's description: > DeviceStateMixin: Update local state and support for setting policy > > Taking over rsorokin's patch at CL:1578742, given that he is OOO. > > DeviceStateMixin now initialized device state values in local > state during setup. > > Add support for setting device policy and device local account policies > in in-memory fake session manager client, in a way similar to > UserPolicyMixin. Later this functionality can be moved to a separate > mixin, which might make sense if/when we add functionality for setting > up policy served by local test policy server to this mixin (this should > already be possible using LocalPolicyTestServerMixin). > > Uses AutoLaunchedKioskTest as an example of new usage. > > Also fixes a number of tests to wirk with the new device state setup. > > Bug: 952855 > Change-Id: I1c0314a51581137d0f5a0907a09a4ef5b0bccda3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600857 > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658297} Bug: 952855 Change-Id: I966406b55aaffe78137be296a31b4b42202fe8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604186Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#658808}
-
Reilly Grant authored
This change updates UsbPolicyAllowedDevices to url::Origin rather than GURL for representing origins. The ChooserContextBase::Object constructor is also updated to take url::Origin as well since all callers now have one available even though internally the origin is still stored as a GURL. This is part of a migration effort to remove GURL from the interface of ChooserContextBase and related classes. Bug: 951785 Change-Id: I12c24f410531982c1c1e1ee5a1e7645cdf884811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604424 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#658807}
-
chrome://downloadsXing Liu authored
This CL adds a metric to track user open a URL in chrome://downloads from context menu. Bug: 957346 Change-Id: I4f681dc22a8bbfe29c3131e9268cbb26e08370e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600860 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#658806}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/91a5f8167151..ff395373a925 git log 91a5f8167151..ff395373a925 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 mbarowsky@chromium.org Pass Blink image decode TRACE_EVENT timing to rendering_metrics. Created with: gclient setdep -r src/third_party/catapult@ff395373a925 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:944756 TBR=skyostil@google.com Change-Id: I46fe723e045a68028102b554e2971695aa789655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606341Reviewed-by:
-
Kenneth Russell authored
This addition may have been what pushed this fleet over capacity. Bug: 850107 Change-Id: I9bc3678bdd1cba1fea08352bcf0f480eb12ef79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606963 Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Chris Palmer authored
Bug: None Change-Id: I92514a0a3be55c1ed746a49de0f484fd924cbe05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602741Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#658803}
-
Sunny Sachanandani authored
Frame tokens are provided by the client and the only guarantee that's enforced is that they're non-zero. Therefore, we should not DCHECK other invariants like not receiving two PresentationFeedbacks for the same token. Also add a deserialization error if the client sends a zero frame token since we have DCHECKs for that anyway. Bug: 958310 Change-Id: I4ffad483b46999c084f88ca62a0bb824522e6d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594070Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#658802}
-
Christopher Cameron authored
In SharedImageFactory::GetFactoryByUsage, only require the interop factory for OOP-raster. This side-steps a number of not-quite-yet supported situations. In SharedImageBackingFactoryIOSurface, add support for opening GpuMemoryBuffers of basic types (R, RG, and RGBA). Bug: 952063 Change-Id: I9261fdb50d4ba8dd7ffe01e44ff6079c15e30bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604329Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#658801}
-
Alison Maher authored
This change adds unit tests for ITextRangeProvider::Move for the Format unit type. The functionality for ITextRangeProvider::Move (TextUnit_Format) came automatically along with ITextRangeProvider::MoveEndpointByUnit (TextUnit_Format) (https://chromium-review.googlesource.com/c/chromium/src/+/1584596), as the Move code simply calls into MoveEndpointByUnit. Bug: 928948 Change-Id: I8b7a14158cc73bc580686f1b075125db6250c278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602381 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#658800}
-
Martin Kreichgauer authored
Bug: 961818 Change-Id: I160878b36492ed5adde3a110661bd082df0301c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606961 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#658799}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee8d4aca..fd99d6f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I345d25f1d2cd0a33fdf8236dcaa60ce74d5e554d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606108Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658798}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/059f26bcb422..cd862e37ea29 git log 059f26bcb422..cd862e37ea29 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 raul@tambre.ee gclient_scm: Decode Git output centrally for better Python 3 support Created with: gclient setdep -r src/third_party/depot_tools@cd862e37ea29 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:942522 TBR=agable@chromium.org Change-Id: Id2148c1b37ad4db40972a8168f8ae1d0bb8d10ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606626Reviewed-by:
-
chrome://downloadsXing Liu authored
This CL adds a metrics for click events on the URL in chrome://downloads for Chromenav. Bug: 957346 Change-Id: I7460f5c2268c375b32c7fbede050c194a57f3fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601691Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#658796}
-
Min Qin authored
With the introduction of SimpleDownloadManagerCoordinator, it has 2 stages. In the first stage, OnDownloadsInitialized() will be called for in-progress downloads. In this stage, clients should be able to access all the in-progress downloads. In the 2nd stage, OnDownloadsInitialized() is called for all downloads. However, if InProgressDownloadManager is passed to a DownloadManagerImpl, the DownloadManagerImpl will not return the in-progress downloads on GetAllDownloads() unless it is fully initialized. As a result, this causes a wierd issue that after stage 1, calling GetAllDownloads() sometimes may not return all the downloads until stage 2 completes. BUG=942770 Change-Id: I44e589ee1bd174c5fef86ec9c8170ac94e6e1b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603208Reviewed-by:
-
Matt Wolenetz authored
MseBufferByPts was enabled by default in M75. This series of changes (in M76) removes: 1) the tests for the old "LegacyByDts" MSE buffering logic (this change), and 2) the old "LegacyByDts" MSE buffering logic and the associated feature gating Later changes will refactor the resulting "NewByPts" logic to remove residual complications such as templating SourceBufferStream by range buffering implementation and clean up confusing usage of DecodeTimestamp where it really contains a presentation timestamp within and below FrameProcessor. Reduces media unittests count (roughly from 5635 to 5056). Also, removes the LegacyByDts portion of each mediasource_*_pipeline_integration_fuzzer BUG=771349,760264,718641,639144 R=sandersd@chromium.org CC=mmoroz@chromium.org Change-Id: I0aca7e72abbf5353294c46876751884886382d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574608Reviewed-by:
-
