- 29 Jan, 2020 40 commits
-
-
shivanigithub authored
Change-Id: Ie8ba0b911176f00be1b1cb77c0fedfe09ce229a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008288 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736607}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3796f09f..a4dcd39d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I631a5b55c968b8b98994745dc49336180f516e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028668Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736606}
-
Manu Cornet authored
This is a step in the direction of letting each shelf component be a little more independent for its layout and animation dynamics instead of relying on the shelf layout manager. Bug: 1040177, 1042911, 1044306 Change-Id: Ia06b72abc5c6e7575489abaf9a9efc0e90e4a840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028163Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#736605}
-
Tim Song authored
BUG=1011065 Change-Id: If4ddd178da9ec019623d50b3f77372be39ae487e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025884Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#736604}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/94294b48c239..1bb1301a369d git log 94294b48c239..1bb1301a369d --date=short --first-parent --format='%ad %ae %s' 2020-01-29 thestig@chromium.org Refactor code into GetJpxDecodeAction(). 2020-01-29 thestig@chromium.org Use FX_SAFE_INT32 in more places. 2020-01-29 thestig@chromium.org Updated libtiff from 4.0.10 to 4.1.0. 2020-01-29 tsepez@chromium.org Remove class CFX_GlobalArray. Created with: gclient setdep -r src/third_party/pdfium@1bb1301a369d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1012369 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Id0f957613b889dac93fe76ee6c951ccefc43fa3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028664Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736603}
-
Jazz Xu authored
Bug: 1046482 Change-Id: Ia9465e9e79ea1c992cb755ac83e676cee02e5039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025747Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736602}
-
Brandon Wylie authored
Making the eligibility variables configurable via finch. This'll allow us to alter these parameters independently of Chrome's release schedule. Doc: go/roti-chrome-design Bug: 1042087, 1041598 Change-Id: Iaf97b0ea4efdda30204596e74f6da2494aef3860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015983 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#736601}
-
Henrique Nakashima authored
Some client code modify prefs with .commit() instead of .apply(), which causes the changes to be immediately committed to disk. Bug: 1022108 Change-Id: Icda8655f0552da3c7adcb5c549397deaa943f471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018146Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#736600}
-
Joshua Bell authored
The class only ever has a single owner (StoragePartitionImpl), so remove the refcounting and change ownership to unique_ptr. Change-Id: I200c7535ba4a238dad83345be5ce10253554ba12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028688 Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#736599}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4356490b7b66..184ea66aed43 git log 4356490b7b66..184ea66aed43 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 kron@webrtc.org Reland "Reland "Reland "Distinguish between send and receive codecs""" 2020-01-29 mbonadei@webrtc.org Reland "Adds trial to use correct overhead calculation in pacer." 2020-01-29 srte@webrtc.org Reland "Reland "Only include overhead if using send side bandwidth estimation."" 2020-01-29 mellem@webrtc.org Allow non-identical datagram transport parameters. Created with: gclient setdep -r src/third_party/webrtc@184ea66aed43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I293fe3b44f45b66ee3bcf47c2d84bd98895a51a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028662Reviewed-by:
-
Kevin McNee authored
We've started rejecting activation of a portal contents with no committed navigations. We already have a test relating to 1P navigation restrictions. We introduce WPTs to cover this condition more generally. We also convert one of the bail out conditions for transferring session history to a DCHECK as this is now covered by the rejection. Bug: 942198 Change-Id: I2f4a9aae5aa3461c7c5e25a677f659a7e7d7ffc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028755 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#736597}
-
chrome://flagsJeremy Roman authored
This is needed to allow developers to turn cross-origin portals back on if necessary when we change the default to same-origin-only for the origin trial. Bug: 1013389 Change-Id: I17ca5919cb8055dc8e010caa69b18ea5d6374f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028124 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#736596}
-
Elly Fong-Jones authored
The ones in this CL are all fairly simple: * PasswordReuseModalWarningDialog calls an internal callback in all three cases. The cases are *almost* simple enough to wrap them up directly like: set_accept_callback(base::BindOnce( done_callback_, WarningAction::CHANGE_PASSWORD)); except that doing this creates multiple copies of done_callback_, which is a no-no since it is a OnceCallback. The fact that it actually is logically only invoked once but that this is invisible to the type system is annoying. * SendTabToSelfBubbleViewImpl pointlessly overrode Close() to call Cancel(), which is what happens anyway when there are no buttons. * SessionCrashedBubbleView had simple overrides that invoked methods on itself and then returned true, so these are just inlined now. * SettingsResetPromptDialog just called into its controller and returned true in all three cases, so these are now inlined. * StoragePressureBubbleView does some stuff and unconditionally returns true, so it now has the OnDialogAccepted pattern, but probably not in a way that will ever be factored out fully. * TabModalConfirmDialogViews just calls its delegate in all three cases, so these are inlined. Bug: 1011446 Change-Id: Ic736fbbf8e2e43ecefcdd3c0e890bc20ee0cc10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028171 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736595}
-
Austin Orion authored
This is an addendum to this CL crrev.com/c/2019805 Change-Id: If77e8adf51935490167a150064515b2cd8cf96eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024692Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Austin Orion <auorion@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736594}
-
Yuly Novikov authored
This toolchain is a manual merge of UWP related changes from toolchain b92fff97f2e0323e99803f37f4b77b843bdbf69d crrev.com/c/2015984 on top of the current toolchain version 8f58c55897a3282ed617055775a77ec3db771b88 crrev.com/c/1836195. The changes to the current toolchain are: 1. Packing windows.winmd from 10.0.18362 SDK into the toolchain 2. Setting LIBPATH to windows.winmd and platform.winmd locations in SetEnv cmd and json files. Manual merge was required because following go/chromium-msvc-toolchain update instructions resulted in upgrading VS 2019 version to a faulty compiler, see crbug.com/1045948. This toolchain keeps all the components at the old versions: VS 2019 version 16.3.1 build 16.3.29324.140 Windows SDK 10.0.18362 Debuggers 10.0.17763 d3dcompiler_47.dll 10.0.17134 Bug: 1032635 Change-Id: I9774cdbfa3e2be6f669b93048375283ac0c114c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025528Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#736593}
-
Carlos IL authored
Change-Id: I3a744965fbc08402effe461a0efd1c7b1bb92bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026309 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#736592}
-
Yi Gu authored
This test is flaky. See bug for details. TBR=wnwen@chromium.org Bug: 1042168 Change-Id: Ic1f38e3512180e86239d8fb57ab3afb10f536bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028735Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736591}
-
tby authored
This is a reland of 2fe77415 Original change's description: > [Structured metrics] Add metric collection and upload logic. > > This is the final CL for the core of the structured metrics system. It > ties together the KeyData class (for managing keys and computing hashes) > with the metrics provider, and implements logic to: > > 1. Hash and store incoming structured metrics events. > 2. Provide stored metrics events for upload. > > It also adds integration tests for the system, checking that an event > created through the public API is correctly prepared for upload. > > Other misc changes: > > - Some minor refactoring of event_base.{h,cc} and equivalent changes > to events_template.py, to fix some bad style. > - Added a missing RemoveObserver call to the metrics provider dtor. > > Bug: 1016655 > Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386 > Commit-Queue: Tony Yeoman <tby@chromium.org> > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735748} Bug: 1016655 Change-Id: I83e69de7a9b865d35036b714f068cfda3c423b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026913Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736590}
-
Darwin Huang authored
sqlite 3.31.1 upgrade changes: https://sqlite.org/releaselog/3_31_1.html Bug: 1046597 Change-Id: Iccfe05026e65d8563b8a8cef31f02a048d9afff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026759Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736589}
-
Matt Mueller authored
Change-Id: I058cb3934c96b38ff4bddea0192c8b36297b4abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028754 Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736588}
-
Matthew Mourgos authored
In this change, the following metrics will have their expiry extended: Apps.AppListFolderOpened Apps.AppListFolderNameLength.* Bug: 1043741, 1043740 Change-Id: I167ec665a98aa6f0e616ab00398b546a98bdd4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024695Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736587}
-
Theodore Dubois authored
RE2 was printing an error whenever a ruleset with no regex rules was initialized. It wasn't causing any problems, but it was bugging me. Fix it by skipping the initialization of an empty RegexRulesMatcher, because it wasn't actually doing anything anyway (other than print an error). R=karandeepb@chromium.org Bug: 974391 Change-Id: Ia381bca2b9d60ac2407fd9121657fccc4b05e81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026592 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736586}
-
Darwin Huang authored
Bug: 1046597 Change-Id: I0a9548d7fe0997c2cf606cff6fac13dc66465bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026377Reviewed-by:
-
Donn Denman authored
Pipes a boolean through Contextual Search to a server request parameter to determine whether to make the Resolve an "exact resolve" request that cannot expand the selection. Uses TemplateUrl to add the parameter to the Resolve request. This additional parameter is needed for the Long-press triggering experiment. Also includes cleanup of initializers in C++ ContextualSearchContext. BUG=956277 Change-Id: Iaa0e1988035ed49d13e7a9e77e20c0c2ef04b4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995842 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#736584}
-
Darwin Huang authored
Bug: 1046597 Change-Id: I27a0520fbdb6b50f12c4530c508c4c0125f913e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026415Reviewed-by:
-
Connie Wan authored
- Tabs will read out their group membership. - Group headers will read out their tab contents. Tiny side bonus: Focusing on group headers will no longer show the wrong hovercard. Bug: 1045844 Change-Id: I5fc98231a5c5a0372aa75e31a5c3a6e321ce24b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025698 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736582}
-
Maksym Onufriienko authored
Depend on cl http://crrev/c/1954209 that will change `shard size` logic, since this cl it will be number of swarming tasks, not number of test classes per swarming task. Bug: 1033656 Change-Id: I4490690cafb290997b3b243d2423a78a113763f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965733Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#736581}
-
rbpotter authored
Add missing imports of assert.html for elements that are using assert but not importing it currently. Also add to deps for closure compiler for settings_idle_load. This is in preparation for autogenerating Polymer 3 versions of these files. Bug: 1026426 Change-Id: I22eacc796d159ff24813c1cccd5c5c9e386e7cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028658 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736580}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e883773e98e..38fc743463bb Created with: gclient setdep -r src-internal@38fc743463bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270 Tbr: jbudorick@google.com Change-Id: I0b907160076cde4a14c28803706d98584d42acb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028849Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736579}
-
kylechar authored
When using SkiaRenderer on Windows use the Skia readback APIs instead of GLRendererCopier by default. The Skia readback API doesn't support RGBA_TEXTURE readback format. This is only used on Chrome OS in production but some cc_unittests exercise it. Don't run those tests on Windows with SkiaRenderer. We still exercise the same test with RGBA_BITMAP which is supported. Bug: 1042646, 1046788 Change-Id: Ida4a1a921c838ee7a2d628da4535d9367140ff04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019466 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#736578}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37e7b36a3dc2..8a46f7664675 git log 37e7b36a3dc2..8a46f7664675 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 kjlubick@google.com [canvaskit] Add demo for RT shader 2020-01-29 csmartdalton@google.com Add a "kSimpleInnerPolygons" mode to GrTessellator 2020-01-29 fmalita@chromium.org [skottie] Cleanup: convert shape stroke/fill to new adapter pattern 2020-01-29 bsalomon@google.com Check for valid stencil buffer in GrGLGpu::clearStencilClip Created with: gclient setdep -r src/third_party/skia@8a46f7664675 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:984747 Tbr: reed@google.com Change-Id: I2fdadd8f2fe2725433a19e262355f54a537ff6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028655Reviewed-by:
-
Garrett Beaty authored
Change-Id: Id7abe4dc8ba4f14fd09dfd0bdf7048fa07ab79d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028176 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Oriol Brufau authored
The ::marker pseudo-element is being implemented behind a flag, so it shouldn't be exposed in devtools unless this flag is enabled. That was already happening for ::markers that already existed before opening the devtools tree. However, if a ::marker was created afterwards (e.g. by setting 'display: list-item' to some element), then the ::marker was shown even if the flag was disabled. This patch fixes the issue so that ::marker is only shown when the flag is enabled. BUG=457718 Change-Id: Ie2261c15a1211599355ca687b38cc525be8e2bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027909 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#736575}
-
Xianzhu Wang authored
CompositeAfterPaint no longer produces different result. Remove the extra baseline, and the test passes. TBR=wangxianzhu@chromium.org Bug: 979369 Change-Id: I8da553bfcc71a4a08e7f4cb8a758fcf37f5107d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028736Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736574}
-
Eric Karl authored
Change-Id: Ic12f69ef4d4ba6c9fe02217ad6912175550cd8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028631 Auto-Submit: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736573}
-
Geoff Lang authored
The validating command decoder exposes GL_ANGLE_texture_usage unconditionally but the passthrough decoder did not because it had to be requested first (for WebGL contexts). Request the extension at command buffer initialization time. BUG=1030835 Change-Id: I001f35650bd947eddf18878c56ac566c7dfd5588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023293Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736572}
-
Chris Lu authored
This is an intermediate step to scoping FullscreenController to a Browser. In order to accomplish this, the code needs to be able to switch between associating it to both a BrowserState, which it current is, and a Browser. FullscreenController will have two new static getter methods FromBrowser() and FromBrowserState() to provide such abilities. A new FullscreenControllerContainer class that will be associated to either a BrowserState or Browser will own and manage the FullscreenControllerImpl instance. Since it is not used after this change, FullscreenControllerFactory is removed. Bug: 790886 Change-Id: I9a1e4e9832911d045b389b892538c00327c83127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006111 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#736571}
-
Josh Simmons authored
Bug: 1040661 Change-Id: I9fbb5af6e50f11926afce57efbf2348bc69c1b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028210Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#736570}
-
Will Harris authored
This CL sets the shutdown parameters of child processes regardless of whether the build is Google Chrome or Chromium. This fixes the issue where sad tabs might briefly appear during logoff/shutdown on Chromium builds. BUG=1043938 TEST=load tabs in Chromium, log off user, check no sad tabs appear. Change-Id: I488f3d276a4ea93892527c39561d15a64e247127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025771Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#736569}
-
Kent Tamura authored
This CL adds "-internal-empty-line-height" CSS property, which is available only in UA stylesheets. The property takes "none" or "fabricated" as a value, and affects LayoutBlock:HasLineIfEmpty(). The property would help to decrease the number of LayoutBlock subclasses, and it would makes LayoutNG migration easier. Bug: 485982, 1040828 Change-Id: I9cb33c7c676bb7606018bc7a360bd4cbc2b2e52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026327 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#736568}
-
