- 04 Dec, 2020 40 commits
-
-
Sophie Chang authored
Bug: 1146151 Change-Id: Ic327827d7c3fb65c1baaf92562320062372ca8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573520Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833740}
-
Alice Wang authored
This CL hides the dismiss button of the account picker bottom sheet behind a feature flag for UX experiment. Bug: 1155517 Change-Id: I8d595c5e1797cf86ab17de98bf9a68c8b128450c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573083Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833739}
-
Andrew Grieve authored
This reverts commit 49606d08. Reason for revert: Official builds are taking too long. Original change's description: > Reland #2 "Android: Enable use_debug_fission for official builds" > > This reverts commit d4c88d4c. > > Reason for reland: Fixed in 9ab29d69 > > Original change's description: > > Revert "Reland "Android: Enable use_debug_fission for official builds"" > > > > This reverts commit 30f14e92. > > > > Reason for revert: official bot breaking > > https://bugs.chromium.org/p/chromium/issues/detail?id=1144538#c8 > > > > Original change's description: > > > Reland "Android: Enable use_debug_fission for official builds" > > > > > > This reverts commit 86befdda. > > > > > > Reason for reland: Bugs fixed in other CLs (see issue) > > > > > > Original change's description: > > > > Revert "Android: Enable use_debug_fission for official builds" > > > > > > > > This reverts commit 9d3a4611. > > > > > > > > Reason for revert: Official builds failing crbug.com/1144538 > > > > > > > > Original change's description: > > > > > Android: Enable use_debug_fission for official builds > > > > > > > > > > Bug: 1122182 > > > > > Change-Id: I29b579cf7c5e7eb6d2528a6fad28562059698bf8 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508342 > > > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#822625} > > > > > > > > TBR=agrieve@chromium.org,benmason@chromium.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: 1122182,1144538 > > > > Change-Id: I49cb3f0d42027a5e855cf1aa16f8cd1441f46ca9 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513206 > > > > Commit-Queue: Krishna Govind <govind@chromium.org> > > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#823080} > > > > > > Bug: 1122182 > > > Bug: 1144538 > > > Change-Id: Id3bcf776146a9bd9e66ec50cd8b9529029479faf > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541383 > > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#827946} > > > > TBR=agrieve@chromium.org,benmason@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1122182 > > Bug: 1144538 > > Change-Id: Iccd274ff85e12710206105c713a2f3dbc260f1a8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558781 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#830755} > > TBR=agrieve@chromium.org,benmason@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1122182 > Bug: 1144538 > Change-Id: If770c3864f5c9bf6e90a25bd1985d358d42f2b2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560912 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831414} TBR=agrieve@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1122182 Bug: 1144538 Bug: 1153349 Change-Id: I37a427096c04c4c461170580dc6ded2ae6c2ffd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574436Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833738}
-
Michael Bai authored
Simple patch, just move the implementation, no functionality change. Bug: 1151542 Change-Id: I0f8c72bc244d10ed1ed0faf82694cd437deb4009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573457Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#833737}
-
David Bienvenu authored
Replace with CancelCallbackOnce/Repeating, as appropriate. Bug: 1007788 Change-Id: Ice87e5485f2d5c51ba13162c16162b53f6bcb09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560785Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833736}
-
Rainhard Findling authored
When the password check found only weak passwords, but no compromised passwords, show an info icon instead of a warning icon in password check. Bug: 1128904 Change-Id: I43729548e36e7d263ca6e2465f9d733c6a920bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573101Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#833735}
-
Andrei Pascovici authored
VolumeControlAndroid should be allowed to perform these operations. See internal bug #15 for details. Bug: internal b/174680080 Test: on device Change-Id: I654c8c33c5991894cd44ba2bedfa08f2f1eb7288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572131Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Andrei Pascovici <apascovici@chromium.org> Cr-Commit-Position: refs/heads/master@{#833734}
-
Frédéric Wang authored
content::IsPotentiallyTrustworthyOrigin is just directly calling network::IsOriginPotentiallyTrustworthy. This CL removes content::IsPotentiallyTrustworthyOrigin, move tests for network::IsOriginPotentiallyTrustworthy to is_potentially_trustworthy_unittest.cc and updates callers accordingly. There is no behavior change. Bug: 1153336 Change-Id: Ifc3a45d0d444225e763bb87935d503a882f8a09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563759 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
ckitagawa authored
"&cs=0" is only sometimes appended to the url. Use startsWith instead. Bug: 1155558 Change-Id: I4b4c617dd1a49777792f7b4f5edd5a823ef8eacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572907Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#833732}
-
Joe Downing authored
This is needed in order to instantiate COM objects on the current thread (otherwise the underlying Chromium libraries will complain). I'm not sure why this wasn't needed in the past but AFAICT there have been other changes in the underlying libraries which prevent our solution from working (I have a follow-up CL to fix a crash in //media once this issue has been resolved). If the H.264 encoder performs well and we decide to enable it via the client UI, then I'll look into updating the autothread it runs on to own the scopedCOMInitializer instance. Change-Id: I5ae3aa3a97f3f3f57733e6c00cae3b7281ea950c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572794Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#833731}
-
Dominic Battre authored
It's a common mistake that developers just remove Register...Pref() calls for preferences they don't need anymore. If they do this, the preference stays in the prefs files on disk for ever. A proper approach is to first ClearPref() the preference for some releases and then to remove the code. This CL introduces a presubmit warning if we detect that a Register...Pref() call is removed from a non-unittest. Bug: 1153014 Change-Id: If8f19933de039553ef47e0ddce12eb194df45ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560205 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Tim van der Lippe authored
These are ported to Karma unit tests in https://crrev.com/c/2573372 R=yangguo@chromium.org Bug: 983851 Change-Id: Iafd49b402b98b6f1797b1a55ef75a1ab405f0e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572843 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#833729}
-
Matt Falkenhagen authored
Tbr: timvolodine Change-Id: Ief88cd6583a4a0777e6672b5abe161b8699ea420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569293 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833728}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1606996231-fb1aa25fe6cd29fd31733f8199da138cbb1f5caf.profdata to chrome-win32-master-1607061555-42057a46d6898e28766e44cc3eff7a0d211d34f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I001ab32553afdfb4fd5b9666cd67447d7839169b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573644Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833727}
-
sandromaggi authored
We would like to know in the delegate whether there was a failure or a cancellation by the user. Bug: b/174304769 Change-Id: Ic5b08baa30bdcdee37135f637c07a54460a904ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562843 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#833726}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e3c1ee2e2188..8e12f9222902 2020-12-04 tvanderlippe@chromium.org Use Python version bundled with depot_tools for all scripts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icf2b545e428b0bc10d9ddf024f961b3b6d943be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574421Reviewed-by:
-
Xi Han authored
When showing the Start surface with state SHOWN_HOMEPAGE, we will reset the scrolling position by expending the AppbarLayout "task_view_header", as well as scroll the Feed to the first item if it is enabled. Demo: https://drive.google.com/file/d/1nRSQ6v7ySkI41ihrohQsRpH9d7SpvPni/view?usp=sharing Bug: 1154716 Change-Id: Ib22e748e0e982f695f9e44a631ac8b7866d81d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568659Reviewed-by:
Hao Dong <spdonghao@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833724}
-
arthursonzogni authored
The RenderWidgetHost has multiple ownership model. For main frame and iframes, its is owned by the RenderViewHost and the RenderFrameHost respectively. It might also be self-owned. It deletes itself as a result of mojo IPC / function call / process exit. There is apparently a use-after-free on [issue] for a RenderWidgetHost owned by a std::unique_ptr. This suggests this instance might have self destroyed mistakenly, while it was still referenced by the unique_ptr. This patch CHECK only the self-destroying instance will self-destroy. For this purpose, two constructors: - RenderWidgetHost::Create() => unique_ptr<T> - RenderWidgetHostImpl::CreateSelfOwned() => T* [issue]: https://bugs.chromium.org/p/chromium/issues/detail?id=1153966 Bug: 1153966 Change-Id: I7993ed471e036a5babf03d51418fb37e3ca21c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566997Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#833723}
-
Tomasz Wiszkowski authored
Bug: 1046863 Change-Id: If1ac9ea7a490b2f2ae097e3051a489394fca87a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572789 Auto-Submit: Tomasz Wiszkowski <ender@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#833722}
-
Vasiliy Telezhnikov authored
This metric is still useful with ongoing work for overlays. Fixed: 1144786 Change-Id: If6aac824f4f268c505309de739ef5676eea7c163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572243 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#833721}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //third_party/. R=yfriedman@chromium.org Bug: 1113033 Change-Id: If7ee35e80c00f427198e6f30bc42e7e921fee708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572725 Auto-Submit: Gavin Mak <gavinmak@google.com> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#833720}
-
Rune Lillesveen authored
For container queries, we need to enter style recalc from layout when the a size change causes a container query to change evaluation. This CL introduces: 1. A flag on ComputedStyle which is set for an element whose styles rely on container query evaluations. 2. UpdateStyleAndLayoutTreeForContainer, to be called from layout, which does a style recalc pass over descendant elements marked with the flag from 1, but skips sub-tree rooted at descendant containers. Document::InStyleRecalc() had to be modified to also return true when we do style recalc from the layout lifecycle phase. Bug: 1146097 Change-Id: Ib866544725e1edefe390beaddbecfde2cec034aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556938 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#833719}
-
Austin Sullivan authored
If not, use GetDefaultDirectory Bug: 1142824 Change-Id: Ifda516adbce1d29ab55b094f2f43efc79c4252a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503340 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833718}
-
Harvey Yang authored
Update with CL:2507599, as we'll support ACPI_ALS as a light sensor (type LIGHT), this commit removes type ACPI_ALS. BUG=b:172208566 TEST=builds Change-Id: Ie47a9718b3b0add7b590cd2b40f90f7b2c98473f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574044Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833717}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d8090fdc866d..a58c14025a27 2020-12-04 reed@google.com Remove some flutter flags If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I34f05578ff5c6bd976baaac97902d4e26d63394e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574416Reviewed-by:
-
Chris Sharp authored
Bug: 1139046, 1139306 Change-Id: I96d60fe9d4c2969910318f50080c98fe89073518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570667Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833715}
-
Omar Morsi authored
This CL forces the users of the ExtensionForceInstallMixin (Mixin for force-installing extensions in tests) to check the result of force-installing an extension before assuming that it has been installed successfully. Bug: None Change-Id: Id45c87b6ce3419a0db7102cdc384754a6e7b8162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574196 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#833714}
-
David Van Cleve authored
Without patch: "local variable gradle_cmd referenced before assignment," because of the duplicate if debug: gradle_cmd.append('--debug') which is called before gradle_cmd is initialized. With patch: runs fine with -v -v -v R=smaier@google.com Bug: None Change-Id: I4e405c26dcacacd2311ae75c83553ffddc85cef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572901 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#833713}
-
Miyoung Shin authored
This patch adds support for the new ":dir" pseudo-class. The patch is covered by several of tests imported from the web tests including generic tests in addition to the tests from Firefox and apart from some minor changes on current tests to add the new selector. Intent-to-ship thread is available at: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/p0Wc66rbVOc BUG=576815 Change-Id: I503c6af95d9c5817e3e71b1b2025a5562929f0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460849 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#833712}
-
Nidhi Jaju authored
This CL adds the main implementation for supporting BYOB readers and byte stream controllers for readable streams according to the Streams API standard[1]. As added in previous CLs, this is done using polymorphism where there are two base classes: - ReadableStreamGenericReader, and - ReadableStreamController which the default/BYOB readers and default/byte stream controllers inherit from. This approach is further elaborated upon in detail in the design document[2]. The three main classes that implementation was added for in this CL are: 1. ReadableStreamBYOBReader 2. ReadableByteStreamController 3. ReadableStreamBYOBRequest This CL also includes: - new GetBYOBReader unittest - UnderlyingSource WebIDL files [3] among other things for adding the functionality of supporting readable byte streams. [1] https://streams.spec.whatwg.org/ [2] https://docs.google.com/document/d/1rvKpGjppeqRSWntokY-ft_hU2i2us8gis6zgrrLWSTI/view# [3] https://streams.spec.whatwg.org/#underlying-source-api Bug: 614302 Change-Id: I380258453e6fd5d617810e21fa8996f8f08b26f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537281 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#833711}
-
Robert Sesek authored
Bug: 1153883 Change-Id: I671164099c29cc91680d5f489d3c34723edb5675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572887Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833710}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: If589b16f6a24cd24cfa0b72238c120aa3e17f9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574419Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607061555-8d9d9dcaca67926a840853364e67940d5514d29c.profdata to chrome-mac-master-1607082643-ec3aa91ed6cc9a4e56961da34010bfe7d1bfcfad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I73fe0337bea8be5a2c27a6b3f1bddeeb84642822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574172Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607029132-2a42c327be2c82f8e58a0c22074906c3f86b0ba0.profdata to chrome-win64-master-1607061555-9d7880873554417bd44ed300f865acac635c5256.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I073673df1deea00785441913eb319d4c764d58d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574101Reviewed-by:
-
sandromaggi authored
Bug: b/173986107 Change-Id: I87b5c441950053c19fb8c1cce430b126ed446167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574278Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#833706}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6fa0fe33e81c..e3c1ee2e2188 2020-12-04 kimanh@chromium.org [LMI] Highlight settings button if settings are open 2020-12-04 kimanh@chromium.org [LMI] Implement refresh functionality 2020-12-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-12-04 aerotwist@chromium.org Add relative positioning to position metric 2020-12-04 kimanh@chromium.org [LMI] Add feature to jump to an address 2020-12-04 aerotwist@chromium.org Update Web Audio landing view text color 2020-12-04 w.hernandez.code@gmail.com Allows the pretty printing of directly visited minified asset files. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202,chromium:1154619,chromium:1155094 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic684eb111e98c7c99035db37a64cd0e517398644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574272Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607061555-5365375ab5da132dd8a522b9aa558547e7f10eee.profdata to chrome-linux-master-1607082643-9d7584569e97498303bfc8f363e6d14838d94e40.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0a0b37a8c7f67d10c85487fe91da02a163c08037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574171Reviewed-by:
-
Aya ElAttar authored
- Initialize Crostini in DataTransferDlpController browser tests. Bug: 1139884 Change-Id: I08199336bfdab4945506cfdd01a0926fdd0b8fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573356 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#833703}
-
Stephen McGruer authored
The WPT importer was accidentally using a cached version of the WPT manifest, which meant that it could not add expectations for new reftest files (as they didn't exist in the cached manifest). Since the cached version is needed to clear out *old* entries in WPTExpectationsUpdater, we need to keep that ability but clear the cache after we import the new files. To do so, we add a cache_clear ability to @memoized. This is similar to cache_clear in functools.lru_cache[0] (which is only available in Python 3). It requires some strange binding to get around the descriptor __get__ hack, however. Bug: 1154650 [0]: https://docs.python.org/3.9/library/functools.html#functools.lru_cache Change-Id: I962d02f4c451a3f6ec77580fc7bffe019ebf4bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570115 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#833702}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I29ea1d96ab0893b485d919667aea262fd2e340a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562303 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#833701}
-
