- 20 Feb, 2014 40 commits
-
-
pedrosimonetti@chromium.org authored
Related change: https://chrome-internal-review.googlesource.com/#/c/154947/ BUG=341765 Review URL: https://codereview.chromium.org/164753005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252261 0039d316-1c4b-4281-b951-d872f2087c98
-
brianderson@chromium.org authored
BUG=344090 Review URL: https://codereview.chromium.org/164373012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252260 0039d316-1c4b-4281-b951-d872f2087c98
-
damienv@chromium.org authored
Abort the playback if a specific stream triggers some high memory usage. BUG=343304 Review URL: https://codereview.chromium.org/164233005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252259 0039d316-1c4b-4281-b951-d872f2087c98
-
weitaosu@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/138833009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252258 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Applying the transforms on a Window's bounds does not give the correct transformed bounds of the window in its parent's coordinate system. For example, a Window with size 300x200 at position 20,10 and scaled at 50% has bounds (20, 10, 150, 100), and not (10, 5, 150, 100). So remove this transform from the window-targeting code, and instead convert the event's location to be in the child Window's coordinate system when doing hit-testing. This fixes selecting windows when in overview mode. BUG=339834 R=sky@chromium.org Review URL: https://codereview.chromium.org/167323004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252257 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
In certain scenario SyncSetupOverlay shows and closes very fast. In this case according to comment for ensureTransitionEndEvent in utils.js webkitTransitionEnd doesn't fire. Call ensureTransitionEndEvent to make sure event fires. R=dbeam@chromium.org BUG=343121 Review URL: https://codereview.chromium.org/173123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252256 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
Use version 41 and put the chrome version in the id field. BUG=344694 Review URL: https://codereview.chromium.org/171683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252255 0039d316-1c4b-4281-b951-d872f2087c98
-
bokan@chromium.org authored
Changed the painting method to translate the canvas back to the origin before performing the scale to prevent losing pixels due to rounding. Also made the it take the layer-space rect as a parameter, instead of trying to reconstruct it from the (possibly-clamped) content-rect, and calculate the layer-space to content-space scaling factor directly from rects. BUG=336534 Review URL: https://codereview.chromium.org/150603004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252254 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
We have a number of instances where unit tests call UrlOf('blank.html') or something similar. The _base_dir is src/tools/telemetry/unittest_data, so the output of relpath is something like ../blank.html. This works because the http server just ignores the ../ and serves up http://localhost/blank.html. In the case of cros autotests, the output of relpath ends up being something like ../../../../../../autotest/, and this doesn't work. When running unit tests via autotest, cwd and the unittest_data directory have no common parent. If they did, the buggy code would continue to work. This patch introduces navigate_to_test.NavigateToTestFile, which takes a filename relative to the unittest data directory, converts it to an absolute path, sets up an http server pointing to the unittest data directory, and navigates the tab to the file as requested. tab_test_case.Navigate is a wrapper used by the majority of these unit tests. Enable all previously failing cros unittests as well. BUG=337582 TEST=manual Review URL: https://codereview.chromium.org/151003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252253 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252251 0039d316-1c4b-4281-b951-d872f2087c98
-
falken@chromium.org authored
Now ServiceWorkerScriptContext::OnFetchEvent provides a dummy response to the callback. BUG=342301 TEST=content_browsertests:ServiceWorkerVersionBrowserTest.Fetch Review URL: https://codereview.chromium.org/164753006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252249 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelbai@chromium.org authored
TBR=benm NOTRY=true Review URL: https://codereview.chromium.org/173073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252248 0039d316-1c4b-4281-b951-d872f2087c98
-
lambroslambrou@chromium.org authored
Also added copyright notices to these files. strings.xml has been moved to a values/ directory for consistency, although we ultimately want to get rid of that file. NOTRY=true Review URL: https://codereview.chromium.org/171533011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252247 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
This patch prevents us from constructing a new Tab object at each navigation which permits the tab contents video capture API to cache its tab contents bounding box. I also suspect it might help with flake and noise as we no longer connect and disconnect so frequently and no longer depend on the python GC to do so. BUG= Review URL: https://codereview.chromium.org/170283006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252246 0039d316-1c4b-4281-b951-d872f2087c98
-
dslomov@chromium.org authored
Revert of Removed tls_edit post process rules from nacl_irt (https://codereview.chromium.org/157053008/) Reason for revert: Google Chrome compilation breakage http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/16569 Original issue's description: > Removed tls_edit post process rules from nacl_irt > > Now that build_nexe.py is in charge of applying tls_edit to IRT Nexe's, > we no longer need separate rules to apply tls_edit. > > BUG= https://code.google.com/p/nativeclient/issues/detail?id=3127 > TEST= trybots > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252237 TBR=mcgrathr@chromium.org,noelallen@chromium.org,mseaborn@chromium.org,bradnelson@google.com,bradnelson@chromium.org,noelallen@google.com,dyen@chromium.org NOTREECHECKS=true NOTRY=true BUG= https://code.google.com/p/nativeclient/issues/detail?id=3127 Review URL: https://codereview.chromium.org/172473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252245 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252242 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
R=bsalomon@google.com Review URL: https://codereview.chromium.org/173133005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252241 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerta@chromium.org authored
Check the valid_session bit to determine if the account in the cookie is valid. BUG=305249 Review URL: https://codereview.chromium.org/166433005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252240 0039d316-1c4b-4281-b951-d872f2087c98
-
ccameron@chromium.org authored
There is nothing in the documentation that suggests that this change is necessary -- nothing says that you can't use the GL context that CoreAnimation is using outside of CoreAnimation. So this patch is not well-informed, in that sense. That said, the crashes reported did not appear until I merged the two GL contexts. Also, locally, they went away as soon as I separated them back out. BUG=340385 Review URL: https://codereview.chromium.org/164873006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252239 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
We shouldn't provide NaCl SDK headers for interfaces which are not available in NaCl. This change removes PPB_ interfaces that are not built on OS_NACL in ppapi/thunk/interfaces_ppb_public_dev.h BUG=280338 R=binji@chromium.org Review URL: https://codereview.chromium.org/171703003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252238 0039d316-1c4b-4281-b951-d872f2087c98
-
dyen@chromium.org authored
Now that build_nexe.py is in charge of applying tls_edit to IRT Nexe's, we no longer need separate rules to apply tls_edit. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3127 TEST= trybots Review URL: https://codereview.chromium.org/157053008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252237 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
Hasn't been used in forever. BUG=none TEST=compiles NOTRY=true Review URL: https://codereview.chromium.org/154573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252236 0039d316-1c4b-4281-b951-d872f2087c98
-
dslomov@chromium.org authored
Revert of Fix crash which occurs when a widget destroys itself as a result of ET_GESTURE_TAP_DOWN (https://codereview.chromium.org/169443005/) Reason for revert: Breaks ChromiumOS ASAN: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%281%29/builds/15949 Original issue's description: > Fix crash which occurs when a widget destroys itself as a result of ET_GESTURE_TAP_DOWN > > BUG=342867 > TEST=WidgetTest.WidgetDeleted_InDispatchGestureEvent > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252214 TBR=sadrul@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=342867 Review URL: https://codereview.chromium.org/173863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252235 0039d316-1c4b-4281-b951-d872f2087c98
-
peter@chromium.org authored
This patch changes layout tests on Android to be ran using a 980x735 canvas instead of an 800x600 one, basically breaking everything. The "WebKit Android (Nexus4)" tester is currently red because of this. > Support viewport in content_shell. > > Viewport preferences are overridden even with the --enable-viewport > flag passed in. > > BUG=343993 > BUG=343993, 345221 NOTRY=true TBR=zeeshankq@chromium.org, aelias, jochen Review URL: https://codereview.chromium.org/171603015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252234 0039d316-1c4b-4281-b951-d872f2087c98
-
tommyw@chromium.org authored
A test have been discovered that under certain conditions a use after free can occur. BUG=339667 Review URL: https://codereview.chromium.org/170243005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252233 0039d316-1c4b-4281-b951-d872f2087c98
-
rlarocque@chromium.org authored
Moves the definition of the "Await*" methods' sources into the StatusChangeChecker. This allows the removal of some code that had overlapping responsibilities and the creation of more informative debug messages. BUG=323380 Review URL: https://codereview.chromium.org/167873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252231 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
BUG=344936 Review URL: https://codereview.chromium.org/165733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252230 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=337910 R=nona@chromium.org, komatsu@chromium.org, oshima@chromium.org, stevenjb@chromium.org TEST=compile succeeds Review URL: https://codereview.chromium.org/167793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252229 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
This was broken for Aura (and not Mac) back in r224214, with the work on the tab media indicators. This change restores the intended behavior. BUG=337439 TEST=Confirmed fix using repro steps in bug 337439. Review URL: https://codereview.chromium.org/172013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252228 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
This was the behavior in the GTK port. Replicating it in the views based linux_aura. BUG=339399 Review URL: https://codereview.chromium.org/171563006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252227 0039d316-1c4b-4281-b951-d872f2087c98
-
jrummell@chromium.org authored
In order to manage the lifetime of the CDM, have WebContentDecryptionModuleImpl and WebContentDecryptionModuleSessionImpl both keep RefPtrs to SessionIdAdapter (now renamed CdmSessionAdapter). CdmSessionAdapter owns the MediaKeys object, so the CDM gets destroyed when there is no more need for it. BUG=341567 TEST=EME content tests pass Review URL: https://codereview.chromium.org/171073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252226 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
These were a leftover from the shared_webcrypto refactor. BUG=245025 Review URL: https://codereview.chromium.org/170843006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252225 0039d316-1c4b-4281-b951-d872f2087c98
-
rlarocque@chromium.org authored
Introduces the P2PInvalidationForwarder. This class listens to ProfileSyncService events and generates P2P invalidations when it sees that the ProfileSyncServce has committed something. This is useful only in tests, where we do not have a real (non-P2P) invalidations. The P2PInvalidationForwarder's functionality is not new. It used to reside in the ProfileSyncServiceHarness. Moving it into this new class is a step towards making the ProfileSyncServiceHarness not listen to ProfileSyncService events. BUG=323380 Review URL: https://codereview.chromium.org/167913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252224 0039d316-1c4b-4281-b951-d872f2087c98
-
rtoy@google.com authored
CopyPcmDataToBus incorrectly assumed that each pipe contained a integer number of frames. This is only true if the number of channels is 1 or 2. For more channels, this is false, so we have to copy the data carefully, keeping track of which sample in a frame we are in. BUG=343648 Review URL: https://codereview.chromium.org/164023007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252223 0039d316-1c4b-4281-b951-d872f2087c98
-
etienneb@chromium.org authored
Removed from this CL: https://codereview.chromium.org/171143002/ R=cpu, dsinclair BUG= Review URL: https://codereview.chromium.org/172563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252222 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
Fixed ScopedPrinterHandle::OpenPrinter interface. Review URL: https://codereview.chromium.org/168003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252221 0039d316-1c4b-4281-b951-d872f2087c98
-
dpolukhin@chromium.org authored
BUG=343606 TEST=browser_tests Review URL: https://codereview.chromium.org/165643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252220 0039d316-1c4b-4281-b951-d872f2087c98
-
fgorski@chromium.org authored
Small update to fix a problem: when DELETE request is issued, response is 405 I looked for a test to update, but request type is not exposed on the fetcher. BUG=344657 Review URL: https://codereview.chromium.org/171403005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252219 0039d316-1c4b-4281-b951-d872f2087c98
-
juyik@chromium.org authored
BUG=284553 Review URL: https://codereview.chromium.org/165903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252218 0039d316-1c4b-4281-b951-d872f2087c98
-
psj@chromium.org authored
The remoting host changes, including the associated policy definitions, required to proxy gnubby traffic through a Chrome Remote Desktop session. BUG=134250 Review URL: https://codereview.chromium.org/138753005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252217 0039d316-1c4b-4281-b951-d872f2087c98
-