GitLab

BUG=None
TBR=oshima@chromium.org, ygorshenin@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/683763002

Cr-Commit-Position: refs/heads/master@{#301568}

This adds several performance tests for Web Animations initiated in
various ways.

BUG=421733

Review URL: https://codereview.chromium.org/665893005

Cr-Commit-Position: refs/heads/master@{#301567}

The Continue Dialog (along with a few other dialogs) in Remote Assistance references
localized strings defined in rmeoting_strings.grd.  To make Remote Assistance work
on Chrome OS, we need to get those resources into Chrome.

This CL
1. Modifies repack_locales.py to merge the generated strings from remoting_strings.grd
into the merged resource packs (e.g. merge remoting/resource/en.pak -> en-US.pak).
2. Chrome currently supports more languages than remoting.  This CL adds the missing
languages into remoting_strings.grd.  This is required to avoid compilation failures.
The list of added locales are based-on on referencing other chrome grd files (e.g.
generated_resources.grd).
3. remoting_strings.grds currently uses an overlapping resource ID range with chrome.
To avoid conflicts, this CL reserves ids [29550-30000) for strings in remoting
(see the changes in remoting/resources/resource_ids and tools/gritsettings/resource_ids).

Review URL: https://codereview.chromium.org/682863002

Cr-Commit-Position: refs/heads/master@{#301566}

This patchset only separates the header definition for ime_keyboard_x11 to .h file. After that, I will create ime_keybord_ozone.h also.  So the file structure will be:

ime_keyboard.h
fake_ime_keyboard.h
fake_ime_keyboard.cc
ime_keyboard_x11.h
ime_keyboard_x11.cc
ime_keyboard_ozone.h
ime_keyboard_ozone.cc

BUG=342336

Review URL: https://codereview.chromium.org/666693010

Cr-Commit-Position: refs/heads/master@{#301565}

ContextMenuDelegate talks in RVCMBase. This is fine for
ContextMenuDelegate::BuildMenu, but while showing it through
ContextMenuDelegate::ShowMenu, each platform downcasts the
RVCMBase to its own variant (RVCMViews, RVCMMac, RVCMImpl),
this seems unnecessary since the showing functionality can be
moved to RVContextMenuBase.
This CL does that and adds a virtual Show() function on
RVCMBase.

BUG=397364
Test=No visible change should occur.
For reference, this CL is related to brining up right-click context menus
in chrome.

Review URL: https://codereview.chromium.org/678653003

Cr-Commit-Position: refs/heads/master@{#301564}

Use of aura::Env::AddPreTargetHandler won't compile on Mac, so we hide it
behind an interface and add a Mac implementation.

BUG=425229

Review URL: https://codereview.chromium.org/678823002

Cr-Commit-Position: refs/heads/master@{#301563}

Allow decltype.
Disallow long long, uniform initialization, raw string literals.

BUG=427584
NOTRY=true

Review URL: https://codereview.chromium.org/685663002

Cr-Commit-Position: refs/heads/master@{#301562}

This can be built by GN or from the mojo repo (by GN)

R=ben@chromium.org
TBR=deleting a dead target, sky@chromium.org for testing/buildbot/chromium_trybot.json change

Review URL: https://codereview.chromium.org/685533002

Cr-Commit-Position: refs/heads/master@{#301561}

BUG=427447

Review URL: https://codereview.chromium.org/683463002

Cr-Commit-Position: refs/heads/master@{#301560}

This ability was added for Android WebView to limit the number of
gralloc buffers, which has a low limit on the number of allocations.
Android WebView no longer uses gralloc buffers, so no need to keep this
ability.

Use memory limit to limit the staging resource pool for 1-copy
rasterizer.

BUG=426548

Review URL: https://codereview.chromium.org/643993005

Cr-Commit-Position: refs/heads/master@{#301559}

Modify json_output_formatter to include trace values in the result output.

This is a partial land of Ethan's patch in https://codereview.chromium.org/545523002/.

BUG=

Review URL: https://codereview.chromium.org/663023005

Cr-Commit-Position: refs/heads/master@{#301558}

R=dtu@chromium.org, achuith@chromium.org
BUG=402172, 388256

Review URL: https://codereview.chromium.org/682953002

Cr-Commit-Position: refs/heads/master@{#301557}

Review URL: https://codereview.chromium.org/676613002

Cr-Commit-Position: refs/heads/master@{#301556}

Review URL: https://codereview.chromium.org/686573003

Cr-Commit-Position: refs/heads/master@{#301555}

BUG=412884
R=bengr@chromium.org

Review URL: https://codereview.chromium.org/674103003

Cr-Commit-Position: refs/heads/master@{#301554}

BUG=383995

Review URL: https://codereview.chromium.org/675453003

Cr-Commit-Position: refs/heads/master@{#301553}

BUG=418375

Review URL: https://codereview.chromium.org/686623002

Cr-Commit-Position: refs/heads/master@{#301552}

Previously it created a button per child of the bookmark bar node. Now
it creates only as many buttons as are needed, lazily creating more if
the size changes.

BUG=416641
TEST=covered by tests.
R=msw@chromium.org

Review URL: https://codereview.chromium.org/677533003

Cr-Commit-Position: refs/heads/master@{#301551}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=msw@chromium.org

Review URL: https://codereview.chromium.org/680133002

Cr-Commit-Position: refs/heads/master@{#301550}

They're causing failures on the bots, and are incorrect anyway.

BUG=419786
TEST=None.

Review URL: https://codereview.chromium.org/671713004

Cr-Commit-Position: refs/heads/master@{#301549}

This is because content view core object could be destroyed at the time when
a method is called on it.

BUG=427684

Review URL: https://codereview.chromium.org/677423003

Cr-Commit-Position: refs/heads/master@{#301548}

This restriction doesn't allow registration of the ServiceWorker scope outside the script directory.
As per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468

BUG=423983

Review URL: https://codereview.chromium.org/677003002

Cr-Commit-Position: refs/heads/master@{#301547}

BUG=313539

Review URL: https://codereview.chromium.org/677373002

Cr-Commit-Position: refs/heads/master@{#301546}

Adding SetLastTokenFetchingTime to GCMStore
Adding Get/SetLastTokenFetchingTime to GCMDriver
Propagating the last token fetching time up and down the GCM stack

BUG=374969

Review URL: https://codereview.chromium.org/681453004

Cr-Commit-Position: refs/heads/master@{#301545}

BUG=427538

Review URL: https://codereview.chromium.org/683683002

Cr-Commit-Position: refs/heads/master@{#301544}

BUG=427089

Review URL: https://codereview.chromium.org/681903002

Cr-Commit-Position: refs/heads/master@{#301543}

Adds urls to the settings and 'learn more' links.
Adds CSS animation to the speech training pages.
Adds steps through speech training UI with clicks.

BUG=390086

Review URL: https://codereview.chromium.org/666073005

Cr-Commit-Position: refs/heads/master@{#301542}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=flackr@chromium.org

Review URL: https://codereview.chromium.org/645513008

Cr-Commit-Position: refs/heads/master@{#301541}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=calamity@chromium.org

Review URL: https://codereview.chromium.org/681873002

Cr-Commit-Position: refs/heads/master@{#301540}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=dcaiafa@chromium.org

Review URL: https://codereview.chromium.org/660803004

Cr-Commit-Position: refs/heads/master@{#301539}

Added unittest coverage removed from CL 634523004

BUG=57376

Review URL: https://codereview.chromium.org/677423004

Cr-Commit-Position: refs/heads/master@{#301538}

This fixes a bug where data sends that had been fully written to the
data pipe were not considered when deciding whether to cancel (or wait
for an in-progress cancel) during DataSender serialization.

Review URL: https://codereview.chromium.org/678223002

Cr-Commit-Position: refs/heads/master@{#301537}

BUG=378074

Review URL: https://codereview.chromium.org/668313002

Cr-Commit-Position: refs/heads/master@{#301536}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/679283002

Cr-Commit-Position: refs/heads/master@{#301535}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/678073006

Cr-Commit-Position: refs/heads/master@{#301534}

AppKit is responsible for determining the height of the NSSavePanel and
NSOpenPanel. It will never pick a height that causes the panel to be taller
than the screen, but it may pick a height that requires the panel to be
positioned near the top of its presenting window. Chrome's logic for
positioning panels did not take this into consideration, so it was possible to
position a panel that extended past the bottom of the screen.

This CL fixes this oversight.

BUG=423635

Review URL: https://codereview.chromium.org/665933005

Cr-Commit-Position: refs/heads/master@{#301533}

With this patch, if one extension has a recursive watcher, and another non-
recursive one, then the providing extension will know about both of them.

In an upcoming patch ObservedEntry will be renamed to Watcher, since now
we can have two observed entries for the same path, which doesn't sound the
best.

TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=248427

Review URL: https://codereview.chromium.org/679573002

Cr-Commit-Position: refs/heads/master@{#301532}

BUG=None

Review URL: https://codereview.chromium.org/684453004

Cr-Commit-Position: refs/heads/master@{#301531}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/686563002

Cr-Commit-Position: refs/heads/master@{#301530}

BUG=82385
R=jdduke@chromium.org

Review URL: https://codereview.chromium.org/684643003

Cr-Commit-Position: refs/heads/master@{#301529}