- 04 Sep, 2020 40 commits
-
-
Fredrik Söderqvist authored
For SVGNumberList and SVGLengthList we can forward the Add() and CalculateAnimatedValue() operations to each item (== the item type animator). This may be slightly slower, but avoids duplicating some fairly hairy code (for SVGLength; SVGNumber is fairly trivial). Also move some variable declarations closer to their first use. Remove the redundant 'length' bit from some local variables. Bug: 1017723 Change-Id: Ia0e5047891b1fa8584ecc65524f724ddfafff696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392461Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#804567}
-
Hans Wennborg authored
The zlib test suite has 96% coverage of the 'optimizations' folder and is part of the development workflow (i.e. used to validate correctness of zlib patches). This change will ensure that the test suite will run as part of the buildbots. Bug: 1113596, 1124704 Change-Id: Icfcc88cfa5d1165549521d18915c743e45ceb782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390654Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804566}
-
kdillon authored
QueueClass is currently used for high-level policy decisions in the main thread. For the most part, the policies applied to each queue class are largely the same (the exception being that QueueClass::kTimer queues are the only ones paused for webview). This change removes QueueClass entirely and adds 'can_be_paused_for_webview' as a queue trait so only the queues previously belonging to the kTimer QueueClass will be paused for webview when this bit is set on the policy. Change-Id: I18b238652e8bf3dfe1535f74e40f87db668d0357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388400 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804565}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ee980a91ff42..f005191db5ba 2020-09-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 5e85f689b911 to f564aa5f30f1 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I99bc9b500087c31009cabc83f352afa484f95c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393709Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804564}
-
Evan Stade authored
DecoderService is split into the image decoding portion, which is renamed ImageDecoder, and the service portion, which is embedder specific and provided by [...].photo_picker.DecoderService in Chrome. In WL, it's provided by ImageDecoderService. ImageDecoderService proxies from the WL client to implementation library for access to process setup (sandbox init) and image decoding via ImageDecoder. Bug: 1110930 Change-Id: Ifae62538ea841f3a1183aea98e10da1062a05841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376553 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#804563}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36794166c410..ada084561668 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: If23cfc1c7e6edfa4c7e8b4880f514c20075f2507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393707Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804562}
-
Dominic Farolino authored
R=haraken@chromium.org Bug: N/A Change-Id: I00a2274e866abc0680db244d8f2a64fa3e17a909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391418Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#804561}
-
Daniel Libby authored
If a layer has a child that has a large negative inset for the top/left properties, along with other content, the size of the layer can exceed the max layout unit in either dimension. When this happens, currently the min of left/top is used when creating the clip rect for the layer, but because of the size limitations, the content that is actually in view is not painted. Instead of using the min for left/top, favor the positive (right/bottom) portion of the rect when the size is saturated up against the LayoutUnit max value. Bug: 1122807 Change-Id: I8276f1556eebb3c9f197e0fba36571f7e7dd4546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391389Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804560}
-
Frédéric Wang authored
MathMLOperatorElement::ComputeDictionaryCategory was wrongly implemented in [1] and returns an unknown category for an operator that is not in the dictionary AND has an explicit form attribute. This caused a crash when the function was finally used in [2] and [3]. This CL fixes that mistake and adds a DCHECK after the unique call to ComputeDictionaryCategory to ensure the category is not unknown. Additionally, the documentation of the corresponding low-level platform/text API is updated to make clear it never returns an unknown category. WPT tests are added, one of them contains an munderover whose base is an operator outside the dictionary with an explicit form, allowing to ensure no crash happens for the code added in [2] [3]. Another one verifies default operator spacing and will cover the code added in [4]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2368362 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2390760 [3] https://chromium-review.googlesource.com/c/chromium/src/+/2383023 [4] https://chromium-review.googlesource.com/c/chromium/src/+/2390652 Bug: 6606, 1124617 Change-Id: Ic6ba0b663d14634ca5c66070a5b3cfc2eaa3d198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390633Reviewed-by:
Rob Buis <rbuis@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#804559}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I60b814380cf3773c7734f9c815428be4d84022c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393710Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599190607-5206f3168b9b0d0e0456f3bee274b28f7a3aa0ec.profdata to chrome-win32-master-1599213075-8de6fbfad2c0ba88366e24b5675f87337bc4120e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4ccbf776fdefd8c73ba2f91ad6f073c6c5b5f97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393703Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5dba9c97fbc3..a070dd18d79d 2020-09-04 thakis@chromium.org Revert "mac: Add an arm64 slice to ninja-mac." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103315,chromium:762354 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I482fb8f70564eeb20896a13ebc90cbd21a7c0bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393706Reviewed-by:
-
Pavel Iliin authored
Set optimize_max compiler options to build some hot blink render components and improve size-vs-speed balance on Android. Pixel4 Aarch32/64: +628Kb/+884Kb libchrome size +6.9%/+5.7% speedometer2 speed Bug: 1125115 Binary-Size: Will revert this after perf graphs show impact of it. Change-Id: I45e176ae1cbc2e513eda986b667ce65640ec9a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390778 Commit-Queue: Pavel Iliin <Pavel.Iliin@arm.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#804555}
-
Fredrik Söderqvist authored
Since filters applied to HTML content do not explicitly clip to the filter region, apply (clip with) the filter region to the crop rect. In future we'll also need this when applying filters to SVG content. Remove Filter::AbsoluteFilterRegion() since it unused. Bug: 109224, 512453 Change-Id: I86ad620ead2a8a184431975891565a6fc0e64b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390909Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#804554}
-
Andrew Grieve authored
Bug: 1123726 Change-Id: I5f6ced3f613961ec3ea14857e20e7df19fb9764f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393250 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a7d7f1baef0..ee980a91ff42 2020-09-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 75690ce7ef4a to e63aa953ddfd (2 revisions) 2020-09-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 2c60d16a646b to fd05605bef1c (1 revision) 2020-09-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 399ebf707295 to 4a7362c2b223 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I92ee7a9ba042557a5b832a7214e9d3f9c8cfa799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393701Reviewed-by:
-
Antonio Gomes authored
... as per section 2.1.2 in [1]. Method is also renamed to GetInstance(). [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80 BUG=787252 R=guidou@chromim.org, haraken@chromium.org Change-Id: I5a80ee2168d8b150439559ce74e9ce3fd6089b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391005 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#804551}
-
Jacobo Aragunde Pérez authored
This is a tricky test due to the asynchronous nature of the event. It is produced in response to a system window event, so we need the test to produce an actual window so we can listen to it, and we need to add a way to wait for it. Bug: None Change-Id: If7cd10c5db282f7cc465505286790ab1f4b458a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370984 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#804550}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f39c62ab1284..27e1867266a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id55657d82c80a8effe0ea4fd40dff6ff4d1d5d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392847Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f39c62ab1284..27e1867266a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5a4db3ce43eea983700884294335834a53f84f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392846Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599069432-d8eb5597bd424e2ad3cbb5c17808a3e6923469d2.profdata to chrome-win32-master-1599190607-5206f3168b9b0d0e0456f3bee274b28f7a3aa0ec.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1dbd55cbc1621458ea1e24c609a6b759852891e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391873Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599177512-32aa3809c8758c536a0ce48902826b7d778eb6b3.profdata to chrome-win64-master-1599198987-f51a65ad37e561beab550a72f46d734c30300605.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I022706382a42bc01dbe2cc8428e8a9fcc36a22a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393695Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f39c62ab1284..27e1867266a0 2020-09-04 treehugger-gerrit@google.com Merge "Add PERFETTO_EXPORT macros to GlobalNodeGraph" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If6a56a64657986260a2c0785ec9343cc0882ce43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393699Reviewed-by:
-
Antonio Gomes authored
This is a follow up of https://crrev.com/c/2388721, done separately so that the rename itself was not noisy to reviewers. BUG=787252 R=guidou@chromim.org, haraken@chromium.org Change-Id: Ia64f7c4da453b8a2c313f79e13f811ccc41eba18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389018 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a41204d8175..4a7d7f1baef0 2020-09-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5881c1ad to c934ea57 (380 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I927e8967dc65c061a91c65b529a5d3d2c7ad7435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393660 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a6842d3aa4de..77ed48ad2159 2020-09-04 patrick.brosset@microsoft.com Grid: New histogram to track how many grids users highlight in the page If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibf7ad1d3695405df6f23a304c1c17cc0c5b0dd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392845Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599155892-1c7afa3c86090c53f24aedb3e14a5f3170b93aea.profdata to chrome-win64-master-1599177512-32aa3809c8758c536a0ce48902826b7d778eb6b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae3a14ffea0a1f61cd26640bb2fc7f981b18f6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393133Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/583b1e36f36b..36794166c410 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1101058,chromium:1124945 Tbr: Change-Id: Ic19aaf0f0f0896a72b41c2df51b491348cb4724f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393298Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c278dada96d9..fd05605bef1c 2020-09-03 stefanomil@google.com spirv-fuzz: Transformation to convert OpSelect to conditional branch (#3681) 2020-09-02 46493288+sfricke-samsung@users.noreply.github.com spirv-val: Add Vulkan VUID labels to BuiltIn (#3756) 2020-09-02 vasniktel@gmail.com spirv-fuzz: Add support for BuiltIn decoration (#3736) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I36e0f9d10e0d1d2e62f7350e679cca5322cc73a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393658Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/23909d8cfc57..a6842d3aa4de 2020-09-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I89c190de93eebe3eff2bef4484d4731e28b52b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393656Reviewed-by:
-
Alexey Baskakov authored
Background: WebAppMigrationManager uses BookmarkAppRegistrar::GetAppUserDisplayMode() getter to obtain user_display_mode field. user_display_mode is a user-controllable field which we sync across all user's devices. user_display_mode shouldn't depend on anything else (like manifest display mode or any other web app field) The call path: BookmarkAppRegistrar::GetAppUserDisplayMode() -> extensions::GetLaunchContainer() -> extensions::GetLaunchType() -> extensions::GetLaunchTypePrefValue(). The problem: While extensions::GetLaunchTypePrefValue() returns a raw launch_type that we are really interested in, extensions::GetLaunchType() resets launch_type to "run as a tab" if the bookmark app is not locally installed (Background: we sync bookmark apps as non-locally installed on all OSes except ChromeOS): LaunchType GetLaunchType(const ExtensionPrefs* prefs, const Extension* extension) { ... // Force hosted apps that are not locally installed to open in tabs. if (extension->is_hosted_app() && !BookmarkAppIsLocallyInstalled(prefs, extension)) { result = LAUNCH_TYPE_REGULAR; } else ... } This is the place where we were loosing information. If local migration happens first on a device with non-locally installed app, this preference gets uploaded to the sync server as the source of truth. As a result, all secondary installs treat this "run as a tab" value as a user choice. Solution: Our ideal raw GetAppUserDisplayModeForMigration() getter must not "Force hosted apps that are not locally installed to open in tabs". We need to convert a raw value from prefs extensions::GetLaunchTypePrefValue() using a switch statement with all cases covered. This is a P0 bug. This CL will be merged into M85 branch ASAP. TBR=mgiuca@chromium.org Bug: 1125020 Change-Id: Ie68aa8a86a2a052456fa66349bbd86758aaa56db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392168 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#804537}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599177512-b01388e3af00195f29af1f849ccfb9a29d0804ad.profdata to chrome-mac-master-1599198987-d991dddb2c00d3ed866518be68c89430502fa377.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Icb8f46f44e2abc74261ef75708bdf593974719da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393655Reviewed-by:
-
My Nguyen authored
As part of moving spell check settings to OS settings in Chrome OS, updating spelling service pref when spell check pref changed is identified to be better dealt with in spellcheck_service. Related CL: https://crrev.com/c/2360093 Bug: 1113439 Change-Id: I0532d28d92912e5437ef729bd84b4916ffc55af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387912Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804535}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/84902ce006f0..d91cd6b5ee2b 2020-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 210fb6b5 to 7a93e029 (467 revisions) 2020-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 75690ce7ef4a to e63aa953ddfd (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ib6485c6ae29d552007899fc264237a93a5377273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391874Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_PrintingFailed message to PrintingFailed() in mojom::PrintManagerHost. Bug: 1008939 Change-Id: I9fa3b5d5ca1db492aeaa23cc3a13f467d3149c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377264 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#804533}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bef95be956d4..23909d8cfc57 2020-09-04 chrche@microsoft.com [Loc] Presubmit performance improvement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116989 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8e69839832a7ecb7638e1f132899d3132a6a8448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391872Reviewed-by:
-
Victor Fei authored
AXPosition::AtEndOfTextSpan relies on CreateParentPosition to determine if an inline text box marks the end of text span. Since CreateParentPosition calls into AtStartOfLine which calls AtEndOfTextSpan so we end up with an infinite loop and stack overflow. https://crrev.com/c/2245611 fixed most cases with this infinite loop of AtStartOfLine/CreateParentPosition/AtEndOfTextSpan by checking for AtEndOfAnchor first before calling AtEndOfTextSpan. However consider the following example: <style> .required-label::after { content: " *"; } </style> <label class="required-label">Required </label> labelText #1 ++staticText name='Required ' nextOnLineId=inlineTextBox #2 ++++inlineTextBox name='Required ' nextOnLineId=inlineTextBox #3 ++staticText name=' *' previousOnLineId=inlineTextBox #4 ++++inlineTextBox name='*' previousOnLineId=inlineTextBox #5 AtEndOfAnchor check would not prevent this infinite loop, if AtStartOfLine is called on staticText #4 name=' *' as the max text offsets differ between staticText #4 and its inlineText #5. This CL fixes the above issue by making AtEndOfTextSpan not to call CreateParentPosition. Instead it determines end of text span by directly looking at the current position's parent role and its index among its siblings. AX-Relnotes: Fixes hangs in certain accessibility scenarios. Bug: 1120636 Change-Id: Ic99c27b069f220f26da736b3946560ef23d6b622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369681 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9eb24f89..5966c3d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia75618a5a90d9e1b35edd894b9343ea612fba1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391985Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804530}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1877f680e3b2..1e7df19a137f 2020-09-04 thestig@chromium.org Revert "Optimize a tight loop in FX_Number." 2020-09-04 tsepez@chromium.org Remove CFGAS_FontMgr::EnumFontFromFiles. 2020-09-03 nigi@chromium.org Enable FPDFFlattenEmbedderTest.BUG_889099 for Skia/SkiaPaths. 2020-09-03 tsepez@chromium.org Fix some layering between fpdfsdk and fxbarcode. 2020-09-03 tsepez@chromium.org Initialize CPPGC heap with kNoConservativeStack. 2020-09-03 tsepez@chromium.org Tidy CFX_Font If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124998 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Icad9dc4826d872eb2bdb59afd73b9773d240e005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393386Reviewed-by:
-
Sadrul Habib Chowdhury authored
If the main-thread is blocked until a vsync's deadline, then the reporter is cloned, submitted, and marked as having 'partial update'. However, it is possible for the main-thread to respond, after the deadline, with 'no updates' (or 'no damage'). In such cases, the frame that was submitted did not really have a 'partial update' So reset the flag that was set, so that the metrics are reported correctly. To do this: . When a reporter is cloned, track the link between the original reporter and the cloned reporter. . When the original reporter is no longer blocked, check if the frame ended with 'no updates'. If it did, then unset the 'partial update' flag from the cloned reporter. . The cloned reporter can be displayed before the original reporter has a response from the main-thread. In such cases, keep the cloned reporter alive until the original reporter receives the main-thread response, so that the 'partial update' flag can be unset if necessary. BUG=1115376 Change-Id: Ib2e8b0bc1fc924e7442625c4cb82dfa5a88ced95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385929 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#804528}
-
