- 03 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/76bd0f030f3c..71b51fa69ee9 git log 76bd0f030f3c..71b51fa69ee9 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 nator@chromium.org [PeriodicBackgroundSync] Remove DevTools experiment Created with: gclient setdep -r src/third_party/devtools-frontend/src@71b51fa69ee9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1038678 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc53ab7ee73d62e4760d97c7b23c4780f07f844a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728207}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7af927e60755..15e191fdcca2 git log 7af927e60755..15e191fdcca2 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 moragues@google.com mushu: add board 2020-01-03 tcwang@google.com afdo: Replacing the email of old sheriff rotation to new one Created with: gclient setdep -r src/third_party/chromite@15e191fdcca2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Iaabc23c4513a2d715b8e9808b2dca07a51f2ee3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986777Reviewed-by:
-
Dave Tapuska authored
Since the class is no longer memcopied between processes we can use virtuals. - Add virtual destructor - Add pure virtual cloning - Remove memset - Remove size attribute BUG=836826 Change-Id: I92f7c1394009223d0e7970929ae5cdfc4bec2b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972167 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728205}
-
Koji Ishii authored
Following bot results are included. 775 777 779 780 781 782 783 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 808 809 810 811 813 814 815 816 817 818 819 820 821 33 lines were removed and 17 lines were deflaked by consecutive results since 788. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I0b739907c03c41eb7e5b021b5adf26a1fb31faa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983105Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#728204}
-
Dave Tapuska authored
- Define ScrollDirection in mojom. - Move bubble scroll methods into LocalFrameHost and RemoteFrame interfaces BUG=1008432 Change-Id: Ib8cda8a7c403cc483d4c718521f87f5f46642b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955858Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#728203}
-
Ian Barkley-Yeung authored
c2978022d178 Update comment to match current state of MemorySnapshotGeneric 558b7ea43ff5 Pass --always_allow_feedback during integration tests Bug: chromium:1037656 Change-Id: I3c95e30aa585cf6782b6c66c0ce8bc3e063d1ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985123 Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#728202}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/873610ca688a..df344bb8dec4 git log 873610ca688a..df344bb8dec4 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d4992c6f..9427b393 (728071:728171) Created with: gclient setdep -r src/third_party/webrtc@df344bb8dec4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I25b62fd3fade9341ecf6f20d859b358982e777b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986774Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ee635638fc1..7ac038f302f2 git log 4ee635638fc1..7ac038f302f2 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 benjaminwagner@google.com Move Android GPU ASAN jobs to NVIDIA_Shield. 2020-01-02 herb@google.com Document fBrokenRun in VertexRegenerator. 2020-01-02 benjaminwagner@google.com Add xSAN jobs for Vulkan 2020-01-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 25234a0a9c2c..ab3cf9c7bd22 (1 commits) 2020-01-02 mtklein@google.com add some useful Debug/ASAN bots 2020-01-02 mtklein@google.com build libjpeg-turbo with -DUSE_CLZ_INTRINSIC 2020-01-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ec78f685becd..25234a0a9c2c (1 commits) 2020-01-02 brianosman@google.com Move SkRuntimeEffect.h to include/effects 2020-01-02 brianosman@google.com Fix asserts in SkRuntimeEffect color filter benchmarks 2020-01-02 benjaminwagner@google.com Enable Vulkan Debug layers 2020-01-02 mtklein@google.com reland "clarify that there's no kMedium here" 2020-01-02 mtklein@google.com Reland "pass more information to shaders" Created with: gclient setdep -r src/third_party/skia@7ac038f302f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I1cb50634a21f5102bf17de08cc21c345607fdcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986769Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f7810a6a39e..114e7ffbe641 Created with: gclient setdep -r src-internal@114e7ffbe641 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic013fb7ac0aed5da8250c1aa37450c91641a4f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986772Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728199}
-
Olivier Robin authored
Bug: 1037681 Change-Id: I118bc49076c2ab9e658d60fc926781923166f18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986077 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#728198}
-
Michael Lippautz authored
This change enables detailed class names for debugging when the marking verifier is enabled. Change-Id: I2d0c8e3587a28768eeb8bad5cc4f5de85c81e578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986785Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#728197}
-
Peter Marshall authored
This test registered a callback that was an async function, but the caller doesn't await the result. This means that we re-entered the callback and modified the global counter, which was not expected. Update the test to de-register the callback before awaiting the stopTracking call, even though we still have an async function where it doesn't belong, this could at least stop the flakiness. Bug: 824904 Change-Id: Ib32eabdefb409f082dcb1f99db5f1d527fff88fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986080 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#728196}
-
Francois Beaufort authored
Bug: 1038778 Change-Id: I0ebc318354a8b2f2101e2a9097dd4511f28c3deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986069 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#728195}
-
Balazs Engedy authored
The tests used to work with a global singleton CrowdDenyPreloadData instance. This is wrong semantically, and had also been leading to use-after-frees because this global instance used to a reference to a ThreadPool instance that would be created (and destroyed) with the first ever test case run. Bug: 1038902 Change-Id: Ie6e560de3a779e7d9621bbe5a53587a76a019826 TBR: andypaicu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983176Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728194}
-
Yi Gu authored
The test was flaky on Mac 10.13 due to Timeout rather than Failure. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=virtual/threaded/fast/scroll-snap/snap-to-area-with-fractional-offset.html Bug: 1036054 Change-Id: I497b3bb58fc15fd29be0608f6be3326dd7085e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986767Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728193}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2bd85ab03921..873610ca688a git log 2bd85ab03921..873610ca688a --date=short --first-parent --format='%ad %ae %s' 2020-01-03 mirtad@webrtc.org Fix updating degradation preference in SetRtpParameters. 2020-01-03 saza@webrtc.org Remove one acquisition of capture lock in APM AudioFrame API Created with: gclient setdep -r src/third_party/webrtc@873610ca688a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3e102cdd0b959e6d9c0e11016b355a4c59a85338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986766Reviewed-by:
-
Gauthier Ambard authored
Renderer.WKWebViewCallbackAfterDestroy is no longer logged as the callbacks are no longer called while the handler is being destroyed. The metric can be removed and deprecated. Fixed: 991950 Change-Id: I598b9b8a018c7c6503d01497764282c39803af2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982542 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#728191}
-
Michael van Ouwerkerk authored
Bug: 1009516 Change-Id: If0e14a7940a5dc8b7b0b5002fd4d9bd04bdbb911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985842Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#728190}
-
Philip Rogers authored
LayoutNG paints hit test display items with NGPhysicalLineBoxFragment display item clients in NGBoxFragmentPainter::PaintLineBox. With this patch, these line box fragments are now invalidated via the block flow invalidation. This fixes touch-rect-crash-on-unpromote-layer.html with CompositeAfterPaint. Change-Id: Id1c1961d2acdfe5638134f9b3e44dcaeae6a65cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984874Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728189}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/93061d4e764f..de97fb4ac4c6 git log 93061d4e764f..de97fb4ac4c6 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src e4a2b7f22782..2be3fe0f8471 (7 commits) Created with: gclient setdep -r src/third_party/angle@de97fb4ac4c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I188bdcfdd20fdac35aa45472b80c9ead4c808b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986712Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e7a24f881291..9f7810a6a39e Created with: gclient setdep -r src-internal@9f7810a6a39e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic86cba0ed5752ae95e96952390896815215e52cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986723Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/172d5213f9a6..76bd0f030f3c git log 172d5213f9a6..76bd0f030f3c --date=short --first-parent --format='%ad %ae %s' 2020-01-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@76bd0f030f3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6206b4d614f0eab32800952449c1771b504f1d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986718Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/83ee98292f2b..2bd85ab03921 git log 83ee98292f2b..2bd85ab03921 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 peah@webrtc.org Avoid AGC2 runtime allocation and activate it on demand Created with: gclient setdep -r src/third_party/webrtc@2bd85ab03921 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib4ae8decf5f485d6594ad589e19879428588f2d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986720Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9427b393. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I01da1bf59bf5822f433f3797d0cfaaf0dabe2ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986129Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728184}
-
Christian Dullweber authored
The string is a bit confusing about first- vs third-party websites. Bug: b/146824693 Change-Id: Icca3c40c3a3099aaabadf93f58bd271c6dcfc3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986068Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#728183}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/contacts_picker. Bug: 1001114 Change-Id: I9bff1f21d95e6690f50605421af317dbfb6c9e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986473Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#728182}
-
Sergio Villar Senin authored
It's currently using a double to represent a duration. Migrated to AnimationTimeDelta to ease the migration from doubles to base::Time* types. Bug: 737867 Change-Id: I53ca0cad341ea7c6b5068edef070b202d7174733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982543Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#728181}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e7ad3848550e..e7a24f881291 Created with: gclient setdep -r src-internal@e7a24f881291 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic53ea41d5fcba3eccd30e069304feceaf9f06a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986628Reviewed-by:
-
Jan Scheffler authored
This cl updates the test results for crrev.com/c/19671359. Cl disabling the test: crrev.com/c/1985772. Bug: chromium:1019723 Change-Id: I82ef805dc837e2c3b91dafc5709366da0d8bdb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985775 Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
-
Sergio Villar Senin authored
NaN is used to represent null values for double types. Replace them by Optional<double> so that the base::nullopt represents the null value. This will ease the transition to an free of doubles animation engine. Bug: 994811 Change-Id: I4562999e05faeb284661878b86820c794dbfe5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984311Reviewed-by:
-
Peter Marshall authored
The test was flaky a long time ago but now fails consistently. The TracingStartedInPage trace event doesn't seem to be emitted anymore so I replaced this with the TracingStartedInBrowser event. That event doesn't emit nodeIds so I updated the expectation to assert that they are undfined. Also a drive-by cleanup to tracing-test which was trying to JSONify the wrong variable which meant the output in case the test failed was not helpful. Also clean up the test itself with const, JS style etc. Bug: 734762 Change-Id: I3f7f5665ace38525fca5967c5de6f6fba02d3d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983172Reviewed-by:
-
Oriol Brufau authored
LayoutNGListItem was applying some style adjustments to markers, like 'white-space: pre' to preserve trailing spaces in outside markers. But this was only affecting markers with 'content: normal', and the changes weren't exposed in getComputedStyle(). This patch moves these adjustments into StyleAdjuster, so that all markers are affected equally. BUG=457718 TEST=external/wpt/css/css-pseudo/marker-content-018.html The test fails in legacy because the 'content' property is not supported yet in ::marker. There is a new failure in marker-supported-properties.html because now 'white-space' will compute to 'pre' in outside markers, even if you specify a different value. But normal markers were already enforcing 'pre' at used value time anyways. Change-Id: I6d8b8ec7fb26cb04402032924f87b2c3b8fdb9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985966Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#728176}
-
Koji Ishii authored
This patch adds |NGFragmentItem| support when computing scrollable overflow. To share logic between child fragments and child items, this patch converts a local lambda function to an internal struct with member functions. Fixes ~80 tests when FragmentItem is enabled. Otherwise no behavior changes. Bug: 982194 Change-Id: Ia9f107f830404dc74e258bf9cd4fa3b878e22e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963597 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#728175}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c0734715d1c0..83ee98292f2b git log c0734715d1c0..83ee98292f2b --date=short --first-parent --format='%ad %ae %s' 2020-01-03 nisse@webrtc.org Delete p2p/base/packet_transport_interface.h Created with: gclient setdep -r src/third_party/webrtc@83ee98292f2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibb82bc53862fbf8a6ded208805e1aea57dd44526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986710Reviewed-by:
-
Oriol Brufau authored
StyleAdjuster adjusts the style for ::marker depending on whether it's inside or outside. This is mostly defined by the 'list-style-position' property, however, Chromium forces some markers to be inside. This patch is a follow-up of r726310, it fixes a problem with the logic for detecting these forced-inside markers, it was not working at all. BUG=457718 TEST=fast/lists/list-marker-computed-display.html The test is internal since forced-inside markers are a non-standard quirk. Change-Id: Ibfda8459defb036eabdb2cd01990fde000bae533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985668Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/17463ef0e0d9..172d5213f9a6 git log 17463ef0e0d9..172d5213f9a6 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 janscheffler@chromium.org Improve formating when copying network requests Created with: gclient setdep -r src/third_party/devtools-frontend/src@172d5213f9a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If4c1ce054845b80fbe5a8618c7a61e77fe182288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986707Reviewed-by:
-
Mugdha Lakhani authored
Now that the feature has shipped, the Devtools experiment for Periodic Background Sync can be removed. The experiment is removed in: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1985661 This change disables affected web tests so the CL linked above can be checked in. Once Devtools autoroller merges the changes from the CL linked above into Chromium, these tests will be re-enabled with updated expectations. Bug: 1038678 Change-Id: I210a2d8a16fce6db9b0aa98b69afae16b0e5b968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985985Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#728171}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7b2ee5b3. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I71720d93d62c0fc9319d7f9dccac24a7df9f89c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984502Reviewed-by:
-
Himanshu Jaju authored
This allows us to find ack times by platform and message type, so we can know if some platform is slower and needs extra work. Bug: 1035433 Change-Id: I36d1eabe1a28b1948671a4985594da8eed96b74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984299Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#728169}
-
Rayan Kanso authored
Bug: 1037426, 1036959, 1036957, 1036958 Change-Id: I24a3d11293472f078606de7ce0ab1e05b2c47adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983237Reviewed-by:
-
