GitLab

The following supressions are no longer needed:

bug_60667c
bug_70327
bug_71152
bug_75051
bug_75127a
bug_75127b
bug_75127c
bug_77766
bug_78201
bug_78786
bug_79357a
bug_79357b
bug_79651
bug_79652
bug_79865a
bug_79865b
bug_79933a

BUG=60667,70327,71152,75051,75127,77766,78201,78786,79357,79651,79652,79865,79933
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/584473002

Cr-Commit-Position: refs/heads/master@{#295452}

This is necessary to be able to use async operation on handles.

This is a reland of https://codereview.chromium.org/552783004 after the
build dependency issue has been fixed.

R=sdefresne@chromium.org
BUG=415485

Review URL: https://codereview.chromium.org/577193002

Cr-Commit-Position: refs/heads/master@{#295451}

This reverts commit:
  https://chromium.googlesource.com/chromium/src/+/93ea39da5423d641ecbc5687764f6b12972e302a.

Additionally, it also changes the |first_id| for the string resource group chrome/browser/browser_resources.grd / "includes", because the group has ran out of IDs.

BUG=370966
NOPRESUBMIT=true
R=asvitkine@chromium.org, dbeam@chromium.org, erg@chromium.org, gab@chromium.org, sky@chromium.org, vasilii@chromium.org

Review URL: https://codereview.chromium.org/533183002

Cr-Commit-Position: refs/heads/master@{#295450}

BUG=366145

Review URL: https://codereview.chromium.org/576073004

Cr-Commit-Position: refs/heads/master@{#295449}

https://chromium.googlesource.com/chromium/blink/+log/279b7e70bf67f06afd9bd69571c3a2e3d6aee919..745f4126ebd8d4235f56cfe6be13739493149e8c
TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/578263002

Cr-Commit-Position: refs/heads/master@{#295448}

TBR=nduca,dsinclair
BUG=415388

Review URL: https://codereview.chromium.org/583583002

Cr-Commit-Position: refs/heads/master@{#295447}

clang + icecc has problems finding libFindBadConstructs.so, probably
due to a path bug in icecc.

We can however workaround this bug by using the canonical absolute path
instead of an absolute path that includes redundant directories (ie
remove "tools/clang/scripts/../../../" from the middle).  This has the
benefit of simplifying and shortening clang compile commands.

BUG=409571

Review URL: https://codereview.chromium.org/525733005

Cr-Commit-Position: refs/heads/master@{#295446}

When using a prebuilt libwebviewchromium, instead of skipping the entire
directory just include the makefiles needed to build V8 for
external/chromium-libpac to use.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/583573002

Cr-Commit-Position: refs/heads/master@{#295445}

BUG=392154

Review URL: https://codereview.chromium.org/371413002

Cr-Commit-Position: refs/heads/master@{#295444}

The tool can be run with a preprocessed nm file as input and trying
to run a DWARF version check in that case won't work.

BUG=415084
R=andrewhayden@chromium.org

Review URL: https://codereview.chromium.org/573273002

Cr-Commit-Position: refs/heads/master@{#295443}

BUG=404012

Review URL: https://codereview.chromium.org/579813002

Cr-Commit-Position: refs/heads/master@{#295442}

R=sdefresne@chromium.org

Review URL: https://codereview.chromium.org/578893002

Cr-Commit-Position: refs/heads/master@{#295441}

BUG=415472
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/576493003

Cr-Commit-Position: refs/heads/master@{#295440}

Changing in the initialization order of WeakPtrFactory in src/gin module
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructor are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/573133003

Cr-Commit-Position: refs/heads/master@{#295439}

BUG=366145

Review URL: https://codereview.chromium.org/563083004

Cr-Commit-Position: refs/heads/master@{#295438}

Script streaming is implemented here: https://codereview.chromium.org/368283002

BUG=

Review URL: https://codereview.chromium.org/547373002

Cr-Commit-Position: refs/heads/master@{#295437}

 - Corrected handling of the BISECT_MODE_RETURN_CODE when using BisectOptions.FromDict.
 - Refactored code to avoid parsing metrics when bisect is running in BISECT_MODE_RETURN_CODE.
 - Other minor corrections.

R=qyearsley@chromium.org

Review URL: https://codereview.chromium.org/568423002

Cr-Commit-Position: refs/heads/master@{#295436}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/579123002

Cr-Commit-Position: refs/heads/master@{#295435}

BUG=370850
R=blundell@chromium.org, brettw@chromium.org

Review URL: https://codereview.chromium.org/553783003

Cr-Commit-Position: refs/heads/master@{#295434}

https://chromium.googlesource.com/chromium/blink/+log/74361aeabdc1193cb57d19c347ecee0ffddc8aa5..279b7e70bf67f06afd9bd69571c3a2e3d6aee919
TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/578203002

Cr-Commit-Position: refs/heads/master@{#295433}

The following supressions are no longer needed:
bug_16093
bug_16095
bug_16128
bug_19371
bug_27665
bug_29675
bug_32623
bug_43471
bug_46250
bug_50304
bug_50936
bug_52831
bug_58564

BUG=16093,16095,16128,19371,27665,29675,32623,43471,46250,50304,50936,52831,58564
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/583553002

Cr-Commit-Position: refs/heads/master@{#295432}

The following supressions are no longer needed:
bug_122189
bug_122192
bug_122245a
bug_122245b
bug_122429
bug_122431
bug_122435a
bug_122435b
bug_122436
bug_122437
bug_122454
bug_122455
bug_122670
bug_122716
bug_122752a
bug_122752b
bug_124156

Note: omitting bug 122752 from BUG list as the bug doesn't seem to exist.

BUG=122189,122192,122245,122429,122431,122435,122436,122437,122454,122455,122670,122716,124156
R=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/579973003

Cr-Commit-Position: refs/heads/master@{#295431}

Previously we do a two step write: SetLength() followed by Write(). However,
if CdmFileIOImpl is destroyed after SetLength() but before Write(), the file
will be corrupted (having the new length but the old data). This CL refactor the
write operation to: WriteToTempFile() followed by Rename(). This way, if
CdmFileIOImpl is destroyed after WriteToTempFile() but before Rename(), the
original file will not be touched.

Other refactions done in this CL:
- Add STATE_ERROR state.
- Move OpenFile() from Open() to Read() and renamed it to OpenFileForRead().
- Update/Add test cases to cover new changes.

BUG=410630
TEST=Updated unittests.

Review URL: https://codereview.chromium.org/545983005

Cr-Commit-Position: refs/heads/master@{#295430}

The following supressions are no longer needed:
bug_108146a
bug_108146b
bug_108147
bug_108620
bug_108621
bug_108622
bug_108624
bug_108624a
bug_108628
bug_108832
bug_109495e
bug_109495f
bug_109496
bug_109872

BUG=108146,108147,108620,108621,108622,108624,108628,108832,109495,109496,109872
R=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/581023002

Cr-Commit-Position: refs/heads/master@{#295429}

The following supressions are no longer needed:
bug_110734
bug_111186
bug_111341
bug_112315
bug_112573
bug_112835
bug_115294
bug_116475

BUG=110734,111186,111341,112315,112573,112835,115294,116475
R=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/579103002

Cr-Commit-Position: refs/heads/master@{#295428}

The following supressions are no longer needed:
bug_138522
bug_139467
bug_139470
bug_139853
bug_139996
bug_140196
bug_143545
bug_144118
bug_144913
bug_144930
bug_145244
bug_145645
bug_145704
bug_145705
bug_149734a
bug_149734b

BUG=138522,139467,139470,139853,139996,140196,143545,144118,144913,144930,145244,145645,145704,145705,149734
R=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/577143002

Cr-Commit-Position: refs/heads/master@{#295427}

https://chromium.googlesource.com/chromium/blink/+log/e5f2db40bf30ce95edbff9b881f8c72a0f246e6a..74361aeabdc1193cb57d19c347ecee0ffddc8aa5
TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/576173004

Cr-Commit-Position: refs/heads/master@{#295426}

Currently Galley opens files that have an image/* mime type. But ThumbnailLoader
does not generate an image for the files correctly.

BUG=415022
TEST=Download an image file with invalid extension, and select it in Files.app.

Review URL: https://codereview.chromium.org/577003005

Cr-Commit-Position: refs/heads/master@{#295425}

Also, add results logging of the average lateness of the late video frames.

Review URL: https://codereview.chromium.org/575313002

Cr-Commit-Position: refs/heads/master@{#295424}

Recent refactoring has made this function unnecessary.

BUG=414363

Review URL: https://codereview.chromium.org/565713004

Cr-Commit-Position: refs/heads/master@{#295423}

FileSystemOperationRunner::{CopyInForeignFile, CopyFileLocal, MoveFileLocal}

BUG=413545
TEST=content_unittests

Review URL: https://codereview.chromium.org/565073002

Cr-Commit-Position: refs/heads/master@{#295422}

Speculative fix for 415307. CF will confirm.
The stack trace for that bug indicates an attempt to index by -1, which is consistent with no visible page.

BUG=415307

Review URL: https://codereview.chromium.org/560133004

Cr-Commit-Position: refs/heads/master@{#295421}

BUG=none

Review URL: https://codereview.chromium.org/581003002

Cr-Commit-Position: refs/heads/master@{#295420}

https://skia.googlesource.com/skia/+log/0e9770515cab45decb56a5926d1741b71854fb4c..613d579471a4515dae60bdf7e3ab25cb3977fa01

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/558473003

Cr-Commit-Position: refs/heads/master@{#295419}

This patch adds a feature to show the icon. See the issue for the detail.

BUG=412978
TEST=manually tested

Review URL: https://codereview.chromium.org/578823002

Cr-Commit-Position: refs/heads/master@{#295418}

BUG=367631
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/561223002

Cr-Commit-Position: refs/heads/master@{#295417}

BUG=409938

Review URL: https://codereview.chromium.org/580903007

Cr-Commit-Position: refs/heads/master@{#295416}

It's flaky on Linux as well.
BUG=410891
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/584443002

Cr-Commit-Position: refs/heads/master@{#295415}

Under pnacl the filename-dev irt interface is not
available which means the "real" pointers end up
being NULL.

Without this fix nacl_io will crash on fist call
to open(2) in the passthrough fs (the default root
filesystem!).

Technically this change is only needed for newlib
today but applying to all libc versions since the
availability of dev interfaces is never guaranteed.

Review URL: https://codereview.chromium.org/576363002

Cr-Commit-Position: refs/heads/master@{#295414}

If location icon bubble is shown, then clicking on it again should
hide it. That is, it should toggle the popup on every click (press
and release).

BUG=107876

R=pkasting@chromium.org

TEST=
1) Navigate to any webpage so that page info is enabled.
2) Click on page info icon to show the popup.
2) When the popup is shown, click the icon again and observe.
3) 2nd click should close the popup instead of showing it again.

Review URL: https://codereview.chromium.org/561883006

Cr-Commit-Position: refs/heads/master@{#295413}