GitLab

Updates the expires_after attribute for 44 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2021-02-08.

TBR=chromium-metrics-reviews@google.com

Change-Id: I8d739166f458d861cff936467f658b736a62c597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530976Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826407}

This reverts commit d22a4cef.

Reason for revert: build failure:

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863899624870692272/+/steps/compile/0/stdout

Original change's description:
> wtf: Build traits based on cppgc for when using Oilpan library
>
> Currently WTF uses forward declarations to define basic GC traits that
> are used throughout WTF and Blink globally, i.e., without any specific
> context or other traits being available. This is an implicit
> dependency on blink.
>
> With Oilpan throuhg V8, we make this dependency a header-only
> dependency that is explicit which allows to re-use existing traits
> from the library to define the WTF equivalents.
>
> Change-Id: I3995c0d587424299ed880adcd5ac848a635e4f1e
> Bug: chromium:1056170
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532236
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826397}

TBR=haraken@chromium.org,mlippautz@chromium.org

Change-Id: Ifaf0414b054fd37de410acfd8ced1a5814e04232
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1056170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532729Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826406}

This reverts commit ff1d9dd5.

Reason for revert: crbug.com/1146687 still occurring after this revert.

Original change's description:
> Revert "Refactor subresource redirect renderer code"
>
> This reverts commit 674a1af2.
>
> Reason for revert: suspected cause of crbug.com/1146687
>
> Original change's description:
> > Refactor subresource redirect renderer code
> >
> > This CL refactors the existing subresource redirect code to make the
> > robots rules and login based image compression implementation easy.
> >
> > * Separate out the url loader throttle that does redirect and timeout
> > handling from the public image hints decider logic. The robots decider can
> > be subclassed and used.
> >
> > * Make public image hints agent as renderframeobserver. This reduces
> > cluttter in ResourceLoadingHintsAgent. The upcoming robots checker agent
> > could also observe renderframeobserver directly.
> >
> > No change in behavior is expected.
> >
> > Change-Id: Ic555a4402016a645b8820fa87dd5157c7112fb71
> > Bug: 1144836
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514068
> > Commit-Queue: rajendrant <rajendrant@chromium.org>
> > Reviewed-by: Michael Crouse <mcrouse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#825115}
>
> TBR=rajendrant@chromium.org,mcrouse@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1144836, 1146687
> Change-Id: I483882b29ac342d188137690e7ba9f8cbedcd6ee
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527859
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825966}

TBR=kbr@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1144836
Bug: 1146687
Change-Id: I5334a53226d6641fbc4ec601e6b4d01bb6c8b48c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533196Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826405}

The class will be used by BrowserNonClientFrameViewAsh, in
both ChromeOS and Lacros builds.

CL also migrates BrowserFrameHeaderAsh away from using ash::TabletMode,
in favor of chromeos::TabletState.

For more details, see phase 2.12 in [1].

[1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/

BUG=1113900
R=jamescook@chromium.org
TBR=sky@chromium.org

Change-Id: I8a6c3ee2138ee9659454afd25c4c016a394a1b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529492
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826404}

Also
-Add histogram to track js execution time.
-Pipe web contents into internal code to allow for triggering this module from the lens sdk.

Bug: 1145865
Change-Id: Ia22e285d7b8ebcf6fa214dcb7d8aa35aa7202c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520334Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ben Goldberger <benwgold@google.com>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ben Goldberger <benwgold@google.com>
Auto-Submit: Ben Goldberger <benwgold@google.com>
Cr-Commit-Position: refs/heads/master@{#826403}

This reverts commit ef949e14.

Reason for revert: Fix the compile issue, caused by a change after
trybots run but before landing.

Original change's description:
> [BreakoutBox] Add MediaStreamTrackProcessor
>
> This CL introduces MediaStreamTrackProcessor, an object that allows
> exposing a MediaStreamTrack's media frames as a readable stream,
> enabling applications to perform custom processing.
> This basically allows the creation of a custom sink, in terms of the
> model proposed by the Media Capture and Streams spec [1].
> A MediaStreamTrackProcessor can be combined with a TransformStream and a
> MediaStreamTrackGenerator to effectively insert a processing step inside
> an existing track.
>
> [1] https://w3c.github.io/mediacapture-main/#the-model-sources-sinks-constraints-and-settings
>
> Bug: 1142955
> Change-Id: I2a119f0c2ea9ce50432509286bd0f43758d8a272
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524322
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826153}

TBR=kinuko@chromium.org


Change-Id: Ia68309f8e5d8b3c58174ec13e520040984d4809f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532213Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826402}

* Fix a couple of incorrect include guards.
* Use "return std::make_unique<T>(...)" instead of
  "return std::unique_ptr<T>(...)" because the latter is banned by a
  presubmit.

https://source.chromium.org/chromium/chromium/src/+/master:PRESUBMIT.py;drc=9c1f87c53ca0d29afdd5763b50cb26341ba1fd64;l=2596

I just noticed these incidentally while investigating another issue.

Bug: none
Change-Id: Id5ea994517ff41641a724cf0832da80f8ac7b680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530900
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826401}

A navigation redirect chain can include the same URL more than
once, for example, b.com -> a.com -> c.com -> a.com.

However, when mapping Safe Browsing decisions to pending
queries, the logic assumes there can only be at most one
pending query with a given URL. This means that, in the
above example, if the Safe Browsing decisions for a.com
arrive after there are two queries for a.com, only one
of these queries will be assigned a result, even after
both decisions are computed.

This CL modifies
SafeBrowsingTabHelper::PolicyDecider::GetPendingMainFrameQuery
to return the oldest matching query that does not yet have
a decision, and renames this method to
GetOldestPendingMainFrameQuery. With this change,
decisions for URLs in a redirect chain are sent to the
first query that doesn't yet have a decision.

This CL also relaxes a DCHECK in
SafeBrowsingTabHelper::PolicyDecider::HandleMainFrameResponsePolicy
that currently checks that the given URL (passed in by
ShouldAllowResponse) matches the pending query's URL (from
ShouldAllowRequest). There are at least two cases where this fails
to hold:

1) Sometimes when there's a server redirect, a ShouldAllowRequest
   call is never made for the target of the redirect. Instead,
   an additional ShouldAllowRequest call arrives for the source
   of the redirect, and WKWebView's URL is still the source URL
   when DidRedirectNavigation is called. This bug does not seem
   to reproduce in trunk WebKit, so may be fixed there.

2) When the request is handled by a ServiceWorker, the ServiceWorker
   is able to set a different URL on the response it produces. In
   these cases, the URL still has the same origin as the request.

Bug: 1144690
Change-Id: Idae3161c9ddee4fd6e1fe6e13c111a5e90b29c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518330
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826400}

Deletion from the in-memory URL DB can be slow: http://shortn/_eSkRG8RvpV
This CL makes the deletion of queries from the in-memory URL DB async
by posting the deletion task to a sequenced task runner on the UI thread.

Fixed: 1110077
Change-Id: Ia8099093eea6efde952bfbb58cd182b06174f8e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531654Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826399}

android test runner has integrated with resultsink directly, so we should update those test suites to stop using default result_adapter.

Bug: 1104245
Change-Id: I581afa657d972d7a30aca7c70a9b939b436b54d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530524Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826398}

Currently WTF uses forward declarations to define basic GC traits that
are used throughout WTF and Blink globally, i.e., without any specific
context or other traits being available. This is an implicit
dependency on blink.

With Oilpan throuhg V8, we make this dependency a header-only
dependency that is explicit which allows to re-use existing traits
from the library to define the WTF equivalents.

Change-Id: I3995c0d587424299ed880adcd5ac848a635e4f1e
Bug: chromium:1056170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532236
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826397}

This matches the current logic of the internal TabImpl#isVisible method
(inverted), which is true when a tab is active and in a started
fragment. The name reflects the reason for exposing this method, i.e.
why we think it's notable to clients.

Test coverage will be added in a follow up.

Bug: 1146058
Change-Id: Ibb538fa349623ca214774ef53496fab2414a6c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525848
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826396}

Some tests in the AgentImplTest suite were accidentally sending FIDL
messages over unbound channels. This was not caught by the test because
the tests did not spin the run loop to let the asynchronous callbacks
run or not run. This error is caught by new instrumentation being added
to the FIDL bindings.

This fixes up the bindings mismatch, spins the run loop to perform the
asynchronous portions of the test, and also adds some cleanup logic
that is also necessary now that the asynchronous portion of the test is
executing.

Test: cr_fuchsia_base_unittests
Bug: fuchsia:63593
Change-Id: I251124d9099695fc56096fd7baeb7a8fb67fdf7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530268
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Auto-Submit: James Robinson <jamesr@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826395}

https://android.googlesource.com/platform/external/perfetto.git/+log/0d4297e6b205..dfff133590c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I3133bd26e0edf4e9e914b082dd32b8bba52719d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533156Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826394}

Miscellaneous fixes:

- Simplify the unit tests by unparameterizing them. Instead, the tests
  simply iterate over an array of test cases, using SCOPED_TRACE() to
  make it easier to debug failures.
- Convert metrics enums to be a scoped enumeration, which allows:
  - clang to enforce kMaxValue correctness
  - autodeduction of the max value by UMA_HISTOGRAM_ENUMERATION()
- Remove the unused Gamma enum. The metric itself was removed in
  https://crrev.com/c/1684563.

Bug: 742517, 1047547
Change-Id: I0a5b4aeaa8540505a7b0596a4d0df6f871fef8b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527341Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826393}

typ has integrated with resultsink directly, so we should update those test suites to stop using default result_adapter.

Bug: 1104252
Change-Id: I7210d3abf2e2b259b61e148c59c69f85f1482fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531513Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826392}

After allocate a large buffer in memory and creating canvas, it will
trigger the garbage collection from v8, which will trigger
offscreenCanvas::Dispose to be called. This call will cause the
offscreencanvas detached from the |host|. However the |host| is saved
as a valid callback in the observer list of the canvas resource
provider. Calling this |host| without offscreencanvas causes this access
to poison address.

In my fix, after garbage collection is triggered and dispose is called,
DiscardResourceProvider() is called as well, so it removes itself from
the observer list.

Bug: 1143662
Change-Id: I82c9a1f70c117b03de9fb64f4849c1f3c4311d1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531136Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826391}

This reverts commit 6f8b5118.

Reason for revert: caused compile failure on multiple builders.

Sample build: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/90601?

Original change's description:
> Remove empty base/bind_helpers.h
>
> The contents moved to callback_helpers.h.
>
> Also renames a few new bind_helpers.h includes that have been added
> in the meantime.
>
> R=​dcheng@chromium.org
> TBR=
>
> Change-Id: Ia511a4939d60bd2ef5b474185e3716017543f8af
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523545
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826387}

TBR=danakj@chromium.org,dcheng@chromium.org

Change-Id: I7405532513d9195295aab659f565c8d00cdb3016
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533278Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826390}

crrev.com/6f8b5118 adjusted location of callback helpers.

TBR=danakj@chromium.org
NOTRY=true

Change-Id: I4af7bd6b70c4716db7059b16ec7dd7843fc0fd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533026Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Auto-Submit: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826389}

Adds back call mistakenly removed in
https://chromium-review.googlesource.com/c/chromium/src/+/2496287

R=dmazzoni@chromium.org

Change-Id: I3fab6b94a8c9c80527b0b2d451ef1d6911be1f10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532928Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826388}

The contents moved to callback_helpers.h.

Also renames a few new bind_helpers.h includes that have been added
in the meantime.

R=dcheng@chromium.org
TBR=

Change-Id: Ia511a4939d60bd2ef5b474185e3716017543f8af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523545
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826387}

This CL adds metrics for counting the number of times a user adjusts a
capture region. Visit go/capture-mode-metrics to see other planned
metrics.

Test: manual + added
Bug: 1140182
Change-Id: Ib058be572eff6c539e8673cd9a25d340e053b521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523492Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826386}

Sort the scanners in the scanner dropdown alphabetically and set the
first scanner as the default scanner.

Bug: 1059779
Change-Id: I5a40ea0fadeb5c6166450a537c81dfe8fecdd240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528941Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826385}

Change-Id: Ibc08b6a720494c7234104a8089b6ad9c580e774f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528298Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826384}

Change-Id: I63536d743f3396f422fb9959eada4e0fec733a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528633
Auto-Submit: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#826383}

Some unit tests should be removed or re-worked when non-Ozone X11 is
deprecated.  Here the TODOs are changed so they refer to the relevant
issue.

Bug: 1109112
Change-Id: I221c8447b62bb4aa4a7e38acb53cca84ff6427d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526300Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Alexander Dunaev <adunaev@igalia.com>
Cr-Commit-Position: refs/heads/master@{#826382}

Looking at crash reports where the LocalRootImpl is null it is clear
that the HandleMouseUp can detach the frame and the GetPage accessor
will then be null.

Change-Id: If856e914135b833bfacbce84be5c15b242acd09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533021
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826381}

Disable IncognitoBackgroundSyncBrowserTest.OffTheRecordProfile. This is
failing on Android bots.

TBR=nator@chromium.org

Bug: 1147754
Change-Id: Ib192173097ab3afe4371431d3a9b2c5d6440a57d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532856Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826380}

This adds an integration test, testing changing element conditions.

This CL also fixes several bugs that were discovered during testing:
- Fixed issue where ElementConditions were not correctly added and
cleared.
- Constructing a new instance of AssistantHeaderCoordinator no longer
has a side effect in AssistantHeaderModel.
- Fixed a possible crash when showing a new trigger script while another
was in the process of being hidden (crash comes down to timing). The fix
is to always create a new BottomSheetContent, instead of re-populating
the old one.

Bug: b/171776026
Change-Id: I7eac6673100ab21d459ec7f1ed200b2be9a44ff5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524532
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Marian Fechete <marianfe@google.com>
Cr-Commit-Position: refs/heads/master@{#826379}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=vasilii@chromium.org

Bug: 1145565
Change-Id: I12660e862e5b73ed06f39d1ca4eb40a8067a4760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533022
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826378}

This CL is a followup to https://crrev.com/c/2482443.
This adds simple unittest that verifies that device
scroll list in bluetooth tray view is updated correctly.

Fixed: 1141995
Change-Id: I8237871ff6c06f864a804d106a0556d3552b6109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508234Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826377}

Bug: 1145379
Change-Id: I5284a9c080e5b3d951eff65ca8ef4426b3377cd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532918
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826376}

This change enables by default the feature where the
long search suggestion text would be wrapped to the
second line.

Bug: 1085184
Change-Id: Id1e8848457250e8bf35cca2a7b8bf6723374661c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504071Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#826375}

The ArcSharesheetBridge will receive share requests from Android
and handle them with Chrome's sharesheet in a Chrome Custom Tab.

This change sets up the skeleton to accept connections from
Android.

BUG=b:172963488
TEST=Deployed chrome, and verified share intents is received from
     Android using Android's APIDemos apk.

Change-Id: Ib14e414f65c3bb7b675a0d1a0d846fc3a17b0769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531394
Auto-Submit: Prameet Shah <phshah@chromium.org>
Commit-Queue: Josh Horwich <jhorwich@chromium.org>
Reviewed-by: Josh Horwich <jhorwich@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826374}

ARC provisioning can fail due to ARC instance abruptly stopping. This
can have three possible reasons however we show the same generic error
"Something went wrong" instead of a more useful error.

With this change, we're adding the ability to show a unique error for
each of the three reasons for ARC instance stopping.

BUG=b:166322619
TEST=force the arc stop error, deploy to dut, ensure new metric is
logged in chrome://histograms

Change-Id: I5d73fcf9f845237e6d4d52e52a24a6cfe7f34e74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518664Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826373}

All non-primitive types need explicit non/null modifier as per style guide.

chrome/test/data/webui/chromeos/diagnostics:closure_compile

Bug: 1125150
Test: autoninja
Change-Id: Ic1a6ff8c08cb1fb8770158c3154eb0bec8879712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530191
Auto-Submit: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826372}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=harringtond@chromium.org

Bug: 1145565
Change-Id: I00ea07dd484293ba9cc164f97838def2a4e15615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532657
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826371}

Change-Id: Iece225a990448b954161d3286a1f595f60e6f04e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530262Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826370}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=msramek@chromium.org

Bug: 1145565
Change-Id: I10357ac1f5c2ae101b2a63a7e0841f890cf3134a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532717
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826369}

- Current full battery capacity was moved to a different struct

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I64e6c3ff810a38e53c4ea1bf95e58f56469d81de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531114
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826368}