Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 19 Nov, 2019 31 commits
  3. 18 Nov, 2019 9 commits
    • Sharon Yang's avatar
      Reland "[Fuchsia] Send Chrome a11y updates to Fuchsia SemanticsManager" · fbb9ba4a
      Sharon Yang authored 
      This is a reland of fc5589ac

Race conditions and flakes in the tests have been fixed.
AccessibilityBridge.TestNavigation has been added.

Original change's description:
> [Fuchsia] Send Chrome a11y updates to Fuchsia SemanticsManager
>
> This change adds functionality to the Accessibility Bridge:
> * Listens for change in AccessibilityMode from Fuchsia
> * Gets the semantic tree from Chrome accessibility and sends it to the
> SemanticsManager
> * Sends live updates when nodes are added, updated or removed
>
> To send updates, this change includes the following:
> * Creates a ViewRefPair and registers it with the SemanticsManager
> * Initialize an AccessibilityBridge
> * Listen for changes in the Chrome Accessibility tree, serializes them
> to Fuchsia data structures and sends that data to the Fuchsia
> SemanticsManager
>
> Testing: Added AccessibilityBridge browsertests.
>
> Bug: 973095
> Change-Id: I89658288b846b6b9ce84a04e49434ec266b84dfc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787171
> Commit-Queue: Sharon Yang <yangsharon@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714588}

Bug: 973095
Change-Id: I920435c123b66dbe2172ce7fe164d64ba679321b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916961
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: default avatarKevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716379}
      fbb9ba4a
    • Greg Kerr's avatar
      Extend flags expiration date. · 39485498
      Greg Kerr authored 
      This extends the expiration date of several flags still relevant to
sandbox and scheduler configurations.

Bug: 1025993
Change-Id: I43866b5424d326fef1487e0881f1a4f0c77f1477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922547
Auto-Submit: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716378}
      39485498
    • Victor Hsieh's avatar
      Refresh system info at login screen after enabled adb sideloading · 26eb8b08
      Victor Hsieh authored 
      Test: see the warning indicator at login screen
Bug: chromium:893332
Change-Id: Ia34fb90163efc22015255473e468e52a50ac42e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919788
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Auto-Submit: Victor Hsieh <victorhsieh@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716377}
      26eb8b08
    • Nick Diego Yamane's avatar
      Remove unused WeakPtrFactory from DWTH{Platform,X11} · 22cf8ed3
      Nick Diego Yamane authored 
      These seem to be leftovers from recent code movings among DWTHX11 =>
DWTH{Linux,Platform}.

Bug: None
Change-Id: I02ed92616b92ffea1b5cb14333b3e012d3f73534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919600
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716376}
      22cf8ed3
    • Chris Davis's avatar
      Setup etw registration in chrome.dll · a9274264
      Chris Davis authored 
      Update ETW manifest usage so chrome.dll can be used to register the ETW
provider. Prior to this a DummyChrome.dll was needed which registered
the ETW provider used by Chrome. The chrome_events_win.man file was
updated to be a general application manifest containing a
instrumentation section.  The chrome_events_winTEMP.BIN and
MSG00001.bin files are auto-generated by the manifest compiler.

chrome.dll size (release x64)
Before: 122,627,584
After:  122,629,120
Total Increase: 1536 bytes

BUG: 1024949

Change-Id: Ibb3783da20a35a5caeabab93bd2da10a2cf67faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896040Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
Commit-Queue: Chris Davis <chrdavis@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#716375}
      a9274264
    • Jeremy Roman's avatar
      Move existing PortalBrowserTest.* to use PortalActivatedObserver. · 2168b708
      Jeremy Roman authored 
      The separate observer has a couple of advantages.

Firstly, it allows waiting and access to occur after the
content::Portal (and its interceptor) may have been destroyed.
Instead, it's valid as long as the Portal is valid when the
observer is created.

Secondly, it allows examination of the activate result.

Since there are existing tests which rely on the ability to
observe activation immediately after a portal is created or
adopted (ideally we would more explicitly sequence these events
in the test, but this is not always possible), the created
observer is augmented with the ability to run a callback
immediately (rather than after the run loop quits, which is
subtle due to other work in the same task and nested run loops).
This is used to create a PortalActivatedObserver immediately
when the Portal is created, before the browser UI thread can
process any task which might either activate or destroy the Portal.

This mostly makes PortalInterceptorForTesting an implementation
detail of the more specific observers.

Change-Id: I6ee3bd8e847235654cc4a063659818e2e970c2b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900258
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: default avatarLucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716374}
      2168b708
    • Xianzhu Wang's avatar
      Update expectations and baselines of some tests under compositing/ and paint/ · 1ad89879
      Xianzhu Wang authored 
      - compositing/3d-cube.html is modified to a pixel test instead of a
  ref test because there seems no way to make the ref test pass. The
  new pixel result is platform independent.

- compositing/video/video-controls-layer-creation-squashing.html is
  modified from a ref test to a text test because what we care about
  is how we composite the layers.

- paint/invalidation/compositing/*-float-under-*-inline.html are updated to
  expect the new LayoutNG result. They are now expected to fail with
  LayoutNG disabled.

- Other rebaselines.

Change-Id: Ieeb195dfeea6b8478cf90b77f03a0a84984f6281
Bug: 726075, 591099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915459Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716373}
      1ad89879
    • Mike Wittman's avatar
      [Sampling profiler] Add profiler browser tests · 3fc2bdd0
      Mike Wittman authored 
      Implements browser tests to verify that startup profiles taken in the
browser and child processes are received by the metrics provider.

To work within the test timeouts and to avoid non-determinism this
requires a couple adaptations to be made to the code when run under
these tests. The profiling period is reduced from 30 seconds to one
second, and profiles are taken in all renderer processes. The behavior
is enabled by providing a 'browser-test' argument to the existing
'start-stack-profiler' switch.

The main thread profiler for browser tests is moved later, after the
command line is set up, to be able to observe the added switch
argument. StackSamplingConfiguration is made responsible for the
sampling parameters, reusing the GetSamplingParamsForCurrentProcess()
function which was previously unused.



Bug: 1011877
Change-Id: Ibad55178ebd3ff5ea497971868c9619210c2c8a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900262
Commit-Queue: Mike Wittman <wittman@chromium.org>
Auto-Submit: Mike Wittman <wittman@chromium.org>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Reviewed-by: default avatarEtienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716372}
      3fc2bdd0
    • nancy's avatar
      Remove InternalAppModelBuilder. · 0ee588c5
      nancy authored 
      AppServiceAppModelBuilder is used to replace InternalAppModelBuilder.
AppService integration to ui/app_list has been enabled for a couple
of months, so it should be safe to remove InternalAppModelBuilder.

Unit tests are updated to use AppServiceAppModelBuilder. I will use a
separate CL to move the internal_app_model_builder_unittest.cc to
src/chrome/browser/ui/app_list/app_service/, and convert it to
AppService unit tests. This CL still uses
internal_app_model_builder_unittest.cc, as it is more clear to show
the change.

BUG=1016159

Change-Id: I2d537aa940eae29201dd64bb7b345d3ae820d777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919534Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716371}
      0ee588c5