- 27 Aug, 2018 40 commits
-
-
James Cook authored
Pull initialize_webui_hidden_ computation into a utility function. This simplifies various IsUsingWindowService() checks for mash. Bug: 143298, 756071 Change-Id: I538ea8597f2fd970dbd246a9ee184144a76462ca Reviewed-on: https://chromium-review.googlesource.com/1189052Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#586276}
-
David Bertoni authored
Bug: 695711 Change-Id: Ic286b58b0d9a9984428e1db62ce82bd6f9c0ec0e Reviewed-on: https://chromium-review.googlesource.com/1187826Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#586275}
-
Charlie Harrison authored
Bug: 873316 Change-Id: Ifddbd91938e0bede3e68fc681009bafcd69e5882 Reviewed-on: https://chromium-review.googlesource.com/1188843Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#586274}
-
Michael Lippautz authored
Bug: chromium:843903 Change-Id: I2b2cd2efac7119945a32ba74435b4d443f2396f7 Reviewed-on: https://chromium-review.googlesource.com/1190003 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#586273}
-
Michael Lippautz authored
Move roots marking into ThreadState as most necessary data structures do not live in ThreadHeap but ThreadState. Bug: chromium:843903 Change-Id: I5e4f56f594911ebc0d9a17dcdfb4834c6befa555 Reviewed-on: https://chromium-review.googlesource.com/1189864 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ef678672fb04..47ee776a2c56 git log ef678672fb04..47ee776a2c56 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 stevenperron@google.com Revert "Have the constant manager take ownership of constants." 2018-08-24 stevenperron@google.com Have the constant manager take ownership of constants. 2018-08-24 31666470+s-perron@users.noreply.github.com Copy decorations when creating new ids. (#1843) 2018-08-23 alanbaker@google.com Fixing instances of iteration over unordered containers 2018-08-23 31666470+s-perron@users.noreply.github.com Don't "break" from selection constructs. (#1862) 2018-08-23 31666470+s-perron@users.noreply.github.com Update the order when predicating blocks. (#1859) 2018-08-22 karl@lunarg.com spirv-as: Fix error in help text. 2018-08-21 alanbaker@google.com Moving constant opcode validation into a new file 2018-08-21 ehsann@google.com [kokoro] Stop building and running tests for VS2013 (#1852) 2018-08-21 31666470+s-perron@users.noreply.github.com Fix VS2013 build break. (#1853) 2018-08-21 31666470+s-perron@users.noreply.github.com Have PredicateBlocks jump the existing merge blocks. (#1849) 2018-08-21 alanbaker@google.com Fix EvalInt32IfConst to fail on type instructions. 2018-08-21 31666470+s-perron@users.noreply.github.com Handle breaks from structured-ifs in DCE. (#1848) 2018-08-21 31666470+s-perron@users.noreply.github.com Have dead-branch-elim handle conditional exits from selections. (#1850) 2018-08-20 dnovillo@google.com Ignore *.pyc files in git commands. 2018-08-17 dnovillo@google.com Add testing framework for tools. 2018-08-15 dj2@everburning.com Add GN rules to build spriv-as (#1842) 2018-08-15 31666470+s-perron@users.noreply.github.com Change when instruction is registered in validator. (#1840) 2018-08-15 31666470+s-perron@users.noreply.github.com Keep decorations when replacing loads in access-chain-convert. (#1829) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@47ee776a2c56 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8a33db138f16b119e375ac66058517f926896568 Reviewed-on: https://chromium-review.googlesource.com/1190103Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586271}
-
Marc Treib authored
There are multiple reports of these DCHECKs triggering. To unblock other developers, let's disable them for now, and also add some logging to help debug what causes this. Bug: 872360 Change-Id: I3cc0898adab9e3e81bb56c3deeeeeb4e1629669c Reviewed-on: https://chromium-review.googlesource.com/1189923Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#586270}
-
Etienne Bergeron authored
This CL is adding the average disk usage (bytes transfered by seconds) to base::process_metrics. This metric is sampled by the performance monitor every 2 minutes and an UMA metric (e.g. PerformanceMonitor.AverageDisk.BrowserProcess) is produced. The current implementation is only working for windows. Other platforms need to implement |GetCumulativeDiskUsage|. The purpose of this metric is to allow adding slow-report triggers based on disk usage. R=fdoray, gab, oysteine Bug: 872900 Change-Id: I168a066cf5ebb3b0e879f8bbc5cc73740de1e938 Reviewed-on: https://chromium-review.googlesource.com/1174904 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#586269}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e00fe30b8fe7..adb4bfef0cd8 git log e00fe30b8fe7..adb4bfef0cd8 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 egdaniel@google.com A bunch of fixes for calling abandon on vulkan context. Created with: gclient setdep -r src/third_party/skia@adb4bfef0cd8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: If132ff66acd9758675b99d61121819626c04eac0 Reviewed-on: https://chromium-review.googlesource.com/1190104Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586268}
-
Anders Hartvoll Ruud authored
It is not spec'ed anywhere that <image> values interpolate in this way. They should however interpolate as gradients, but we don't have an InterpolationType for that yet. R=flackr@chromium.org Bug: 641877 Change-Id: I1a554d578c505f228f728ad7e09c3d5b4e5117e7 Reviewed-on: https://chromium-review.googlesource.com/1186416Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#586267}
-
manuk authored
This cl removes horizontal white-space between adjacent page actions' hover circles. White-space will remain between the icons visually, as the icons are smaller than their hover circles. Padding between the page actions and the location bar remains unchanged. This only affects material refresh and touchable material refresh. Bug: 866191 Change-Id: I8b48256a068fc5078c6c4bcb558ab9cd68763e91 Reviewed-on: https://chromium-review.googlesource.com/1185531 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#586266}
-
Markus Heintz authored
This reverts commit caf38a10. Reason for revert: Finit identified this CL as reason for breaking cronet_tests: - cronet_tests failing on chromium.mac/Mac10.13 Tests (dbg) - cronet_tests failing on chromium.linux/Linux Tests (dbg)(1) - cronet_tests failing on chromium.linux/Linux Tests (dbg)(1)(32) e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/74010 Original change's description: > cronet: Add ScopedTaskEnvironment to native tests. > > This is needed to fix cronet_unittests_android on the > android_cronet_tester bot after https://crrev.com/c/1187783. > > TBR=mef > > Bug: 877868, 875486 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester > Change-Id: If59e993e3e6b19cb54f04c2259014c34d6ad4592 > Reviewed-on: https://chromium-review.googlesource.com/1189712 > Reviewed-by: Victor Costan <pwnall@chromium.org> > Commit-Queue: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586221} TBR=wez@chromium.org,mef@chromium.org,pwnall@chromium.org Change-Id: Id1975c8bec0d0c863bbc36c23516e0c1cdc47ace No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877868, 875486 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/1190622Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#586265}
-
Koji Ishii authored
As we found SkPaint::getTextWidths has rather high entry cost, HarfBuzz has added a function to batch the call in [1]. This patch supports the batch function in HarfBuzzFace. blink_perf.layout (Legacy): 3-25% improvements in 10 tests. https://pinpoint-dot-chromeperf.appspot.com/job/137a7165640000 blink_perf.layout (LayoutNG): 3-40% improvements in 20 tests. https://pinpoint-dot-chromeperf.appspot.com/job/111903c5640000 [1] https://github.com/harfbuzz/harfbuzz/commit/79e21984b13bdb879f3007ba9a97fde47df340d3 Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I04f839526cd35876996b679971d49a99e47ae46c Reviewed-on: https://chromium-review.googlesource.com/1158671Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#586264}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 45ff1e77. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23500 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/compat rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic7b6110dd9c9bc9d872e048ffb2c9ebbc5ece47c Reviewed-on: https://chromium-review.googlesource.com/1190123 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586263}
-
David Benjamin authored
The spec says the body is a NULL, so we should enforce it. Otherwise implementations may accidentally produce certificates that get this wrong, and then other consumers will need to mimic our laxness. https://tools.ietf.org/html/draft-iab-protocol-maintenance-00 Bug: 851778 Change-Id: I0bcfd076d94743ab285ce0a6938182b9a32b0e36 Reviewed-on: https://chromium-review.googlesource.com/1189061 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#586262}
-
Koji Ishii authored
fast/table/column-in-inline.html says it tests "a table-column with a table-cell sibling are wrapped inside an inline-table when the parent is inline" but it also tests: 1. Anonymous inline box inherits non-inherited properties, which contradicts with the spec (crbug.com/877946). 2. If the above was fixed, it tests baseline alignment of inline tables. LayoutNG fails because it does not have crbug.com/877946. This patch changes the test to focus on what it says, and creates a separate test for crbug.com/869877. Bug: 869877, 877946 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0b53ec68d5ea59a93010d49891d6bfe3a6688158 Reviewed-on: https://chromium-review.googlesource.com/1179736Reviewed-by:
-
Steven Valdez authored
Bug: boringssl:226 Change-Id: I9541ae612322776a7ccddd8e163ab3025dba1e7a Reviewed-on: https://chromium-review.googlesource.com/1188849Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#586260}
-
Stephen McGruer authored
The addition of CSS filter properties as animatable values caused not one, but two Persistent reference cycles (where we went from garbage collected classes to non-garbage collected classes and back again). The two cycles are documented in crbug.com/821547#c24 and crbug.com/821547#c28 This CL fixes the reference cycle by making everything in the above chains GC'd. Bug: 821547 Change-Id: I49133875f8a476da1d45cd715d90b74783b15a4f Reviewed-on: https://chromium-review.googlesource.com/1060693 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
-
Balazs Engedy authored
Previously, it was gated on a command-line option which cannot be controlled via field trials. Also, enable the feature on continous build. Bug: 847985 Change-Id: I07ae0a7ef372b27309017da538f1dd4f85a9e3e3 Reviewed-on: https://chromium-review.googlesource.com/1187157Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#586258}
-
David Davidović authored
Refactor Nigori to better isolate the key derivation implementation. Add a function for scrypt-based key derivation, based on SymmetricKey::DeriveKeyFromPasswordScrypt, but do not expose it externally. Since the new functionality is not yet exposed, no unit tests for it have been added. Bug: 875931 Change-Id: I2bf1649e80fdeec4b44ac64034f246444b4a6d8b Reviewed-on: https://chromium-review.googlesource.com/1181903 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#586257}
-
Sylvain Defresne authored
Pass the PrefRegistry as a PrefRegistrySimple to the static method registering the properties as they are not synced. This allow calling the helper method in the tests instead of manually registering the properties. Fix include what you use in the factories. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaaad21d0a3cfe8278fb08a8c32dd890c0eb29a91 Reviewed-on: https://chromium-review.googlesource.com/1187145 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#586256}
-
Owen Min authored
Platform policy should be in the machine level as it applies to all profiles. Change-Id: Idc5bab84d31cb577299c689ca27e75a68e87441b Reviewed-on: https://chromium-review.googlesource.com/1188892Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586255}
-
Henrik Grunell authored
Removes false positives. Bug: 830624, 826664 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2be987f17cae4200146f565374c63dcb411345c2 Reviewed-on: https://chromium-review.googlesource.com/1188137Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#586254}
-
Marc Treib authored
Supervised user creation has been gone for a long time, so these aren't necessary anymore, and were never supplied (outside of some tests). TBRing a whole bunch of trivial call site updates (i.e. not passing an empty string as supervised_user_id). TBR=jochen Bug: 828890 Change-Id: I45bb13111960b5c8b39a13b8368df1749fcfaa6d Reviewed-on: https://chromium-review.googlesource.com/1188570 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, if the only method of payment available was a payment handler that is not yet installed, but is available or installation Just-In-Time (JIT), then PaymentRequest.canMakePayment() would return "false". This prevented JIT installable payment handler usage by merchants that don't call PaymentRequest.show() unless PaymentRequest.canMakePayment() returns true. This patch makes canMakePayment() return "true" for JIT installable payment handlers on both desktop and Android. (iOS does not support payment handlers at this point.) After this patch, if the only method of payment available is a payment handler that is not yet installed, but is available for JIT installation, then PaymentRequest.canMakePayment() would return "true". Bug: 877644 Change-Id: I614a02789b514d5d0e7738ca827178a844e74199 Reviewed-on: https://chromium-review.googlesource.com/1188900 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#586252}
-
Fredrik Söderquist authored
When synchronizing an empty list, the result should be that the attribute is removed. However, since StringBuilder::ToString for an "empty" StringBuilder returns the empty string we end up setting an empty attribute. Add a special case to handle empty lists, and return the null String there instead. The null String will translate to an attribute removal. All the SVG*List types that inherit from SVGListPropertyHelper are changed call a new shared implementation (SerializeList) in that class. Bug: 843901 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9442268196aaa605886fd4d6d31d66ae075f901d Reviewed-on: https://chromium-review.googlesource.com/1189862Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#586251}
-
Michael Lippautz authored
SVGPropertyTearOffBase::context_element_ is already TraceWrapperMember and will thus emit a write barrier for wrapper tracing. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I89d540179dc47792172f75bf769b898f0290c59e Reviewed-on: https://chromium-review.googlesource.com/1190163Reviewed-by:
-
Koji Ishii authored
r583983 (CL:1178441) checks associated InlineBox are cleared when LayoutText and LayoutInline are destructed. This patch checks associated paint fragments are cleared too. https://chromium-review.googlesource.com/c/chromium/src/+/1180828 Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I83e66e44be04366fcb072a2218e674c29be497c8 Reviewed-on: https://chromium-review.googlesource.com/1188407Reviewed-by:
-
Jan Wilken Doerrie authored
This change adds a CanPower() method to BluetoothAdapter. By default it simply delegates to IsPresent(), but it is overriden for WinRT, where we can be in a state where we were able to get accesss to the adapter, but not the underlying radio. Bug: 821766 Change-Id: I46544d542b49a73f7876a10daccb6d78c492b36c Reviewed-on: https://chromium-review.googlesource.com/1189903 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#586248}
-
David Davidović authored
Add a method for key derivation using the scrypt algorithm to crypto::SymmetricKey. Rename the pre-existing method for key derivation (which uses PBKDF2) to clearly disambiguate between the two. TBRing because all the changes to files not under crypto/ are a trivial library method name change. TBR=mnissler@chromium.org,droger@chromium.org,alemate@chromium.org,cfroussios@chromium.org,tbarzic@chromium.org Bug: 875931 Change-Id: Iaa0b2bb0fc3ae2481733072363718cffd8811b97 Reviewed-on: https://chromium-review.googlesource.com/1181881 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
-
Fredrik Söderquist authored
When an SVGAnimatedProperty has its associated attribute updated, we can cancel any pending attribute synchronization. This prevents overwriting the new value with the old in some cases. Bug: 843901 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3654ad616fd6e6ef82a1933ec034bc9cf0097d56 Reviewed-on: https://chromium-review.googlesource.com/1189842Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dcad91db..6e2adae6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7a336e3ccc72865a30f38cb382f61b0dd8f7a8b5 Reviewed-on: https://chromium-review.googlesource.com/1190122Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586245}
-
Scott Wu authored
Bug: 865114 Change-Id: I74a77252b7280f2e85df56f3ce7f4a0fd28b9873 Reviewed-on: https://chromium-review.googlesource.com/1169028 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#586244}
-
Patrik Höglund authored
This adds experimental test suites I can call from my new LUCI bots. Depends on a change which makes variable substitutions available to gtests. Bug: chromium:877018 Change-Id: Iadf529513e5a92a4e731d3adcaff874101356646 Reviewed-on: https://chromium-review.googlesource.com/1186412 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586243}
-
Armando Miraglia authored
Looking at the referenced bug (crbug/338503) it looks like this comment is outdated since the spec was already implemented. This CL removes the comment. BUG=338503 Change-Id: Id986c398ea59ea1d50c0835567a160b900769cd0 Reviewed-on: https://chromium-review.googlesource.com/1188566Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#586242}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/420696961c8c..e00fe30b8fe7 git log 420696961c8c..e00fe30b8fe7 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 reed@google.com remove SkIPoint16 from documentation -- it is private Created with: gclient setdep -r src/third_party/skia@e00fe30b8fe7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I2dc3b8bdcd4944b435980ac6eb01e1ea2565337d Reviewed-on: https://chromium-review.googlesource.com/1190004Reviewed-by:
-
Jinho Bang authored
The following pattern is wrong in browser tests: ResetEventWaiter(...); RetryPaymentRequest(...); WaitForObservedEvent(); The first line in the pattern is unmeaningful because the RetryPaymentRequest(...) helper method has already ResetEventWaiter() and WaitForObservedEvent() internally. So, this patch makes the helper method take DialogEvent and wait for the event internally. Bug: 861704 Change-Id: I94495cb0f0ed2369a08f49d1065571fa02251a00 Reviewed-on: https://chromium-review.googlesource.com/1189662Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#586240}
-
Alexander Hendrich authored
This CL adds handles the status code 417 from DMServer on an enrollment request, which occurs when the user has a packaged license and tries to enroll with a consumer account. The new error message hints the user to create an admin console. Bug: 871203 Change-Id: I9ddf696a252809f80104502b6df6744b1620e009 Reviewed-on: https://chromium-review.googlesource.com/1180961Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#586239}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifb2bad243924f0260802a3b01cf6813b7dc23ae3 Reviewed-on: https://chromium-review.googlesource.com/1189344 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586238}
-
Eriko Kurimoto authored
This UI allows users to know the type of log (speech, event..) easily. Bug: 874349 Change-Id: Ia525731a02752fbc5fa9a29a6aeeeea55c66d2df Reviewed-on: https://chromium-review.googlesource.com/1179116 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586237}
-
