GitLab

BUG=720034

Review-Url: https://codereview.chromium.org/2867663004
Cr-Commit-Position: refs/heads/master@{#473737}

The preference is deprecated and has been replaced by
kShowFullscreenToolbar.

BUG=590827

Review-Url: https://codereview.chromium.org/2896763003
Cr-Commit-Position: refs/heads/master@{#473736}

Also removes everything that depends on it, including its inclusion in
chrome, where it was never used, along with two subdirectories in mash/,
which appeared to be defunct.

BUG=722546

Review-Url: https://codereview.chromium.org/2901613002
Cr-Commit-Position: refs/heads/master@{#473735}

TouchDeviceServer is necessary for hooking up AshTouchTransformController in mus/mash.

BUG=705686
TEST=covered by tests
R=erg@chromium.org,rockot@chromium.org,tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2901563002
Cr-Original-Commit-Position: refs/heads/master@{#473651}
Committed: https://chromium.googlesource.com/chromium/src/+/68e20f488cc2ea0216832c8fe3640d9b748595d2
Review-Url: https://codereview.chromium.org/2901563002
Cr-Commit-Position: refs/heads/master@{#473734}

Revert of Enable LLD for POSIX LTO builds on Linux. (patchset #1 id:1 of https://codereview.chromium.org/2877913003/ )

Reason for revert:
Breaks crash reporting.

BUG=716484

Original issue's description:
> Enable LLD for POSIX LTO builds on Linux.
>
> This is a stripped down version of (reverted)
> change: https://codereview.chromium.org/2831213006/
>
> That change was reverted because ThinLTO regresses the binary
> size too much. LLD was a harmless part of the change,
> so it's worth enabling it.
>
> Based on https://codereview.chromium.org/2844883002/ by
> krasin@chromium.org, who is no longer with Google.
>
> BUG=607968
> R=dpranke@chromium.org,thakis@chromium.org
>
> Review-Url: https://codereview.chromium.org/2877913003
> Cr-Commit-Position: refs/heads/master@{#471532}
> Committed: https://chromium.googlesource.com/chromium/src/+/e6a66337552cfd9a9af9471775ad5b67ee588b88

TBR=dpranke@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=607968

Review-Url: https://codereview.chromium.org/2900883002
Cr-Commit-Position: refs/heads/master@{#473733}

This CL Adds an UMA metric to record the outcome whenever the Media Route
Provider attempts to create a media route controller.

BUG=707326

Review-Url: https://codereview.chromium.org/2894623002
Cr-Commit-Position: refs/heads/master@{#473732}

Start replacing some chrome.send calls with cr.sendWithPromise in print
preview by using cr.sendWithPromise for the getInitialSettings message.
To avoid breaking tests during transition, also:
- Change NativeLayerStub in PrintPreviewWebUITests to inherit from
settings.TestBrowserProxy.
- Change NativeLayer so that it no longer inherits from cr.EventTarget.
- Add an EventTarget member to NativeLayer for dispatching and
receiving the print preview messages that have not yet been migrated
to use cr.sendWithPromise (will be removed when all messages have
been changed).

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2881213003
Cr-Commit-Position: refs/heads/master@{#473731}

This fixes the SDK build which was broken when these
libraries were moved.

BUG=724707

Review-Url: https://codereview.chromium.org/2896703005
Cr-Commit-Position: refs/heads/master@{#473730}

This is needed because window.hashchange message may not arrive on time
and navigation will not be marked as "IsCreatedFromHashChange". This
will result in going through "loadURL" flow for the same document
navigaitons, which is not correct.

BUG=None

Review-Url: https://codereview.chromium.org/2898633003
Cr-Commit-Position: refs/heads/master@{#473729}

This new API will allow removing
-[CRWNativeContentProvider controllerForURL:withError:isPost:] callback
and replacing it with general purpose
WebStateObserver::DidFinishNavigation that takes NavigationContext.

BUG=725241
TBR=droger@chromium.org

Review-Url: https://codereview.chromium.org/2901633002
Cr-Commit-Position: refs/heads/master@{#473728}

Speculative fix for "bad message" crash that started with removal of
these checks. This is a partial revert of
https://codereview.chromium.org/2818173003

BUG=724868
R=dmurph@chromium.org

Review-Url: https://codereview.chromium.org/2900863002
Cr-Commit-Position: refs/heads/master@{#473727}

BUG=

Review-Url: https://codereview.chromium.org/2902563003
Cr-Commit-Position: refs/heads/master@{#473726}

SuppressedHTTPSFormFetcher is a helper used by FormFetcherImpl to fetch
credentials stored for the HTTPS counterpart of a non-secure (i.e HTTP) origin,
when the FormFetcherImpl itself is created for an HTTP origin. The suppressed
forms are fetched asynchronously, without blocking Consumer::ProcessMatches.

This data will be used to measure how often HTTPS credentials cannot be filled
on HTTP sites. When no matching HTTP credentials exist for a non-secure origin,
but there are suppressed HTTPS credentials, that could indicate a premature
`move-to-HTTPS` migration, or simply that the site serves its sign-up or some
of its sign-in forms over HTTPS, while others still over HTTP.

BUG=720599

Review-Url: https://codereview.chromium.org/2878463003
Cr-Commit-Position: refs/heads/master@{#473725}

Increase the max duration recorded for
MobileStartup.IntentToCreationTime.ChromeTabbedActivity.

BUG=709240

Review-Url: https://codereview.chromium.org/2897573005
Cr-Commit-Position: refs/heads/master@{#473724}

Specifically, this removes the skip lines added in
http://crrev.com/c/490551. This import included the addition of one new
directory that has no owners, so it is added to the list in NeverFixTests.

The purpose of this is to clean up TestExpectations.

Review-Url: https://codereview.chromium.org/2895853002
Cr-Commit-Position: refs/heads/master@{#473723}

All DownloadController java method can be static.
So there is no point to hold a java reference.

Review-Url: https://codereview.chromium.org/2902453003
Cr-Commit-Position: refs/heads/master@{#473722}

Currently client sets insert_after_item_id, but doesn't properly order commit
entries with respect to this field. It causes commit to fail on the server under
certain conditions:
- Two new sibling bookmarks are committed
- They get broken into different commit messages with second bookmark being sent
  in the first message

In this case server either expects server id in the field or bookmark being
referred to in insert_after_item_id being present in the same message.

This field was deprecated since before M26, therefore I'm simply removing the
code that sets this field on the client.

BUG=722487
R=pnoland@chromium.org

Review-Url: https://codereview.chromium.org/2895933003
Cr-Commit-Position: refs/heads/master@{#473721}

https://skia.googlesource.com/skia.git/+log/edf8a762190e..bcd8637772e3

$ git log edf8a7621..bcd863777 --date=short --no-merges --format='%ad %ae %s'
2017-05-22 brianosman Revert "Revert "fix ubsan warning""
2017-05-22 brianosman Revert "fix ubsan warning"
2017-05-22 brianosman Revert "We can mask load and store with just AVX."
2017-05-22 brianosman Revert "add tilers against 1"
2017-05-22 brianosman Revert "mark SkRasterPipelineBlitter final"
2017-05-22 brianosman Revert "fix ubsan warning"
2017-05-22 bsalomon Remove kZeroCopy_GrSurfaceFlag
2017-05-22 msarett Blacklist memory instensive tests on 32-bit bots (part 2) Bug: skia:
2017-05-22 mtklein fix ubsan warning

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I9be699fe612c0027e3194d170126858b41467708
Reviewed-on: https://chromium-review.googlesource.com/510943Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473720}

This change extends the peeking behavior when there are multiple
infobars attempting to show simultaneously. When a new infobar is
added, it will peek above the existing ones giving a brief view of
it's contents and bringing more attention to it.

BUG=721389

Review-Url: https://codereview.chromium.org/2846663002
Cr-Commit-Position: refs/heads/master@{#473719}

This only fails when no X11 headers are present on the system and

  use_ozone = true
  ozone_platform_wayland = true
  ozone_platform_x11 = false
  use_sysroot = false

BUG=295089

Review-Url: https://codereview.chromium.org/2892343002
Cr-Commit-Position: refs/heads/master@{#473718}

Functional changes here are:
 - Treating an extension-origin "about:blank" iframe as extension,
   for the purposes of the web_accessible_resources ancestor
   check.
 - Treating nested URLs as non-web_accessible_resources for
   the purposes of subframe navigation (this fixes 661324)

These should both be minor, and are incidental.

Pure refactoring here is:
 - Preferring url::Origin() checks (which leads to the functional
   changes above).
 - Renaming of variables for clarity.
 - Hoisting the extension lookup to the top of the function, and
   eliminating !extension and !registry checks after dealing
   with the lookup result.
 - A more efficient lookup of the parent frame, in a way
   that shouldn't require an "this is safe" apology comment.
 - Reflow control logic in anticipation of adding new BLOCK
   cases for platform apps (in a follow-on CL).

BUG=661324
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2830893002
Cr-Commit-Position: refs/heads/master@{#473717}

It's better to leave this test app mainly for the manual testing
purposes and for the whitelist tests, but place the code for the
automated tests in another test app. The reason for that is the
complexity of updating it: besides changes in the source tree, each
updated version has to be published on the Web Store and then the CRX
file has to be fetched from it.

Therefore this CL makes this decision explicit by reflecting it in the
file names, readme file and the constant names.

Also an OWNERS file is introduced for it, in order to make the
ownership of this code clearer.

Bug: chromium:626343
Change-Id: Ic644b55379c45fa2da79db2df2e65c802778a2cc
Reviewed-on: https://chromium-review.googlesource.com/509512Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473716}

Also remove the function completely where it makes the code simpler:
- FrameCaptionButton
- ExitWarningWidgetDelegateView
- UserCardView

BUG=none

Review-Url: https://codereview.chromium.org/2901503003
Cr-Commit-Position: refs/heads/master@{#473715}

https://pdfium.googlesource.com/pdfium.git/+log/671630e52cda..ed75ee25f40a

$ git log 671630e52..ed75ee25f --date=short --no-merges --format='%ad %ae %s'
2017-05-22 tsepez CFX_ByteStringC: avoid taking unreferenceable vector::data() ptr.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I4dc5ce447a5f84ed238fb6fd7642d1c017bc53a0
Reviewed-on: https://chromium-review.googlesource.com/511162
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473714}

BUG=689758

Change-Id: Iab841c65ab1a5acdd81b7e3e41015b16edd7ef30
Reviewed-on: https://chromium-review.googlesource.com/511302Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473713}

It appears that SkSurface is not getting created in some particular
cases.  It's not clear why this is happening, so add a bunch of
CHECKs that replicate Skia code to try to diagnose from the callsite
which of these conditions are the culprit.

Bug: 721744
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ida76afe7086756ba52276d1212860ebaf7a2f7c7
Reviewed-on: https://chromium-review.googlesource.com/511182Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473712}

BUG=724692

Review-Url: https://codereview.chromium.org/2896053002
Cr-Commit-Position: refs/heads/master@{#473711}

BUG=706699

Review-Url: https://codereview.chromium.org/2805593002
Cr-Commit-Position: refs/heads/master@{#473710}

It's left over from the early days of mustash/mash and we don't need it
anymore.

I left one reference because it'll be easier to clean up when WmShelf
gets converted.

Pure refactor, no behavior changes.

BUG=722552
TEST=ash_unittests, manual tests of chrome stylus tools

Review-Url: https://codereview.chromium.org/2895843002
Cr-Commit-Position: refs/heads/master@{#473709}

Changing from:
To get your settings on all your devices, sign in to Chrome.

to:
Sign in to Chrome to get your bookmarks, passwords, and more on all your devices.

BUG=723547

Review-Url: https://codereview.chromium.org/2893353003
Cr-Commit-Position: refs/heads/master@{#473708}

This CL fixes some issues in FlingTracker:

* The velocity from the OS is in pixel/second so it needs to be converted into
  pixel/ms.
* The displacement equation is missing the time constant multiplier.
* It is safer to decide the fling threshold by calculating the maximum
  displacement rather than just the time it takes.
* Just check whether the time elapsed is greater than the fling duration rather
  than calculating the speed every time the object moves.

Review-Url: https://codereview.chromium.org/2888423003
Cr-Commit-Position: refs/heads/master@{#473707}

BUG=724943

Review-Url: https://codereview.chromium.org/2893343002
Cr-Commit-Position: refs/heads/master@{#473706}

Follow-up work
- Trigger the right Feedback activity
- Control frequency of feedback via Finch

BUG=706438

Review-Url: https://codereview.chromium.org/2887383002
Cr-Commit-Position: refs/heads/master@{#473705}

This CL adds the following to the OIB (Page Info):
 - The menu only has two items (no default), with custom strings
 - The selected text uses user managed strings instead of default string
   (e.g. "Block" instead of "Block (default)"

BUG=689487

Review-Url: https://codereview.chromium.org/2884813003
Cr-Commit-Position: refs/heads/master@{#473704}

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
R=nick@chromium.org

Review-Url: https://codereview.chromium.org/2883503002
Cr-Commit-Position: refs/heads/master@{#473703}

address_input_strings.grd and the translation were moved to
third_party/libaddressinput/chromium/ in:
https://codereview.chromium.org/2886173002/

BUG=672458

Review-Url: https://codereview.chromium.org/2894673006
Cr-Commit-Position: refs/heads/master@{#473702}

XMLHTTPRequest::response_document_ gets incorrectly cleared because
Document::well_formed_ is incorrectly false. This is because
well_formed_ is initialized in Document::ImplicitClose().
XMLHttpRequest used to call ImplicitClose() directly, but I changed
it to call Document::CheckCompleted() (which may then call
ImplicitClose) in
https://chromium.googlesource.com/chromium/src/+/716a136332fbd8efc12a3892b6ae2a6c0be94ba7

I had thought that CheckCompleted() would always call ImplicitClose()
for an XHR response document, but it's possible for CheckCompleted()
to early-exit because the document is not complete if a style element
has blocked load completion and won't un-block it until a timer is
fired.

There's no reason to wait until ImplicitClose() to set the well-formed
bit, though. Document::FinishedParsing() is sufficient, and setting it
there removes the need for XMLHttpRequest to manually call
CheckCompleted().

BUG=721225
TEST=http/tests/xmlhttprequest/style-tag-in-responseXML.html

Review-Url: https://codereview.chromium.org/2885633002
Cr-Commit-Position: refs/heads/master@{#473701}

BUG=717501

Review-Url: https://codereview.chromium.org/2857143002
Cr-Commit-Position: refs/heads/master@{#473700}

Add SheetContentStateChangeObserver, which emits events specialised
for the visibility of a BottomSheetContent, and use it to record
user actions for the Suggestions bottom sheet

BUG=693593,717704

Review-Url: https://codereview.chromium.org/2862893002
Cr-Commit-Position: refs/heads/master@{#473699}

Because BeaconSeeds can take quite a bit of space, we also add an option in
RemoteDeviceLoader whether or not to load the BeaconSeeds.

Review-Url: https://codereview.chromium.org/2859053003
Cr-Original-Commit-Position: refs/heads/master@{#473489}
Committed: https://chromium.googlesource.com/chromium/src/+/c3636c2887c896911de99d208889b2582cf5e56b
Review-Url: https://codereview.chromium.org/2859053003
Cr-Commit-Position: refs/heads/master@{#473698}