GitLab

Introduces an atomic value to guard access to a cached
TaskRunner which read from multiple threads but written
at some arbitrary time on the IPC thread inside Bind().

BUG=630835
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2178773002
Cr-Commit-Position: refs/heads/master@{#407504}

Simple fix, there's no need to quit the message loop on channel
connection. If the expected error isn't encountered the test
will hang. This seems sufficient and is not racy.

BUG=630831
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2175113002
Cr-Commit-Position: refs/heads/master@{#407503}

ErrorLog:
gyp: Key 'conditions' repeated at level 6 with key path 'targets.0.conditions.5.1' while reading C:\b\build\slave\win64\build\src\printing\printing.gyp

Change was reverted with a poorly rebased patch in 04b30ad6

R=govind, thestig@chromium.org

BUG=630890

TEST=build/gyp_chromium --check passes

Review-Url: https://codereview.chromium.org/2178003002
Cr-Commit-Position: refs/heads/master@{#407502}

Cleaning up video-seek* and video-served* http tests
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2177793003
Cr-Commit-Position: refs/heads/master@{#407501}

This updates the property list layout to use settings-box instead
of multiple columns.

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2167403002
Cr-Commit-Position: refs/heads/master@{#407500}

and all the related IPC code

It's not used anywhere, and it's not documented at http://dev.chromium.org/embeddedsearch

Also remove searchBox.setRestrictedValue

BUG=628207

Review-Url: https://codereview.chromium.org/2151483004
Cr-Commit-Position: refs/heads/master@{#407499}

Also while I'm here:
* Eliminate some hard coded position calculations
* Contain the remaining position calculations in helper functions
* Rename some members for consistency and clarity
* Delete unused NewTabPageRecyclerView#getLinearLayoutManager

BUG=616090

Review-Url: https://codereview.chromium.org/2158413004
Cr-Commit-Position: refs/heads/master@{#407498}

This removes some ash::Shell access in the shelf, which we need to eliminate
to port to mus.

* Move ShelfDelegate to //ash/common
* Move ownership to WmShell
* Move ShelfDelegate creation slightly earlier by doing it on Shelf creation,
rather than lazily on access. It can't happen in WmShell::Initialize() because
Chrome's implementation depends on the user being logged in.

TODO: Fix ash::ShelfWindowWatcher ownership and creation time.

BUG=629244
TEST=ash_unittests, chrome unit_tests and browser_tests
TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2177663002
Cr-Commit-Position: refs/heads/master@{#407497}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2befef4332bc..c3cf2e8ef854

$ git log 2befef433..c3cf2e8ef --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2179023002
Cr-Commit-Position: refs/heads/master@{#407496}

Review-Url: https://codereview.chromium.org/2180563002
Cr-Commit-Position: refs/heads/master@{#407495}

BUG=627844

Review-Url: https://codereview.chromium.org/2180913002
Cr-Commit-Position: refs/heads/master@{#407494}

Revert of [Chromedriver] Re-enable ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement on ChromePublic (patchset #1 id:1 of https://codereview.chromium.org/2175893002/ )

Reason for revert:
Test was re-enabled because the bots were running against old chromedriver build having name "rNone" . But the test is still failing on correct Head builds that confirms it's a real bug & hence needs to be disabled again.

Original issue's description:
> [Chromedriver] Re-enable ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement on ChromePublic
>
> BUG=chromedriver:998
>
> Committed: https://crrev.com/970ac6812ff04c3f44ae770b612b093b6feb5d80
> Cr-Commit-Position: refs/heads/master@{#407234}

TBR=samuong@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromedriver:998

Review-Url: https://codereview.chromium.org/2176203002
Cr-Commit-Position: refs/heads/master@{#407493}

Cast device certificates may be revoked through two ways:
1. The hash of the public key.
2. A serial number range for an issuer identified by the hash
   of its public key.

A customized proto is used as the medium for this information.

This change contains the implementation for verifying the custom CRL
and verifying a certificate's revocation status based on that CRL.

BUG=618463

Review-Url: https://codereview.chromium.org/2050983002
Cr-Commit-Position: refs/heads/master@{#407492}

https://chromium.googlesource.com/skia.git/+log/1d35231e7b5c..2adecda92b2f

$ git log 1d35231e7..2adecda92 --date=short --no-merges --format='%ad %ae %s'
2016-07-25 reed add gm to test bleed with downscale
2016-07-25 reed remove fClipStack and attach/deattach-from-canvas
2016-07-25 halcanary typedef uint16_t SkGlyphID

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2179793002
Cr-Commit-Position: refs/heads/master@{#407491}

This CL improves usability of Desktop Capture Picker on Mac
a little.

1. we auto select the first screen source,
2. we omit the label "Entire Screen" in the case there is only one screen, as this is redundant.

BUG=580116,630172

Review-Url: https://codereview.chromium.org/2168853003
Cr-Commit-Position: refs/heads/master@{#407490}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/81df7973..4a6e5346

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2174353002
Cr-Commit-Position: refs/heads/master@{#407489}

BUG=none
TEST=none
R=vadimb@chromium.org

Review-Url: https://codereview.chromium.org/2174063002
Cr-Commit-Position: refs/heads/master@{#407488}

BUG=616502

Review-Url: https://codereview.chromium.org/2181553003
Cr-Commit-Position: refs/heads/master@{#407487}

Some keychain access is currently broken on the latest Xcode beta.

BUG=619982

Review-Url: https://codereview.chromium.org/2180773002
Cr-Commit-Position: refs/heads/master@{#407486}

The Ozone X11 platform now directly creates an appropriate GLSurface
instead of creating a SurfaceOzoneEGL. Remove the SurfaceOzoneEGL
subclass and add a new GLSurface subclass.

Modify gl_factory_ozone.cc to use the new Ozone surface creation API.
For kGLImplementationOSMesaGL and kGLImplementationMockGL there is a
default implementation that is shared by all Ozone platforms. For other
GL implementations surface creation is delegated to the Ozone platform.

Add an OWNERS file for ui/gl/init/ that contains the per-file directive
for Ozone files from ui/gl/. This code was all moved from ui/gl/ since
it reduced the set of OWNERS. Add myself to this set as well.

BUG=611142

Review-Url: https://codereview.chromium.org/2156503003
Cr-Commit-Position: refs/heads/master@{#407485}

https://chromium.googlesource.com/chromium/src/+/24420dc04

BUG=630695
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/2182513002 .

Cr-Commit-Position: refs/heads/master@{#407484}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/937acaa..e3488c3

BUG=
TEST=bots
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2174253003
Cr-Commit-Position: refs/heads/master@{#407483}

The flakiness caused by not waiting for the password store to reply with the results.

BUG=629459

Review-Url: https://codereview.chromium.org/2177213002
Cr-Commit-Position: refs/heads/master@{#407482}

BUG=630709

Review-Url: https://codereview.chromium.org/2177913002
Cr-Commit-Position: refs/heads/master@{#407481}

This CL adds another code path of computing target space transforms. The
old code path is still in use as we have no idea what performance impact
would be.

The new logic is to compute the transforms on demand and cached all the
intermediate results. It is hidden behind the flag verify_transform_tree
_calculation. The flag is enabled in unit tests to verify the correct-
ness of the new logic.

BUG=624120
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2166043002
Cr-Commit-Position: refs/heads/master@{#407480}

BUG=548624

Review-Url: https://codereview.chromium.org/2163983006
Cr-Commit-Position: refs/heads/master@{#407479}

https://chromium.googlesource.com/skia.git/+log/b5acf6e702e3..1d35231e7b5c

$ git log b5acf6e70..1d35231e7 --date=short --no-merges --format='%ad %ae %s'
2016-07-25 benjaminwagner Remove long-running sk_linear_to_srgb test for ASAN in public.bzl.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2181663002
Cr-Commit-Position: refs/heads/master@{#407478}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7827ca06..81df7973

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2177253002
Cr-Commit-Position: refs/heads/master@{#407477}

NOTRY=True
TBR=ymalik@chromium.org
BUG=631039

Review-Url: https://codereview.chromium.org/2175333002
Cr-Commit-Position: refs/heads/master@{#407476}

CancellationFlag is really just a flag that can be set once from
one thread and read from a number of other threads. It is already
used to express other things than cancellation (e.g. in
after_startup_task_utils.cc) and could be used at a few places
in base/task_scheduler instead of WaitableEvent.

BUG=553459

Review-Url: https://codereview.chromium.org/2163753004
Cr-Commit-Position: refs/heads/master@{#407475}

NOTRY=TRUE
TBR=caseq@chromium.org
BUG=399507

Review-Url: https://codereview.chromium.org/2175313002
Cr-Commit-Position: refs/heads/master@{#407474}

We don't have good coverage for sprite bleeds.

Add a layout test which also runs for virtual/gpu-rasterization/.

TEST=fast/images/sprite-no-bleed.html
R=junov@chromium.org,schenney@chromium.org

Review-Url: https://codereview.chromium.org/2180453002
Cr-Commit-Position: refs/heads/master@{#407473}

This is a spin off from the change to partially move mixed content
checks to the browser process [1]. With the move the information about the
RequestContextType of the navigtation load needs to be available in
browser and this change makes that happen.

[1] https://codereview.chromium.org/1905033002/

BUG=1905033002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2161073002
Cr-Commit-Position: refs/heads/master@{#407472}

Signed Certificate Timestamps (SCTs) designate Merkle tree leaves that can
be checked for inclusion with a CT Log's Signed Tree Head (STH).
However, inclusion should only be checked against an STH that is newer
than the SCTs timestamp by at least 24 hours - this is because Logs'
have a Maximum Merge Delay of 24 hours, which is the time they have
to produce a new STH that incorporates a given SCT.

STHs are delivered periodically out of band. If there isn't a new enough
STH, then SCTs will need to be marked as pending inclusion check,
waiting for a new STH to be delivered.

To determine how frequently an STH should be delivered (currently,
daily) and how big the SCT queue list should be (that is, how frequently
clients encounter a brand new SCT that is newer than any STH),
measure how often an SCT can't be checked for inclusion immediately
after it's been seen.

BUG=613495

Review-Url: https://codereview.chromium.org/2153123002
Cr-Commit-Position: refs/heads/master@{#407471}

https://chromium.googlesource.com/skia.git/+log/1638c0deea80..b5acf6e702e3

$ git log 1638c0dee..b5acf6e70 --date=short --no-merges --format='%ad %ae %s'
2016-07-25 mtklein Add a clamp stage to SkRasterPipelineBlitter.
2016-07-25 caryclark fix fuzz
2016-07-25 mtklein Arithmetic xfermode stage.
2016-07-25 borenet webpages_playback: Make --upload_to_partner_bucket work without --upload

BUG=630736

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2177883002
Cr-Commit-Position: refs/heads/master@{#407470}

Current spellcheck code lives in the chrome/ layer, but we want to make it
available in webview as well. Therefore this effort of making a dedicated
spellcheck component. As a first step we create a //components/spellcheck
and move the chrome spellcheck related switches there.

BUG=583616, 629609

Review-Url: https://codereview.chromium.org/2166683003
Cr-Commit-Position: refs/heads/master@{#407469}

When consumer specifies a chunked upload or a fixed stream upload, Cronet's
HttpURLConnection starts the request right away. If an error happens, we will
surface that error as an IOException to consumer. However, if the consumer
tries to call any other API (like getResponseCode(), getResponseMessage())
afterwards, we will spin up the message loop and wait forever.

This CL marks the request as complete if an error occurred in upload, so
getResponseCode() etc. do not spin up the message loop to wait for response.

R=pauljensen@chromium.org
BUG=630664

Review-Url: https://codereview.chromium.org/2173923002
Cr-Commit-Position: refs/heads/master@{#407468}

The goal of this CL is to workaround a bug where Apple serves the
wrong content for itunes.apple.com pages, see the associated bug
report.

This CL adds a class that observe navigation events.
If a page concerning a product on the iTunes App Store is *loaded*,
this class triggers the opening of a SKStoreProductViewController
presenting the information of the said product.
If Apple fixes what the server serves, than the iTunes App Store
pages won't ever be loaded: the users will be automatically offered to
open the App Store application.

BUG=623016

Review-Url: https://codereview.chromium.org/2176503003
Cr-Commit-Position: refs/heads/master@{#407467}

According to the GLSL spec, GLSL float can represent exact integers between 0 and 2048.
However, some drivers might not respect the spec. So use uint for == operator.

In detail,
1. GLSL uses IEEE 754 float or half float.
https://www.opengl.org/wiki/Data_Type_(GLSL)#Scalars
2. IEEE 754 half float preserves integers between 0 and 2048 exactly represented.
https://en.wikipedia.org/wiki/Half-precision_floating-point_format#Precision_limitations_on_integer_values

BUG=535198
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2170933002
Cr-Commit-Position: refs/heads/master@{#407466}

* s/CreateSynStream/CreateHeaders/ in SpdySession.
* Use HEADERS instead of SYN_STREAM in SpdyStream::SendRequestHeaders(),
  SpdySession::DoWrite(), and various CHECKs in SpdyStream and SpdySession.
  This does not make a difference on the wire, since
  SpdySession::CreateHeaders() (formerly known as CreateSynStream()) has already
  been creating HEADERS frames anyway.
* s/waiting_for_syn_reply/waiting_for_reply_headers_frame/ in
  SpdySession::ActiveStreamInfo.
* s/SynReply/Reply/, s/Syn/Headers/ in spdy_test_util_common methods.
* Update out-of-date comments referring to SYN_STREAM or SYN_REPLY frames.
* Rename NetLogSpdySynReplyOrHeadersReceivedCallback to
  NetLogSpdyHeadersReceivedCallback.
* Use HEADERS frames in SpdyWriteQueueTests.
* s/SynStreamBufferProducer/HeadersBufferProducer/,
  s/ProduceSynStreamFrame/ProduceHeadersFrame/ in SpdyStream.
* Remove unused TYPE_HTTP2_SESSION_SYN_STREAM, TYPE_HTTP2_SESSION_SYN_REPLY,
  and TYPE_HTTP2_SESSION_PUSHED_SYN_STREAM.
* Remove unused SetPriority() from spdy_test_util_common.{h,cc}.

BUG=624095

Review-Url: https://codereview.chromium.org/2167253002
Cr-Commit-Position: refs/heads/master@{#407465}