- 06 Nov, 2018 40 commits
- 
- 
Shawn Gallea authoredAdd enable_cast_wayland_server flag to selectively enable exo server use. Add a Cast-specific implementation of wm_helper. This implementation contains the minimum required to make exo work on cast shell. support EXO. Bug: 896710 Test: Built on ChromeOS, is not utilized yet as cast does not yet Change-Id: I0e38a415fbdecdbe7f116885ed9048834cbca1b5 Reviewed-on: https://chromium-review.googlesource.com/c/1294835 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#605851} 
- 
Adithya Srinivasan authoredAfter resetting the operation runner, we should clean up any existing FileSystemCancellableOperation bindings as they all point to operations that no longer exist. Bug: 899146 Change-Id: I70cf4008f64534a1ac22c2ffe507d5b2a9d16208 Reviewed-on: https://chromium-review.googlesource.com/c/1301960Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#605850} 
- 
Ken Rockot authoredRenames the "user ID" and "instance name" fields to "instance group" and "instance ID", respectively, per discussion on the bug. A follow-up will change the types of the instance group and ID fields to be optional UnguessableTokens instead of free-form strings. TBR=jam@chromium.org Bug: 895591 Change-Id: I0c4d75f5e12a468dad251f238813bc79c497830a Reviewed-on: https://chromium-review.googlesource.com/c/1318836 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#605849} 
- 
John Chen authoredIn W3C mode, Element Send Keys command should get keys from string property "text", instead of list property "value". Bug: chromedriver:2649 Change-Id: I68b915ad572c289364d797aa34496b2278cb3997 Reviewed-on: https://chromium-review.googlesource.com/c/1320208Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605848} 
- 
chromium-autoroll authoredhttps://chromium.googlesource.com/catapult.git/+log/0273c5e3c23a..70df4ea4898e git log 0273c5e3c23a..70df4ea4898e --date=short --no-merges --format='%ad %ae %s' 2018-11-06 dpranke@chromium.org Address review comments from https://crrev.com/c/1171862. 2018-11-06 eroman@chromium.org Add --proxy-bypass-list parameter to explicitly allow proxying of localhost. Created with: gclient setdep -r src/third_party/catapult@70df4ea4898e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:835690,chromium:901896 TBR=sullivan@chromium.org Change-Id: Icea4759cfbfe703010fc8136b82755bd9be74c18 Reviewed-on: https://chromium-review.googlesource.com/c/1320614Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605847} 
- 
Fady Samuel authoredFrameSink debug labels are useful to identify the client associated with a particular FrameSink or Surface. This CL introduces the appropriate plumbing to allow printing the FrameSink debug label given a FrameSinkId from the surfaces layer. The debug label will now be printed if a temporary reference is orphand and will be garbage collected. Bug: 655231 Change-Id: I75abd9b6aff484fee946e2ee584bd9927a0b843c Reviewed-on: https://chromium-review.googlesource.com/c/1320018Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605846} 
- 
Yuichiro Hanada authoredAfter calling these method, return values of TextInputClient is not updated. This CL removes the text input state update timer when calling the methods to prevent send a false state. Bug: 897691 Test: Ran on DUT Change-Id: I7fdb7f8038391f7e9433ad1de0e0607232e2e890 Reviewed-on: https://chromium-review.googlesource.com/c/1319396Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#605845} 
- 
Zach Helfinstein authoredReland "Update existing Switch Access tests" This is a reland of d4860fed Original change's description: > Update existing Switch Access tests > > Bug: 897365 > Change-Id: Ic8ff1ea5511f3d6cc907a880fffdffa7c5fdbcc9 > Reviewed-on: https://chromium-review.googlesource.com/c/1306787 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605719} Bug: 897365 Change-Id: Ic0b73345f79bf5a075fd42cbea69a74b0e890257 Reviewed-on: https://chromium-review.googlesource.com/c/1320027Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605844} 
- 
Matt Mueller authoredChange-Id: I20754af1acb09faa74d73d1ba1dbc627ca740759 Reviewed-on: https://chromium-review.googlesource.com/c/1320731 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605843} 
- 
Paul Jensen authoredChange-Id: I798f714ba544e01370f9289067a0e180d7b67f45 Reviewed-on: https://chromium-review.googlesource.com/c/1308035 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#605842} 
- 
rajendrant authoredChrome-proxy is piecemeal constructed when NetworkService is enabled. For example, the secure hash is added from the post_cache_headers in NetworkContext. 'frfr' is added for first media requests from the blink layer. This CL adds page ID for mainframe requests via post cache headers in URLLoader. Bug: 893728 Change-Id: I9110896ed7242e424b02e2c125a080dd853d6325 Reviewed-on: https://chromium-review.googlesource.com/c/1318431Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#605841} 
- 
Min Chen authoredBug: 900959 Change-Id: Iae62ce77d2fd38105120d86799e52157d6313f3c Reviewed-on: https://chromium-review.googlesource.com/c/1313738 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605840} 
- 
Dmitry Titov authoredThis reverts commit 18a9ef45. Reason for revert: Broke the accessibility test (again): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/29232 Please note this does not look like a flake, after this landed a dozen runs failed consistently. Original change's description: > Full AttachLayoutTree on a new Document not necessary. > > We called AttachLayoutTree on a new Document which just got its > LayoutView created. The new Document should not have any child nodes, > it's not marked initially dirty, but trying to land this change the > first time we caused flakiness for a Window accessibility test. > > Instead of the AttachLayoutTree call, do the AXObjectCache update which > would otherwise be called from Node::AttachLayoutTree. > > This is a new attempt after the previous got reverted: > > https://chromium-review.googlesource.com/c/chromium/src/+/1317889 > > Bug: 902050 > Change-Id: I4e366013549627b54f016d76b3dcbf12ea115f70 > Reviewed-on: https://chromium-review.googlesource.com/c/1319610 > Reviewed-by: Anders Ruud <andruud@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605657} TBR=futhark@chromium.org,andruud@chromium.org Change-Id: Ied8ff9426940489ac4693abdb34001f44b13478c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902050 Reviewed-on: https://chromium-review.googlesource.com/c/1321229Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605839} 
- 
chromium-internal-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6eef2ff50b8c..9e5f6a771e82 Created with: gclient setdep -r src-internal@9e5f6a771e82 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icdc56be655426d87954602251063a6caa6a2d73c Reviewed-on: https://chromium-review.googlesource.com/c/1320612Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605838} 
- 
Oksana Zhuravlova authoredThis change adds a note and an example to clarify why it's safe to return read-only views in struct traits accessors. Change-Id: I0b6b646de10dd01fe5ae347f48d9a119b6e118a6 Reviewed-on: https://chromium-review.googlesource.com/c/1316787 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#605837} 
- 
Micah Morton authoredThis reverts commit 50444a9b. Reason for revert: We want shill sandboxing default-enabled on M72. Original change's description: > Revert "Wire up ShillSandboxing flag to be enabled by default" > > This reverts commit e034d163. > > Reason for revert: We want to change shill sandboxing back to > default-disabled rather than default-enabled. We will still roll out > sandboxing to 50% of users in M70. > > Original change's description: > > Wire up ShillSandboxing flag to be enabled by default > > > > In a previous CL:1173260 I meant to wire up this feature flag to be > > enabled by default. Somehow I mistakenly landed the code with the > > FEATURE_DISABLED_BY_DEFAULT flag instead. > > > > Bug: 649417 > > Test: Same as CL:1173260 > > Change-Id: I2154749addb0539be9a2ef53c368d80dc10bee41 > > Reviewed-on: https://chromium-review.googlesource.com/1190644 > > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > > Commit-Queue: Micah Morton <mortonm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#586444} > > TBR=stevenjb@chromium.org,mnissler@chromium.org,mortonm@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 649417 > Change-Id: Ice783f6bced9828e1ae8fb966f00f5dc32aff3f2 > Reviewed-on: https://chromium-review.googlesource.com/1251326 > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Commit-Queue: Micah Morton <mortonm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595474} TBR=stevenjb@chromium.org,mnissler@chromium.org,mortonm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 649417 Change-Id: I1a949e2711d59945b838fabb321c9dfaed3f0799 Reviewed-on: https://chromium-review.googlesource.com/c/1269947Reviewed-by: Mattias Nissler <mnissler@chromium.org> Commit-Queue: Micah Morton <mortonm@chromium.org> Cr-Commit-Position: refs/heads/master@{#605836} 
- 
James Darpinian authoredBug: 863221 Change-Id: Id2fe5975439c2d2cb5ee59c80f7c02a7fce3320d Reviewed-on: https://chromium-review.googlesource.com/c/1318834Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#605835} 
- 
chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/5d3deb7301b1..fe454acf5ef1 git log 5d3deb7301b1..fe454acf5ef1 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4169b31090db..1d8c8dba995a (1 commits) 2018-11-06 reed@google.com split out fontmetrics into its own struct 2018-11-06 mtklein@google.com Reland "make enum santizer fatal" Created with: gclient setdep -r src/third_party/skia@fe454acf5ef1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Id9f53a74892e8aa0fc475d07df5c18b5a67c6b7e Reviewed-on: https://chromium-review.googlesource.com/c/1319953Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605834} 
- 
Matt Mueller authoredBug: 827318,876947 Change-Id: I72ead221b797a90c19d7742422d65a29ed5f1741 Reviewed-on: https://chromium-review.googlesource.com/c/1318849Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#605833} 
- 
Antoine Labour authoredThis adds 2 entrypoints: - CreateSharedImage, which takes a GpuMemoryBuffer to wrap into a shared image (equivalent to CreateImageCHROMIUM+BindTexImage2DCHROMIUM) - UpdateSharedImage, which updates the binding after CPU/external writes to the GMB (equivalent to ReleaseTexImage2DCHROMIUM+BindTexImage2DCHROMIUM). This is only plumbed to SharedImageBackingFactoryGLTexture in this CL. Bug: 870116 Change-Id: Ie7645b65649b0f34d5431fc00f62da9d5661c570 Reviewed-on: https://chromium-review.googlesource.com/c/1316250Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605832} 
- 
Daniel Cheng authoredAlso get rid of the SIZE placeholder constant, since it requires additional case statements in switches. Define kMaxValue instead: clang enforces the correct definition of this value, and the UMA enumeration histograms can take advantage of it without any weird casting. Bug: 742517 Tbr: oshima@chromium.org Tbr: thestig@chromium.org Change-Id: I34373733f7be363aa1d70827ae88dc03c6934819 Reviewed-on: https://chromium-review.googlesource.com/c/1312685 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#605831} 
- 
Matt Mueller authoredBug: 678391 Change-Id: I7751e50a050d32f826315832d6e250137eaba1cf Reviewed-on: https://chromium-review.googlesource.com/c/1320730Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#605830} 
- 
Tom Sepez authoredThis callback may be reached as part of a close document action after the engine has been destroyed. Further inspection of the code shows that the same might also happen for Print(). Bug: 901640 Change-Id: I8faaeaf72adb37441f9e9c977093273c9e055e91 Reviewed-on: https://chromium-review.googlesource.com/c/1320810Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605829} 
- 
chromium-autoroll authoredhttps://android.googlesource.com/platform/external/perfetto.git/+log/cc7964918f7c..02924fce9a91 git log cc7964918f7c..02924fce9a91 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 primiano@google.com Merge "UI: tracks drag & drop + minor fixes" Created with: gclient setdep -r src/third_party/perfetto@02924fce9a91 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I51387a85e5496afa1a2d2959fcd7dae3809c18ed Reviewed-on: https://chromium-review.googlesource.com/c/1320789Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605828} 
- 
Alexander Timin authoredAs there are no implicit conversions, break the inheritance completely and clean a few remaining callsites. R=gab@chromium.org TBR=gab@chromium.org BUG=891670 Change-Id: Ib8cd1461c24cecec70248e31597198fc670ec857 Reviewed-on: https://chromium-review.googlesource.com/c/1312481Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605827} 
- 
Scott Graham authoredVectors of primitive types and strings were previously implemented; this extends support to vectors of unions and structs. Bug: 883496 Change-Id: Id00174b05d04c3f432fae39112afde658e533806 Reviewed-on: https://chromium-review.googlesource.com/c/1318676 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605826} 
- 
Jared Saul authoredWe're looking to merge this (ideally temporary) metric into M71. A problem has been discovered with regards to checkout flows that span multiple domains, and this will help determine its impact. Bug: 892299 Change-Id: I79c9acba23eb750aecf0171ee92d0de456c2ce0e Reviewed-on: https://chromium-review.googlesource.com/c/1315953Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#605825} 
- 
Findit authoredThis reverts commit 9fb6183a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605820 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzlmYjYxODNhZWY2NzhmYjJmMmJhM2I5ZTU0MGQwZDYxNTU1Y2U1ODQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-rel/9695 Sample Failed Step: compile Original change's description: > Move legacy DNS-related net/ mojo interfaces to proxy resolver service. > > Also moves the code that imlepments each side of the interfaces from > net/ over to the location of the single consumer of each of them, in > the proxy_resolver and network services. > > This CL is strictly a move, with no code changes. I will do some cleanup > work in followup CLs. > > Bug: 901419 > Change-Id: I31f6bb91dccc1d250d7c2fd03a07c4173030fc97 > Reviewed-on: https://chromium-review.googlesource.com/c/1320209 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Eric Roman <eroman@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605820} Change-Id: Ib6e8a9b7501437d72a0a59df5881cdfc5dd12c0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901419 Reviewed-on: https://chromium-review.googlesource.com/c/1320594 Cr-Commit-Position: refs/heads/master@{#605824} 
- 
Nathan Parker authored* Remove jialiul@ (has left Chrome) * Add drubery@ to a few dirs where he's the expert now * Add COMPONENT info to all of them * Other misc cleanups Bug: 894851 Change-Id: I60e6b0f8651486a656363fe2b215b1451ae75615 Reviewed-on: https://chromium-review.googlesource.com/c/1318909 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605823} 
- 
Ahmed Fakhry authoredInstead open links in app windows. See details on the bug. BUG=899092 TEST=Manual; all links open inside app windows rather than tabs. Change-Id: I2fc0dc02a17fb37daec9c715ba1801d35cc1a629 Reviewed-on: https://chromium-review.googlesource.com/c/1320216Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605822} 
- 
Zhongyi Shi authoredNo flag flip. In QUIC, fix a bug where write blocked causes a spurious ack alarm to be set. Protected by FLAGS_quic_reloadable_flag_quic_fix_spurious_ack _alarm. Merge internal change: 219926538 https://chromium-review.googlesource.com/c/chromium/src/+/1318583 Remove unused constants from QuicConstants. n/a (Remove unused constants) Merge internal change: 219898685 https://chromium-review.googlesource.com/c/chromium/src/+/1318674 Factor out common code for sending control frames. Code refactoring, no functional changes. This CL extracts common code out of the several QuicControlFrameManager methods that WriteOrBufferXxxFrame uses to actually perform the write. This done in support of work for IETF QUIC STOP_SENDING frame. Merge internal change: 219844258 https://chromium-review.googlesource.com/c/chromium/src/+/1318672 Create connecting methods in QuicSpdyStream to prevent its own class/subclasses from calling QuicStream::WritevData() and QuicStream::WriteMemSlices() directly. This CL prepares for change in IETF HTTP/QUIC mapping. no behavior change. Merge internal change: 219826835 https://chromium-review.googlesource.com/c/chromium/src/+/1318581 Replace FLAGS_quic_enable_version_99 with (enabling_blocked_by) FLAGS_quic_reloadable_flags_quic_enable_version_99. Merge internal change: 219787903 https://chromium-review.googlesource.com/c/chromium/src/+/1318573 Remove RetransmittableOnWireDelegate and the associated alarm and replace it with the ping alarm in QuicConnection. n/a (RetransmittableOnWireAlarm and PingAlarm are client only) Merge internal change: 219732352 https://chromium-review.googlesource.com/c/chromium/src/+/1318569 Prevent all class/subclasses of QuicSpdyStream from calling QuicStream::WriteOrBufferData() directly. Instead, call QuicSpdyStream::WriteOrBufferData(). This CL prepares for change on IETF HTTP/QUIC mapping. no behavior change. Merge internal change: 219711495 https://chromium-review.googlesource.com/c/chromium/src/+/1317897 Change method signature of data frame encoder to take a length instead of a frame struct. The reason is that often times when the encoder is called, there isn't a well constructed data frame that is ready to use. Computing the length of data is much easier. n/a --unused code. Merge internal change: 219708783 https://chromium-review.googlesource.com/c/chromium/src/+/1317920 Use GetCryptoStreamId() rather than hard-coded 1 for crypto stream ID Test used a hard-coded 1 for the crypto stream ID. This is not the case when Version 99 is enabled. This change uses GetCryptoStreamId() to get the actual crypto stream ID for the current version. n/a -- tests only Merge internal change: 219471728 https://chromium-review.googlesource.com/c/chromium/src/+/1318445 Add OnCanCreateNewOutgoingStream to QuicSession, Also revises the simple server session and grpc client session so that they will receive the notification that more streams are avialable. N/A code all in support of and protected by flag for version-99 (IETF QUIC). Merge internal change: 219177525 https://chromium-review.googlesource.com/c/chromium/src/+/1318440 Change-Id: I5819d9c9a9fc45fc5cbeba2f3ddd8b925ae1c381 Reviewed-on: https://chromium-review.googlesource.com/c/1318678Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605821} 
- 
Matt Menke authoredAlso moves the code that imlepments each side of the interfaces from net/ over to the location of the single consumer of each of them, in the proxy_resolver and network services. This CL is strictly a move, with no code changes. I will do some cleanup work in followup CLs. Bug: 901419 Change-Id: I31f6bb91dccc1d250d7c2fd03a07c4173030fc97 Reviewed-on: https://chromium-review.googlesource.com/c/1320209Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#605820} 
- 
Miguel Casas authoredCanvasImageProvider is an inner class of CanvasResourceProvider, that only needs to be defined on the header for the base::Optional use of it. This CL changes that to std::unique_ptr<> like its sister member |canvas_|, moves its implementation to the .cc file and inlines the 1-line methods. Also I replaced a base::Unretained() with a WeakPtr() since I didn't see why wouldn't it work. No new code intended beyond that, just cleaning up what there is. Bug: 839970 Change-Id: I8f3b299c12662a7a83c72ac7bc3eae1b8c1f27ea Reviewed-on: https://chromium-review.googlesource.com/c/1318816 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: enne <enne@chromium.org> Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#605819} 
- 
Ted Choc authoredThis simplifies "some" of the dependencies from the AutocompleteCoordinator to the list view itself. The key handling is going to get a bit gnarly, but this is closer to being able to move the bulk of the coordinator into the existing AutocompleteMediator. NOPRESUBMIT=true BUG=898522 Change-Id: I71f6458220d4ba48c80db4aa18a3e78fe910872e Reviewed-on: https://chromium-review.googlesource.com/c/1316832 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#605818} 
- 
chromium-autoroll authoredhttps://chromium.googlesource.com/catapult.git/+log/7b391c51f694..0273c5e3c23a git log 7b391c51f694..0273c5e3c23a --date=short --no-merges --format='%ad %ae %s' 2018-11-06 perezju@chromium.org Revert "[Telemetry] Increase timeout on CollectChromeTracingData" Created with: gclient setdep -r src/third_party/catapult@0273c5e3c23a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900920 TBR=sullivan@chromium.org Change-Id: Iae4302cfb076a8bcd26ce8dbdb99be7afa47bcf3 Reviewed-on: https://chromium-review.googlesource.com/c/1320611Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605817} 
- 
Takuto Ikuta authoredNow this flag is unnecessary. Bug: 681136 Change-Id: I76d762a7d2d36b42a0556cfd4667731d79cbc01a Reviewed-on: https://chromium-review.googlesource.com/c/1316949Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#605816} 
- 
Leszek Swirski authoredThis is a reland of 5528336d, which was a reland of dd9df78c, which was a reland of 7bd91635. VR tests have been properly deflaked in https://crrev.com/c/1319715, this is otherwise unchanged. Original change's description: > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource"" > > This reverts commit c564235f. > > No changes from the original, VR flakes are caused by issues with > loadUrl and have been deflaked (see 894796 for details) > > Original change's description: > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource"" > > > > This reverts commit dd9df78c. > > > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796) > > > > Original change's description: > > > Reland "[blink] Control ScriptStreamer with ScriptResource" > > > > > > This is a reland of 7bd91635 > > > > > > No changes from the original, revert reason is fixed with > > > https://chromium-review.googlesource.com/c/1283037 > > > > > > Original change's description: > > > > [blink] Control ScriptStreamer with ScriptResource > > > > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to > > > > ScriptResource. In the future, this will allow us to start streaming > > > > a ScriptResource before the ClassicPendingScript is available, e.g on > > > > preload. > > > > > > > > The ClassicPendingScript now only sends one "finished" callback, from > > > > ScriptResource. This callback is either when the streaming completes, > > > > or when there is no streaming and the ClassicPendingScript has told > > > > the ScriptResource that it doesn't intend to start streaming. In the > > > > long run, we want all scripts to go through the streaming interface, > > > > and we want ScriptResource to control when streaming starts, so the > > > > "no more streaming" call will disappear -- however it is necessary to > > > > maintain the current behaviour, and be able to control it with a > > > > runtime flag. > > > > > > > > Bug: chromium:865098 > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#599148} > > > > > > TBR=kouhei@chromium.org,kinuko@chromium.org > > > > > > Bug: chromium:865098 > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450 > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#601143} > > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: chromium:865098 > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138 > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#602310} > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:865098 > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76 > Reviewed-on: https://chromium-review.googlesource.com/c/1317566 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605295} TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org Bug: chromium:865098 Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4 Reviewed-on: https://chromium-review.googlesource.com/c/1318923 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#605815} 
- 
Harley Li authoredThe original URL points to an article outside of DevTools's website. This patch updates to URL to a newly-added article section inside DevTools's website. That article section was added by: https://github.com/google/WebFundamentals/pull/6781 Bug: 847462 Change-Id: If93df903011a714c657ff673c01376c2a5ee78ec Reviewed-on: https://chromium-review.googlesource.com/c/1320709Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#605814} 
- 
Chris Lu authoredThis will set up the next CL that creates an abstract LargeIconService class and adds the Impl class. Change-Id: I25c7f1dcc8955d420683e6037c4a9fb653ef9ae9 Reviewed-on: https://chromium-review.googlesource.com/c/1313277Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#605813} 
- 
Mustaq Ahmed authoredThis is done as per the interop disucssion in UAv2 intent thread: we decided to try 1 sec timeout first, and would switch back to a longer expiry if see any compat problem (specially in a slow network). https://groups.google.com/a/chromium.org/d/msg/blink-dev/nkTDR8AUlwM/RVHaoPgLCQAJ Bug: 776404 Change-Id: I228eb9d2426d07c3f796ccdad14e7185fa06f98e Reviewed-on: https://chromium-review.googlesource.com/c/1320021Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#605812} 
 
-