- 18 Mar, 2020 40 commits
-
-
Kent Tamura authored
The element has status text of input[type=file], such as "No file chosen". This element is not rendered in legacy layout. This CL is a preparation to enable LayoutNG for input[type=file], and has no behavior changes at this moment. Bug: 1040826 Change-Id: I58490a5f0524c1e61407b067c8f26311d4035a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108246Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#751256}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1052232 Change-Id: I94e3e0fdab11cdb25ec5927c199d9bfcfe250d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108249 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |LayoutInlineTest.RegionHitTest| to check having inline boxes instead of |HitTestCulledInline()| becuase |NGFragmentItem| doesn't use |HitTestCulledInline()|. Bug: 982194 Change-Id: Ib62395142113900a36d4451a7896e2191916ec11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108210Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751254}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Remove DEFINE_FONT_DATA_TYPE_CASTS. 2. Use new downast helpers for blink::SegmentedFontData and blink::SimpleFontData. Bug: 891908 Change-Id: Ia42e0f889a11462545463c205a324152900d7ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019749Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#751253}
-
Wei Lee authored
These lines are added to collect more information for debugging crbug.com/1053569 Bug: 1053569 Test: Information appear in logs Change-Id: Ifb1ed1c4762f1470bb1f626936a6b9a11f63dffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083979Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#751252}
-
Yoshifumi Inoue authored
This patch changes |NGPaintFragmentTest| and |NGPaintFragmentTraversalTest| to do nothing when NGFragmentItem runtime feature is enabled because NGFragmentItem doesn't use |NGPaintFragment|. Bug: 982194 Change-Id: Id9b82eb3dec975214d8cb0561457136fe96f67ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107979 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751251}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8dc55c95..be16737b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I265661f44b71f543b2797f83f199273121c268c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107397Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751250}
-
Yoshifumi Inoue authored
This patch changes |NGPhysicalTextFratmentTest| to do nothing when NGFragmentItem runtime feature is enabled because NGFragmentItem doesn't use |NGPhysicalTextFratment|. Bug: 982194 Change-Id: I27aa35196376d453f2672f10ccb181f8158aaa5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106982 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGOffsetMappingGetterTest| to use runtime enable flag instead of gTest's parameter for ease of debugging NGFramgneItem. Before this patch, "NGOffsetMappingTest/NGOffsetMappingGetterTest.Get/0" is faled when running blink_unittests with --enable-blink-features=LayoutNGFragmentItem Bug: 982194 Change-Id: I45815dd550b46b7196708dc7fd83c14f12c3f1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108209 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Khushal authored
This reverts commit 56d27fb4. Reason for revert: This was a temporarily landed as a safer merge candidate for M81. The long term fix for the bug has already landed. Original change's description: > gpu: Disable AImageReader for ARM GPUs on Android P and below. > > This change adds a temporary workaround to effectively revert the > following changes. While the long term fix for this bug has landed, it > might be too risky to merge to M81. So this change reverts enabling of > AImageReader on these GPUs, to restore the behaviour prior to M80. > > Reverted changes: > https://chromium-review.googlesource.com/c/chromium/src/+/2015553 > https://chromium-review.googlesource.com/c/chromium/src/+/1873393 > > TBR=nyquist@chromium.org > R=dalecurtis@chromium.org > > Bug: 1051705 > Change-Id: I2f7f0828c8ba4a7279c2f6bb95de449402d88f92 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087987 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747355} TBR=dalecurtis@chromium.org,nyquist@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1051705 Change-Id: I97c4e3198a3581fc3c437894c0be57681d4d80fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107807Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#751247}
-
Nathan Zabriskie authored
This CL replaces another use of ContextGL in PaintCanvasVideoRenderer with the equivalent API on RasterInterface,a necessary step of the OOPR Canvas2D project. Bug: 1023270 Change-Id: I4dcb21e874c1b890c88667ac76e5026dad8134a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101534 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#751246}
-
Yuki Shiino authored
Introduce three types in platform/bindings/v8_binding.h. - IndexedPropertySetterResult - NamedPropertySetterResult - NamedPropertyDeleterResult (was: DeleteResult) Bug: 839389 Change-Id: I5c2f2bfba4463a8ac9a552bea3b3e004d38baa86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106046Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#751245}
-
nancy authored
This CL implements the change for the pause dialog and block dialog based on the new requirement: https://docs.google.com/presentation/d/1npuBQVumqdMLd82NlVLCVyaojKGIP-QX93AOxwcAK4g/edit?ts=5e6fa394#slide=id.g715badb10b_0_34 https://docs.google.com/presentation/d/1npuBQVumqdMLd82NlVLCVyaojKGIP-QX93AOxwcAK4g/edit?ts=5e6fa394#slide=id.g715badb10b_0_50 1. For Chrome browser, don't show the pause dialog when the user clicks the icon. The Chrome browser can still be launched, but show the pause page. 2. Modify the dialog format, to align with the uninstall dialog, including: a) Show window icon b) Add app name to window title c) Modify the label text Modify AppDialogView to show window icon for all app dialogs. Modify AppDialogView::InitializeView to keep consistency with the uninstall dialog. Modify the label text based on the new requirement. BUG=1061564 Change-Id: Ib753f228253fdf3615000ecbe88364615c19c209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104788Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751244}
-
Sergey Ulanov authored
Now CastRunner creates a FilteredServiceDirectory to pass to the web Context. It then intercepts requests for AudioCapturer and redirects them to the agent. This is necessary to allow agents to process the microphone audio stream used by the app. Bug: 1059836 Change-Id: If46d70f294b43f831856b179bc382b8f48bf3644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095398 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751243}
-
Kent Tamura authored
LayoutObject::GetNode() can't be a ShadowRoot. This CL has no behavior changes. Change-Id: I0a29734abf4fbf388b4702038f051910cdd28956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108262 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1bf5f826..8dc55c95 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d38c5b36327b1dc5b31a5820c31d0b2bb92c2ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107450Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Id51dc7dfde5a4710076d3b9f5ae9a467519af1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108002Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751240}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1052232 Change-Id: Ib6e3b3522b405f75cdd3164c4117155198837279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106979 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
On macOS, we use the system spelling & grammar correction panel; this panel needs to receive a final notification from the client (i.e. us) when there are no misspelled words left, so that the panel can update its state to reflect that. Otherwise, the panel keeps showing the last misspelling as though it was still a misspelling, even if it's been corrected. This changes the circumstances under which the UpdateSpellingUIWithMisspelledWord method can be called, but this method only has a non-empty implementation on macOS, so it should be safe to change the contract like this. Bug: 24011 Change-Id: I26de6f1617cc6801a2b8916a08d84e6e2cb811c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106484Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
DongJun Kim authored
This Cl updates the calls to DeprecatedEqualIgnoringCase to use EqualIgnoringASCIICase as needed. Bug: 627682 Signed-off-by:
DongJun Kim <djmix.kim@samsung.com> Change-Id: I3382fbd2b77b7ae2d6e0812f48b6add384c78137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108202 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
DongJun Kim authored
This Cl updates the calls to DeprecatedEqualIgnoringCase to use EqualIgnoringASCIICase as needed. Bug: 627682 Signed-off-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#751236}
-
Hiroshige Hayashizaki authored
Follow-up of: https://chromium-review.googlesource.com/c/chromium/src/+/2096165/ https://chromium-review.googlesource.com/c/chromium/src/+/2094493/ Bug: 829084, 972476 Change-Id: Ib5e33dde0254aaff0effc1cad290697e790e1dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099686 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#751235}
-
Eriko Kurimoto authored
This CL adds WPTs to test subresource fetch from data: URL dedicated and shared workers with upgrade-insecure-request CSP. The manual change is only in upgrade-insecure-requests/spec.src.json. Others are automatically generated by generate.py. Bug: 989399 Change-Id: Iefb7764be8ce68b5aefb1ac83f253302050fe55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102088 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#751234}
-
bttk authored
This includes NativeUmaRecorder#recordUserAction This does not include a complete implementation of CachingUmaRecorder#recordUserAction Bug: 1048429 Change-Id: I02fac4ef6a21dbfdd70508bb8a12d3ac7baf07a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073153 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#751233}
-
Hiroshige Hayashizaki authored
this CL suppresses generation of debug-only files in release target, to avoid unintended addition of such files into git repositories. Bug: 906850 Change-Id: I55dac746fb7f2690f50d8a40a8c97af51615db03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107337Reviewed-by:
-
Xiaohan Wang authored
PipelineTestRendererFactory is needed by remoting integration test which wraps the default renderer. Instead of PipelineTestRendererFactory and the subclasses, which are hard to read with implementation inheritance, this CL adds WrapRendererCB so remoting integration test can easily wrap the default renderer. This also fixes a bug I accidentally introduced previously that the |renderer_factory_| is actually not used by the pipeline. Instead, it uses CreateRenderer() directly which ignores the factory. Bug: 1062130 Change-Id: I0482922d65fe1727d68936988f04b1e72c048350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106878 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ibc2305de30f1dfdf7e37d01fe7adcdb6c19144c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107334Reviewed-by:
-
Hirokazu Honda authored
The ImageProcessor option in V4L2VEA is formerly both STORAGE_GPU_MEMORY_BUFFER and STORAGE_OWNED_MEMORY for output buffer storage type and both IMPORT and ALLOCATE for output mode. The v4l2 encoder driver should be able to consume GpuMemoryBuffer today, and all the existing ImageProcessor support GpuMemoryBuffer. Therefore, the option of STORAGE_OWNED_MEMORY and ALLOCATE is no longer needed. Bug: 1033799 Test: appr.tc on kukui Change-Id: I4274bba117cb16195e0a92c9448acc55cc353d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104727 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#751229}
-
Samuel Huang authored
For BulkForkAndCall(), the first exception encountered can get re-raised. However, this bypasses code to clean |pool|. For the upcoming work to convert SuperSize to Python 3, this causes parallel_test.py: testBulkForkAndCall_exception() to hang, if another test is also run, and vpython3 (instead of python3) is used. This CL prevents the problem by ensuring that BulkForkAndCall() cleans up |pool| when an exception is raised. Also fix missing parameter to _ForkTestHelper() in testBulkForkAndCall_exception(). Bug: 1054018 Change-Id: I2942438130700fa7ccf804064ae317159c2aa895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107121Reviewed-by:
-
Mike Reed authored
Change-Id: Ib0cdcc31d2daf89f79f3c620aee472c8d3f38d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107722 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#751227}
-
Hirokazu Honda authored
This is the similar fix to crrev.com/c/2096427. V4L2IP originally sets the area of coded size and offset. The byte_used can be less than the real used bytes in the case the coded size's width is less than stride. The correct value is GMB's plane size and offset. Bug: None Test: ip_test --gtest_filter=NV12* on kukui Test: appr.tc on kukui Change-Id: If9e22e60ddac32e056f080cf28b2800b4a9b5380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102367Reviewed-by:
-
Hirokazu Honda authored
Bug: 1033799 Test: ip_test on kukui Test: appr.tc on kukui Change-Id: I9378d91c2bc97edb5a49aa54612d01923ab29177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102368Reviewed-by:
-
Mohsen Izadi authored
Scrolls can have different input modalities: Wheel, Touch, Autoscroll, and Scrollbar. This CL adds metrics for scroll events in the form of EventLatency.<event_type>.<input_modality>.TotalLatency. Bug: 1058162 Change-Id: I0cf063e6537215d89fcc46af912b294d6df21f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091602 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#751224}
-
Hirokazu Honda authored
The input VideoFrame of ImageProcessor on V4L2VEA is the one given by the VEA client. The input config of the ImageProcessor should be multi-planar layout so that ImageProcessor can deal with arbitrary offsets of the VideoFrame. Bug: 1033799 Test: appr.tc on kukui Change-Id: I43df37bb4c2dc9ab1221acd14d19d2413f2c4402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102938 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
wutao authored
The StyledLabel calls two different ctors of Label based on the styled range, one with |custom_font| and the other one with |text_style|. The two ctors will create labels with different heights, which causes a misalignment between normal and bold texts. This cl adds an ash typography to support semi bold text style to emphasize a matched search string. Then the label in the styled range will call a same ctor of Label with |text_style| to eliminate the difference. Bug: 1061271 Test: New unittest Change-Id: I5b7415ef3b7bd06c5ad296fe9e5211ddd18685ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108061 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751222}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I9134b9a8b8313901d256f1deab42c3f2f2ba76fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107906Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751221}
-
John Smith authored
ShouldCustomDrawSystemTitlebar will never change during the runtime of the browser now so these checks are unnecessary. Bug: 953982 Change-Id: Icc9e8201a0e23fe0eab9cfe62d1a9d2a2290af88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108128Reviewed-by:
-
Manu Cornet authored
Change-Id: Ib5679894cee1646f1bebc4a079b81df7a72326df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107614Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751219}
-
Joel Hockey authored
Terminal will not be on by default in M82. This CL is created to be merged in M82 beta, then TerminalSystemApp will be re-enabled on trunk in a followup CL. Bug: 1016190 Change-Id: I40f8f0e22d91b90b166703a92ef0652ff7099561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107051 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#751218}
-
Reilly Grant authored
This change removes the old serial enumeration code on Windows and always uses the new enumeration path while listening to window messages to discover when ports are added and removed from the system. This will allow us to keep the UI up-to-date in real time when the user plugs in a device and deliver connection events to web apps. Bug: 981483 Change-Id: I4126e370b02973458b5c2aac6a230244248b2320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099238 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751217}
-
