- 24 Sep, 2020 40 commits
-
-
Nina Satragno authored
This reverts commit 1208732e. Reason for revert: likely making ExecuteScriptApiTest.ExecuteScriptInFrame flaky. Bug: 1131966 Original change's description: > Remove unneeded CursorLoaderWin::SetPlatformWindow calls > > SetCursorNative is only called from WindowTreeHost::SetCursor, which > guarantees that the platform cursor has been set. > > Bug: 1097556 > Change-Id: I4c140a872482ba33bf957ed6817279c275bf7f36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417893 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Cr-Commit-Position: refs/heads/master@{#810120} TBR=sky@chromium.org,hferreiro@igalia.com Change-Id: I60d2de90149af77a5d6ebdce2f02a859f9262f9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429229Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#810251}
-
Ian Wells authored
Bug: 1110685 Change-Id: If30b18f3d1b0dd1643442cfd4a6fd5bd730bae22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424666Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#810250}
-
Alison Maher authored
Similar to CL:2404109, ComputedStyle::DecorationColorIncludingFallback() was not handling system colors correctly with CSSSystemColorComputeToSelf enabled. Bug: 1081945,1129485 Change-Id: I3b01f5060c0758a9167a771058d365dbb4629008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424674Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810249}
-
manukh authored
Just a helper to check if both suffix and prefix autocompletion are empty. This is in preparation for the potential introduction of a 3rd autocompletion field. Bug: 1062446 Change-Id: I58aecb9cffb690618bb835ed97e1cb69cfdae635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426964 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#810248}
-
Daniel Libby authored
This allows the state from freezing the tree to match the updates we're about to send up to the browser process. On amazon.com homepage, activating the hamburger menu results in a focus to the hamburger menu, then a synthesized click. The click handler bounces focus to the popup menu's close button and also modifies its styles so that it is visible. The first focus event queues up a deferred notification for HandleNodeGainedFocusWithCleanLayout. This is then added as an AXEvent (and queues a SendPendingAccessibilityEvents) as part of the lifecycle update triggered by RenderAccessibilityImpl::PerformAction for the click. The click happens and script bounces focus to the other element. The SendPendingAccessibilityEvents task then runs, which snapshots the pending_events_ (and clears it) before freezing the tree and updating layout. Due to this there is an AXTreeUpdate where focus points to the close-menu. However the close-menu element has not yet recomputed to be unignored as the relevant events are queued up in pending_events_. This change runs the document lifecycle before snapshotting the pending_events_ and dirty_objects_ so that we send up a self-consistent set of accessibility updates. Also added some tracing to help narrow down Accessibility focus issues in the future. AX-Relnotes: N/A Bug: 1131827 Change-Id: Ia8133c9bff45c243018185041bd13762bac25295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427749Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810247}
-
Ehimare Okoyomon authored
Temporary remove non factory-default permissions from the summary string until we are able to populate the permissions subpage directly using this controller's returned permissions: https://chromium-review.googlesource.com/c/chromium/src/+/2410859 Bug: 1077766 Change-Id: If57829db3c656c0631dda7fc755b9a46b2abb714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429044Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#810246}
-
Roman Arora authored
Bug: 1099917 Change-Id: I51249a533b84439513708d62e5f56ac83120cce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427184Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#810245}
-
Steven Bennetts authored
The logic for determining whether a network is metered for the purpose of auto updates is implemented separately in session_manager. We need to resolve this before enabling the toggle. See issue for details. Bug: 1129994 Change-Id: I976e191b8b27017339876d747c01967bab6081dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426982 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#810244}
-
Evan Stade authored
This reverts the changes to GoogleAccountsCallback and introduces a new API for retrieving the user email, name and avatar. - getEmail is synchronous because the information is UI-blocking. We could show the UI, then later update, but that would be more jarring and more likely to cause misclicks, since the UI would move under the user's fingers. - getAvatar is async because the above problems don't apply. Bug: 1129893 Change-Id: I2cde39cc18f1da9edf6c3004f4c909492cd424c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421444 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#810243}
-
Stepan Khapugin authored
Instead of exposing MainController's conformance to BrowsingDataCommands use the app state's dispatcher to access it. Bug: 1045659 Change-Id: I71bd5d4693d5d2eefdc67def9abb345a84d24ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418336 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#810242}
-
Olivier Robin authored
Bug: 1088801 Change-Id: Ib266b90c1dabf72cc1b5e31ee2dfebc937e393f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421823 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#810241}
-
Robert Phillips authored
Skia has improved its blurred rect handling in: https://skia-review.googlesource.com/c/skia/+/318757 (Allow rect and circle blur fast cases to be used with rotation matrices) This resulted in layout test differences in: vulkan_swiftshader_blink_web_tests --- transforms/shadows.html Bug: 1131901 Change-Id: I2485b867b37941abb65ed3f2b985d268a91e16df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427301Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#810240}
-
Javier Fernández García-Boente authored
Change-Id: I42b1dbf1318feb44f90edef02e71e64c97380a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426452Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#810239}
-
Richard Knoll authored
This adds a new NotificationBlocker that listens for screen share events and stops notifications when a full screen is currently being recorded. Implemented behind a mute-notifications-during-screen-share flag. Bug: 1131375 Change-Id: Icebcb9223614e07134ce038aef2ec2e45190c893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421665 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810238}
-
Anton Bikineev authored
This is a prerequisite for quarantine bitmap in PCScan. Bug: 11297512 Change-Id: I4d99e348140fe8b4826be46c4bc0a0e88afed4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421894 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810237}
-
Ken Rockot authored
On devices and Android versions which support 5G, this allows the NetworkChangeNotifier to update the ConnectionType to 5G when observing use of a network of type NETWORK_TYPE_NR, which corresponds exclusively to 5G standalone networks. The NCN Java code is also updated to treat TYPE_MOBILE_DUN and TYPE_MOBILE_HIPRI networks the same as TYPE_MOBILE. Currently they are ignored and treated as "unknown" network types, but they are legitimate values when on a cellular network, up to and including 5G. Bug: 1127134 Change-Id: I5b054635a633970d26f4cfcc34b5a58376ed2fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427104Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#810236}
-
Toby Huang authored
FamilyUserMetricsProvider causes an OOBE crash from dereferencing a null sign-in profile. Revert this code temporarily while working on a fix. Bug: 1128281 Change-Id: If13d6fc4a0c222053e8beae3d306e9aa9fae2340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427426 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#810235}
-
Minoru Chikamune authored
[Target problem] - The current code uses g_current_agent_group_scheduler_impl global variable. [What this CL does] - Get rid of the g_current_agent_group_scheduler_impl global variable, and keep this pointer in MainThreadSchedulerImpl as a field. - Make it possible to access current AGS from arbitrary places with `ThreadScheduler::Current()->GetCurrentAgentGroupScheduler()`. [Related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1105403 Change-Id: Iac332a9400bc20537e5d64ce700d0e5866e7f406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427945 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810234}
-
Becca Hughes authored
Change-Id: Id8d677caba6f2353d969efb210f01a4e831acacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427432Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#810233}
-
Zentaro Kavanagh authored
- Making usage consistent in file Bug: None Test: None Change-Id: If88abfc0a7fe424f5d6da7f623e321cee72b3936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427042Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#810232}
-
Dan H authored
This reverts commit 3742fb2f. Reason for revert: builder failure crbug.com/1131947 Original change's description: > chromeos: Set is_linux to false. > > Bug: 1110266 > Test: Built locally. > Change-Id: I291f594060beed19d8497c5d6b7689effbe3dc9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413458 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810162} TBR=thakis@chromium.org,hidehiko@chromium.org Change-Id: I710cbf3c96f26a1e5e9f22617443348ea249984c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429364Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#810231}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a952a34..2f1c8428 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I748185aaeb34c94ab36bef63e41c50b939d1731f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428823Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810230}
-
Felipe Erias authored
For consistency, rename the ScrollbarGutterIs* methods in ComputedStyle to IsScrollbarGutter*. Bug: 710214 Change-Id: I0f63528112fe00ce91aa7f3877b370e7bfe7d8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416434Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#810229}
-
Prashant Nevase authored
As dark mode image classification logic works on integral values, making APIs accept SkIRect will help callers decide how to round the SkRects. This patch rounds |src| and |dst| by calling SkRect::roundOut() in DarkModeFilterHelper::ApplyToImageIfNeeded(). Bug: 1094005 Change-Id: I86dead7936932e207d0e1a3540de1741c27587d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389862 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810228}
-
Garrett Beaty authored
This is a reland of 229a7c61 Configs for the mojo builders were copied to thew new builder group in mb_config.pyl and waterfalls.pyl. Original change's description: > Switch the builder group for mojo builders. > > The recipe-side config for the mojo builders has already been copied to > the new builder group. > > Bug: 1131163 > Change-Id: Id1d01ccdac7f242e347db02586b04bb6927b9e0b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427123 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#809869} Bug: 1131163 Change-Id: I1e1db95eec3513ec1fc85f2ace2cffddc5567a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427286 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#810227}
-
Jan Wilken Dörrie authored
This change replaces usages of autofill::PasswordForm with password_manager::PasswordForm in the export and import sub directories of //components/password_manager/core/browser/. Bug: 1067347 Change-Id: Ic8059ed095401354323efc7e8f9b295d30bb7773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428240 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#810226}
-
Olivier Tilloy authored
- Use $SNAP_USER_COMMON to store profile directories, to avoid data loss when the snap is refreshed while running. - Add the bluez plug to enable Web Bluetooth. - Use 'snapctl is-connected password-manager-service' instead of D-Bus calls. Change-Id: Iee24e689a9bbd678875d206fe00c7cbb28af38d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398521Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Olivier Tilloy <olivier.tilloy@canonical.com> Cr-Commit-Position: refs/heads/master@{#810225}
-
Aaron Leventhal authored
Bug: 1129111 Change-Id: I5c5db22feb752e42d0620f03c3e765c6319517ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422719 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810224}
-
Jan Wilken Dörrie authored
This change replaces usages of autofill::PasswordForm with password_manager::PasswordForm in the file range [brow...cred] in the //components/password_manager/core/browser directory. Bug: 1067347 Change-Id: I33b577e5f87619a85a395a59671fa8d0e63801fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426571 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#810223}
-
arthursonzogni authored
There are some properties added to reports depending on the redirects. This adds tests so that we can verify what is reported. body.{referrer,initialPopupURL} depends directly from the redirects. body.{openeeURL,openerURL,otherDocumentURL} might depend in the future from the redirects. Bug: 1090273 Change-Id: I2ca80ee2664005bd156e4cbf2c08f1d2983b91b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424136 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810222}
-
Jan Wilken Dörrie authored
This change replaces usages of autofill::PasswordForm with password_manager::PasswordForm in the /generation, /sync, and /ui sub-directories of //components/password_manager/core/browser/. Bug: 1067347 Change-Id: I48d239ff688dbd7ddc6a43ea0df923db2eee18f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426647Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810221}
-
Richard Knoll authored
This adds a new NotificationDisplayQueue that can queue up notifications. It owns a list of NotificationBlockers that determine if notifications should be blocked and shows them once all of them get unblocked. This CL on its own has no behavioural change. A follow-up CL will implement a blocker for when Chrome records a full screen. Bug: None Change-Id: Id95398944390b274b4fa01399b2a12a39c99e083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401101 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#810220}
-
Antonio Gomes authored
browser_non_client_frame_view_ash.cc includes ash/public/cpp/ash_switches.h to make use of the `kAshEnableV1AppBackButton` runtime switch. However, as for the bug linked to its declaration, the support is flagged for removal (https://crbug.com/749713 - WONTFIX'ed). This CL removes it, and the code associated with it, including if-blocks it was being checked and unittests. This is phase 2.3 in the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los The idea is to move browser_non_client_frame_view_ash.cc|h away from using "ash" symbols. Ultimately, this file will be used by lacros/chrome builds. BUG=749713, 1113900 Change-Id: Iab1a7766f0142e66abda34a265d1308b341b2328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424637Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#810219}
-
Dan McArdle authored
Change-Id: I7c6ea9c7742d67d0e2eb0d365757558818001a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418987 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810218}
-
Richard Knoll authored
Not all observers are tied to a specific WebContents. Currently they would have to observe any streaming WebContents to get notified when it is being destroyed. This CL will make sure that the observers get called when the capturing stops because the WebContents is being destroyed. Refactored the unit tests to use parameterized tests so this can easily be tested for all capture types and portals. Bug: 1131375 Change-Id: I06cf23643b22c798978d52af9f493ab69d1c1612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426593 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#810217}
-
yilkal authored
This cl ensures that manually allowed urls will always return early in SupervisedUserURLFilter. Bug: 1131201 Change-Id: I8622737dd55aaa338b3bf46642c2650bf9b61c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424673Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#810216}
-
Michael Checo authored
Screenshots: - Diagnostics Page (before) http://shortn/_k8NLMVtA6A - Diagnostics Page (after) http://shortn/_2lCAX0PQSg Bug: 01125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I6e48d0e2f3de61a859333eafdebb0e83ecff222f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425426 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#810215}
-
Nina Satragno authored
This reverts commit c2ca6d1c. Reason for revert: browse:social:twitter:2020 time out on mac Bug: 1131939 Original change's description: > [system_health] enable performance.mark metrics for Twitter browsing story > > R=johnchen@chromium.org > CC=cbruni@chromium.org, jdecaires@twitter.com > > Bug: 1114635 > Change-Id: I224fd77a89e316ba982c958ca9227ebb45db6eaa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345308 > Auto-Submit: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810126} TBR=johnchen@chromium.org,tmrts@chromium.org,tmrts@google.com Change-Id: I4c990af08436e45e582383e4e289864fb49ca502 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427574Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#810214}
-
Bruce Dawson authored
RestrictedTokenTest.OpenLowPrivilegedProcess was occasionally failing under asan due to a use-after-free failure. Some of the output was misleading (in particular the line number of the claimed use-after-free) but the size/offset/alloc-size/alloc-site/free-site information was enough to find the bug and create a simple fix. The lesson is to not use a member of an object to identify the object to delete. Bug: 1012356 Change-Id: Iac5e032c5f4bc364eb367a8424a18868918f6181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427055Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#810213}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I5dc9d75e7e136afd351db710e1cf5e4e87a72a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424834Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#810212}
-