- 28 Aug, 2019 33 commits
-
-
John Budorick authored
Bug: 990454 Change-Id: Id2051e013bc1727ce320f1b5c2c6f0c9d83628b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772388 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690971}
-
Xianzhu Wang authored
They were set by blink before BlinkGenPropertyTrees when cc:PropertyTreeBuilder used them to generate property trees at cc side. Now blink generate property trees directly, so remove them. Bug: 994361, 754339, 993936 Change-Id: I98559a49778ef6f14f96de61f1f6f54ad16631b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767492 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690970}
-
Albert J. Wong authored
This is a simple consistency cleanup that makes it easier to read through all the functions. Bug: 998273 Change-Id: I2c45fe1befcf4bc72a3c92f63854e65e13d7aa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773215Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#690969}
-
Erik Chen authored
RenderWidget holds onto a WebWidget. It has two methods GetFrameWidget() and GetWebWidget() which should both just reference the WebWidget. Instead, RenderWidget will [inappropriately] call out to its delegate to get the FrameWebWidget, which the WebWidget should already be. This induces confusion. This CL fixes the RenderWidget's webwidget_internal_ to always be a WebFrameWidget when the RenderWidget is associated with a RenderView. This changes the semantics, as we will never pass a WebViewImpl as a RenderWidget's webwidget_internal_. This has one main side effect -- a remote main frame's RenderWidget will now have a null WebWidget. Change-Id: I930a9c91a88ac05882289df795ed1c4008e146fd Bug: 995981, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766889Reviewed-by:
-
Ken Rockot authored
This changes RPHI::Cleanup to tear down the corresponding IOThreadHostImpl, preventing further IO-thread tasks from being handled by the object. This ensures that no further incoming interface requests will be handled on the IO thread for the RPHI. Specifically the purpose of this CL is to avoid any potential interface binders referencing the host's ResourceContext, which may be destroyed after Cleanup is run. Bug: 997634 Change-Id: I25fb96daebd5b2801bb95189e5715986dc4af88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773403 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#690967}
-
Friedrich Horschig authored
The new borderless icons are based on transparency which works in all places that have a white background. In some dark mode surfaces, some dark icons have nearly no contrast. This looks bad, like shown in the linked bug. Therefore, this CL reintroduces the white backgrounds. The borders are still gone on all surfaces. Bug: 985318 Change-Id: I064b500934b47aecb6321fbacaade461f161c251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771967 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#690966}
-
Finnur Thorarinsson authored
i Bug: 993746, 860467 Change-Id: I6922f39db47de5c20d01d8eaf42894b8469f2dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773257 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Darren Shen authored
Tbr: kyleju@chromium.org Bug: 856601 Change-Id: I971d50f4f6629d3496e5c70d8ceaf7e1b00543a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772207Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#690964}
-
David Black authored
The proactive suggestions service needs locale to support I18N. Bug: b:140108241 Change-Id: I18a651cb61cc1c4bf37eeae95833a9fdc6229f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769684Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#690963}
-
Chris Hall authored
Test was failing because the final inlineTextBox element has split into two. The layout of the text on this page is not critical for this test. Using BLINK-DENY-NODE to ignore inlineTextBox elements. R=aleventhal,aboxhall Change-Id: Ib805e7b9d99975eb775eefde67d40c98e96772df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768513Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#690962}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/daddc3da9672..ea78a142b81f Created with: gclient setdep -r src-internal@ea78a142b81f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I575483fdde4142de0dad27678da12d77cb33ce72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772432Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690961}
-
David Black authored
Per UX requirement, if the user doesn't interact with proactive suggestions within 15sec, the widget should automatically be closed. Bug: b:139199754 Change-Id: I77d398a4d6d376b2ee3aadf4888da3fb764ee77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772481 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
John Abd-El-Malek authored
It was previously using GetLastCommittedURL but that's not the correct one to use as sky mentioned in https://chromium-review.googlesource.com/c/chromium/src/+/1772123/1/weblayer/browser/browser_controller_impl.cc#62 Change-Id: I1e4e470de6babd43c3d2506d676f907218484730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772645Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#690959}
-
Abhishek Bhardwaj authored
This changed moves device scheduled update checker file to a sub folder called scheduled_update_checker. BUG=924762 TEST=Compile. Change-Id: I7bb5be971524daf32c8e88333f9d9a9354194585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757392 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#690958}
-
Julie Jeongeun Kim authored
This CL converts TrustedHeaderClientPtr and TrustedHeaderClientRequest to new Mojo types. It also updates OnLoaderCreated and CreateWebSocket from network_context.mojom. Bug: 955171, 978694 Change-Id: If288b38aa8efd7d2fd7f76f817ee2434e10e9edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767298Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#690957}
-
Kurt Catti-Schmidt authored
GetUnignoredSelection (introduced in crrev.com/c/1691559) introduced a new selection API built on AXPosition. Exposing AXPosition in such a broad way revealed limitations of AXPosition on specific platforms. In particular, ChromeOS doesn't have a BrowserAccessibilityManager, so workarounds were necessary for selection to work there. This DCHECK is another of those exceptions - BrowserAccessibilityManager isn't available on ChromeOS, so the DCHECK is too aggressive to be a universal expectation. The callers of the function already handle it returning nullptr, so it's safe to simply return nullptr if there's no BrowserAccessibilityManager available instead of DCHECKing. Bug: 995807 Change-Id: I43d21337ce071045d0653be39e10f5003402675e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773209 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#690956}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 601cc468. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" eaee4be5 "CSS: Consolidate block/inline tests for scroll-margin, scroll-padding" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jrummell@chromium.org: external/wpt/encrypted-media NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5af457a1214a420e67c783bc4912e041eb7bd0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772644Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690955}
-
John Lee authored
Pinned tabs are presented as a grid, with a maximum of 4 tabs stacked vertically. This CL adds placeholder "ghost" tabs to fill in each column where there are not enough actually pinned tabs to fill the 4 spaces. This CL aims to create the placeholders using only HTML and CSS, with minimum JS to avoid keeping track of a dynamic number of placeholders and constantly re-creating and removing placeholders. https://i.imgur.com/0NK8ikk.png Bug: 989131 Change-Id: I511a7f82fbf4480b53a437dae4b6d9445249514a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772227Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#690954}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cde5dea64717..f79bd7c2ef34 git log cde5dea64717..f79bd7c2ef34 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 vapier@chromium.org cros_build_lib_unittest: fix env test after LC_MESSAGES=C tweak 2019-08-27 tcwang@google.com afdo: Rename release-afdo-verify to chrome-* 2019-08-27 yueherngl@google.com drallion/zork: mark paladins important Created with: gclient setdep -r src/third_party/chromite@f79bd7c2ef34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9f8b3af731106474bd51a0d9578c0d77c2a6ba23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690953}
-
Jimmy Gong authored
- When there is no connectivity, we disable the ability to add a printer and display a message to users. Bug: 993834 Test: browser tests, end to end manual Change-Id: I6f0eb28bcd2df604c8e27e799df239a646d0119a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761482 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690952}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5059864006c0d88f302f4e29d863222db2b228bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772519Reviewed-by:
-
Xida Chen authored
Right now we have places in Blink that uses std::vector<std::pair<std::string, CompositorElementId>, which is exactly the CompositorPaintWorkletInput::PropertyKeys. This CL makes changes to those places, no behavior change is introduced. Bug: None Change-Id: I16b60f258ad54a7ae807d222a2472d9eeedcb67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768894Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690950}
-
Darren Shen authored
Test has been failing for over 50 runs. TBR=alemate@chromium.org Bug: 998330 Change-Id: Ib9c5446d32b1354011407b2b8597655a40159741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772930Reviewed-by:
-
Brian Sheedy authored
Updates the golden images for the VR browser suggestion hovering pixel test, as the order of suggestions was recently changed. TBR=alcooper@chromium.org Change-Id: I943f62372414470a038e4a16633acb3f75e8cfa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773860Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#690948}
-
Lijin Shen authored
This CL adds some metrics to record actions related to the long press tab switcher menu. Bug: 993046 Change-Id: Ic0320fbf4dd63646cd098e2b674d193485c1c38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772278Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#690947}
-
Nico Weber authored
Including directories full of generated files causes incorrect incremental builds. But using data_deps makes it easy to copy just the generated files here, so just do that instead. To make sure this does the right thing, I ran gn gen out/gn --runtime-deps-list-file=<(echo //chrome/test:browser_tests) with and without this patch and compared out/gn/browser_tests.runtime_deps. The diff is -test_case.html -test_case.html.mock-http-headers -test_page.css -test_page.css.mock-http-headers -test_url_loader_data/ +corb_eligible_resource.json +corb_eligible_resource.json.mock-http-headers +test_case.html +test_case.html.mock-http-headers +test_page.css +test_page.css.mock-http-headers +test_url_loader_data/hello.txt -corb_eligible_resource.json -corb_eligible_resource.json.mock-http-headers -test_case.html -test_case.html.mock-http-headers -test_page.css -test_page.css.mock-http-headers Importantly, `test_url_loader_data/` no longer appears. (For some reason, the non-directories were listed twice previously.) We now bundle corb_eligible_resource when we weren't previously, but that seems fine. I then downloaded an isolate from the command printed on a browser_tests run on swarming like so: tools/swarming_client/isolateserver.py download -I https://isolateserver.appspot.com \ --namespace default-gzip -s 60fe18ca29dd47b47425717c01e67516cc26d6bf \ --target foo and verified that these are in fact all files: $ ls foo/out/Release/test_url_loader_data/ hello.txt Bug: 912946 Change-Id: I1ad01f8b53a1eb47c5b572ad645b1901305fcbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769213Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690946}
-
Charlene Yan authored
Bug: 985382 Change-Id: I65181f7b063b05e1a382761786cd9df92d35fe5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754622 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#690945}
-
Jun Mukai authored
When the display bounds is changed, the app-list updates its layout but the searchbox can remain in the original position. This CL fixes this situation. The search box happens to change to the correct bounds when in peeking state, since AppListView::SetState() invokes UpdateYPositionAndOpacity() and ContentsView updates the search box position. This is not the case of half/fullscreen-search state. I do believe the existing code of UpdateYPositionAndOpacity looks weird since the search box bounds is neither of y-position nor opacity. Doing the re-calculation in Layout() would look better to me -- though I keep the existing code as-is in case it matters on certain operation. Bug: 998220 Test: new test cases in ash_unittests Change-Id: I799461069c2168c5e8fc58382812116444dc4430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773514 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#690944}
-
Peter Kasting authored
This number was last updated in 2012. The numbers here are based on the last week of Windows stable data, taking the mean across all samples. Other desktop platforms have higher means than Windows, so this is still aggressive compared to what we could do. The expectation is that this change should reduce the total number of renderer processes we create, and result in reducing the total renderer memory footprint. Bug: 22546 Change-Id: I2308759644ed2720e4904052e93b37d6ee8367fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772641 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#690943}
-
David Bokan authored
This enables fractional scroll offsets which allows non-integer values in Blink's scrolling data structures. https://github.com/bokand/RenderingIndependentScrollOffsets/blob/master/README.md Bug: 414283 Change-Id: I145899dd4a3ae9f3b3c936749fbe0b52cbc9ba3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766355 Auto-Submit: David Bokan <bokan@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#690942}
-
Julian Watson authored
Bug: 998319 Change-Id: I0ea11d3804c065052ab1929ec93ca8336273bf09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772929 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#690941}
-
Joe DeBlasio authored
This CL adds lookalike heuristic checking to safety tips. A safety tip is only triggered when a lookalike domain is identified, but an interstitial would NOT be triggered. In practice, this means a safety tip is triggered when: - there's an edit distance of 1 to a top or engaged domain, or - there's skeleton similarity to a non-top-500 top domain. This CL also tidies the logic in lookalikes slightly. Now Chrome identifies lookalikes first and as a separate step decides whether to display an interstitial. Both functions are used when determining whether to trigger a safety tip, so as interstitialling logic changes, safety tips will move out of the way appropriately. Bug: 984725, 996733 Change-Id: I590f6d707a5347d55fb48e71e1420434b14bccb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771940 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#690940}
-
Piotr Bialecki authored
Subscription-based hittest explainer can be found here: https://github.com/immersive-web/hit-test/blob/master/hit-testing-explainer.md This CL omits the asynchronous hit test also mentioned in the above explainer (XRFrame::requestAsyncHitTestResults) as it's not yet clear how it should work, see issue: https://github.com/immersive-web/webxr/issues/506 Bug: 928481 Change-Id: I92c69b58794f2850025ab5ff2e68855b3162646d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546710 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#690939}
-
- 27 Aug, 2019 7 commits
-
-
David Black authored
Per feedback from UX, the proactive suggestions window animation should be 350ms in duration with a cubic bezier tween. Bug: b:139199754 Change-Id: I9d5cc06cd441c9cedbe60066a364d09c7b005a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773840Reviewed-by:
-
Peter Boström authored
Prevents activating the grouping border stroke when a user hovers the main item. This is currently either extensions' puzzle icon or the avatar icon, neither of which need to communicate which group of icons they belong to. Bug: chromium:993105 Change-Id: Iedcb82865517504efb452f00680fe50833a8b9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773726 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#690937}
-
Sophie Yang authored
Removed duplicate variable menuOriginNode that likely appeared after a merge. Bug: 982004 Change-Id: I857049cda8387b9e5d40189d1ed9afec49156e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773213Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Sophie Yang <sophyang@google.com> Cr-Commit-Position: refs/heads/master@{#690936}
-
Becca Hughes authored
Add rounded artwork corners as per spec. There is a screenshot of the implementation in the bug. BUG=998314 Change-Id: I8e92628693c64618628d05b064a5a46027fbeee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772380 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690935}
-
Avi Drissman authored
There have been no scrollbar buttons since 10.7. The code handling them on the renderer side is long-gone; remove the code from the browser side. Do mild other cleanup while we're here. BUG=997934 Change-Id: Ia217b4de1b0451e3aff738a0e4c3f1db7526b6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773162 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Adjusts the offset of the bottom sheet so that it appears as expected when the omnibox control is not on screen. This CL fixes the issue by overriding BottomSheetContent.onHideScroll so the browser controls won't have an effect on NavigationSHeet. Bug: 996535 Change-Id: I32d5a1a15d5a7275ce0fdba1a86e7dd82a570086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767283Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#690933}
-
Kent Tamura authored
This CL reduces pre-processed size of foo.mojom(-blink)-forward.h including interfaces or structs significantly. For example, file_chooser.mojom-blink-forward.h: 1.66MB => 0.004MB * mojo/public/cpp/bindings/*_forward.h New files. They contain some forward declarations for mojo/public/cpp/bindings/. * mojo/public/tools/bindings/generators/cpp_templates/module-forward.h.tmpl Include only *_forward.h and native_struct.mojom-forward.h. native_struct.mojom-forward.h is necessary for [native] structs. * ipc/message_view.{h,cc} Move TakeHandles() implementation to message_view.cc in order to avoid instantiation of mojo::StructPtr<> in the header. * Other files Add #includes or forward declarations which were included indirectly from mojo headers. Change-Id: I08ac30fc40cb7af4ce248e8e9b5b1ff4fb55ed68 Bug: 862064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768608Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#690932}
-
