- 14 Feb, 2019 40 commits
-
-
Lily Chen authored
Disallow setting NEL headers and queueing NEL reports when the HTTP response is fetched via a proxy. Disallow NEL reporting on 407 responses. Bug: 930777 Change-Id: I803c3e087630cd5e6c244771550c97091e5d6e74 Reviewed-on: https://chromium-review.googlesource.com/c/1466195 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#632021}
-
Vlad Tsyrklevich authored
Currently we mark unused pages inaccessible but don't release their memory back to the OS. Release it so that we can make use of a large quarantine without incurring memory overhead. This showed a ~2-4% regression on a microbenchmark that looped allocating and deallocating. Bug: 912286 Change-Id: Iab5fd441071ef0fc45aa793708b886c7fe864158 Reviewed-on: https://chromium-review.googlesource.com/c/1471331 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#632020}
-
Olivier Robin authored
This method allows to replace the content of the page with given data and MIME type. The method does not trigger a navigation. The method also takes a URL that will replace the current URL in the navigation stack. Bug: 929492 Change-Id: If1295915718d8dd9e582d2e88035eb63ce7341ea Reviewed-on: https://chromium-review.googlesource.com/c/1436359 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#632019}
-
David Trainor authored
Add the ability to simulate an inline update flow, which will be used by variations, test, and PM/UX to look at the update flow. BUG=922714 Change-Id: Ic313e8cae6e9fc9f0413c227c151990d192e62a5 Reviewed-on: https://chromium-review.googlesource.com/c/1461831Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#632018}
-
Avery Musbach authored
This CL is meant as a low-risk fix of Issue 926602 to merge back to M73. For the long term, it will be preferable to avoid maximizing windows before snapping them. Then we might even be able to eliminate |defer_bounds_updates| altogether (even though it existed before anything about snapped windows carrying over from desktop to tablet). TabletModeControllerTest.DeferBoundsUpdatesForWindowsInOverview* TabletModeControllerTest.ProgrammaticallyStartSplitViewAndThenOverview Test: ash_unittests TabletModeControllerTest.StartTablet* Test: ash_unittests Test: ash_unittests Bug: 926602 Change-Id: I0a068ffae314871c8466d1364bcd96f72b69d345 Reviewed-on: https://chromium-review.googlesource.com/c/1457235Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#631462} Reviewed-on: https://chromium-review.googlesource.com/c/1471013 Cr-Commit-Position: refs/heads/master@{#632017}
-
Garrett Beaty authored
This reverts commit 200e1df8. Reason for revert: Forgot to make necessary changes chromium_tests. Original change's description: > Add win32-arm64-rel to the gitiles trigger. > > Bug: 925575 > Change-Id: I0fb736af2963b307f6bf141ea1c23ee16b1cf671 > Reviewed-on: https://chromium-review.googlesource.com/c/1471249 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632005} TBR=jbudorick@chromium.org,gbeaty@chromium.org Change-Id: Ic5959773ad89664013cbc3801be08feddda60951 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925575 Reviewed-on: https://chromium-review.googlesource.com/c/1471453 Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#632016}
-
Derek Schuff authored
A few domains used to be whitelisted to always allow them to load non-PNaCl NaCl modules. Remove the the whitelist and the associated tests. Bug: 919940 Change-Id: I98d410313adcd75ab3b69e724c97a4550ce18f1c Reviewed-on: https://chromium-review.googlesource.com/c/1471232Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#632015}
-
Lan Wei authored
ChromeDriverTest.testActionsTouchStart is flaky on Mac10.12 bot, fix the test to pass on Mac bot. Bug: 931440 Change-Id: I8d8d2080d20c23c8f4de6352eb8067ba3f09c9f9 Reviewed-on: https://chromium-review.googlesource.com/c/1471305Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#632014}
-
chrome://browser-switchNicolas Ouellet-payeur authored
Bug: 887005 Change-Id: Ic5940c15a652c0fceea34f8a1ca493b7707d9236 Reviewed-on: https://chromium-review.googlesource.com/c/1467022 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#632013}
-
Kent Tamura authored
Add the following style: white-space: pre-wrap; line-height: 1.5; Change-Id: I51be1df221787ff5fcac3cf92c528fbecb27c744 Reviewed-on: https://chromium-review.googlesource.com/c/1469198 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#632012}
-
Clark DuVall authored
This adds CHECKs to all loaders that are not null checked before calling ResumeReadingBodyFromNet, which will hopefully give a better stack so we can find the real culprit. Bug: 916098 Change-Id: I11f01f6bffe44dd17efb16f9c89ee5d6bd078d5c Reviewed-on: https://chromium-review.googlesource.com/c/1471210Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#632011}
-
Steven Bennetts authored
This CL: * Fixes a Polymer2 bug where networkProxy.isShared_ was called while networkProperties was undefined without checking, causing a console error. * Fixes a DCHECK in the ONC code when configuring Ethernet nameservers or IP config properties. * Also updates NULL -> nullptr in onc_translation_tables.cc. Bug: issue 931845 Change-Id: I87a953a0b7779f0d7f4538a5b9e8a5a95f9d5235 Reviewed-on: https://chromium-review.googlesource.com/c/1471307Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632010}
-
Tommy C. Li authored
Instead of showing the Search Provider favicon in the omnibox, this experiment shows a generic magnifying glass icon. This also applies to the NTP, as the omnibox in the NTP has always had the same icon as the omnibox showing a search suggestion. Doing something different would require a more extensive change. Bug: 931836 Change-Id: Ia16422b8e4c710b6d664d10c20a322b1083dd57a Reviewed-on: https://chromium-review.googlesource.com/c/1471247Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#632009}
-
Dominik Röttsches authored
Modify DWriteFontLookupTableBuilder to support off-main-thread scheduling of the font unique name lookup table construction. For now, schedule this as a USER_BLOCKING-prioritized startup task in a separate SequencedTaskRunner. Synchronize using a WaitableEvent that the DWriteFontProxyImpl can wait on when it receives an incoming Mojo request from a renderer for this table. Once the UpdatePriority() API for SequencedTaskRunners becomes available, downgrade the priority to BEST_EFFORT, then bump it once the renderer requests the table. This TODO is tracked in [1]. Background for font unique name local lookups in the design review doc in https://crbug.com/828317. See also startup job scheduling discussion in [2]. [1] https://crbug.com/931366 [2] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iDClDAsZnrE/bb5eZXkUFAAJ Bug: 889864 Change-Id: I8e19d34520422fc9404ca01cb8357221d7a11495 Reviewed-on: https://chromium-review.googlesource.com/c/1459635 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#632008}
-
Stephen Martinis authored
This reverts commit ab8cc613. Reason for revert: Changed the trybot, meant to change the CI bot. Original change's description: > Use 32 cores on 'win-asan' > > https://crrev.com/i/828938 added a new bot which has 32 cores. This CL > should make the builder use that machine instead of the old 8 core > machine. > > Bug: 919189 > Change-Id: I3cf8894e73c21a9d590ce709c3fa3b40ca23d0f2 > Reviewed-on: https://chromium-review.googlesource.com/c/1470991 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Auto-Submit: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#631830} TBR=martiniss@chromium.org,jbudorick@chromium.org,gbeaty@chromium.org Change-Id: I8ba9ebc0cc660e736106afdf91baf058906040d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919189 Reviewed-on: https://chromium-review.googlesource.com/c/1471344Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#632007}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googletest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature TBR=hychao,bartfab Bug: 925652 Change-Id: I71a4345703ca76c05540fc8062ca0d24c7d204c2 Reviewed-on: https://chromium-review.googlesource.com/c/1471375Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#632006}
-
Garrett Beaty authored
Bug: 925575 Change-Id: I0fb736af2963b307f6bf141ea1c23ee16b1cf671 Reviewed-on: https://chromium-review.googlesource.com/c/1471249Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#632005}
-
Zhuoyu Qian authored
This patch replaces the erase(std::remove_if()) used in the chrome folder with base::EraseIf(). Bug: 875665 Change-Id: I8ebc80225ca4477dac2ae96f2e6dd21ef4602c52 Reviewed-on: https://chromium-review.googlesource.com/c/1469183Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#632004}
-
Patrick Noland authored
Bug: 931458 Change-Id: I9d78475075ae8cdb006fceb402b888c7dfd10bf8 Reviewed-on: https://chromium-review.googlesource.com/c/1471335Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#632003}
-
Kurt Horimoto authored
Bug: 931826, 916806 Change-Id: Id48042e7f7c567e3174d9afa6f9fc09b2b85ae31 Reviewed-on: https://chromium-review.googlesource.com/c/1470717Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#632002}
-
Siddhartha authored
The argument filter is required to make sure only whitelisted arguments are present in traces from users. To be able to use Perfetto backend in slow reports in JSON mode, this CL implements argument filtering as it exists in TraceLog. The metadata filtering is done by TracingControllerImpl with both backends. BUG=925148 Change-Id: I65ad53a8ccfea8f721b7fbf4dd7e66969e50fda2 Reviewed-on: https://chromium-review.googlesource.com/c/1464433 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#632001}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd4d1d64..9c2fa40d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I100cc9925a626faa1902246dee02f05b98312234 Reviewed-on: https://chromium-review.googlesource.com/c/1470722Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632000}
-
Pete Williamson authored
The experiment has been at 100% for several milestones now and seems stable. There have not been serious problems reported. To complete the feature, let's remove the feature flag, and then set an end milestone in finch (that will be in a separate changelist). Remove the "Offline pages sharing" flag Bug: 885285 Change-Id: I508e2210233f5678b30120f6ccd4d3e8a420cab0 Reviewed-on: https://chromium-review.googlesource.com/c/1468765Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Peter Williamson <petewil@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#631999}
-
Luciano Pacheco authored
EntryListItme.sortEntries uses the first item to determine the volume it's sorting, when the array to be sorted was empty it was failing. Bug: 904658 Change-Id: I1442d10bd40ddaa246873b135b4e1ddebd5fccf3 Reviewed-on: https://chromium-review.googlesource.com/c/1469815 Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#631998}
-
Robbie McElrath authored
Bug: 931502 Change-Id: I081a32b007d9dad40007b04821548df9ae5c3619 Reviewed-on: https://chromium-review.googlesource.com/c/1471022 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#631997}
-
Katie D authored
Change-Id: I6824e1a3a90ade940b07931ee6d473ee33b6892f Reviewed-on: https://chromium-review.googlesource.com/c/1471029Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#631996}
-
Marcin Wiącek authored
This patch is aligning various @IntDef to some standard used with many other CLs: 1. @IntDef is first, @Retention second and related @interface third 2. NUM_ENTRIES declaring number of entries is not included into @IntDef 3. there is used @Retention(RetentionPolicy.SOURCE) BUG=919666 Change-Id: I0a2e0600e09ec1919b83e7bafc7e4ff6698dfa9d Reviewed-on: https://chromium-review.googlesource.com/c/1461041Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#631995}
-
Ce Chen authored
Add on device head serving component in omnibox, which will be used by on device head suggest provider later. Tested on iPhone (https://photos.app.goo.gl/6T49WV6fxMcbP4Gy7; using https://crrev.com/c/1388125) Bug: 925072 Change-Id: If5b0a3a3402ebd35158c3d319f406db720e42f26 Reviewed-on: https://chromium-review.googlesource.com/c/1452367 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#631994}
-
Sajad Maysam authored
DialogDelegate and BubbleDialogDelegateView default drawing rounded corners during creation of the NonClientFrameView. ExtensionPopups do not draw rounded borders. This prevents the regression of ugly border colors not matching the ClientView. FindBarView border manually updated due to not being a Bubble. Also updated corner radius emphasis metrics in LayoutProvider to match the material design updates. Increased top and bottom margins of PageInfo to prevent corners being drawn over. Bug: 822075 Change-Id: I7fe0a07e4cad7a84fbf54a0dc92e52d36501be9c Reviewed-on: https://chromium-review.googlesource.com/c/1444275 Commit-Queue: Sajad Maysam <sajadm@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#631993}
-
David Benjamin authored
The SimpleURLLoader work mentioned in the bug seems to be done, and the try jobs are passing. Enable it and see what happens? Bug: 140976 Change-Id: Ic85aaa4352801fcc4be21a0d1dc7e1d4ed8df7c7 Reviewed-on: https://chromium-review.googlesource.com/c/1469293 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#631992}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/01a85176b3e4..e67fcf9ed6c6 git log 01a85176b3e4..e67fcf9ed6c6 --date=short --no-merges --format='%ad %ae %s' 2019-02-13 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@e67fcf9ed6c6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7af08581fe8e70fbe983faaab784ee848a0938d2 Reviewed-on: https://chromium-review.googlesource.com/c/1470956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#631991}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Patch is migrating BrowserServices code to @IntDef with form common with other Chrome @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface BUG=919666 Change-Id: I9d725fc0401d3203f133cfb47b1ee76aae45029f Reviewed-on: https://chromium-review.googlesource.com/c/1450130Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#631990}
-
David Bertoni authored
Change-Id: I02623445a38902900fc80f00a98040712cd6b951 Reviewed-on: https://chromium-review.googlesource.com/c/1468164 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#631989}
-
Reid Kleckner authored
This test times out on the clang tot windows debug bots (32 & 64): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTWin%28dbg%29/2360 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTWin64%28dbg%29/2335 TBR=tommi@chromium.org Bug: 902310 Change-Id: I0ac5995fd573ff6505127ce5ef93ea26f4e8f164 Reviewed-on: https://chromium-review.googlesource.com/c/1471302Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#631988}
-
Daniel Rubery authored
The None filter quality uses a nearest-neighbor approach for blurring, which leads to poor representation of the colors within the block. Instead, we use a block mean approach, for consistency with the backend. Also fixes some problems with RGB vs BGR byte ordering which can lead to incorrect colors on the backend. Bug: 922226 Change-Id: I666d29c557d3c86870332394b9838951d04a2d21 Reviewed-on: https://chromium-review.googlesource.com/c/1467462 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#631987}
-
Reid Kleckner authored
It times out on the clang Windows debug bots. TBR=scottchen@chromium.org Bug: 902310 Change-Id: I7687103ddf44a7ef9860c8b8d8d07cf880fae991 Reviewed-on: https://chromium-review.googlesource.com/c/1471228Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#631986}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googletest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature Bug: 925652 Change-Id: Iac0bef29d129c3e48c24d6bff14605f1a116fdd8 Reviewed-on: https://chromium-review.googlesource.com/c/1471372 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#631985}
-
Kent Tamura authored
The new behavior matches to the standard, Firefox, and Safari. Bug: 927626 Change-Id: Ifc6687992c10fbca13faaaeb4a56e59f5469f594 Reviewed-on: https://chromium-review.googlesource.com/c/1469843Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#631984}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/da5e03954dd3..5105d68f93e9 git log da5e03954dd3..5105d68f93e9 --date=short --no-merges --format='%ad %ae %s' 2019-02-13 brianosman@google.com Use half-floats for out-of-gamut color in GrAAFillRRectOp 2019-02-13 nigeltao@google.com Keep scaledHeight calculation across oID calls 2019-02-13 reed@google.com work to fix bookmaker 2019-02-13 jvanverth@google.com Fix drag events in Mac viewer. 2019-02-13 herb@google.com Use SkStrikeSpec to consolidate SkDescriptor, Effects and Typeface. 2019-02-13 mtklein@google.com rewrite SkMasks::CreateMasks to work in bytesPerPixel 2019-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d3fac74a236e..6fc22a13d45d (7 commits) Created with: gclient setdep -r src/third_party/skia@5105d68f93e9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I5dba42616bfa9b108289ee470d58573c5282a927 Reviewed-on: https://chromium-review.googlesource.com/c/1471192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#631983}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6fc22a13d45d..3805122b0297 git log 6fc22a13d45d..3805122b0297 --date=short --no-merges --format='%ad %ae %s' 2019-02-13 syoussefi@chromium.org Revert "Roll Vulkan repos" Created with: gclient setdep -r src/third_party/angle@3805122b0297 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie5bb05a2da1b44ad303b4692bb45957008d7f667 Reviewed-on: https://chromium-review.googlesource.com/c/1471270Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#631982}
-