- 30 Nov, 2018 40 commits
-
-
Sam McNally authored
Bug: 909056 Change-Id: I04b2180f58d86db40e8775015f44158916c7a157 Reviewed-on: https://chromium-review.googlesource.com/c/1351981 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612497}
-
Daniel Rubery authored
Add a field to DownloadFileType that determines the type of content inspection we should do (treating it as a ZIP,DMG,RAR, or none) This allows us to more easily configure which files should be treated as archives. Bug: 628796 Change-Id: I8b02f3be316df23db9593cdda230afef5d825da2 Reviewed-on: https://chromium-review.googlesource.com/c/1352849 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#612496}
-
Alex Moshchuk authored
Currently, SiteInstance::IsSameWebSite() is static and will need to be modified to support dynamic isolated origins. Those origins will apply only to future BrowsingInstances, meaning the answer to IsSameWebSite will depend on which frame/SiteInstance is asking this question. This CL replaces this method with a non-static SiteInstance::IsSameSiteWithURL method. This will ensure that the internal implementation will be able to provide sufficient context (i.e., BrowsingInstance info) in the future, without having to expose that context outside of content/. Note that the content-internal version of this call, SiteInstanceImpl::IsSameWebSite, stays as-is for now. The only two non-test uses of this were in NaCl code. They were checking whether the current SiteInstance's site URL is same-site with the URL of the NaCl file to be loaded, with both URLs expected to be extension URLs. There should be no behavior change in these, as the underlying implementation doesn't change. A few tests are also refactored to either avoid using IsSameWebSite entirely, or, for tests inside content/, to use the internal version of IsSameWebSite. Bug: 905513 Change-Id: Ia2957bb1ec7a16de8c3d18ef167149f1f5a08066 Reviewed-on: https://chromium-review.googlesource.com/c/1352856Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#612495}
-
Sergey Ulanov authored
This will allow to reuse the class in //webrunner when starting context process. Bug: 861853 Change-Id: I499850a7ba8df4b73e5f71b6a61568a5cfca1e6b Reviewed-on: https://chromium-review.googlesource.com/c/1355764Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612494}
-
Katie D authored
In Chrome OS and Android, the TTS platform implementation needs to stay in chrome. Bug: 517317 Change-Id: I09858ce1edc412dd5d0d53abc3fab645fece6a8a Reviewed-on: https://chromium-review.googlesource.com/c/1352055Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#612493}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/74c126845dcd..0de9e8166ee4 git log 74c126845dcd..0de9e8166ee4 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 derat@chromium.org cros_uprevchrome: Fix cross-site CQ-DEPEND links. 2018-11-30 dburger@chromium.org Remove waterfall parameter from InsertBuild method Created with: gclient setdep -r src/third_party/chromite@0de9e8166ee4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ife933160984e095875cdf9a1b41e1ad34a95310c Reviewed-on: https://chromium-review.googlesource.com/c/1355906Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612492}
-
Joey Arhar authored
This is a replacement for the fix made in https://chromium-review.googlesource.com/c/chromium/src/+/1350170 which uses the same-origin mode instead of bypassing service workers in order to make sure changes made by the service worker get into devtools properly. Bug: 823392 Change-Id: I7773a0281d52ebeddc1aa3b9facb7353f7fd1dcc Reviewed-on: https://chromium-review.googlesource.com/c/1353991 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612491}
-
Becca Hughes authored
This is a reland of 0475617f Binary-Size: Adding duplicate classes that will be removed in https://crrev.com/c/1241554 TBR=mlamouri@chromium.org,tedchoc@chromium.org Original change's description: > [Media Session] [2/4] Move Metadata to service > > This CL moves any existing uses in Android of MediaMetadata > to the new version in the media_session service. > > BUG=875004 > > Binary-Size: Adding duplicate classes that will be removed > in https://crrev.com/c/1241554 > > Change-Id: I8ed9afd45a37e515ae89d5d82a542a6f4c139136 > Reviewed-on: https://chromium-review.googlesource.com/c/1241466 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605498} Bug: 875004 Change-Id: I4689ac36b9dcf6b0582d4789016e238811b498e2 Reviewed-on: https://chromium-review.googlesource.com/c/1318809Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#612490}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ee85992c5c61..63d69d7792c1 git log ee85992c5c61..63d69d7792c1 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 charliea@chromium.org Fix bug where disabling stories on N5 also disabled them on N5X Created with: gclient setdep -r src/third_party/catapult@63d69d7792c1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:894906 TBR=sullivan@chromium.org Change-Id: I82daa446bb0740864fe1e0e433c9c72e680ddb28 Reviewed-on: https://chromium-review.googlesource.com/c/1355560Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612489}
-
Clark DuVall authored
These mostly fall into two categories: 1. tests trying to crash network service 2. tests using NetworkServiceTest (which isn't available with in-process NS) Bug: 908993 Change-Id: I91d518b260f79ef263a58fb2a3a24e28e7c96210 Reviewed-on: https://chromium-review.googlesource.com/c/1355615Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612488}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I98dc447ef5c8a58fc2e8256586d2dbb32cd88f70 Reviewed-on: https://chromium-review.googlesource.com/c/1355905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612487}
-
Scott Little authored
This CL records VisibleBeforeLoaded histograms when lazily loaded images become visible before they've finished loading. This metric is useful to look at alongside the existing VisibleLoadTime metrics, since the VisibleLoadTime metrics aren't recorded until the image finishes loading, which can lead to misleading data if the user navigates away or closes the tab before the image finishes loading, particularly on slow networks. TBR=mpearson@chromium.org Bug: 910347 Change-Id: I349eb69d173420ada94e3febeaeb4e369c998e07 Reviewed-on: https://chromium-review.googlesource.com/c/1356009 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#612486}
-
Peter Kotwicz authored
This CL makes FirstRunFlowSequencer#launch() shorter by extracting the logic to check whether the generic FRE is active into a separate function checkIsGenericFreActive(). This CL also changes maybeSwitchToTabbedMode() to only return whether the FRE should use tabbed mode and to not modify the FRE launch intent. This CL is in preparation to adding WebAPK-related complexity to FirstRunFlowSequencer#launch() BUG=None Change-Id: If3605de61905edde800129f2d5e36c572432566f Reviewed-on: https://chromium-review.googlesource.com/c/1355327 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#612485}
-
Giovanni Ortuño Urquidi authored
This reverts commit d20781e1. Reason for revert: Causes compile failure in Google Chrome ChromeOS https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59164 In file included from ../../chromeos/services/assistant/assistant_manager_service_impl.cc:5: ../../chromeos/services/assistant/assistant_manager_service_impl.h:142:31: error: no type named 'AndroidAppInfo' in namespace 'chromeos::assistant::action'; did you mean 'mojom::AndroidAppInfo'? void OnOpenAndroidApp(const action::AndroidAppInfo& app_info, ^~~~~~~~~~~~~~~~~~~~~~ mojom::AndroidAppInfo gen/chromeos/services/assistant/public/mojom/assistant.mojom.h:1276:8: note: 'mojom::AndroidAppInfo' declared here class AndroidAppInfo { ^ Original change's description: > Handle Open/Verify android apps for Assistant > > Bug: b/117793081 > Test: Manual Test > Change-Id: If747d3317cb163715ff907839203e0c0eee57a1c > Reviewed-on: https://chromium-review.googlesource.com/c/1352341 > Commit-Queue: Yue Li <updowndota@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612448} TBR=sammc@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org,llin@chromium.org Change-Id: If0edc6853dfdce343f6f52edd6bc059f8c7ec1aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/117793081 Reviewed-on: https://chromium-review.googlesource.com/c/1356164Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612484}
-
agrieve authored
This reverts commit 8dc97871. Reason for revert: Broke compile for android-rel https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928477879975314896/+/steps/compile/0/stdout Original change's description: > Android: Using R8 instead of ProGuard for public targets > > Bug: 908988 > Change-Id: Iaaee8124c56945a8769e6d4ff2a0859ef39c1aea > Reviewed-on: https://chromium-review.googlesource.com/c/1355424 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612439} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I6cdf8fd95b254abe733426f9e38aa1446661f9e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908988 Reviewed-on: https://chromium-review.googlesource.com/c/1356229Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612483}
-
Varun Khaneja authored
R=drubery Bug: 867518,890484, 887186 Change-Id: I1e5a8c342deef6737f6c69d99ede839028d9aae9 Reviewed-on: https://chromium-review.googlesource.com/c/1356124 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612482}
-
Paul Irish authored
Bug: 772558 Change-Id: Ie1ef89f7a189687e600e5e22d376c53dac242079 Reviewed-on: https://chromium-review.googlesource.com/c/1355176Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#612481}
-
Sam McNally authored
Bug: 909056 Change-Id: I70453c9a11b2d2cab1fa0355647b333508ba700c Reviewed-on: https://chromium-review.googlesource.com/c/1351982 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612480}
-
chcunningham authored
Adds flags for configuring the size of the rolling window and the number of days to keep stats before expiring. Bug: 910404 Test: new unit tests Change-Id: I8a88a81154c710a1cc9b029e2b8ef8af61d945e0 Reviewed-on: https://chromium-review.googlesource.com/c/1355996Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#612479}
-
Alan Cutter authored
This reverts commit 6d4576ad. Reason for revert: On second thought this is too risky to land on branch day. Also I want to land the new binary separately from the shortcuts pointing to it so we can make sure it deploys properly before irreversibly depending on it (it's difficult to update shortcuts). Original change's description: > Add chrome_proxy.exe target for bookmark app shortcuts to target on Windows > > This change adds a new executable to Windows called chrome_proxy.exe which > opens chrome.exe with all arguments forwarded. > > The purpose of the executable is for bookmark app shortcuts to target so > they don't pick up the chrome.VisualElementsManifest.xml file when pinned > to the Windows 10 start menu. This fixes a bug where pinned bookmark app > shortcuts all use the Chrome logo instead of their own. > > Bug: 732357 > Change-Id: I6f4385219329e6d6e446053fc1325082ce4328c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1335075 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612477} TBR=thestig@chromium.org,alancutter@chromium.org,mgiuca@chromium.org,grt@chromium.org Change-Id: If327a489864c0bd6066ec13b3f9421f3be57636b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732357 Reviewed-on: https://chromium-review.googlesource.com/c/1356163Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#612478}
-
Alan Cutter authored
This change adds a new executable to Windows called chrome_proxy.exe which opens chrome.exe with all arguments forwarded. The purpose of the executable is for bookmark app shortcuts to target so they don't pick up the chrome.VisualElementsManifest.xml file when pinned to the Windows 10 start menu. This fixes a bug where pinned bookmark app shortcuts all use the Chrome logo instead of their own. Bug: 732357 Change-Id: I6f4385219329e6d6e446053fc1325082ce4328c6 Reviewed-on: https://chromium-review.googlesource.com/c/1335075Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#612477}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/471358f39a6a..b51eb09fb5bb git log 471358f39a6a..b51eb09fb5bb --date=short --no-merges --format='%ad %ae %s' 2018-11-29 syoussefi@chromium.org Vulkan: Allow bindings to compute stage 2018-11-29 syoussefi@chromium.org Vulkan: Uber-shader generated code optimization 2018-11-29 jmadill@chromium.org Pass Context to setLabel. 2018-11-29 jmadill@chromium.org Clear draw attachments as a dirty object. 2018-11-29 cnorthrop@google.com Add temporary icon for ANGLE apk 2018-11-29 jmadill@chromium.org Use packed enum for DrawElementsType. Created with: gclient setdep -r src/third_party/angle@b51eb09fb5bb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I939db58664276d98db325bcfbe51cc161b43a941 Reviewed-on: https://chromium-review.googlesource.com/c/1356000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612476}
-
sczs authored
After the recent Infobar refactoring I think I have enough knowledge to become an Infobar owner. This will also help on the implementation of the new design. Doc: go/bling-infobar-refactoring CLs: https://crbug.com/892376 Bug: 892376 Change-Id: Idaf4bc27e8ab2f490ad5d93268331616a35a0b71 Reviewed-on: https://chromium-review.googlesource.com/c/1354560Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#612475}
-
Andreas Butler authored
Implementing an explicit commit function for the IndexedDB Transaction API. The addition of this API allows developers to preempt IndexedDB's autocommit functionality by sending their own explicit commit signal. Explainer: https://andreas-butler.github.io/idb-transaction-commit/EXPLAINER Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=898257 Change-Id: I5e8bdc697052139d014757408d9a7f2b6367655b Reviewed-on: https://chromium-review.googlesource.com/c/1300055 Commit-Queue: Andreas Butler <andreasbutler@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#612474}
-
Hwanseung Lee authored
DOMMatrix should be alias to SVGMatrix. (It was not implement in blink yet) SVGMatrix have scaleNonUniform() function. but DOMMatrix was not. there are some website which is used SVGMatrix.scaleNonUniform(). it would be possible brake some website when DOMMatrix be alias to SVGMatrix. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BJJKDby5p7w Bug: 905921 Change-Id: Ic09b8d6e46d0aa822b766bd6cfbc5ce7c2164849 Reviewed-on: https://chromium-review.googlesource.com/c/1341279 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#612473}
-
Scott Violet authored
Ash's MultiUserWindowManagerBridge now creates ash::MultiUserWindowManager in multi-process mode. BUG=875111 TEST=covered by tests Change-Id: I9702b18b453ae4cdde5aad4a8774e2c510e4e9f1 Reviewed-on: https://chromium-review.googlesource.com/c/1355484 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#612472}
-
Sunny Sachanandani authored
Two fixes: 1) Create a weak ptr on main thread before use to prevent data race on calling GetWeakPtr() from multiple threads. 2) Ensure sync token release callback is called on main thread so that the weak ptr is not dereferenced on another thread. Sync tokens aren't released on any other thread today, but that might change with ChromeOS image decode accelerator work, and using WaitNonThreadSafe() will not post a task if on the same thread anyway. Bug: 908669 Change-Id: I0bd9e0d56fe94c750513bc792e9e632bb83b30b9 Reviewed-on: https://chromium-review.googlesource.com/c/1352858 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612471}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5a88d16b87f5..f737d4bdb38d git log 5a88d16b87f5..f737d4bdb38d --date=short --no-merges --format='%ad %ae %s' 2018-11-29 tsepez@chromium.org Squeeze some 0s out of barcode name strings. 2018-11-29 tsepez@chromium.org Tidy string hash implementation. Created with: gclient setdep -r src/third_party/pdfium@f737d4bdb38d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I830cf3d40aa4d7a55e80c636064beea4b9667560 Reviewed-on: https://chromium-review.googlesource.com/c/1355370Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612470}
-
CJ DiMeglio authored
This is a reland of cf071719 Original change's description: > [Accessibility] Volume slider reads out level in percentages. > > This CL makes it such that the volume level is read out as a percentage > in aria. This CL also amplifies how the accessibility information is > given to aria, by setting attributes instead of explicitly creating > accessibility nodes. > > Bug: 905024 > Change-Id: I0ee5a91215669f39c7394d3c8f113ae83a74cf00 > Reviewed-on: https://chromium-review.googlesource.com/c/1337298 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612160} TBR=mlamouri@chromium.org, dmazzoni@chromium.org, thakis@chromium.org Bug: 905024 Change-Id: Ie35c05c274dfd36f3e9ec0a32b587a98a62249d9 Reviewed-on: https://chromium-review.googlesource.com/c/1356007Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#612469}
-
Sam McNally authored
Bug: 909056 Change-Id: I9b8c0f4a6aaa04d601c50a76311b9a44d2138ff0 Reviewed-on: https://chromium-review.googlesource.com/c/1351985Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612468}
-
Vlad Tsyrklevich authored
Currently, GetErrorType() sanity checks that a crash never happens when accessing an allocated page; however, while testing locally I was able to trigger this DCHECK very infrequently. Replace it with a LOG and return kUnknown instead to be safe. Change-Id: I2a970ac4ff22b88155598988a4ce23aada542b36 Reviewed-on: https://chromium-review.googlesource.com/c/1354652 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#612467}
-
Darren Shen authored
The docs is wrong: the callback that setContainerBehavior takes also takes a bool indicating success (see [1]). [1] https://cs.chromium.org/chromium/src/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc?type=cs&g=0&l=135 Bug: 902232 Change-Id: Ieead5072d7ab13c2b1cac1a8042b143fdd01eebb Reviewed-on: https://chromium-review.googlesource.com/c/1354738Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#612466}
-
Sunny Sachanandani authored
We got 1 crash dump for NV12 and 3 for YUY2 all of which are due to OOM. NV12 failures in UMA seem to be from older clients before the fix for odd dimensions went in. Filtering UMA to recent versions shows that there are no NV12 swap chain creation failures. Also change default swap chain format to NV12 when overlays are enabled using command line flags. Bug: 869677 Change-Id: If847f1d0a6121df27445b99e3bcb62290b3ed5df Reviewed-on: https://chromium-review.googlesource.com/c/1355616Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#612465}
-
Meilin Wang authored
Add a new UMA histograms metrics to record the Assistant query response type (e.g., new browser tab, inline element). Test: local compile and manually test. Change-Id: Ibc8c8e28f1880bc1c748b5c151ab7d6e3ae58cb8 Reviewed-on: https://chromium-review.googlesource.com/c/1318733 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612464}
-
Sky Malice authored
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1345422, doing a couple of things. 1. Removing the destroy warning comment, as all bridges will need to follow this pattern indefinitely. It is not a temporary comment, and adds significant bulk to any bridge that may become out of sync over time. 2. Call consumers/callbacks immediately with error, null, or default responses. This allows the Feed to take reasonable responses and not hang during shutdown. 3. Fix mistake in scheduler check that was backwards, causing the scheduler to think it perpetually had an outstanding request. Bug: 901414 Change-Id: Ied653541755d5fb1b204c4968e755364cdcece81 Reviewed-on: https://chromium-review.googlesource.com/c/1355614Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#612463}
-
Dave Tapuska authored
Fix a few last truncation errors. BUG=879657 Change-Id: I75339fe7a46efa336bdaa91c73c21a5c673b32f3 Reviewed-on: https://chromium-review.googlesource.com/c/1355856Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#612462}
-
Sergey Ulanov authored
FuchsiaVideoDecoder was calling DecodeCB synchronously in Decode(). DecoderStream doesn't expect this, so it was failing a DCHECK. Bug: 909018 Change-Id: Ibf445447b3875ae76ff5d69a5ba9af174836a21b Reviewed-on: https://chromium-review.googlesource.com/c/1351647Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612461}
-
Dale Curtis authored
This is part 3/4 CLs to move the <audio>/<video> elements off of a synchronous API that can lead to renderer hangs and premature audio renderer errors. This moves the AudioRendererSinkCache from AudioRendererMixerManger to a base::NoDestructor instance in AudioDeviceFactory and stops ARMM from using the cache at all. The users remaining are WebAudio and WebRTC, we can reevaluate metrics on keeping it after. Due to base::(SingleThread|Sequenced)TaskRunner::Get() being deprecated for content/ I've had to switch to use base::PostTask to generate a cleanup task runner. Unfortunately this doesn't guarantee that it runs on the render thread, but since we're now using a static instance, we can just always use base::Unretained and drop the WeakPtr factory that was handling the cancellation of these tasks. There's no point in the cache for ARMM since we're going to require a sink to get a mixer. That sink will always be used to get output device info first too and then reused for the mixer. BUG=905506 TEST=updated tests, compiles. R=olka Change-Id: I03408753f974e4c6fb9c89270508e26689162002 Reviewed-on: https://chromium-review.googlesource.com/c/1347730 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#612460}
-
Jazz Xu authored
Fix two problems: 1. While focused, mouse move in and move out, control won't hide. 2. While focused, mouse move in and stay, control won't hide after 3 seconds. Bug: 909087 Change-Id: I4a2c009758e36fd7f3cec5dd9f8042773cc6d454 Reviewed-on: https://chromium-review.googlesource.com/c/1354573Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612459}
-
Quinten Yearsley authored
I just realized I had asked back in May whether anyone still uses legacy-results.html, and nobody replied, so I think it's now safe to remove this. Context: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9NFDSTEzcd4 Bug: 748628 Change-Id: I21e7d7451f3fa2e421daeb08e50a446e1e0a3253 Reviewed-on: https://chromium-review.googlesource.com/c/1355480 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612458}
-