- 07 Jun, 2018 40 commits
-
-
Ben Pastene authored
This reverts commit 43bebb1d. Reason for revert: suspected to have broken analyze on android CQ bot https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel?limit=200 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-kitkat-arm-rel/6471 ERROR at //components/browser_sync/profile_sync_test_util.cc:27:11: Include not allowed. #include "services/network/test/test_url_loader_factory.h" Original change's description: > Migate SyncStoppedReporter to SimpleURLLoader > > Bug: 844966 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I3c198d95735770668eed4a1342a3979224239529 > Reviewed-on: https://chromium-review.googlesource.com/1089132 > Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565321} TBR=sky@chromium.org,mmenke@chromium.org,pilgrim@chromium.org,mastiz@chromium.org Change-Id: Iaf73cd80c169fc9451d82c42f807685258d3b09f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844966 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1091306Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#565362}
-
Kevin McNee authored
This reverts commit c7c852a5. Reason for revert: This did not revert cleanly. generate_build_files is failing e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-gcc-rel/12779 Original change's description: > Revert "S13n: Port components/image_fetcher to SimpleURLLoader." > > This reverts commit d6f27e51. > > Reason for revert: image_fetcher is used from more than UI thread, > and SharedURLLoaderFactory isn't cross-thread. > > Note that this isn't a 100% mechanical revert since it needed a merge > with some ImageDataFetcher cleanups; I also kept in some iOS glue bits > that are used in a pending CL and aren't directly related to the substance > of the revert. > > Bug: 850089 > > Original change's description: > > S13n: Port components/image_fetcher to SimpleURLLoader. > > > > URLFetcher will stop working in the browser process with advent > > of Network Service, and SimpleURLLoader is the replacement API > > for most clients. > > > > Bug: 843205 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I23f22f2b00e4ece0ca85d0bad95909cd15309eb6 > > Reviewed-on: https://chromium-review.googlesource.com/1060254 > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#564526} > > TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 843205 > Change-Id: Ifeb0c24a9e83bf271be3f10cb32f6d81ea0d0832 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1090930 > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565348} TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org Change-Id: Iee4b628c585b7f3f4509f4dc0c691a012d31c874 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850089, 843205 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1091305Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#565361}
-
Nico Weber authored
It already runs on the regular linux main waterfall and memory bots. TBR=hans Bug: 843511 Change-Id: I3f5f97694291f4143614fb2b72344dda31cf1556 Reviewed-on: https://chromium-review.googlesource.com/1091141Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#565360}
-
Toni Barzic authored
BUG=NONE Change-Id: I6130bcff05d90ad35b3106eeee6d8973c58b8c11 Reviewed-on: https://chromium-review.googlesource.com/1090311Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#565359}
-
Florin Malita authored
https://github.com/w3c/csswg-drafts/issues/2714 clarified that serialization should always use the expanded form. Bug: 850537 Change-Id: I77e60df149fb490b0c2c1db78f020a7246ea7b5c Reviewed-on: https://chromium-review.googlesource.com/1090820Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#565358}
-
Ben Pastene authored
We collect logs from the VM after tests. The problem is, if the test hangs indefinitely, we won't get a chance to grab the logs before swarming kills us when we reach the timeout. Swarming sends a SIGTERM, waits for grace_period, then SIGKILLs the task if it's still running. This CL will catch the SIGTERM and kill what should be the frozen test process. This will let cros_run_vm_test pull the logs before we get SIGKILLed. Bug: 848402 Change-Id: I48be1de865e3b287584978b5461f15e2bae49dfd Reviewed-on: https://chromium-review.googlesource.com/1087800 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#565357}
-
Jonathon Kereliuk authored
This CL renames the send_command_and_get_result endpoint to /goog/cdp/execute which follows the extension specification format and is a more appropriate API name. Note we still support the old name. Bug: chromedriver:2307 Change-Id: Ia7a389781eb92a2cf9bd6244e766e6c32e9b5ab9 Reviewed-on: https://chromium-review.googlesource.com/1091216Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#565356}
-
Matt Wolenetz authored
Since these two flags should map 1:1 to each other, this change removes the former in favor of the latter, which is reachable from SourceBufferState even before OnSourceInitDone has occurred. It also notes a pre-existing spec incompliance with newly filed crbug 850316. BUG=607372,850316 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I83d10db6b7c367615f5b968447dbdb415aee5cb7 Reviewed-on: https://chromium-review.googlesource.com/1089494Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565355}
-
Aga Wronska authored
Bug: 827376 Test: Run WizardControllerDemoSetupTest Change-Id: I84525ecf4b370fac104aba99e8da04eaf32342de Reviewed-on: https://chromium-review.googlesource.com/1088127Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#565354}
-
vitaliii authored
Connect ConsentSyncBridge to ConsentAuditor behind a feature on all platforms except iOS. ConsentAuditor does not use the bridge at all yet. This CL is a part of a series to split user consents from user events into a separate datatype. Bug: 840357 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id23914d4afcf105f21dab856208d98979aa82209 Reviewed-on: https://chromium-review.googlesource.com/1084475 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Benoit Zanotti <bzanotti@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565353}
-
Tessa Nijssen authored
Toolkit-views menus positioned with POSITION_BEST_FIT are be positioned to the side of the anchor when the menu height is greater than ~50% of the screen. Currently in this situation, the "actual" position of the menu is incorrectly recorded as POSITION_BELOW_BOUNDS. If a menu delegate invokes MenuChildrenChanged() and recalculates the menu bounds, this can cause the menu to reposition itself under the anchor rather than remaining to the side. To fix, record the "actual" position as POSITION_BEST_FIT in this situation. Bug: 840919 Change-Id: I4102e014c058b2f89d5bc38b7b4371c010367119 Reviewed-on: https://chromium-review.googlesource.com/1087516 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#565352}
-
Dmitry Gozman authored
Added a helper to ChromeDevToolsManagerDelegate and DevToolsWindow to check whether inspection is allowed. This helper is used to: - not open DevToolsWindow; - not show "Inspect Element" context menu item; - disable DevTools-related browser commands; - not show inspectable views on chrome://extensions; - not show extensions on chrome://inspect. RenderFrameDevToolsAgentHost also disallows attaching a debugging session when embedder says so to prevent exposure over protocol or remote debugging. Bug: 838146 Test: browser_tests --gtest_filter=DevToolsSanity*Policy* Change-Id: I59f255cc89919f2568170f4854955ba95eadae7f Reviewed-on: https://chromium-review.googlesource.com/1069411Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565351}
-
Christopher Thompson authored
This lets the #ExperimentalUi flag control showing only the lock icon for SECURE (non-EV) sites. Change-Id: I8e807ada60c2e8ccbd9fb560f2148e87f863d74c Reviewed-on: https://chromium-review.googlesource.com/1080238 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#565350}
-
Elly Fong-Jones authored
These tests are hitting some corner case of MacViews fullscreen. TBR=sky@chromium.org Bug: 850594 Change-Id: I7ee54c3d1076ef29007c89ff573013a0514ace1a Reviewed-on: https://chromium-review.googlesource.com/1091136Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565349}
-
Maks Orlovich authored
This reverts commit d6f27e51. Reason for revert: image_fetcher is used from more than UI thread, and SharedURLLoaderFactory isn't cross-thread. Note that this isn't a 100% mechanical revert since it needed a merge with some ImageDataFetcher cleanups; I also kept in some iOS glue bits that are used in a pending CL and aren't directly related to the substance of the revert. Bug: 850089 Original change's description: > S13n: Port components/image_fetcher to SimpleURLLoader. > > URLFetcher will stop working in the browser process with advent > of Network Service, and SimpleURLLoader is the replacement API > for most clients. > > Bug: 843205 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I23f22f2b00e4ece0ca85d0bad95909cd15309eb6 > Reviewed-on: https://chromium-review.googlesource.com/1060254 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564526} TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843205 Change-Id: Ifeb0c24a9e83bf271be3f10cb32f6d81ea0d0832 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1090930 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#565348}
-
Iker Jamardo authored
Adds a new XRSessionRequest structure to be passed when the RequestSession call is made to be able to pass information like user gesture. The RequestSession now requests camera permission in ARCoreDevice. The code to ask for camera permission has been copied and adapted from src/chrome/browser/media/webrtc/media_stream_devices_controller.cc and a re-check for the Android OS level camera permission is still needed. Bug: 835037, 845160, 775372 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Iecabc3927beb6106a1ada5289f3af3ecffd48ed8 Reviewed-on: https://chromium-review.googlesource.com/1055677 Commit-Queue: Iker Jamardo <ijamardo@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#565347}
-
Xida Chen authored
It is not obvious why we need to account for effective_zoom_ for the shadows in the CSS Paint API, but not for line width. This CL adds some comments to ensure the knowledge won't be lost. Bug: None Change-Id: Ibc5086449a929af0d7877874aaec482a2487ab92 Reviewed-on: https://chromium-review.googlesource.com/1090791 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#565346}
-
glevin authored
As per crbug.com/788014 Comment 1 (and previous dlgs): - Change button text "OK" -> "Continue" - Remove X (Close) button from upper right Bug: 788014 Test: Cast to a screen while multi-logged in. Try switching profiles. Try to spot the Harmony. Change-Id: Icdb122f100d6f0b00129da7534150b7314a17686 Reviewed-on: https://chromium-review.googlesource.com/1065021Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
sebsg authored
Some forms have multiple sequential fields predicted as being the whole street address. We should rationalize those to a set of address lines 1, 2 and possibly 3 depending on the situation. Bug: 835975 Change-Id: I75b2fa891a9ca3006066df6ba418f3475ffe01b8 Reviewed-on: https://chromium-review.googlesource.com/1089804 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#565344}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/18562b8..faef514 git log 18562b8..faef514 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 kjlubick@google.com More libfuzzer cleanups from GPU switchover 2018-06-07 caryclark@skia.org generate SkColor include 2018-06-07 mtklein@chromium.org clean up some unused parts of SkArenaAlloc 2018-06-07 jvanverth@google.com Add test of tiny text with perspective. Created with: gclient setdep -r src/third_party/skia@faef514 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Iccd1d42777c1d4040b520f6e8fc0451b86ba72a4 Reviewed-on: https://chromium-review.googlesource.com/1090762Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565343}
-
Nico Weber authored
Enables these tests on the linux memory bots: filesystem_service_unittests leveldb_service_unittests traffic_annotation_auditor_unittests They already run on the regular main waterfall linux bots and on the clang tot bots. Bug: 843511 Change-Id: Ie0f1b5ea6433c2f21f87df993ac205f4553ced89 Reviewed-on: https://chromium-review.googlesource.com/1091070 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565342}
-
Varun Khaneja authored
The tests check whether we can parse the file properly, identify if the .rar file contains other archives, or executables, etc. Bug: 750327 Change-Id: I71f75521a186115d8ba2c7f2983dfb4abdbbbe1a Reviewed-on: https://chromium-review.googlesource.com/1089853Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#565341}
-
Nico Weber authored
They run on the main waterfall, so they should run on the clang/tot bots as well. Bug: 843511 Change-Id: I6fe7256c741d224c090fb38074fe98ff07353149 Reviewed-on: https://chromium-review.googlesource.com/1091071 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
glevin authored
Note that there are 3 app dialogs here generated by the same code: one for uninstalling, one for USB list permission, and one for USB access permission. As per crbug.com/788010 Comment 1 (and previous dlgs): - Allow text to run to right edge of dialog (minus margin) - Remove X (Close) button from upper right - Width = 448px Bug: 788010 Test: Try to uninstall an ARC++ app, or use one to access USB devices. OMG Harmony! Change-Id: I6ffe099ba9f4fe3fae7cd3b6f203873000dd62e8 Reviewed-on: https://chromium-review.googlesource.com/1066450 Commit-Queue: Greg Levin <glevin@chromium.org> Reviewed-by:
-
James Cook authored
They seem to pass now in mash_browser_tests (--enable-features=Mash) Bug: 723880 Change-Id: If1695c2b175dd72188c32233ae016aeef1d9636a Reviewed-on: https://chromium-review.googlesource.com/1091115Reviewed-by:
-
Daniele Castagna authored
blink::VideoFrameSubmitter produces quads using VideoFrameResourceProvider.VideoFrameSubmitter, that produces at most one quad. This CL DCHECKs that at most one quad is produced, since we want to use this property for optimizing damage tracking in SurfaceAggregator/GLRenderer. Having the guarantee that only one quad will be produced for this CompositorFrame will allow us to mark the video as the only quad producing damage in SurfaceAggregator. In this way GLRenderer will be able to promote to HW overlay the quad for the video and completely skip compositing of the remaining quads. This will result in significant power savings. Bug: 795008, b/80061773 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic4c612c5c221366bd67039d937dc0e42104b4c56 Reviewed-on: https://chromium-review.googlesource.com/1083977Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#565337}
-
Tiger Oakes authored
D8 is the new default dexer in Android Studio. We're replacing DX with D8. This improves the APK size by removing 30 KB. Bug: 842681 Change-Id: Ic0d310f615d6aad44a55a2ab5f56ef40288df53f Reviewed-on: https://chromium-review.googlesource.com/1079373 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#565336}
-
Robbie McElrath authored
I've made several sensor changes since this test was disabled that should fix the flakiness. Bug: 846920 Change-Id: Ibe38cad96acd7d5636f89d0eb8a6d915ab6798a0 Reviewed-on: https://chromium-review.googlesource.com/1089712 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#565335}
-
Nico Weber authored
It runs without issues on the clang tot linux bots, and on the main waterfall cros bots already. Bug: 843511 Change-Id: I9b0fa22cbb5adc146d7d6a72e12c177eb92b0179 Reviewed-on: https://chromium-review.googlesource.com/1090821Reviewed-by:
-
Theresa authored
BUG=841928 Change-Id: I3ca67c780818d360d93830c0507734edba401a6e Reviewed-on: https://chromium-review.googlesource.com/1089993Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#565333}
-
Chris Hamilton authored
These helpers are intended for use with WebContents hosted in tabs, but are occasionally used outside of that context. This simple fix stops the helper from exploding in that case. BUG=849796 Change-Id: I85caef9cd397eec5fd77b8ad16bdcc9d6f3adbbd Reviewed-on: https://chromium-review.googlesource.com/1089294Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#565332}
-
Chris Nardi authored
word-wrap was previously defined as its own property in CSSProperties.json5, but with the same behavior as overflow-wrap. However, this meant that word-wrap showed up alongside word-wrap in cssText. This patch converts word-wrap to be an alias of overflow-wrap, as this will prevent the issue of both properties showing up in cssText and matches the resolution in https://github.com/w3c/csswg-drafts/issues/866. Bug: 679068 Change-Id: I3d415eb1cde9a92dffa2a045ba5fa8b015eeb2d7 Reviewed-on: https://chromium-review.googlesource.com/1073677Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565331}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a02c34c..1331d4b git log a02c34c..1331d4b --date=short --no-merges --format='%ad %ae %s' 2018-06-07 perezju@chromium.org [soundwave] Make RequestError pickleable Created with: gclient setdep -r src/third_party/catapult@1331d4b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib3e40358a70293053b294c6e588657c83b6ba1e9 Reviewed-on: https://chromium-review.googlesource.com/1091030Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565330}
-
David 'Digit' Turner authored
Nothin too sexy here, but making small improvements to the code base for long term maintainer happiness, and upcoming CLs that will perform more deep cleanup work. - Adding missing const qualifiers to some LibraryView methods. Note that making LookupSymbol() also const requires more changes that are better left to another CL. Noted with TODO. - Make crazy::SearchResult declaration public by moving it to crazy_linker_util.h - Use a VectorBase non-template class that all Vector<> templates inherit from, in order to reduce the amount of generated code for vectors. - Replace Vector::IndexOf() with Vector::Find() which returns a SearchResult value. Gets rid of pesky 'int' indices for InsertAt / RemoveAt method. - Support ranged-based for loops with begin() / end() declarations. And adjust all callers to use them when that makes sense. Cleaner code. Yeah. BUG=NONE R=lizeb@chromium.org, agrieve@chromium.org, pasko@chromium.org, rmcilroy@chromium.org android: crazy-linker: Small Vector<> optimization. Change-Id: If4d22b85fdd44885159a2bb27626f2942ccb437e Reviewed-on: https://chromium-review.googlesource.com/1090840 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#565329}
-
Chris Blume authored
Recently, Skia changed its Vulkan code. This ended up breaking Chrome when building with Vulkan support. This patch fixes the Chrome build with Vulkan. BUG=850342 Change-Id: Ibd12791bca6b06d1124e6014766ed2958bea59c1 Reviewed-on: https://chromium-review.googlesource.com/1089817Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#565328}
-
John Z Wu authored
Cards from Google Pay will require special handling. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia05ff0f31518272a6aaafc6392e730123d805d4a Reviewed-on: https://chromium-review.googlesource.com/1089581 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#565327}
-
Koji Ishii authored
This patch changes RunInfo::CreateSubRun() to copy the entire array, then modify character_index. LayoutNG uses CreateSubRun heavily, with much longer ShapeResult than the current layout engine, and this function turned out to be hot. perf_tests/layout/word-break-break-all.html gets ~10% faster, ~700ms to ~630ms. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I869d1b90b1afe5cd84ad3b809ce8453f1f8feba4 Reviewed-on: https://chromium-review.googlesource.com/1088527 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#565326}
-
Olga Sharonova authored
To run Audio service out of process on bots. Bug: 832666 Change-Id: I226ee0c9ce8e6adccb11c02dc2c3e13fead9886d Reviewed-on: https://chromium-review.googlesource.com/1065911Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#565325}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2b719243. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19162 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI TBR=foolip No-Export: true Change-Id: I2c9b4ca003b6a0044ac8f5d4aee7c10411ae59c8 Reviewed-on: https://chromium-review.googlesource.com/1090796 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#565324}
-
Hayato Ito authored
If we don't clear slot's assigned nodes when detaching a slot, if the slot assignment recalc flag is dirty (the actual condition is more complex, see the code), *cycle* would happen in detaching (after attaching a slot again) because a series of DOM mutations can create a tree of trees as such: - one of the slot's formerly assigned node, call it |A|, is a shadow-including ancestor of the slot. - |A| is already attached. In this case, detaching the slot will try to lazy-reattach |A|, and lazy-reattaching |A| doesn't return early (because |A| doesn't need Attach). As a result, detaching the slot *cycles* and causes an infinite loop (... -> |A| -> .. -> host -> shadow root -> .. -> slot -> |A| -> ...). See the test (or bug 849599) for a concrete example. Bug: 849599 Change-Id: I1c1ddb06ca9777af0052260aa721c2438da3c62b Reviewed-on: https://chromium-review.googlesource.com/1090420Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
-
