- 25 Apr, 2018 40 commits
-
-
https://webrtc.googlesource.com/src.git/+log/a945aee72e4e..09408115cda7 $ git log a945aee72..09408115c --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia0b06d701ad86f290ac3a3bee1140c4d6c6e2af6 Reviewed-on: https://chromium-review.googlesource.com/1027991Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553536}
-
John Abd-El-Malek authored
I forgot to update the filter in that fix. TBR=leon.han@intel.com NOTRY=true Bug: 729848 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I50456a8a863277c06d054a7ba9a5f5834be5057c Reviewed-on: https://chromium-review.googlesource.com/1027993 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#553535}
-
https://skia.googlesource.com/skia.git/+log/9f63153a03c7..e1c37a7b8f21 $ git log 9f63153a0..e1c37a7b8 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 benjaminwagner [infra] Add image dimension for Win GCE bots Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Iae673561a38863a7b1caa17177e950bc9fe43879 Reviewed-on: https://chromium-review.googlesource.com/1027443 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553534}
-
Mark Pilgrim authored
Bug: 773295 Change-Id: I9cc62ea0aaf4eab4639c68b3d76ec82e17ab0e3c Reviewed-on: https://chromium-review.googlesource.com/1024077Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#553533}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=mkwst@chromium.org Bug: 825327 Change-Id: Ic19845b885a4527fbdf5acb2e41a4b75153a1998 Reviewed-on: https://chromium-review.googlesource.com/1024395Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553532}
-
John Abd-El-Malek authored
Bug: 729848 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7bafe16cda83030209f357340c6503154e9b55cf Reviewed-on: https://chromium-review.googlesource.com/1027121Reviewed-by:
-
John Abd-El-Malek authored
Bug: 729848 Change-Id: Ic1fc3f01184585c79f75cd060d4ce94226affb29 Reviewed-on: https://chromium-review.googlesource.com/1027205Reviewed-by:
Han Leon <leon.han@intel.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#553530}
-
Charlie Harrison authored
In general, features should not be changed in the test body. My guess is that InitFromCommandLine is clobbering all features in a non-safe way. This CL stops all feature setting in all test bodies in favor of just using test subclasses. Bug: 836215 Change-Id: I4ffb6f9d16f87359ed1d9df9966faa345f4a72a3 Reviewed-on: https://chromium-review.googlesource.com/1025640Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#553529}
-
Fady Samuel authored
WasResized is a misnomer. This is one of many CLs to change the language in a post-surface-sync world. Change-Id: I546e914e98e9746894a9dae7b1bf65a894cb6fe7 Bug: 836367, 672962 Reviewed-on: https://chromium-review.googlesource.com/1026468 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#553528}
-
Elly Fong-Jones authored
TBR=jbudorick@chromium.org Bug: 828031 Change-Id: I40fbb54ee6399ff5a30e7d65a77d786648dcb83d Reviewed-on: https://chromium-review.googlesource.com/1027894Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#553527}
-
Yutaka Hirano authored
...in order to make the logic work after frame detach. This CL also removes Resource::SetDetachable which is no longer needed. Bug: 836641 Change-Id: I6ebc978021cafa9a6337afab5de29532fc28c4c1 Reviewed-on: https://chromium-review.googlesource.com/1027210Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#553526}
-
Thomas Tangl authored
The UI of the top-level master toggle is added to sync settings. For now the toggle changes whether all data types of sync should be turned on or only a custom selection (taken over from before). This should be changed once the unified consent service is implemented. Bug: 800974 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7eea3059ab90a3e47d9d5306e4a6359efdba0cf5 Reviewed-on: https://chromium-review.googlesource.com/1023934 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553525}
-
Takuto Ikuta authored
I applied modernize-use-override in blink/renderer/platform http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Bug: 428099 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I481f68cd5dfce10e19e938fdee31d4efcadfabef Reviewed-on: https://chromium-review.googlesource.com/1027230Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#553524}
-
David Reveman authored
It should not be possible to minimize transient dialog windows. These windows typically disable input for the parent and minimizing them and leaving the parent in a disabled state can be very confusing. Bug: 821498 Test: exo_unittest --gtest_filter=ShellSurface.Minimum Change-Id: I288b57a4b36f61d6ae0d491796ba45d8c9e44686 Reviewed-on: https://chromium-review.googlesource.com/1027890 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#553523}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8a67bbae. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16248 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations TBR=markdittmer No-Export: true Change-Id: I85211ab928f7aa846dac4b0fa294302186fd4acf Reviewed-on: https://chromium-review.googlesource.com/1027790 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#553522}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a5f8be1f..2875ae01 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I738550c46b6b5c1a8e9e80d94fcc0aa72e1b8f60 Reviewed-on: https://chromium-review.googlesource.com/1027314Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#553521}
-
Mike West authored
In order to make a reasonable decision about the reasonable-sounding feature request in https://crbug.com/835465, this patch starts processing XFO headers on redirect responses in order to collect metrics about how many requests we'd impact by tightening our enforcement. Bug: 835465 Change-Id: Ieb4571aae10e31fb61f1ccc245da5eb5dab791ae Reviewed-on: https://chromium-review.googlesource.com/1023393 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553520}
-
Ulan Degenbaev authored
Currently the function adds "other_spaces" that contains the difference between the total metrics and the sum of spaces. If the sizes do not match, then this can result in size_t underflow: https://bugs.chromium.org/p/v8/issues/detail?id=7668 We should just assert that the sizes match and remove "other_spaces". Bug: v8:7668 Change-Id: Ib768cec6b2fb7faf3e2c53a89cbd926547ddf603 Reviewed-on: https://chromium-review.googlesource.com/1016602 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#553519}
-
Henrik Boström authored
The test is flaky. See https://crbug.com/836783. TBR=orphis@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836783 Change-Id: I854823be77f95bed0d562f5f2968064e7342352e Reviewed-on: https://chromium-review.googlesource.com/1027871Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553518}
-
Rune Lillesveen authored
The style_ member of StyleResolverState is a ComputedStyle which is being built. There's no reason to have a separate Mutable* method to access it, we can always return it non-const. Bug: 813068 Change-Id: I7282441f2cac2e37ace98d0ee0709baf1ec656ea Reviewed-on: https://chromium-review.googlesource.com/1026682Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#553517}
-
https://webrtc.googlesource.com/src.git/+log/2ff7b6adf0b1..a945aee72e4e $ git log 2ff7b6adf..a945aee72 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:829238,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id6e47e0f319c3331213e79ebac289a16527b4e16 Reviewed-on: https://chromium-review.googlesource.com/1027415Reviewed-by:
-
Ben Wells authored
For each Crostini app launch, this records the type of app being launched - either the terminal, a registered app, or an unknown app. Bug: 703927 Change-Id: I326ff4a11028b1030b3c86a0ea4e98048441b983 Reviewed-on: https://chromium-review.googlesource.com/1025542Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#553515}
-
Gauthier Ambard authored
This CL clean the HeaderDefinition class, removing unused properties. Bug: 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iddc78f1a52ca587617d1def9c03455c2a1052f5b Reviewed-on: https://chromium-review.googlesource.com/1026679 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#553514}
-
Dan Elphick authored
Add PageRead to PageAccessibilityConfiguration so pages can be marked read-only. Matching CL in V8: https://chromium-review.googlesource.com/c/v8/v8/+/1006756 Bug: v8:7464 Change-Id: I9acdd9d5c00db9b89b1a2103be83fa2dde257b37 Reviewed-on: https://chromium-review.googlesource.com/1013564Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Henrik Boström authored
See https://crbug.com/836763 TBR=qyearsley@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836763 Change-Id: I91e1edb6e7fac3aa3957b2ac0c20fc25d628be7d Reviewed-on: https://chromium-review.googlesource.com/1027850 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Alexis Hetu authored
In order to enable SwiftShader as the default software GL implementation on MacOS with EGL, a previous change had to be reverted where native buffer formats were disabled for software GL. These formats are required on MacOS with EGL, for IOSurface support, and SwiftShader supports the same formats as Angle anyways, so only OSMesa needs this restriction. Bug: chromium:726075 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I20d9bb4083807ad9ae6d5f7092b912ea18ecb679 Reviewed-on: https://chromium-review.googlesource.com/1024500Reviewed-by:
-
Takuto Ikuta authored
Bug: 832211 Change-Id: I9dbfdb0c49aa10f6655454e0d9958f869454f31c Reviewed-on: https://chromium-review.googlesource.com/1025435Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#553510}
-
David Roger authored
Going forward the default API for interacting with authentication error should be the token service rather than the SigninErrorController. This CL updates tests to use the token service instead of AuthErrorProvider to set authentication errors. TBR=ellyjones Bug: 836212 Change-Id: I694068a1d037b1f2314d389328b9ccbea5f2bcf3 Reviewed-on: https://chromium-review.googlesource.com/1016642 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#553509}
-
Stuart Langley authored
This CL introduces an overload GetChangeList method in JobScheduler that accepts a team_drive_id and a start_page_token as parameters to retrieve the changes. This is the next step in being able to use start tokens to retrieve changes rather then the deprecated largest change id, which does not work for team drives. In DriveServiceInterface I did not overload GetChangeList but rather introduced a new method name that accepts team_drive_id and start_page_token as parameters. This is because base::Bind cannot resolve overloads and I would have had to add static_casts throughout the code to tell base::Bind which method to resolve to, and it's just not worth it. Bug: 833690 Change-Id: I5598cfe9d5a53a47ae8e8482585ae617f0851765 Reviewed-on: https://chromium-review.googlesource.com/1016181 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#553508}
-
Henrik Boström authored
This reverts commit 008759aa. Reason for revert: Breaks MSan Tests Findit (https://goo.gl/kROfz5) confirmed this CL at revision 553428 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAwODc1OWFhNWJjOGNkMDVjNTI5NjkwOGVmYmY3NGRjYjA0M2Q2NmUM Example: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F6869%2F%2B%2Frecipes%2Fsteps%2Fmus_browser_tests%2F0%2Flogs%2FOutOfProcessPPAPITest.Printing%2F0 Uninitialized bytes in __msan_check_mem_is_initialized at offset 0 inside [0x7f914c1f9524, 4) ==9854==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x12c35d8e in WriteBytesCommon ./../../base/pickle.cc:430:3 #1 0x12c35d8e in void base::Pickle::WriteBytesStatic<4ul>(void const*) ./../../base/pickle.cc:395:0 #2 0xb00ffa1 in WritePOD<int> ./../../base/pickle.h:327:5 #3 0xb00ffa1 in WriteInt ./../../base/pickle.h:190:0 #4 0xb00ffa1 in Write ./../../ipc/ipc_message_utils.h:186:0 #5 0xb00ffa1 in WriteParam<unsigned int> ./../../ipc/ipc_message_utils.h:110:0 #6 0xb00ffa1 in IPC::ParamTraits<PP_PrintSettings_Dev>::Write(base::Pickle*, PP_PrintSettings_Dev const&) ./../../ppapi/proxy/ppapi_messages.h:223:0 #7 0xd1e82ee in MessageT<true, false> ./../../ipc/ipc_message_templates.h:124:33 ... Uninitialized value was stored to memory at #0 0xb010122 in IPC::ParamTraits<PP_PrintSettings_Dev>::Write(base::Pickle*, PP_PrintSettings_Dev const&) ./../../ppapi/proxy/ppapi_messages.h:0:1 #1 0xd1e82ee in MessageT<true, false> ./../../ipc/ipc_message_templates.h:124:33 #2 0xd1e82ee in content::PepperPrintingHost::PrintSettingsCallback(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>) ./../../content/browser/renderer_host/pepper/pepper_printing_host.cc:55:0 #3 0xd1e87e2 in Invoke<const base::WeakPtr<content::PepperPrintingHost> &, const ppapi::host::ReplyMessageContext &, std::__1::pair<PP_PrintSettings_Dev, int> > ./../../base/bind_internal.h:447:12 #4 0xd1e87e2 in MakeItSo<void (content::PepperPrintingHost::*const &)(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>), const base::WeakPtr<content::PepperPrintingHost> &, const ppapi::host::ReplyMessageContext &, std::__1::pair<PP_PrintSettings_Dev, int> > ./../../base/bind_internal.h:550:0 #5 0xd1e87e2 in RunImpl<void (content::PepperPrintingHost::*const &)(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>), const std::__1::tuple<base::WeakPtr<content::PepperPrintingHost>, ppapi::host::ReplyMessageContext> &, 0, 1> ./../../base/bind_internal.h:604:0 #6 0xd1e87e2 in base::internal::Invoker<base::internal::BindState<void (content::PepperPrintingHost::*)(ppapi::host::ReplyMessageContext, std::__1::pair<PP_PrintSettings_Dev, int>), base::WeakPtr<content::PepperPrintingHost>, ppapi::host::ReplyMessageContext>, void (std::__1::pair<PP_PrintSettings_Dev, int>)>::Run(base::internal::BindStateBase*, std::__1::pair<PP_PrintSettings_Dev, int>&&) ./../../base/bind_internal.h:586:0 #7 0xd1e7292 in Run ./../../base/callback.h:96:12 ... Original change's description: > Add N-up feature support to pdfium_engine. > > In printing, 2-up, 3-up, or more generally N-up refers to a page > layout strategy in which multiple pages are composited onto a > single page. > > 1. Added ability to pass the N-up feature UI settings (which will be > added in the next CL) to the print preview workflow, so that the > PDF plugin can take action based on user's input. > 2. Added N-up feature support to pdfium_engine, so that when the > source is PDF, pdf plugin will generate the N-up output doc based > on user's input. > > Bug: 775999 > Change-Id: I27933d1a7da65376e70bdcb538393bb8bb3ec688 > Reviewed-on: https://chromium-review.googlesource.com/1014628 > Commit-Queue: Shirleen Lou <xlou@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553428} TBR=raymes@chromium.org,palmer@chromium.org,dcheng@chromium.org,thestig@chromium.org,skau@chromium.org,jochen@chromium.org,xlou@chromium.org Change-Id: I017a6dd2527c843ebb365bf5ec2da19696860898 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775999 Reviewed-on: https://chromium-review.googlesource.com/1027770Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a4bd4e9a. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16247 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding TBR=markdittmer No-Export: true Change-Id: Icdd8a31def9fa28dca027343a6ce3e21c40b2d0d Reviewed-on: https://chromium-review.googlesource.com/1027315 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
HttpRawRequestResponseInfo in ResourceResponseInfo is not thread safe. So if the shared ResourceResponseInfo is deleted on the UI thread, DCHECK(CalledOnValidSequence()) in RefCountedBase::Release() fails. To avoid this, this CL makes a deep copy of ResourceResponseHead before passing it cross-thread. This CL also introduces |devtools_enabled_| in DelegatingURLLoaderClient to avoid unnecessary operations. Bug: 836680 Change-Id: I5cee9b2da8b6183b660e8fc6375d9ee7ab2da343 Reviewed-on: https://chromium-review.googlesource.com/1027390Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/56610207ead6..9f63153a03c7 $ git log 56610207e..9f63153a0 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 angle-skia-autoroll Roll third_party/externals/angle2/ f2807385c..023371b3a (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Icc5728a970de3bb3f10c4cdbb3058cc87508f62a Reviewed-on: https://chromium-review.googlesource.com/1027439Reviewed-by:
-
Thomas Tangl authored
The following strings in the user menu are updated: - "Guest" -> "Open Guest window" - "Close all your windows" -> "Exit <Profile>", in case there are multiple profiles - "Close all your windows": titlecase added Bug: 836066, 130656 Change-Id: I526db685f3efd0c7b8623ab8a0081b9414ceed94 Reviewed-on: https://chromium-review.googlesource.com/1025758 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
It turned out that PROBABLY_ACCOUNT_CREATION_PASSWORD is not so helpful for server-side classification and wasn't used. Let's remove it in order to keep our code clean. Bug: None Change-Id: If53a48f1d8121ac3bb2efaecc291cd6370de9e1c Reviewed-on: https://chromium-review.googlesource.com/1007234Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#553502}
-
https://chromium.googlesource.com/angle/angle.git/+log/2565d48b47aa..023371b3af90 $ git log 2565d48b4..023371b3a --date=short --no-merges --format='%ad %ae %s' 2018-04-24 oetuaho Fix setting mip level metadata on GL backend Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I9c211d86c5b3dfae99338e2b590802a4f2430c9e Reviewed-on: https://chromium-review.googlesource.com/1027434Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553501}
-
Wez authored
The 'shell' feature removal CL was reverted after the sandbox policy files had been split into production and test versions, so the revert did not apply to the new test process policy. TBR: kmarshall Bug: 823927, 836341 Change-Id: I9a4c75cb01c255887a4928c31ab199e039d53397 Reviewed-on: https://chromium-review.googlesource.com/1027441Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#553500}
-
Jonas Olsson authored
Bug: chromium:672469 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1e24e99df4a6d9dc0480aeb460115bafdceeafd5 Reviewed-on: https://chromium-review.googlesource.com/1018475 Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#553499}
-
Yang Guo authored
The old V8 API is being deprecated. R=haraken@chromium.org Change-Id: Iaa5af927df5522ad78ce2b3db2b663568855193e Reviewed-on: https://chromium-review.googlesource.com/1026676Reviewed-by:
-
Friedrich Horschig authored
This CL imports all attribute tests from https://github.com/abarth/http-state/tree/master/tests/data/parser. There are small changes that ensure the tests also clean up when they are run via the debug path. Change-Id: I5cf30824091471e7f65aceb19ad03bd07cfb91d1 Reviewed-on: https://chromium-review.googlesource.com/977923 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
