- 13 Apr, 2020 40 commits
-
-
Yi Gu authored
This test is no longer timeout after crrev.com/c/2110830 where the test was given more time to finish. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=virtual/threaded/external/wpt/animation-worklet/idlharness.any.html Bug: 1045329 Change-Id: Iea17d1053f241f0f36394df7caef947ddace711a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147061Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758554}
-
chromium-autoroll authored
Roll airmont AFDO profile from 83-4099.3-1586165807-benchmark-83.0.4103.7-r1 to 83-4099.3-1586165807-benchmark-84.0.4111.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If86f1ce2e2e774ab6c9dd1da406c61cf2ee2215f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758553}
-
Nick Diego Yamane authored
XWindow can be destroyed in the middle of a delayed resize closure execution. It may happen when that window is snapped into a tab bar. More specifically when a nested move loop, used to intercept and forward the mouse events during a tab dragging session, is triggered by a bounds change event notified from a delayed resize task. To fix it, this uses a weak pointer to verify whether the window instance is still alive after notifying the bounds change in the delayed resize function implementation. Bug: 1068755, 1021490 Change-Id: I08eff38d5f5f28ec54e489dc183f3f0cfdde2480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144996Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#758552}
-
Kai Ninomiya authored
This seems to be necessary to capture them in a test isolate (instead of capturing hollow symlinks). Bug: 1069302 Change-Id: If2c3b2594d05b647d3f6e6a947f5dc0ab26a6444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145702Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758551}
-
Ben Schwartz authored
If a DNS probe happens before the previous probe completes, the previous callback will never be called, leading to a JS stack leak. This change resolves the first callback to free up the stack. This leak is unlikely in practice. If a leak does occur, it persists until the user closes the settings page. Change-Id: Id12a4181bdbe1274c7441d9be9bf223d2a457406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132589 Commit-Queue: Ben Schwartz <bemasc@chromium.org> Auto-Submit: Ben Schwartz <bemasc@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#758550}
-
Devlin Cronin authored
Rename ShowToolbarActionPopup() and ShowExtensionActionPopup() to ShowToolbarActionPopupForAPICall() and ShowExtensionActionPopupForAPICall(). These methods were only used when displaying a popup in response to an API call (outside of tests), and this name makes it more obvious. Additionally, this lets us get rid of the additional "grant_active_tab" bool, which was always (outside of tests) set to false. Bug: None Change-Id: I02b4c489586f6cbec3ac99b02ce15413f2ceff40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145858Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758549}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f61ee1ecac14..ecd82d832f4f git log f61ee1ecac14..ecd82d832f4f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 csmartdalton@google.com ccpr: Ensure stencil buffer gets fully reset to zero 2020-04-13 robertphillips@google.com Allow path renderers to self-identify 2020-04-13 robertphillips@google.com Make GrTextStrike::addGlyphToAtlas a static method in GrTextBlob.cpp 2020-04-13 brianosman@google.com Remove threaded code Created with: gclient setdep -r src/third_party/skia@ecd82d832f4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I1831816b7a30cf865f580c4b02a052389d74ebb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147066Reviewed-by:
-
Jenny Zhang authored
The corner case happens when user type a query in search box then quickly press DOWN or RIGHT key to change the selection to another result, but right after this, search box publish results again, search results UI were updated, and default selection were changed back to the first visible app. But the search box text remained as the previous user selected result's title or url. Fix the issue by restoring the search box text to the original query user typed in the search box to make UI look consistent. Bug: 1065454 Change-Id: I9b773869b89825ec11744bfc997456bbd05779a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146449Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758547}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I299208728a97706bcfed67fe6f1fc8934cc2bf12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147070Reviewed-by:
-
Kevin Babbitt authored
This is a reland of 50fbc87a The CL got reverted due to flakiness on Win7. From the logs it appears that the flakes were caused by test content sometimes extending beyond window bounds, resulting in incorrect hit test results. To address this issue, existing tests have been rewritten to use smaller content. I ran the rewritten tests 100x on a Win7 VM and saw 0 failures. Several cleanups were made along the way: - Update comments and code to reflect the fact that BrowserAccessibilityManager.HitTest takes a point in frame coordinates. - Increase device scale factor in scaled tests from 1.25 back to 2. - AccessibilityHitTestingBrowserTest.HitTestingInIframes: This test was almost identical to AccessibilityHitTestingZoomBrowserTest.HitTest, with the addition of testing with a different event. Combined the two into a single test: AccessibilityHitTestingBrowserTest.HitTest. - AccessibilityHitTestingCrossProcessBrowserTest.*: these two tests were also nearly identical. Combined into a single test which validates both the frame tree and the scrolling case with the same content. - AccessibilityHitTestingBrowserTest.*WithPinchZoom: these tests were not actually exercising accessibility hit testing paths - they were generating input events which got sent directly to Blink. Replaced these with tests that exercise accessibility hit test paths in the presence of pinch zoom. Original change's description: > Parameterize existing accessibility hit-testing tests > > https://crrev.com/c/2117330 added tests for cross-platform > accessibility hit testing code using parameterized combinations of > simulated device scale factor and use-zoom-for-dsf on or off. This CL > expands the parameterization to other existing hit-testing tests. > > To fix issues running these tests on cast_shell_linux I also made two > changes to the tests themselves: > - Reduce the scale factor from 2 to 1.25 > - Relocate one test point to be within the screen size > > Bug: 1007488 > Change-Id: I715270064365458ac9ec69f3c3ac81a674d2718c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135017 > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756884} Bug: 1007488, 1069850 Change-Id: I01fcb7d2b7f6a764ccd76da3e97778dfc184960e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140198 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758545}
-
Maks Orlovich authored
What matters here is the policy for the top-level frame, as filtered by Feature Policy; we were simply not using any persistent settings at all. Change-Id: I1435bdc9dfcc6f6643ea737a135e8c0e07e7ecde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083671Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#758544}
-
Rainhard Findling authored
Bug: 1015841 Change-Id: I7d08cbad60569da8221d58835c59d6793d612208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139692 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
-
David Bertoni authored
The ExtensionCannotFetchHostedResourceWithoutHostPermissions is no longer flaky. Bug: 1038156 Change-Id: Iecadf163ddd5be64e296188352ae3a268fe715a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140777Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758542}
-
Anton Bershanskiy authored
Added getScanRecord_getAdvertiseFlags() to ScanResultWrapper to be called by ScanCallback.onScanResult to pass to ChromeBluetoothAdapterJni.get().createOrUpdateDeviceOnScan() which sends them to UpdateAdvertisementData(). Bug: 661814 Change-Id: Iad8c49936a796d4ca4ec39782c0f28ea66286271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144153Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#758541}
-
yilkal authored
This Cl ensures that the blocking page title is the same as the previous page title if the previous page title has been set. Bug: 1061626 Change-Id: Ia9f813323b09d42aa5c2c12b139aabadea589ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142136 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#758540}
-
David Bertoni authored
The BlockedAppApiTest.OpenAppFromIframeCheck is no longer flaky on ChromeOS. Bug: 153513 Change-Id: Ib23c61d230baec36708127f746bf8c3c23a2b04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145757Reviewed-by:
-
dpapad authored
Previously the code assumed, via the usage of l10n_util::GetStringUTF16, that the underlying resources at chrome/test/data/webui_test_resources.grd are not compressed. Moreover, using l10n_util::GetStringUTF16() is not designed for fetching a file's content and was somewhat misused here. This is one of many CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: I77fe0f9966f6e277288838c42260433c34bd403c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146090 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#758538}
-
Andrew Xu authored
Add ShelfViewTest::ShouldHideTooltipWhenHoveringOnTooltip back. In addition, this CL fixed a bug exposed by this test: shelf icon tooltip should be hidden if the mouse cursor moves outside of icons area. Bug: 1016874 Change-Id: I9d78993d658e659d9a738d6e0be6fa673a2b36bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146783Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758537}
-
Dominic Mazzoni authored
In http://crrev.com/c/2140033, we ensured that we don't try to serialize the accessibility tree starting from a node that's not in the tree - that leads to wasted effort. However, the fix neglected one corner case - I just debugged a case where the parent of that node not in the tree is actually a detached node, leading to the exact same serialization problem. The fix is just to check the parent node validity before serializing, matching how the original node was checked before serializing. Bug: 1066880 Change-Id: Idc404fdce697fe368acd033c87552676a2aab950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146333Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758536}
-
Eric Roman authored
Change-Id: I57e137fc1dd69429d5e132b5dc8d83fa764ad221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147796 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#758535}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/5298ef99bf2b2d77600b3bb74dd572027bf495be..f9e0cda2d81858d10ceeadb0d21f4026f8602cf7 The following commits have Chromium bugs associated: f9e0cda2d Add SSL_SESSION_copy_without_early_data. a49c61719 Implement draft-irtf-cfrg-hash-to-curve-06. ea53011c6 Generalize bn_from_montgomery_small. ad5e3e359 Remove BIGNUM from uncompressed coordinate parsing. 58add794d Add EC_RAW_POINT serialization function. The following commits have update notes: 0064c290d Add DH_set_length. Bug: 1014199, 1066623 Change-Id: I238408605bc8955195e4c8200218e7bf15105c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144475 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#758534}
-
Avi Drissman authored
If `xcrun altool` returns data that can't be parsed or correctly interpreted, rethrow with the actual data so that the data is logged. This way, the next time it happens we can see what bad data is being returned and will be able to make the notarization tool more robust. Bug: none Change-Id: Icb4ceaa669b37ef9cdda7d8abd8f478532108fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147816Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#758533}
-
Chris Lu authored
Remove API now that codebase calls Browser API Bug: 790886 Change-Id: I8ec3b8cae8621c47e31236d6a5552e35c478556a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144463Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#758532}
-
Andrew Xu authored
Bug: 1069625 Change-Id: I29e375bdeb4aa102714b57d60805b3a534825f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146782 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Wei Li authored
The default color used by bookmark menu expanding arrows is black. On Windows, the color is retrieved from system text color. However, none of those responds well to different themes. Change to get the color from native theme. BUG=1059867 Change-Id: Id7c998a4d82bf6812ac9461139fbf72065c9bf03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146174 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758530}
-
Nnamdi Theodore Johnson-Kanu authored
With most of routes shared between ChromeOS and browser renamed except for Sync routes, a DCHECK can be used when opening browser settings pages to that the |sub_page| is not an OS-specific setting. Bug: 990169 Change-Id: I84ca6c5584d405d3a2deed2d61878c70d3744c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138115 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#758529}
-
Tomasz Wiszkowski authored
This CL addresses the SimpleRecyclerViewAdapter propagating incomplete events to the parent RecyclerViewAdapter, resulting in partial UI updates. The CL also adds a few tests that confirm the behavior of the SRVA. Change-Id: I4c35b54e925853e91d686fde5cc476f3d2efe6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146063 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758528}
-
Yann Dago authored
Extensions installed by policy as "normal_installed" were disabled by default contrary to what is documented. They are now silently enabled by default. Bug: 1029516 Change-Id: I5b11b3fdd85ff39f5bbb9e0505d26294c5c5f935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118575 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#758527}
-
Antonio Gomes authored
BUG=767015, 1063749 R=jfernandez@igalia.com Change-Id: I4f88f5540f9d3999081718501399465920d36ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144993 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#758526}
-
Peter Kasting authored
That seems more consistent to me. Bug: none Change-Id: I962a8e1eee04a33436157dc132e81e0231c0d088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147079Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#758525}
-
Leonard Grey authored
This pushes the decision on when to hide/show the download bar into the browser frame instead of ping ponging back and forth with the fullscreen controller. Also cleans up some cruft left over from Cocoa/different fullscreen implementations. Could still be a little better (handling download shelf visibility in BrowserViewLayout), but it's tricky between immersive mode, DownloadShelf expecting to handle its own visibility, etc. so I'm holding off for now to land this. Bug: 902501 Change-Id: If0ba982c8ecbad40eda21e985b77cdda8621c791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141040Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#758524}
-
Thomas Lukaszewicz authored
Eliminated the need for ViewsInteractiveUITestBase, cleaned up more of the Widget test related code. Bug: None Change-Id: Ie4a6410e023e0f9edcaf52b997063e70fa6f3f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146332 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dabe38f611af..f61ee1ecac14 git log dabe38f611af..f61ee1ecac14 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 johnstiles@google.com Fix assertion in ImGui::NewFrame if getBackbufferSurface returns null. 2020-04-13 robertphillips@google.com Expand PlotLocator into a class Created with: gclient setdep -r src/third_party/skia@f61ee1ecac14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I865b14edf5afbe21d09b87790ff87af576807f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147615Reviewed-by:
-
Matt Jones authored
This patch removes ReaderModeInfoBar's use of TabImpl.getActivity() and passes the relevant tab around instead of trying to access it via TabModelSelector. Bug: 1069815, 952703 Change-Id: I359597d1a71914653a948a246275f88bb9de1666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145816 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758521}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8b4d25b6741b..ee7525af4712 git log 8b4d25b6741b..ee7525af4712 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src fd593d5f0834..46572440189e (1 commits) Created with: gclient setdep -r src/third_party/angle@ee7525af4712 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I915947be77f31bc1913c936b0fa65a25374a21c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147614Reviewed-by:
-
Scott Violet authored
This typically means the delegate is calling Stop() from start or a redirect. To continue on is likely to lead to use after free. BUG=none TEST=none Change-Id: I42ffb6081abd282968aaad2243795746906e73e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144478 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#758519}
-
Carlos Knippschild authored
A small follow up to https://crrev.com/c/2138633. Bug: 1010916 Change-Id: I2227fbaedc2104f15e9968421f3bed0f9e134961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145733Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#758518}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/97d7f070200a..e9d37e79b47f git log 97d7f070200a..e9d37e79b47f --date=short --first-parent --format='%ad %ae %s' 2020-04-13 morg@google.com Add Android arm64 support for cbuildbot_run 2020-04-13 hirokisato@chromium.org Revert "device: Don't assume '--device=localhost' means VM." 2020-04-11 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-11 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-10 saklein@chromium.org commandline: Fix ssh parsing. 2020-04-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-10 richardfung@google.com Remove betty-arcmaster 2020-04-10 bpastene@chromium.org device: Don't assume '--device=localhost' means VM. Created with: gclient setdep -r src/third_party/chromite@e9d37e79b47f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Id56272f0673fd63544a135d1b3f78c1c74a26dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147062Reviewed-by:
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: If46c344d0fbf3751041568aff529feef2ffb7d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147652 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#758516}
-
Katie D authored
Reader mode should be considered by users to be a view of the original, rather than its own page. We do not expose reader mode URLs to users in the omnibox, so we should not allow users to bookmark those URLs directly. Instead, bookmarks added on dom-distiller pages will apply to the original article's URL and title. If a user looks at a Reader Mode page which corresponds to a bookmarked URL, the star icon will be active. Bug: 1066165 Change-Id: I2e323977fdd8b218d433e3fef2175af81e0f1b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130446Reviewed-by:
-
