- 24 Jul, 2019 40 commits
-
-
Hiroki Nakagawa authored
The test sometimes times out on linux and win bots. Bug: 987138 Change-Id: I0f23623626b12ecc58696b87095646b0a058c418 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715415Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#680330}
-
Rachel Wong authored
Bug: 985205 Change-Id: I60a5fc905958be1a3f2f56e92ec2be4767e28d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715920Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#680329}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/fd97d43..682a230 Size increase: android_small & ios 5K chromeos 43.3K common 15K Bug: v8:9475 Change-Id: I78c863dfd3dde589e5bdd08968c1b499ad6225bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715115 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680328}
-
Joel Hockey authored
Bug: 968060 Change-Id: I7f6e8b3cf4bd278316e4b2e21af250fcf65ef984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715185 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#680327}
-
Hiroki Nakagawa authored
This test is flaky not only on win and linux but also on mac. Bug: 986282 Change-Id: I5bb49f1e45c984261024d00cdce55825de8fbbd1 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715776Reviewed-by:
-
Fergus Dall authored
Due to a bug in the original implementation of the metrics, Crostini.TimeToInstallCancel and Crostini.AvailableDiskCancel were not collected in most cancellations and could sometimes be collected in the wrong state. Bug: 953545 Change-Id: I9c23abdb61b2b3b8d33dec802f89035ed59d9db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714724 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#680325}
-
Wei Lee authored
This CL supports forwarding Android camera intents from ARC++ intent helper to CCA and is able to return the captured result back to the ARC++ intent helper. Bug: b/131809655, b/134635999, 980812, 967611 Test: am start -a android.media.action.IMAGE_CAPTURE Test: am start -a android.media.action.VIDEO_CAPTURE Test: Run CtsVerifier -> Camera Intents Test: Run Hangout -> Capture photo/VIDEO_CAPTURE Test: ./cts-tradefed run commandAndExit cts -m CtsCameraTestCases Test: (Simulate camera v1 stack on Nocturne) (dut) $ mv /usr/bin/cros_camera_service /usr/bin/cros_camera_service_old (dut) $ (Tested with external camera) Change-Id: I738483dfdf63c56bb0947bb1ff201fba9be02bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592991 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:Ricky Liang <jcliang@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#680324}
-
Hiroki Nakagawa authored
Bug: 987132 Change-Id: I846c70ee0dd07af1ffc9f53f475bed061db6f1e7 Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715169Reviewed-by:
-
Will Harris authored
This test verifies the behavior when CIG is enabled but the signed interception is not in place, for both the case where process startup fails because imports fail to load, and also when a manual dll load fails. BUG=750886 Change-Id: I88575515b566b9edb4f4c4a1ba8fcf91fceb730c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715240 Auto-Submit: Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680322}
-
Paul Dyson authored
1. Move the AppLaunchEventLogger member variable from AppListClientImpl to SearchResultRanker. 2. Move the app_launcher_event_logger* files from chrome/browser/ui/app_list to chrome/browser/ui/app_list/search/search_result_ranker. Bug: 899123 Change-Id: I329d69b00facd3321335ba1cfbc2b86296339aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705459 Commit-Queue: Paul Dyson <pdyson@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#680321}
-
Adrienne Walker authored
This will help diagnose high rates of webview read failures. Bug: 977231 Change-Id: I2fd23593e62291c71c01583e3db6cd8a2ee5e8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707983Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#680320}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I208065ee12e450c785e9c0c4b45b1a7d51d23b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716399Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680319}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83166a2bdb79..ac7c4af504d5 Created with: gclient setdep -r src-internal@ac7c4af504d5 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: I2cddfe6b41ae83ae0ae7e46b4702dc7fc2f01f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716395Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680318}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2de8692b. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6a6b173b "Add type option to showToast helper" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I567e1fa9c2f1c9f951e7fa800948a94e4fb63162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716212Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680317}
-
Kristi Park authored
This is a remnant from when the tile icon images were generated with a (dark) gray background, depending on the system theme. Now that the tile background controlled via CSS, it's no longer required to reload the tiles when the background image is changed in dark mode. Bug: 986935 Change-Id: Iccd076f354a838e9025856151e1e486824ed4c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716100Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680316}
-
David Bokan authored
This reverts commit 5dd16566. Reason for revert: This CL was confirmed to be the cause of the perf regression in crbug.com/978980 - this is artificial so we can reland Original change's description: > Revert "Do not coalesce wheel with phaseBegan to wheel with phaseEnded." > > This reverts commit 2ca01526. > > Reason for revert: Speculative revert for https://crbug.com/978980 > > Original change's description: > > Do not coalesce wheel with phaseBegan to wheel with phaseEnded. > > > > If no element in the scrolling chain is not scrollable in the given direction > > (delta_hints) on GSB we latch to the viewport. This is not user friendly on > > platforms that do not have any scroll affordance animations (e.g. Windows) > > since if the user changes the scrolling direction and an element in the chain > > is actually scrollable in the new direction, the user expects it to scroll and > > has no idea that we have latched to the (possibly unscrollable) viewport for > > the rest of the scroll sequence. To address the issue for timer based wheel > > scroll sequence we end the sequence and start a new one upon arrival of a wheel > > event with different delta directions if no GSU has been consumed since the > > beginning of the sequence. This cl ensures that the GSE/GSB generated for > > breaking the latching seqeunce are not coalesced with each other. > > > > Bug: 882998 > > Change-Id: Icf703c935475fffd69b899c59abc03ec1b548784 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524703 > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > Commit-Queue: Sahel Sharify <sahel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#641719} > > TBR=nzolghadr@chromium.org,sahel@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 882998,978980 > Change-Id: I85799b6e6eace029b4c2ef00e142f035ac9e8e4c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688230 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#674615} TBR=bokan@chromium.org,nzolghadr@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 882998, 978980 Change-Id: I3dfb3f3ec0467b7101597720325222899e46f10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716444Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680315}
-
Takuto Ikuta authored
Test from this builder consumes around the following machine hour * p99 CI: 38.27611111111111 * p90 CI: 34.07888888888889 * p50 CI: 32.31194444444444 * p99 CQ: 36.07277777777778 * p90 CQ: 35.85166666666667 * p50 CQ: 28.64027777777778 in chrome pool in recent 30 days. I took the stats from http://shortn/_vS3Df0uFD0 Bug: 954450 Change-Id: I050e133192423c1bb734e612c9a8be2417259a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712704Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#680314}
-
Nick Diego Yamane authored
At the moment, //ui/events/platform/x11 has a single dependency on //ui/base/x, which is ui::XScopedEventSelector, that actually is a X11 event-related component. This CL moves XScopedEventSelector source files into //ui/events/x, thus getting rid of aforementioned dependency, which prevent //ui/base/x components to depend on X11EventSource* classes (which lives on //ui/events/platform/x11), for instance, which has been becoming more and more common in the aura/x11 -> ozone/x11 migration, where core X11 classes are made reusable and placed in ui/base/x to be shared between ozone and non-ozone X11, e.g: crrev.com/c/1695008. Bug: 789065 Test: None (no functional change) Change-Id: I94aba04b420f6d718c41abcc93ceafaf13963173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712955Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#680313}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I2d7f8bfa090f643a494d2d9965634e638fc29bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716325Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#680312}
-
Alexander Alekseev authored
Bug: 975758 Change-Id: I5262bccc4000f2f0ff2c6ac7ab71abc980395ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713242Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#680311}
-
Gyuyoung Kim authored
NavigatorContentUtils has been installed by ModulesInitialized::InstallSupplements while a frame is created. But, it's also possible to install NavigatorContentUtils when it's real functions are called like other Supplements. The lazy installation is a typical use case of Supplement as well as it helps to occupy less memory if not used. Bug: 987080 Change-Id: If22d7c992b987e59dd326546663bb4c5a16d7959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715167Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#680310}
-
Ryan Hansberry authored
Make UnlockManagerImplTest more closely follow how UnlockManagerImpl actually behaves in production by making UnlockManagerImpl directly listen on RemoteDeviceLifeCycle::Observer events, and make FakeRemoteDeviceLifeCycle::Start() notify observers. This all allows the test RemoteDeviceLifeCycle object to notify UnlockManager as soon as its state changes, instead of having to manually emulate state change events. This CL unblocks testing for the bug fix (crbug.com/890047) in the subsequent CL. As it turns out, this refactor actually exposes that bug -- had this test code been structured this way before, the bug could have been fixed long ago. TODOs have been left in the test code marking accommodations made for the bug -- they will be removed in the subsequent CL. Bug: 926608, 890047 Change-Id: Iee96974d9376bda1f75deba314f28efccae7052c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716154 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680309}
-
Alexander Alekseev authored
Bug: 984272 Change-Id: I5af611329444f07328313b2eb401dbc31522cbbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714044Reviewed-by:
-
Andrew Grieve authored
Was reverted in: 54f75614. Reason for reland: Includes fix for downstream targets. Change-Id: I2a5f77cdbd40934ae206dd91b2e12e7b5e6553e1 Bug: 986693, 986693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715004Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#680307}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I1653b11914eb81117a4d9b35e2ef32ec38ed57bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714949Reviewed-by:
-
Abhishek Bhardwaj authored
This change observes any time zone changes, recalculates the delay for the next update check timer and starts it to override the previous timer. BUG=924762 TEST=Unit tests. Change-Id: I7ebd9114a7282b0d03e3d18d4bbe1aaaa252ff2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677555 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#680305}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0cc6f67d9766..83166a2bdb79 Created with: gclient setdep -r src-internal@83166a2bdb79 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: None Change-Id: Ibc0efc9e2ffbab4ea24133f2930543f1a7ab8398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716387Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5f7b2c2ad2f2..fbd94ccd66ee git log 5f7b2c2ad2f2..fbd94ccd66ee --date=short --no-merges --format='%ad %ae %s' 2019-07-24 simonhatch@chromium.org Pinpoint - Make autocomplete box iron-form compatible. Created with: gclient setdep -r src/third_party/catapult@fbd94ccd66ee The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:986902 Change-Id: I88fd7bc1cadb3106454c59a7e4f4a4c7f8bfcad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715122Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. Bug: 977050 Change-Id: I229c40799a36ec7eeb212043b0503e7e507b876d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700825Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680302}
-
David Bokan authored
Tests can often start sending synthetic events before the renderer has fully initialized and produced a compositor frame. Before that, the browser doesn't yet get the geometry information from the renderer and the gestures This leads to flaky, tough-to-debug, tests. This CL makes the first gesture sent by the SyntheticGestureController wait until the renderer confirms it has produced and presented a CompositorFrame. By that time, it should be ready to receive events. This change should make the synthetic gesture API more intuitive and easier to use. It should hopefully also fix several flakes in addition to the one linked in this CL. The fix in scrollbar-button-gesture-target.html is required because the autoscroll timer begins 250ms after the mouse down. Prior to this CL, this would pass by accident because the first generated compositor frame in web tests appears to take a long time (~200ms). Since that would occur after the MouseDown this test would pass. Now that we force a frame before the MouseDown the MouseUp happens in 100ms, before the autoscroll timer expires. We fix this by making the delay exceed the autoscroll timer delay. Bug: 897520,951638,985374 Change-Id: Idd63e1f2b999253e0392ae37be4180956119a814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566750 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#680301}
-
Hiroki Nakagawa authored
This reverts commit 154a7f11. Reason for revert: This CL causes MSAN failurse on Linux bot: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/18180 Original change's description: > Distinguish between enabling the insecure and secure parts of the async resolver. > > In SECURE or AUTOMATIC mode, we should be able to send secure DoH queries via > the async resolver regardless of whether the async resolver is enabled for > sending insecure queries. > > The network service will be updated in a follow-up cl to actually set the > insecure and secure parts separately; for now support is just being added in > HostResolverManager. > > Bug: 985589 > Change-Id: Ife79f70897229aadc4f7111c3ce07de47b47a32b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497654 > Commit-Queue: Katharine Daly <dalyk@google.com> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680069} TBR=mmenke@chromium.org,ericorth@chromium.org,dalyk@google.com Change-Id: Iead9c38f35cde1411193550799977f580342ce3b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716392Reviewed-by:
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. NOTRY=true Bug: 977050 Change-Id: I9a24112403d29fa8d81dfdc03a5851679e539799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700620 Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680299}
-
Hiroki Nakagawa authored
This CL removes data saver tests for dedicated workers from web_tests. They are covered by DataSaverForWorkerBrowserTest. The motivation of this change is that the tests depend on internals.setSaveDataEnable(), but it no longer works after browser-initiated dedicated worker script loading (PlzDedicatedWorker) is enabled. We already removed the tests for shared workers for the same reason (PlzSharedWorker). Bug: 906991 Change-Id: I93775824d2dab398268bf9b3a7a54d5e9d79f74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715729Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#680298}
-
Hiroki Nakagawa authored
This reverts commit 7faa4bf2. Reason for revert: This CL depends on the CL that causes MSAN failures on Linux bots: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/18180 To revert that CL, let me revert this CL. Original change's description: > Configure the insecure and secure parts of the async resolver separately. > > We can now set the secure dns mode to AUTOMATIC and turn the insecure part of > the resolver off, which will result in the async resolver issuing DoH requests > and falling back to the system resolver without attempting to send plaintext > DNS requests itself. > > In a follow up cl, the secure dns mode part of the configuration will be read from > prefs. For now, we continue to set the mode to AUTOMATIC if there are DoH servers > specified and to OFF otherwise. > > Bug: 985589 > Change-Id: Ia40cbae1fdd57e19e925e125dcf1e82289220242 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709928 > Commit-Queue: Katharine Daly <dalyk@google.com> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680161} TBR=tsepez@chromium.org,ericorth@chromium.org,dalyk@google.com Change-Id: I0e118abc67bb2b06860894079c5ed509d8179dff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715265Reviewed-by:
-
Tim Song authored
BUG=894780 Change-Id: Ib6066153edf992baf4572113155b95d677ac8af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714265Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#680296}
-
Ryan Sleevi authored
Bug: 986958 Change-Id: I3d7dcf1c736243f73c9333d27175f6740842a6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716005Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#680295}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I45851f14cf8653a7818f9b28d5b113ec8da6d730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716295Reviewed-by:
-
Leo Zhang authored
After some attempts of loading our shared library in IME service with an ime-sandbox type, new process of IME service always crashed. strace logging: https://paste.googleplex.com/4705028050780160 Allow clock_gettime will fix that. Bug: 837156 Change-Id: I4e6bf7a777f57ef8f5184be8c60a59bd2fd7e163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677295Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Auto-Submit: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680293}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1844d6a51cbc..886321015e1d git log 1844d6a51cbc..886321015e1d --date=short --no-merges --format='%ad %ae %s' 2019-07-24 vapier@chromium.org lint: fix cros-logging-import handling Created with: gclient setdep -r src/third_party/chromite@886321015e1d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I95fe17e8f7591c240fcc911bca6ad3c0bf6ab818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716294Reviewed-by:
-
Daniel Bratell authored
Two RunOrPostTaskIfNecessary methods, one in content/browser/web_package/signed_exchange_devtools_proxy.cc and one in content/browser/loader/navigation_url_loader_impl.cc, clash in some extreme (non-default) jumbo builds. This CL makes one of them more specialized since it was always called with the same argument, and changes its name. Bug: 824854 Change-Id: I65f1270ca826235596a846dec935a8ea9b7f624b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713515 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680291}
-
