- 25 May, 2018 40 commits
-
-
Mikel Astiz authored
This is a partial revert for https://chromium.googlesource.com/chromium/src/+/87d0207fea94e8f64ca053c813b96e2ddcd3da27 Tabs not only get restored from tab entities (which is usually the case) but can also be restored directly when processing a header entity. For cases where a header references a tab that doesn't have a corresponding tab entity (e.g. was unsyncable), we need to simply skip the reasociation step. Bug: 846480 Change-Id: I5d534645a42e4e660bf2cd110a7a4ee0f57b9c25 Reviewed-on: https://chromium-review.googlesource.com/1073328 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#561838}
-
Ned Nguyen authored
** Perf bot health sheriff: if there are test cases in this benchmark that fails on windows, please disable individual failed test cases instead of revert this CL ** TBR=cbruni@chromium.org, hablich@chromium.org Change-Id: I20b8026608164107f13a6a62a73c812bef4ab12e Reviewed-on: https://chromium-review.googlesource.com/1072502 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#561837}
-
Olga Sharonova authored
(flaky). NOTRY=true TBR=sky@chromium.org Bug: 846656 Change-Id: I711631f169c28c525ed8ce97ae5799ca6a07adae Reviewed-on: https://chromium-review.googlesource.com/1073410Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561836}
-
Hajime Hoshi authored
This CL also removes MediaElementEventQueue::CancelEvent, which is not called anywhere. This is one of the steps to eliminate EventQueue. Bug: 846618 Change-Id: I6e67a84d7bbd5344a5758e58d1db7be0192ac53f Reviewed-on: https://chromium-review.googlesource.com/1072992Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561835}
-
Andy Paicu authored
Bug: 845961 Change-Id: Ifc9609058cd7cbd268785db46534e3ed09da6ce3 Reviewed-on: https://chromium-review.googlesource.com/1071510 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#561834}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c6fb49f6. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18556 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=kereliuk No-Export: true Change-Id: Ifc6a156705f0264de5db0e2aef74c4b558436e83 Reviewed-on: https://chromium-review.googlesource.com/1073086 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561833}
-
Manuel Rego Casasnovas authored
Text from the spec (https://drafts.csswg.org/css-contain/#containment-paint): "... if the element's principal box is a non-atomic inline-level box, paint containment has no effect." The patch disables "contain: paint" in non-atomic inline-level boxes. For that a new method LayoutObject::ShouldApplyPaintContainment() is added, which is used instead of ComputeStyle::ContainsPaint() all around the code. It's worth to highlight the change in ComputedStyle::CanContainFixedPositionObjects() as it doesn't know if the element is inline or not, it cannot check if we're in paint containment anymore. Otherwise it'd make a containing block non-atomic inlines with "contain: paint", the ones in which we're disabling paint containment on this patch. More changes on that new method would be needed to fulfill the rest of requirements from the spec, as paint containment shouldn't apply to internal table and ruby elements for example. Also similar patches for other kind of containment like layout and size are going to be required. Regarding tests this patch makes us pass contain-paint-002.html. On top of that a few extra tests have been added. BUG=843329 TEST=external/wpt/css/css-contain/contain-paint-011.html TEST=external/wpt/css/css-contain/contain-paint-012.html TEST=external/wpt/css/css-contain/contain-paint-013.html Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I140fad061f5cda14e52451aa8f4bc70c9edede3e Reviewed-on: https://chromium-review.googlesource.com/1071794 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#561832}
-
Olga Sharonova authored
See the bug. Bug:846621 Change-Id: Ia3689ade53b5ee775fcc7c3f43b96925d1818e01 TBR=piman@chromium.org Change-Id: Ia3689ade53b5ee775fcc7c3f43b96925d1818e01 Reviewed-on: https://chromium-review.googlesource.com/1073367Reviewed-by:
-
David Roger authored
Going forward the default API for interacting with authentication error should be the token service rather than the SigninErrorController. This CL updates tests to use the token service instead of AuthErrorProvider to set authentication errors. Bug: 836212 Change-Id: I9b5629bad7b17b6cab70978cc23bbc828bf62d61 Reviewed-on: https://chromium-review.googlesource.com/1016904 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#561830}
-
Koji Ishii authored
This patch fixes a case where ShapingLineBreaker may produce incorrect number of characters in the ShapeResult. It was probably introduced in r471636 [1]. When searching for the last safe position, there is a case where last_safe and line_end_result lost sync. Then ShapingLineBreaker constructs the final ShapeResult assuming they are in sync. The fix is done by simplifying the logic for when including more characters can shorten the width. Two nested loops, one to find previous then another to find next is changed to single loop. This also avoids trying opportunities once tried and failed. When no break opportunities can fit and that multiple break points are valid, this patch picks a different break than before. I think the new break is better, but we may want to revisit this as we learn more. Includes following related changes: 1. Add is_overflow state. When it overflows, no need to look for previous opportunities. 2. Add BreakOpportunity struct to ensure the offset and is_hyphenated are in sync. 3. Add more DCHECKs to ensure start, first_safe, last_safe, and break_opportunity are always in this order. 4. Add more DCEHCKs to ensure the offsets above are in sync with each corresponding ShapeResult. 5. Uncommented DCHECK that used to fail on Mac. [1] https://codereview.chromium.org/2875933006 Bug: 636993, 846138 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8e740f9f59ce4d50f20cf4cb360f460685418583 Reviewed-on: https://chromium-review.googlesource.com/1072208 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Stuart Langley authored
Currently the lists of users team drives is loaded on each update using ChangeListLoader. We remove the logic from ChangeListLoader and use TeamDriveListLoader instead. The full list is loaded only on startup, after that team drive changes (new/removed/changed) will arrive via default change list processing. Bug: 845058, 829154, 723955 Change-Id: I06c8d6d8e26ca1f02003768b879af8aa96a78b5b Reviewed-on: https://chromium-review.googlesource.com/1073036 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561828}
-
Michael Lippautz authored
Wrapper tracing uses TraceWrappersWithManualWriteBarrier when dealing with raw pointers. These uses need to use TraceWithWrappers in an Oilpan world as they would not be properly forwarded otherwise. Bug: chromium:841830 Change-Id: I725d2fbc8a8ac1f8387e4efeae5b74f02a294ed7 Reviewed-on: https://chromium-review.googlesource.com/1073171Reviewed-by:
-
Findit authored
This reverts commit 665ceb41. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 561811 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY2NWNlYjQxMmZlOWEyODI2OWMyZmNiMzExMTVmMjdhZWU2NmZmZDYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/69248 Sample Failed Step: browser_tests Original change's description: > Update ContentSettingsService access to incognito profile. > > ContentSettingsService handles incognito mode requests internally, so > a flag is set to redirect incognito mode requests to the original > profile. > Also, in Set Content Settings API, incorrect use of include_incognito() > function instead of IsIncognitoEnabled() is corrected. > Two tests are added to check that all settings written in incognito > are applied and do not affect regular mode, and incognito settings > cannot be modified from regular mode. > > Bug: 832697 > Bug: 845845 > Change-Id: I7fe259af6a6cbc030483ffac445bdef4b972c7cf > Reviewed-on: https://chromium-review.googlesource.com/1061853 > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561811} Change-Id: Iaba120a3b8107c9dddbf2826b72e5e4567ee3a37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845845 Reviewed-on: https://chromium-review.googlesource.com/1073088 Cr-Commit-Position: refs/heads/master@{#561826}
-
Boris Sazonov authored
This CL removes a field and a method that are no longer used. Bug: None Change-Id: I510e1cfa0a864f41618f00152c426399647b716c Reviewed-on: https://chromium-review.googlesource.com/1072090Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#561825}
-
Hans Wennborg authored
This roll includes: - f58d066 Add shebangs to pacify chromium presubmit error - ecc514d Parser.cpp: Fix undefined behaviour in float conversion - 59ca26e [inspector_protocol] Node.js is finally ready for transition.. - dd90116 [inspector_protocol] node uses script names inside own repository Bug: 845816 Change-Id: I3e6ddda9af210e1bfa6350d0999ce2f0ee170a44 Reviewed-on: https://chromium-review.googlesource.com/1070275 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561824}
-
Olga Sharonova authored
This reverts commit 2c2411fb. Reason for revert: Suspected cause of Issue 846609 Original change's description: > Perfetto: Fix ProducerClient threading/sequencing issues > > * TraceWriters will no longer be destroyed when their TLS slot is cleaned > up on thread shutdown as this can trigger a CommitData() call from > Perfetto and cause asserts when Mojo does a TaskRunnerHandle::Get() > for a PostTask; instead we leave the deletion to the taskrunner > Perfetto is running on (if it's getting shut down, the task should > get dropped). > * Run ProducerClients on their own sequence. > > Bug: 844379 > Change-Id: Ie45b36a4e463674122555dbec2105953a882f37c > Reviewed-on: https://chromium-review.googlesource.com/1069528 > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561356} TBR=primiano@chromium.org,oysteine@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 844379 Change-Id: I82eb4e335521ef8f39119bdd2a984f4dc81ac88c Reviewed-on: https://chromium-review.googlesource.com/1073247Reviewed-by:
-
Anders Hartvoll Ruud authored
R=futhark@chromium.org Bug: 751354 Change-Id: I9d2813bc8228bd0346e255bba24a2975fc8de310 Reviewed-on: https://chromium-review.googlesource.com/1067922Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#561822}
-
Kent Tamura authored
Add to_class_data_member() to NameStyleConverter, and use it instead of class_member_name(). * make_runtime_features.py: - Remove feature.class_member_name. Replace its usage with {{feature.name.to_class_data_member()}}. - Introduce _data_member_name() and feature.data_member_name. 'is_{{snake_case_name}}_enabled_' is used repeatedly in the python code and the templates. This CL doesn't change generated C++ code. Bug: 843927 Change-Id: I3b80460a05b155278a5f0bf46bddf0051a768457 Reviewed-on: https://chromium-review.googlesource.com/1073173Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#561821}
-
Alexandr Ilin authored
TBR=twellington@chromium.org Bug: 846619 Change-Id: I3dd36bdd5c57bcc9bfd0b3e826cb40c9b15561d0 Reviewed-on: https://chromium-review.googlesource.com/1073282Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561820}
-
Ned Nguyen authored
TBR=eyaich@chromium.org NOTRY=true # tests by PRESUMIT Bug: 844502 Change-Id: I335e1f3b8ad43fd00bcb3057fe4bb0323fb7289d Reviewed-on: https://chromium-review.googlesource.com/1073085Reviewed-by:
-
Lutz Justen authored
Just a bunch of random cleanups, no real changes: - Don't have default switch case, so that we'll get a compile error if someone adds values. - os << foo; return os ==> return os << foo; - Use base value's operator<< instead of duplicating it. - Use range based loops. - Clang format. BUG=None TEST=Tryjobs Change-Id: I766d7eba43e5ed93cebec4734e9acafc46bcb8ca Reviewed-on: https://chromium-review.googlesource.com/1063835Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#561818}
-
Hitoshi Yoshida authored
NameStyleConverter couldn't handle special tokens that contain numbers if its input string is written in lower camel case. For example, 'uint8ArrayMember' was tokenized as ['uint', '8', 'Array', 'Member'], while ['uint8', 'Array', 'Member'] was expected. This CL adds some lower case special tokens to handle them well. Bug: 761242 Change-Id: I255c4f756b6406ab7bf9d28a504b4fee38220c23 Reviewed-on: https://chromium-review.googlesource.com/1071049 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#561817}
-
Tsuyoshi Horo authored
To distinguish the signed exchange error from network layer errors. Bug: 815024 Change-Id: I165b8d44938575c2c5092c4f0012c1f58122ba79 Reviewed-on: https://chromium-review.googlesource.com/1073182Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#561816}
-
Olga Sharonova authored
This reverts commit f904fcc9. Reason for revert: Suspected of causing virtual/service-worker-servicification/external/wpt/service-workers/service-worker/worker-interception-redirect.https.html failures (example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/32483) Original change's description: > Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled." > > This relands r561423. > Original code review: https://chromium-review.googlesource.com/1069956 > > The original patch had a problem because the shadow page was created > before UnguessableToken. The fix is to not create the shadow page early, > which was only needed in an earlier patchset to get the task runner > from it. > > Bug: 839982, 846545 > Change-Id: Id6545d9d86a3a56a04e7f83a840d9acddd55f51b > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > TBR: kinuko, dcheng > Reviewed-on: https://chromium-review.googlesource.com/1073037 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561793} TBR=falken@chromium.org,dcheng@chromium.org,kinuko@chromium.org,nhiroki@chromium.org Change-Id: I56e491c5d74ee738c2ce6e530b7448319e14ab20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839982, 846545 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1073248Reviewed-by:
-
Michael Lippautz authored
Add unit tests that make sure that visitor dispatch reaches the expected leafs. Reland: - Avoid anon namespace in header file. This reverts commit a398ea4f. Bug: chromium:841830 Change-Id: I870d7f06baac17661a0d8bd16ee4ece78f8cdda6 Reviewed-on: https://chromium-review.googlesource.com/1073168Reviewed-by:
-
Greg Thompson authored
BUG=818832 R=martiniss@chromium.org NOTRY=true Change-Id: I399f412947d597b7b6fb810ef2f44e64233fdc1f Reviewed-on: https://chromium-review.googlesource.com/1071568 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#561813}
-
Kent Tamura authored
Use NameStyleUtilities.to_lower_camel_case() instead. This CL doesn't change generated C++ code. Bug: 843927 Change-Id: I3badfc7a432dcc400303d3d03e4a687f0c95fec4 Reviewed-on: https://chromium-review.googlesource.com/1073127Reviewed-by:
-
Ramin Halavati authored
ContentSettingsService handles incognito mode requests internally, so a flag is set to redirect incognito mode requests to the original profile. Also, in Set Content Settings API, incorrect use of include_incognito() function instead of IsIncognitoEnabled() is corrected. Two tests are added to check that all settings written in incognito are applied and do not affect regular mode, and incognito settings cannot be modified from regular mode. Bug: 832697 Bug: 845845 Change-Id: I7fe259af6a6cbc030483ffac445bdef4b972c7cf Reviewed-on: https://chromium-review.googlesource.com/1061853 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6b5912a. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18549 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hta@chromium.org: external/wpt/webrtc mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy msramek@chromium.org, mkwst@chromium.org: external/wpt/clear-site-data tdresser@chromium.org: external/wpt/navigation-timing yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=kereliuk No-Export: true Change-Id: I5b537b933478b46d5b0556657a36fb4915cf763d Reviewed-on: https://chromium-review.googlesource.com/1073077 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
Use the TabletModeController::EnableTabletModeWindowManager instead of TabletModeClient because frame depends on ash's frame code that depends on TabletModeController. This was passing because the test was comparing a first character of the icon name, which is same for all ash vector icons. Use EXPECT_STREQ instead. BUG=None TEST=fixed the unit test Change-Id: If57d4a69a26f16788d9ab9c880574f9a94e7c083 Reviewed-on: https://chromium-review.googlesource.com/1068641Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#561809}
-
Jérôme Lebel authored
Updating the unity user consent by adding assets and updating the margins to the latest version. Mock "01b": https://folio.googleplex.com/chrome-ux/mocks/467-mobile-unity-temp/_spec#%3Ff=hidden Screenshot: https://drive.google.com/open?id=1O6_s0GAF-9EMO7JGrjwrlQergCy8M7a4 Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4be0c1360a72a23e105cc2195e53dc461f50dc4f Reviewed-on: https://chromium-review.googlesource.com/1071444Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561808}
-
Vasilii Sukhanov authored
Previously we didn't change the state. Now it's gonna be inactive when there are no credentials for the page and "manage passwords" when there is something to manage. Bug: 820696 Change-Id: Ic80b24e97496c104ea807d55a6105bee23b4deaf Reviewed-on: https://chromium-review.googlesource.com/1071789Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#561807}
-
Henrik Grunell authored
Also copy it to Chrome. blink-dev discussion: https://groups.google.com/a/chromium.org/d/topic/blink-dev/ZvL_BhJjXGQ/discussion Bug: 846270 Change-Id: I75fb55a8e71a5b8ae5afb33eb3cd617f88f82f27 Reviewed-on: https://chromium-review.googlesource.com/1071427Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#561806}
-
Hajime Hoshi authored
This CL fixes worker's isolate to use V8 task runner instead of worker thread's default task runner. Bug: 841172, 846255 Change-Id: I3d462d0188f1860cad8b30ce083e24f9161afc84 Reviewed-on: https://chromium-review.googlesource.com/1071310Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I5c66688dcd70dd10b5ad9c4256636390c584d3c9 Reviewed-on: https://chromium-review.googlesource.com/1073083 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561804}
-
Mirko Bonadei authored
This is not updated by the auto-roller and it is not in sync with the real current revision. It is probably better to remove it since it is easy to get the commit position starting from the revision (just look at crrev.com/$revision). Bug: None Change-Id: I0523b9862d68115999b246944d95f94889f35098 Reviewed-on: https://chromium-review.googlesource.com/1071660Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#561803}
-
Yoichi Osato authored
VisualRect() should cover all visual effects including selections on SPVv175 because SPv175 uses VisualRect() instead of LocalSelectionRect() to invalidate selection. SPv1 also did that and the future SPv175 will do that when the DisplayItemClient needs full invalidation. This patch updates ComputeVisualRectInBacking to add selection rect to NGPaintFragment.VisualRect() for selection invalidating. Since NGPaintFragment.VisualRect() didn't consider selection rect, we missed invalidation. This patch fixes the problem by updating ComputeVisualRectInBacking to compute whole visual rect which consists of physical_fragment.VisualRect and NGPaintFragment::ComputeLocalSelectionRect(). ToT: https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/5662/layout-test-results/paint/selection/text-selection-newline-across-blocks-actual.png This patch: https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/5710/layout-test-results/paint/selection/text-selection-newline-across-blocks-actual.png Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie72e3dca922cba0a4c4585cb757156dd543b9bfc Reviewed-on: https://chromium-review.googlesource.com/1068947Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#561802}
-
Trent Apted authored
This reverts commit 2c03b1bd. Reason for revert: tests fail in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/19267 leak log like ({"numberOfLiveDocuments":[1,2],"numberOfLiveFrames":[1,2],"numberOfLiveNodes":[4,9],"numberOfLivePausableObjects":[2,3],"numberOfLiveResourceFetchers":[1,2]}) Original change's description: > Check page exist after dispatch dragstart > > frame_->GetPage() may be null. need to check before use GetDragState > This CL reorder the some checks in MouseEventManager::TryStartDrag > to make sure GetPage is valid before start drag. > > Bug: 843502 > Change-Id: Ifdf5b20d7132ca4b089c9a5b7652ebbd41370c33 > Reviewed-on: https://chromium-review.googlesource.com/1064878 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561262} TBR=dcheng@chromium.org,nzolghadr@chromium.org,eirage@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843502 Change-Id: I9412bbdf67a93acccbe4a75c5b50deee832eac97 Reviewed-on: https://chromium-review.googlesource.com/1072968Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#561801}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af2ffd933d0e..4d2e8bfffdbd $ git log af2ffd933..4d2e8bfff --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I70795d0b79cdc808603abd07dc065ed8fdaf0b87 Reviewed-on: https://chromium-review.googlesource.com/1072705Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561800}
-
Koji Ishii authored
Following bot results are included. 5817 5821 5829 5832 5835 5838 5844 5848 5850 5856 26 lines were removed and 3 lines were deflaked by consecutive results since 5769. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idd8b756bf4f4c8f2d2c1507375919efad09e8d07 Reviewed-on: https://chromium-review.googlesource.com/1071268 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#561799}
-
