- 18 Jun, 2020 40 commits
-
-
Josh Nohle authored
This reverts commit 65e3049c. Reason for revert: The root cause was found server-side; this workaround is no longer needed. Original change's description: > [DeviceSync v2] Force enrollment after SyncMetadata 404 errors > > This is a mitigation put in place to handle 404 errors returned by the > CryptAuth server during SyncMetadata requests. A 404 error is returned > when the server cannot find an enrolled device with the same Instance > ID. > > Theoretically, this should never occur assuming that 1) we never run a > v2 DeviceSync until the device has successfully enrolled using v2 > Enrollment and 2) the Instance ID does not rotate. Without this > mitigation, the user will unsuccessfully try to sync until the next > enrollment, which could be up to 30 days. > > This fix will be removed when the root cause is uncovered. > > Bug: 1092113, b/155642672 > Change-Id: Ibc766ad21d83d1ace26c5e8c6c45f3eed835da74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234126 > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Josh Nohle <nohle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776330} TBR=nohle@chromium.org,vecore@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1092113, b/155642672 Change-Id: I94ac09ca75aba101a800176c644beec4f9ace710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252622Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#779951}
-
Tommy Nyquist authored
Up until now, it has been complex to accessing an Activity UI Surface when you have a WebContents. This dependency acquisition has been a pain point, in particular for the modularization effort. This CL therefore creates a new UnownedUserData[Host] framework that allows any UI surface to make itself available through a host that does not own them. This allows the UI framework to still safely maintain the ownership model it needs, without being worried about resurrection. The UnownedUserDataHost stores the UnownedUserData objects using a WeakRef, allowing the objects to be garbage collected. The initial use-case for this is to allow objects to attach themselves to WindowAndroid, since that is available through WebContents. For usage patterns for this, see the class documentation for UnownedUserDataHost and UnownedUserDataKey. Guarantees provided by the framework: - The UnownedUserDataKey is generically typed to a particular type of UnownedUserData. - One UnownedUserDataKey can be used for multiple UnownedUserData instances. - One UnownedUserDataKey can be attached to multiple UnownedUserDataHost instances. - One UnownedUserDataKey can be attached to a particular UnownedUserDataHost only once. - This ensures a pair of UnownedUserDataHost and UnownedUserDataKey can only refer to a single UnownedUserData. - When an UnownedUserData object is detached from a particular host it is informed of this, except if it has been garbage collected. - When an UnownedUserData object is replaced with a different UnownedUserData using the same UnownedUserDataKey, the former is detached. Bug: 1091584 Change-Id: I4ed5f7f9f86dc28426f85646017e964bf0b1d4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189190 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#779950}
-
Nnamdi Theodore Johnson-Kanu authored
- Updates relevant chromeos BUILD.gn files - Add imports and exports to os_route, os_settings_route and os_settings.js - Update bluetooth test files. Bug: 1045266 Change-Id: I81e52893befe36b4757283428b7844b2de8fe514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220218 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779949}
-
Morten Stenshorne authored
If the block-start edge of a float was above the fragmentainer boundary, and its margin-block-start would take us past the boundary, we'd fail to detect the need for a break. The bug was that MovePastBreakpoint() expects a border edge block-start offset, but we were passing the margin edge from the float code. We also need to introduce an additional check before deferring to MovePastBreakpoint(), because in our implementation, float margins are unbreakable and also don't collapse with the fragmentainer boundaries (which MovePastBreakpoint() assumes that we can). Bug: 829028 Change-Id: If7336055df4e90b7cbf313e843d697f5e4c796a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250063Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#779948}
-
chrome://interstitialsJun Kokatsu authored
This change removes innerHTML usage from chrome://interstitials in order to be compatible with Trusted Types. Bug: 41905 Change-Id: I52416bfcf487ef0aba21ccf76e58ae957f479acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245937Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779947}
-
Aaron Leventhal authored
Bug: 1096515 Change-Id: I753e4d934b6c92d24f7b4276fc5fa9b716b45ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252418 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#779946}
-
Torne (Richard Coles) authored
WebView depends on viz even when weblayer is not being used; move the dependency to browser_java to match where the native dependency is, to fix the case when webview_includes_weblayer=false. Fixed: 1096081 Change-Id: Ic016657b26dee0d9135f7e0bc5a752823e3134f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250951Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#779945}
-
Kyle Ju authored
Change-Id: I4953ac7ea774fea1f6e96446547d2189b7ec30d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252279Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#779944}
-
Bill Carr authored
When a bluetooth device is connected that should be the system default or app default we may get a series of device change events that look something like bluetooth device -> system device (previous default) -> bluetooth device. In these cases if the final transition to bluetooth device occurs within 250ms of the device change notification for the system device we will ignore that change due to the current code that tries to protect against redundant role change notifications. Since in this case we do want to process the change and transition to the bluetooth device adding an additional check to ensure that the device id has not changed when ignoring a device change due to role timeout. Bug: 1095667 Change-Id: Ib6518a27f60aa2a0acfa592eb51fffaf375fc407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245797Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: William Carr <wicarr@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779943}
-
Lily Chen authored
This attempts to detect SameSite cookie "compatibility pairs" and tag them with a new CookieInclusionStatus::WarningReason. These are pairs of two similar cookies used to work around incompatible clients (browsers which do not support SameSite=None), where one has SameSite=None and Secure and the other has no SameSite attribute specified. The intention is that browsers which support SameSite=None and enforce SameSite-Lax-by-default will drop the old-style cookie, while browsers which do not support SameSite=None will drop the new-style cookie. The heuristic used to detect such pairs of cookies is: - The cookies cannot be equivalent (same name, domain, path). - One must have SameSite=None and Secure, and the other must have unspecified SameSite. - They must have the same domain, path, and value. - One must have a name that is a prefix or suffix of the other's name, and the shorter of the two names must have length at least 3. Such pairs of cookies are tagged if they are included in the same cross-site access attempt via HTTP request, HTTP response, or document.cookie read. Setting cookies via writing to document.cookie does not result in tagging of compatibility pairs. Additionally, a cookie access in a non-HTTP (i.e. script) context will not tag or compute cookie pairs from any cookie that has the HttpOnly attribute. Bug: 1095192 Change-Id: I43075cb851e6e02a5d2ef3e443e63e13fb21bd4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243255 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#779942}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2c9d76a4eb0f..f46902c540c3 2020-06-18 jakobi@webrtc.org Add a simple frame length controller. 2020-06-18 zhaoliang.ma@intel.com vp9_impl: Enable VP9D_SET_LOOP_FILTER_OPT for libvpx vp9 decoder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1086942 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia5c370d7284a50e8b5872e4e305ce49d8a360e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779941}
-
Peter Kasting authored
AFAICT, this was only originally added to avoid a crash on GTK (which didn't use views at the time) -- see https://codereview.chromium.org/1528032 . Views does tooltip eliding centrally at this point, so this should no longer be necessary. Bug: 139398 Change-Id: I768234808a6bf6c2b4730462c52927e206252f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249144Reviewed-by:
-
Deepanjan Roy authored
This metric corresponds to the current TBMv2 CPU time metric. See https://source.chromium.org/chromium/chromium/src/+/master:third_party/catapult/tracing/tracing/metrics/system_health/cpu_time_metric.html Bug: 1096236 Change-Id: Ib922da8032724992ac243e87d8b5e3497ac3d912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250946 Commit-Queue: Deep Roy <dproy@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#779939}
-
Peter Wen authored
Fix for `autoninja.py` since otherwise its regex assumes use_goma is not on. Bug: 1092528 Change-Id: I12b53e52485ae5750a9588f57b4518a6bf495ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252615 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#779938}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0ca3d7910867..4ca37e4df727 2020-06-18 zhin@chromium.org Update acorn-logical-assignment to 0.1.3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1080569 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8fa313124d0225814ec1bf6e4b97055416a02951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252438Reviewed-by:
-
Peter Kasting authored
This is the only user of these functions, and they're not "shelf"-related in any particular way. (No code changes to the functions themselves.) Bug: none Change-Id: Idfd321b09fd9926f27523710cca0a3f209e35835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251053 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#779936}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7a1d99d0be42..974cfa9fbbdb 2020-06-18 capn@google.com Optimize out-of-bounds checks with unsigned compare 2020-06-18 capn@google.com Replace instead of add pointer offsets when out of bounds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie6fa6928b3298e6bc329928add2afd80573b981d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252518Reviewed-by:
-
Clark DuVall authored
This makes WebLayer match Chrome's sad frame/plugin bitmap. This required moving the images into //components. Bug: 1023811 Change-Id: Ib3dedd7fb7a901bd1a393fac5f39b370c536046e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250920Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779934}
-
Siyu An authored
Here in the migration dialog the expiration date has the format: "Exp: 06/21" so it may lead to different length when translated. So here to be safe I just limited the label width directly, and hopefully will leave enough space for expiration date. Uploaded screenshot in bug comment #32 Bug: 1082013 Change-Id: I63759412571ac4f163dee779bd3eb98e83952de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241647Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#779933}
-
Etienne Bergeron authored
This CL is adding a ScopedThreadPriority that save the current thread priority and restore it when leaving the scope. This is required since it is possible to run code outside of the Run(...) scope with Background priority. On Windows, this is causing shutdown hangs because the LoaderLock can be held by a background thread while doing TLS destruction. Without this fix, the DCHECK in the code run with Background priority and fails: [9888:28656:0617/210735.064:FATAL:thread_local_storage.cc(331)] Check failed: PlatformThread::GetCurrentThreadPriority() != ThreadPriority::BACKGROUND (0 vs. 0) Backtrace: base::debug::CollectStackTrace [0x00007FF92445E7D2+18] (C:\src\chromium\src\base\debug\stack_trace_win.cc:284) base::debug::StackTrace::StackTrace [0x00007FF9243668F2+18] (C:\src\chromium\src\base\debug\stack_trace.cc:203) logging::LogMessage::~LogMessage [0x00007FF92437F094+148] (C:\src\chromium\src\base\logging.cc:605) logging::LogMessage::~LogMessage [0x00007FF92437FE40+16] (C:\src\chromium\src\base\logging.cc:598) base::internal::PlatformThreadLocalStorage::OnThreadExit [0x00007FF9244425FA+170] (C:\src\chromium\src\base\threading\thread_local_storage.cc:333) RtlActivateActivationContextUnsafeFast [0x00007FF96440B583+291] RtlActivateActivationContextUnsafeFast [0x00007FF96440B67F+543] LdrShutdownThread [0x00007FF964408B8C+348] RtlExitUserThread [0x00007FF9644436FE+62] BaseThreadInitThunk [0x00007FF96240403C+28] RtlUserThreadStart [0x00007FF964443691+33] Bug: 1096203 Change-Id: Ibc011ac370dde4b6a872da6ac81938f52965a5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251199 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#779932}
-
Nicolás Peña Moreno authored
This CL adds UMAs and UKMs for the experimental LCP metric, which considers removed content as valid LCP candidates. The nontrivial logic to compute the frame merges and image-text merges is done by the LargestContentfulPaintHandler, so the method parameters are changed to not explicitly query the non-experimental LCP versions, and the class is reused to computed the same merges for the experimental version. UKM collection review: https://docs.google.com/document/d/1Fdsg8t1d2X3nsE0QiVYnzslBjFA61NGhx0yMJQkZSEo/edit#heading=h.k5jx6iluw4yt Bug: 1045640 Change-Id: I7d733de0bbdd12c66256b203d735efe2fa825a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241943Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#779931}
-
Stephen Nusko authored
Currently when Chrome requests a screenshot we send a CopyOutputRequest from the browser. However while taking this screenshot we need to transfer it over a mojo pipe. This serialization takes 100-200 ms an example traces in the linked bug on the VizCompositor thread and then another 100-200 ms to deserialize it on the CrBrowserMain. This can block high priority tasks which delay input handling causing visible jank to users. We fix this by doing the expensive copies on the ThreadPool, most other copy tasks only take a couple ms so this removes most of the pain relatively easily. Tests had to be updated to know to wait for CopyOutputResult::SendResult to complete async. Bug: internal b/152858656 Change-Id: I114d65894c80742309bc2a02fdd2a0a7ad56dae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201762 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#779930}
-
Robert Sesek authored
The CFRunLoopTimer invalidation hack has been removed from MessagePump, so the workarounds for bugs caused by it can be removed. Bug: 925998, 920795, 1031343 Change-Id: I0c560a5569d798b3b41f5c287b2dc36fd0fcb715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251746Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#779929}
-
Katie Dektar authored
This reverts commit f26312b0. Reason for revert: This was only landed to be cherry-picked to M84. Reverting in M85 as the test doesn't flake in M85. Original change's description: > Disabling Reader Mode test which flakes in M84. > > Flakes are only occurring in M84 because a flake fix landed > after the 84 branch: crrev.com/c/2209281. > > This change will be cherry-picked to M84 and then reverted in M85. > > Bug: 1064776 > Change-Id: I6518458ac57f268b8c762097877b077e8852d833 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250159 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779885} TBR=wychen@chromium.org,katie@chromium.org Change-Id: I406b4fcd74b5af99cbc73f6aef9138b25ddfc7fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252694Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#779928}
-
Akira Baruah authored
Updates the RebootNow implementation on Fuchsia to use the Reboot FIDL interface instead of Suspend in order to provide granular reboot reasons. Bug: 158707064 Test: cast_reboot_unittests (with target_os="fuchsia") Change-Id: Ie13d2082937b191bcc118a6caf37518d94a8a30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250079 Commit-Queue: Akira Baruah <akirabaruah@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#779927}
-
Kyle Milka authored
No longer needed after ccrev.com/c/2196854! Bug: 1022172 Change-Id: I353bfd91654361fba5401ee84cbfcef7b14d1142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252033Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#779926}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5ad9ad04a741..7b282eb5f8fb 2020-06-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from bfa95c7ad8b7 to 23498d296498 (1 revision) 2020-06-18 syoussefi@chromium.org Disable ES3 perf tests on Nvidia/windows7/Vulkan 2020-06-18 syoussefi@chromium.org Fix restricted_traces/.gitignore If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1096510 Tbr: courtneygo@google.com Change-Id: I70e7b8ae274b264250e671b01560af628bc81f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252035Reviewed-by:
-
Stephanie Kim authored
This is a reland of f297bdfa Mac Builder's mb_config was updated to use that of Mac Builder Next's so that nacl is disabled. build761-m9 and build769-m9 now has their xcode paths properly configured Original change's description: > Promote Mac10.15 Tests to main waterfall > > Remove Mac Builder Next, switch OS of Mac Builder to 10.15 > > This CL copies what was done for Mac10.14: > https://chromium-review.googlesource.com/c/chromium/src/+/2036769 > > Bug: 1066873 > Change-Id: If227273be17c14547b16db1a68ff69f84fcc59eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242162 > Commit-Queue: Stephanie Kim <kimstephanie@google.com> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779041} Bug: 1066873 Change-Id: I26810565b9d00eab37ac67708845f8fb311c8e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250825Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#779924}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idef497708f327aa7dcfe265962afeee0b556c309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252558Reviewed-by:
-
cfredric authored
Bug: 973801,1087234 Change-Id: Icc63c547b16fe8c471c98d9b690a096d54a139b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241174 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#779922}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. CL also converts ImageCaptureFrameGragger for the same. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I432385671c44a6700316db6b58bf5c190cfba3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248062Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#779921}
-
Hongbo Song authored
This CL is for plumbing FSD from `render_frame_impl.cc` to browser process and record UKM in `ukm_page_load_mketrics_observer.cc`. Change-Id: I2caa0d5d29e7a4ff82a3a6f606b8bb3ad9f410c3 Bug: 922980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177653 Commit-Queue: Hongbo Song <hbsong@google.com> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#779920}
-
Stephen McGruer authored
This reverts commit a89d80c4. Reason for revert: Being reverted as part of a revert chain for a recent CL that is suspect of causing multiple issues; see https://chromium-review.googlesource.com/c/chromium/src/+/2252612 Original change's description: > Refactor: Decouple PasswordListItem from embedder > > This CL addresses a few design issues with PasswordListItem that predate > the introduction of PasswordsListHandler. > > - PasswordListItem would refer to a "menu" even though it knows nothing > about such menu, which is actually provided by the embedder. This CL > replaces mentions to passwordMenu in the component with what it actually > represents: the "more actions" button. > - The event fired by clicking the button was not documented in the file > overview. Moreover, the typedef for the event lived in the embedder. Now > the file exports the typedef. > - Tests that simulated clicks on the button would use the $$('#id') > syntax instead of the $.id one. This is now fixed. > > Bug: None > Change-Id: Ie815237134236468c639e73831bdb3eb7db36f98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248561 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779777} TBR=fhorschig@chromium.org,aee@chromium.org,victorvianna@google.com Change-Id: Id573b073d8d5081d5c05527896cfc6e230c4d2ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252614Reviewed-by:
-
Alexander Dunaev authored
During the drag and drop operation, the origin window can be destroyed, which will result in destruction of its DnD client that was controlling the operation. This CL adds a check for that. Bug: 1014860 Change-Id: I43410be1262d3ffee30b183c3942f1b309404a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243131 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Ana Salazar authored
This cl is intended to implement some of the recommendations extended by UX for the Launcher app paging. - Fix vertical spacing between pages, should be 12px - Border radius for background cards should be 12px - Peeking pages on top and bottom should have the same height - Focused page's background card should be Grey100 @ 20% - Non focused pages' background card should be Grey100 @ 10% - Add gradient mask in cardified state Bug: 996822 Change-Id: I602952f5776cdb6d28521546f2479d709240105a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250713 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#779917}
-
Stephen McGruer authored
This reverts commit e7be6d6b. Reason for revert: Being reverted as part of a chain of CLs suspected of causing problems - see https://chromium-review.googlesource.com/c/chromium/src/+/2252612 Original change's description: > Add missing flush() calls to passwords_section_test > > crrev.com/c/2246157 is suspect of causing failures in > CrSettingsPasswordsSectionV3Test. This could be caused by click events > in the new tests not being flushed, so this CL adds missing flush() > calls. > > Bug: None > Change-Id: I3abff7ddb894aa4a3cb3f7cf0dd2a06c7f05ec73 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252138 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779837} TBR=treib@chromium.org,fhorschig@chromium.org,victorvianna@google.com Change-Id: Id52fe41ab407b18dd154470832ba6d7798239653 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252613Reviewed-by:
-
Jihwan Marc Kim authored
with Play Billing. Whenever an app-store payment method is one of the payment methods being supported and any of the "requestShipping", "requestPayerName", "requestPayerEmail", and "requestPayerPhone" is true, then payment_request.cc should print an error message in developer console. Bug: 1095812 Change-Id: Icd1c0d1f43d1525591d701458afee1a8a828c7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249206Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779915}
-
Mustaq Ahmed authored
FullscreenControllerTest contains more than just fullscreen tests. This CL renames this into ExclusiveAccessTest, gives some methods a generic name to represent their correct functionalities, and moves mouse lock tests into a separate file. Change-Id: I3507a7cbb8a6e76928e1e6f86358bea2525f2ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239302Reviewed-by:
-
Doug Arnett authored
Adds new parameter within the TranslateSubFrames feature to control whether language detection occurs over sub frames or just the main frame. This will be used in a 3 arm Dev/Canary experiment that will look at language detection latency. Bug: 1096121 Change-Id: I4cb3fa997c070a4345584bbe8cfde29b25098d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250339Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#779913}
-
Xida Chen authored
Right now, the |frames_expected| for the aggregated throughput is simply the same as the |frames_expected| of the impl throughput. However, there are some edge cases where this could be wrong, such as the newly added test. In this case, we add jank in the script, the jank is long enough such that exactly half of the expected main frames gets presented on screen. In this case, half of the impl frames reports no damage, and thus the |frames_expected| for the aggregated throughput is only half of what it should be. This CL fixes the problem and add a test case. It could causes some changes to UMA for the: Graphics.Smoothness.PercentDroppedFrame.* TBR=sadrul@chromium.org Bug: None Change-Id: I3040a2db8a90e7d35ea2785204039b7c764e5435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234063 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779912}
-
