- 10 Jun, 2020 40 commits
-
-
Peter E Conn authored
Bug: 1087108 Change-Id: Ibf1775d96ea5600a1c2d73ee31ef4db8fbe307e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228617Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#776873}
-
Shakti Sahu authored
Bug: 1092953 Change-Id: Id2c700001e561d5ba69f69bd998a5715b0ac6048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238268 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#776872}
-
David Bertoni authored
This CL adds testing for Service Worked-based extensions through parameterized test fixtures. Bug: 1093066 Change-Id: Ie94d9eaa00a15e3a48be91505e02b04796055b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238947 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776871}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2234a98502c3..22c55b7e85c0 2020-06-10 mathias@chromium.org Include Unconfirmed issues in triage guidelines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1022301 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I21dde0c96f69ff7da547b652c0d0f88366d9146c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776870}
-
Maria Kazinova authored
returned an invalid value. Spotted a bug, that kNotSetRendererId value was treated as valid in Objective-C part. Bug: 1075444 Change-Id: Id81c7057075ca4388952248d3f480b504817f1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238166Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#776869}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 27659, 1092519 Change-Id: Ia0b763544724202c95dcc87e124ad62ed642c869 Tbr: futhark@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239591Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#776868}
-
Fredrik Söderqvist authored
When an element is removed from the priority queue, we move the last element into it's position and adjust the position of the element to "fix" the heap invariants. When fixing the invariants we were only considering the children of the former element and not the parents. The last element however is not guaranteed to have a priority/key that is greater or equal to that of the removed element (may for example be from the other subtree of the common ancestor of the two element), so the ordering with regards to the parent elements need to be considered. Try to percolate the last element up first in case it is less than the removed element. This makes Remove() essentially the same as Update() (except for the removal of the element). We now also need to specially consider the case where it's the last element that is removed. Bug: 1092074 Change-Id: I2ebbb4880f582fb32de75da0f5e7b03c2a963c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237786Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#776867}
-
Harald Alvestrand authored
- Allow codecType to be missing in CodecStats - Allow address to be null (not missing) in iceCandidateStats - Allow url to be missing (it is only supposed to be present for STUN and TURN generated candidates) Exceptionally allow address to be missing in order to work around a bug. Bug: chromium:1092721 Change-Id: Ib6d290a177b3c1be4c6238d346cba17ac0c18ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236477Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#776866}
-
Francois Beaufort authored
This CL makes some UI changes to how ptz is presented to the user: - camera is hidden in page info if ptz is granted or blocked - any change to ptz is reflected on camera - users see one permission for both camera and ptz when requested - bubble strings are adjusted when ptz is granted Screenshots: https://imgur.com/a/tlR4KRr Test: https://ptz.glitch.me/ w/ Experimental Web Platform Features flag Change-Id: Ia94c23ae0a79feb6f0744cfd0bc5bc0771604af6 Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224214 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776865}
-
David Munro authored
Test: Browser tests Bug: None Change-Id: I9b310580aa6b64649b72607019dac01862c711f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232252 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#776864}
-
Omid Tourzan authored
It adds a Speedometer to Task and get updated when new progress update comes to the task. The average window is set to 20, based on some experiment update rate is not consistent but it showed about per sec, so the average is for about 20 seconds. It would be updated through more experiments. It only works with CopyTask as the task types like Zip or Move don't report processed bytes. The following new fields dispatched to FE as part of task status: - currentSpeed - averageSpeed - remainingTime All the times unit to pass to FE is in second and speed is in B/s. FE supposed to polish it how to arrange magnitute. Bug: 953308 Change-Id: Idccb0385dc10ff5a6cee83c55f49b1cc0b39da5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217921 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#776863}
-
Simon Zünd authored
Use defaulted constructors and destructors in DevTools where appropriate. R=petermarshall@chromium.org Change-Id: I4f1fba20e636963ba4a8d4e6f8b6cf7dee89f426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239566 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#776862}
-
Peter Qiu authored
The new accelerated video decoder uses V4L2SliceVDA, which is not supported by Cast devices. So instead, we will force disable use of this new decoder through command line switch, which will fallback to use VdaVideoDecoder, which uses V4L2VDA. Bug: b/158230739 Test: Verify mirroring on Cast display devices Change-Id: I7765e6861c09a0357e2d923a20c9a56c1bdcb065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238876Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776861}
-
ssid authored
Make the expiry date same as the other memory histograms so they can be updated along with others. BUG=1053231 Change-Id: I27a5c0d71eb96bd9f4a638926682f15df5c6a0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236291Reviewed-by:
-
tby authored
Settings results now fall into two categories: those matching the 'canonical' name for a setting (eg. powerwash) and those matching an 'alternate' name for a setting (eg. factory reset). We need to handle these differently: alternate matches get extra filtering on the query length and relevance score. However, we always want to show the canonical result name, even if the result matches the alternate name. This CL also adds a couple of short-term TODOs for remaining settings search work. Bug: 1068851 Change-Id: Ief1eb3dbaa3efd28293e7311c5e641b09185bfe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237531 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#776859}
-
Kunihiko Sakamoto authored
This reverts commit 1b06acba. Reason for revert: Broke chromeos-eve-chrome build: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/8007 Original change's description: > Roll Skia from 990a04ecd5e8 to 437c78593cb5 (14 revisions) > > https://skia.googlesource.com/skia.git/+log/990a04ecd5e8..437c78593cb5 > > 2020-06-09 liyl@google.com [fuchsia] Always use full name of FIDL libraries. > 2020-06-09 csmartdalton@google.com Add an interactive sample that fits cubics to circular arcs > 2020-06-09 brianosman@google.com Switch persistent cache to use SkReadBuffer/SkWriteBuffer > 2020-06-09 johnstiles@google.com Update GrAlphaThresholdFragmentProcessor to use a child FP. > 2020-06-09 johnstiles@google.com Update GrCircleBlurFragmentProcessor to use a child FP. > 2020-06-09 mtklein@google.com Reland "remove unnecessary hsw opts" > 2020-06-09 mtklein@google.com remove -Fast bots > 2020-06-09 jcgregorio@google.com Move Pixel4 Perf jobs to the 4XL. > 2020-06-09 egdaniel@google.com Update vulkan linux sdk version on bots. > 2020-06-09 adlai@google.com Allow surfaces to validate against matching contexts, not ptr equality > 2020-06-09 herb@google.com make GrAtlasTextOp a friend of GrRenderTargetContext > 2020-06-09 robertphillips@google.com Auto-resolve DDL targets in flushSurfaces > 2020-06-09 fmalita@chromium.org [skrive] Initial artboard plumbing > 2020-06-09 jlavrova@google.com Removing fOffsets array from Run; optimizing copyTo > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/skia-autoroll > Please CC bungeman@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:1056730 > Tbr: bungeman@google.com > Change-Id: I7cfe11e24be042dc4350738c47a19775b7b0001f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238704 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#776790} TBR=bungeman@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I1ff509b1e9c477a8d3c5ca45062c79121e13f668 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1093216 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239429 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#776858}
-
Joel Hockey authored
Retina now seems to be rendering the same as mac10.13. Bug: 1092813 Change-Id: I9cfd187aa111a0aa74a4b5c45ea4da6f52d24bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237435 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#776857}
-
Timothy Loh authored
Bug: 1087726 Change-Id: I9a8ee94cef620e2b486d280cb62a7895e50a0e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235229 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2943cc478e46..8710a4f9740a 2020-06-10 dberris@chromium.org Revert "Increase length limit for subtest parts" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1092865 Tbr: oysteine@google.com Change-Id: I1b4e2e4dbc4b855df47061c9af1c3de1cf2bce65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239467Reviewed-by:
-
My Nguyen authored
Since arrow is needed to indicate more emojis available. Only loads 5 emojis for now until arrow is implemented. Bug: 1093179 Test: manual Change-Id: I1218c860d379510d3337cfd18244b1c5c9eb1b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237505Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776854}
-
Chris Lu authored
This change adds SaveCardBannerRequestConfig to the known Infobar Overlays. SaveCardInfobarBannerOverlayMediator will serve to configure SaveCard Inforbar banner Overlays properly for this config. Bug: 1071914 Change-Id: I2b37d118b36ba5ab3b109f4e2b79bd1053e81d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236692Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#776853}
-
Kunihiko Sakamoto authored
TBR=joelhockey@chromium.org No-Try: true Bug: 1093203 Change-Id: I3e2c5d9b4f76d21649a2a306327258c922cbba25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239131Reviewed-by:
-
David Bertoni authored
The UninstallWhileActivePageAction test was disabled for flakiness on Windows. It turns out this test was flaky on multiple platforms, because it would occasionally try to execute a JavaScript function defined in the extension's script before the script was finished initializing. The simple fix is to use TestExtensionMessageListener instances to wait for the extension script to finish initializing. Bug: 515717 Change-Id: Icc8e3accbbd6bf5e47524b1b34501eba2fe0fd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229416Reviewed-by:
-
Nathan Zabriskie authored
ClusterFuzz found a potential bad address read in RasterDecoderImpl::DoWritePixelsINTERNAL when |row_bytes| < SkImageInfo::minRowBytes() for the image. This CL enforces that minimum size on the client and service sides of the command. Bug: 1087921 Change-Id: Id4e95adb7a1be9d9b5d0d6640b8b8780a580b7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238847Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776850}
-
Chromium WPT Sync authored
Using wpt-import in Chromium af332606. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" a8a28083 "[Security][Coop] Browsing context switch reporting WPT" b2436c3b "Ensure cloning a template element into an inactive document does not crash." 027aefc6 "OPTION element: Update OPTION label even if it has invalid markup" 0776aa6d "Mark pointerevent_pointermove_in_pointerlock test non flaky" d2ee98f4 "Move manual offscreen wpt tests to own folder" 458dc853 "WPT: Migrate content-visibility tests to wpt." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools ksakamoto@chromium.org, npm@chromium.org: external/wpt/resource-timing NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I5b97cc3159beed5dade22288836283c1be8c4854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237757Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776849}
-
Adam Rice authored
The Streams implementation in Blink no longer uses JavaScript, so the eslint presubmit check is no longer necessary. Remove it. Change-Id: Ibd9362f6eb37175851df262e843a58712ef1b1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237566Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#776848}
-
Giovanni Ortuño Urquidi authored
As precursor to adding support for chrome-untrusted:// to WebUIController we add chrome-untrusted:// to HasWebUIScheme(). After auditing uses of HasWebUIScheme() it seems fine to add chrome-untrusted:// to it. After calling HasWebUIScheme(), ChromeWebUIControllerFactory only compares hosts when looking for the WebUIController for the URL. So this change causes ChromeWebUIControllerFactory to return WebUIControllers for chrome-untrusted:// URLs with the same hosts as chrome:// URLs. To avoid this we early return if the URL's scheme is chrome-untrusted. Change-Id: Ic63ccd9fc1c9066b79957af55ffcaedb27be9cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223709 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#776847}
-
Kunihiko Sakamoto authored
external/wpt/html/canvas/offscreen/filter/offscreencanvas.filter.w.html has been renamed to external/wpt/html/canvas/offscreen/manual/filter/offscreencanvas.filter.w.html. TBR=aaronhk@chromium.org No-Try: true Bug: 1093192,1041052,1091267 Change-Id: Ic488ff1a87cce9d27d770dfbaa745c658d572978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237584Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1c3a77ed8e33..62ace59d8c88 2020-06-10 rosasco@google.com [fuchsia] Fix fidlc command. 2020-06-10 johnstiles@google.com Revert "Update GrCircleBlurFragmentProcessor to use a child FP." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Ia20307257e4d090b677424af00f9c3d326fc03ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239104Reviewed-by:
-
Luciano Pacheco authored
Change SMB credentials dialog to comply with the new styles for Files app. Remove close button/icon from the dialog. Adjust the padding and spacing in the dialog, which changed the total height for the dialog from 250px to 230px. See crbug.com/992827#c38 for screenshots of before and after. Bug: 992827 Change-Id: Iaf0401186beb0f997451080e43d14b735fd93e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235228 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#776844}
-
Clark DuVall authored
WebLayer browsertests load the WebLayer implementation from the same APK the client is running in. This confuses Android and it no longer resolves dynamic attributes correctly, since a shared library APK is not expected to both be run as a normal APK and loaded as a shared lib. To fix this, switch to using app_as_shared_lib instead of shared_resources, which is what Monochrome uses to run both as Chrome and WebView. This was exposed by Colin's infobar CL which must be the first browsertest to hit a piece of UI using a dynamic attribute: http://crrev.com/c/2232555. Note that passing shared_resources to the "test" gn rule was added earlier for WebLayer, so switching to app_as_shared_lib shouldn't affect anyone else: http://crrev.com/c/1864517. Bug: 1025620 Change-Id: I95ec5500cdcf52167dfedffc9dbe79071895dc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238706 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#776843}
-
dpapad authored
Bug: 1091516 Change-Id: Ibcbb1dce1ca16b293f3f8998413632c29ed34042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236674 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#776842}
-
Hitoshi Yoshida authored
bindings team is going to update IDL dictionaries to be strict about their members' existence. After the update, accessing a getter on a missing dictionary member will crash. This CL fixes the potential bug in mojo conversions in ManifestImageResource. Bug: 839389 Change-Id: I90d2fd5c1361345892ce972fad7727952ab5fb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233105Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#776841}
-
Dominic Farolino authored
It is no longer needed. This reverts the mojo traits changes from https://crrev.com/c/2229205. TBR=kinuko@chromium.org Bug: 1090391,1091711 Change-Id: I93a38bc2351bbc1e5dffda040c7944271e01cde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238901Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit b47e683b. Reason for revert: The revert didn't fix the issue. Relanding. Original change's description: > Revert "Ignore CanvasResourceProvider::Clear in OOPR Mode" > > This reverts commit 84c360e5. > > Reason for revert: Suspect this CL causes OOPBrowserTest.Basic failure on linux-trusty-rel > > https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/12426 > > Original change's description: > > Ignore CanvasResourceProvider::Clear in OOPR Mode > > > > In OOPR Canvas2D we no longer have access to Skia in the client process. > > We need to update CanvasResourceProvider::Clear to not access SkCanvas > > in the case of OOPR. A more ideal fix is tracked in > > https://crbug.com/1090081 but simply ignoring it is fine for now as > > OOPR automatically handles clearing the canvas during initialization. > > > > Bug: 1090083 > > Change-Id: I5fb75e4fac312ec00b8e5215d3756219672461ee > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236193 > > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > > Reviewed-by: Khushal <khushalsagar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#776618} > > TBR=khushalsagar@chromium.org,nazabris@microsoft.com > > Change-Id: Ib906f07089a6b48eaf3e4b1f13fcfeae9d9b0896 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1090083 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237572 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776782} TBR=ksakamoto@chromium.org,khushalsagar@chromium.org,nazabris@microsoft.com # Not skipping CQ checks because this is a reland. Bug: 1090083 Change-Id: Ie523abd0820a9a7d02c47bda13d778e5c6f177df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237502Reviewed-by:
-
Jinsuk Kim authored
The CL was reverted due to a bug when used in Tablet which was fixed by https://crrev.com/c/2237012. Now can be landed again as is. This reverts commit c90c90f1. TBR=twellington@chromium.org Bug: 966272, 1092390 Change-Id: I4a6c671afa6544ccc2846214e1e841200e0083c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237536Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776838}
-
Naoki Fukino authored
I'd like to move LocationLine.PathComponent class and LocationLine.getComponents_() method out of LocationLine to share the logic in LocationLine and QuickView. Bug: 1092950 Test: Existing test passes / closure compiles Change-Id: I394a4a99815f9d6d8f60aefb7fd76cf0d8e423d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237570 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#776837}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/750036ef9035..2234a98502c3 2020-06-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I15dd2aa64c1534b07085accb7951cef3dcd34f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239346Reviewed-by:
-
Nektarios Paisios authored
On Windows, moving forward by one word should move to the start of the next word, punctuation or line break. On other platforms, it should first try to move to the end of the current word. This patch clarifies the attached accessibility event intents to specify whether we are moving to the end of the current word or to the start of the next one when selecting forward. Also, this patch fixes the "sentence/line/paragraphboundary" granularities to expose more information on the boundary they move to, depending on the selection direction. It fixes the "sentence/line/paragraph" granularities to always indicate that they move to the start of the next / previous boundary. AX-Relnotes: n/a. R=dmazzoni@chromium.org Change-Id: I3298f0d73b6bb5d123a15be34fc8c6c587d9594c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238186Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#776835}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/14f20b0ab38d..527080ff03ce 2020-06-10 xinghua.cao@intel.com Check FP16 support on Metal backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I9986ebcffab0690aff3824e8b2eaeaa27e8064ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239347Reviewed-by:
-
