GitLab

which are only called from one place:

  RecordAndCloseSessionOnError
  CloseSessionOnErrorInner

Review-Url: https://codereview.chromium.org/2849823005
Cr-Commit-Position: refs/heads/master@{#468272}

Cr-Commit-Position: refs/heads/master@{#468271}

When the Chrome installation has a brand code, the SettingsResetPromptModel may try to fetch default settings over the network. If the fetch fails, the ProfileResetter is passed a null pointer and any attempt to reset a setting will crash.

BUG=716372

Review-Url: https://codereview.chromium.org/2852883002
Cr-Commit-Position: refs/heads/master@{#468270}

TEST=run_compiler
BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846783006
Cr-Commit-Position: refs/heads/master@{#468269}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2847353002
Cr-Commit-Position: refs/heads/master@{#468268}

- NSS/ClientCertStoreTest/CertAuthorityFiltering
- DeviceDescriptionServiceTest.TestCleanUpCacheEntries

BUG=716730,716810
TBR=mattm@chromium.org,zhaobin@chromium.org

Review-Url: https://codereview.chromium.org/2850083002
Cr-Commit-Position: refs/heads/master@{#468267}

This CL adds SwapMetricsObserver which records swap rates and reports
them as platform-specific metrics. The purpose of adding these metrics
is to measure the impact of actions we take to free up memory. If we
aggressively free up memory under high memory pressure, we may touch
pages which are already swapped out (or compressed). In such cases
thrashing could happen and we are making the situation worse.
Swap rates and page compression/decompression rate would be good
indicators of thrashing. Metrics will be recorded every 60 seconds.

This CL only adds metrics for Android/ChromeOS/Linux. Follow-up CLs
will add them for macOS.

BUG=617492

Review-Url: https://codereview.chromium.org/2824133002
Cr-Commit-Position: refs/heads/master@{#468266}

This CL adds a feature flag which, when enabled, causes media requests to call
into PermissionManager::RequestPermissions in order to display a permission
prompt (among other things). The feature flag is added because this results in
the UI changing, and also won't work on Android until we have unified the
permission request codepaths (see https://crbug.com/606138).

BUG=596786

Review-Url: https://codereview.chromium.org/2829123003
Cr-Commit-Position: refs/heads/master@{#468265}

This CL fixes a regression since r467828. It changed the working directory, but
it missed to update relative path in "git add" argument.

BUG=710535
TBR=jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2848183002
Cr-Commit-Position: refs/heads/master@{#468264}

Revert of Change ScopedFeatureList to overrides FeatureList not reset (patchset #6 id:140001 of https://codereview.chromium.org/2834583002/ )

Reason for revert:
Mac ASAN bots reporting use-after-free errors.

Original issue's description:
> Change ScopedFeatureList to overrides FeatureList not reset
>
> The current situation is that using ScopedFeatureList resets to an
> empty feature list and then enables/disables an explicit list of
> features.
>
> That's never what you want for browser tests (or other higher-level
> tests) since it effectively overrides higher-level test configurations
> (e.g. those in fieldtrial_testing_config.json, or a bot set up to
> specifically test a feature).
>
> In this patch:
>
> 1. Keep SFL::Init, SFL::InitWithFeatureList,
>    SFL::InitFromCommandLine reset to empty list but add warning to
>    remind developer should use them with care.
> 2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
>    SFL::InitWithFeatures to not reset but override current FeatureList
>    with given enables/disables.
>
> We also add unit tests for ScopedFeatureList.
>
> BUG=713390
>
> Review-Url: https://codereview.chromium.org/2834583002
> Cr-Commit-Position: refs/heads/master@{#468210}
> Committed: https://chromium.googlesource.com/chromium/src/+/9c04ed553bd7abe820a6a93c5e8981e6738881a9

TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,chaopeng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713390

Review-Url: https://codereview.chromium.org/2850073002
Cr-Commit-Position: refs/heads/master@{#468263}

1. A local variable |copied_files| is never read. Remove it.
2. So, copy_file() needs to return nothing.
3. Then, _webkit_root is removable.

Review-Url: https://codereview.chromium.org/2852673003
Cr-Commit-Position: refs/heads/master@{#468262}

BUG=710535

Review-Url: https://codereview.chromium.org/2848853002
Cr-Commit-Position: refs/heads/master@{#468261}

It can be replaced with path_from_tools_scripts().

BUG=710535

Review-Url: https://codereview.chromium.org/2849743003
Cr-Commit-Position: refs/heads/master@{#468260}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dabd7bd5..489561d2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2853703002
Cr-Commit-Position: refs/heads/master@{#468259}

The 'offset-rotation' property has been replaced by 'offset-rotate'.

'offset-rotation' is among the properties disabled in M58.

The runtime flag to conditionally enable 'offset-rotate' is also
being retired, as offset-rotate has shipped.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/FgU5o52yBAAJ

BUG=711937

Review-Url: https://codereview.chromium.org/2842933003
Cr-Commit-Position: refs/heads/master@{#468258}

See: https://github.com/KhronosGroup/WebGL/issues/2274

BUG=714240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2821363003
Cr-Commit-Position: refs/heads/master@{#468257}

R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2851953003
Cr-Commit-Position: refs/heads/master@{#468256}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4aa32418..dabd7bd5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2851853005
Cr-Commit-Position: refs/heads/master@{#468255}

https://skia.googlesource.com/skia.git/+log/135c90881287..0c5cf5d7a260

$ git log 135c90881..0c5cf5d7a --date=short --no-merges --format='%ad %ae %s'
2017-04-30 update-skps Update SKP version

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I88d87a480e2ee4f590bfa952f3121b206e613ab7
Reviewed-on: https://chromium-review.googlesource.com/491069Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468254}

BUG=714672

Review-Url: https://codereview.chromium.org/2846703004
Cr-Commit-Position: refs/heads/master@{#468253}

BUG=714191

Review-Url: https://codereview.chromium.org/2831183004
Cr-Commit-Position: refs/heads/master@{#468252}

Discover process:
  DialMediaSinkService.Start() registers itself with DialRegistry
  DialMediaSinkService.OnDialDeviceEvent() gets invoked when device data comes back, and starts a 3s timer
  Start description fetches for each device
  DeviceDescriptionService.OnDeviceDescriptionFetchComplete() gets invoked when device description comes back.
  Starts an XML parser in utility process to parse device description XML
  DialMediaSinkService.OnDeviceDescriptionAvailable() gets invoked when parsing in utility process finishes
  Create MediaSinkInternal and store it in DialMediaSinkService's sink map
  Invoke DialMediaSinkService.FetchCompleted() when timer expires

Design doc:

https://docs.google.com/document/d/1lJbE4Oc9q1amkWEaD2ZL4mHEdRRlKHvwxUUcJmNC8b8/edit#heading=h.ur85je1upm9u

BUG=687375

Review-Url: https://codereview.chromium.org/2701633002
Cr-Commit-Position: refs/heads/master@{#468251}

Cr-Commit-Position: refs/heads/master@{#468250}

Revert of Reland "[Chromecast] Use base::FeatureList to control features." (patchset #4 id:60001 of https://codereview.chromium.org/2836263003/ )

Reason for revert:
Breaks ATV at runtime.

Original issue's description:
> Reland "[Chromecast] Use base::FeatureList to control features."
>
> This feature was reverted due to the new browsertest being flaky on
> internal Cast infrastructure: crrev.com/2838813003
>
> === Original Commit Message ===
> In Chromium, Finch-enabled features are controlled through base::FeatureList,
> a class which abstracts the experiment framework and developer overrides
> from client code. Though Chromecast's experiment framework is fundamentally
> different (in that it is server-driven) Cast builds can still make use of
> this class. Introduce some utilities to help.
>
> At boot-up, the pref store will be queried for experiment configs, which
> were cached to disk on the most recent config fetch from the last boot
> cycle. If a developer overrides these features from the command line,
> that value takes precedence. These features will be used to initialize
> base::FeatureList, which can then be statically queried from any client
> code that depends on //base.
>
> This patch does not actually introduce or convert any existing features
> to use this framework.
>
> BUG=714291
> BUG= internal b/35424335
>
> Review-Url: https://codereview.chromium.org/2836263003
> Cr-Commit-Position: refs/heads/master@{#467998}
> Committed: https://chromium.googlesource.com/chromium/src/+/aab6bf24d32d931359b2d0c25fb39b3ed51fbc86

TBR=maclellant@chromium.org,halliwell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=714291

Review-Url: https://codereview.chromium.org/2847423002
Cr-Commit-Position: refs/heads/master@{#468249}

Changes:
As from discussion with UX writer, updating the label name here.

BUG=658048
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2847173003
Cr-Commit-Position: refs/heads/master@{#468248}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/144ff1bd..4aa32418

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2851963002
Cr-Commit-Position: refs/heads/master@{#468247}

Adding COMPONENT/TEAM information into OWNERS file.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=wfh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2703443002
Cr-Commit-Position: refs/heads/master@{#468246}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bfd28fa6..144ff1bd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2849033002
Cr-Commit-Position: refs/heads/master@{#468245}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2848163002
Cr-Commit-Position: refs/heads/master@{#468244}

Currently ToCoreProbe code checks the given ExecutionContext's type
and calls different code to get its CoreProbeSink, but in this way
we need to keep adding new ToCoreProbe code every time we add
new ExecutionContext, which sounds a bit cumbersome.

This CL adds ExecutionContext::GetProbeSink() virtual method
to mitigate that.

BUG=538751

Review-Url: https://codereview.chromium.org/2847703002
Cr-Commit-Position: refs/heads/master@{#468243}

Adds labels describing missing information (e.g., "Add Email Address") to shipping + contact info views. Adds validation for shipping addresses. Adds cacheing to PaymentsProfileComparator, and adds an instance to PaymentRequestState so that cached values can be used throughout the request.

BUG=711358,709454,
TBR=mahmadi@chromium.org

Review-Url: https://codereview.chromium.org/2847503002
Cr-Commit-Position: refs/heads/master@{#468242}

Some metrics about encryption migration are already recorded in cryptohomed.
In this CL, I'd like to add following UI-related UMA metrics on the app.

Cryptohome.MigrationUI.FirstScreen
Cryptohome.MigrationUI.UserChoice
Cryptohome.MigrationUI.ConsumedBatteryPercent

BUG=714887
TEST=Disable reboot after the migration by modifying the code, and check that chrome://histograms shows the added metrics.

Review-Url: https://codereview.chromium.org/2849833002
Cr-Commit-Position: refs/heads/master@{#468241}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2846413002
Cr-Commit-Position: refs/heads/master@{#468240}

This is a single character change to temporarily switch Chrome to
building with VC++ 2017. This CL is currently purely for testing
purposes and will be landed for the weekend in order to flesh out any
remaining bugs.

This is a retry of crrev.com/2762093003 which failed due to a compiler
warning which was missed in local testing and the try bots. That warning
has been resolved and a local build of 'all' completed cleanly.

BUG=683729

Review-Url: https://codereview.chromium.org/2852433005
Cr-Commit-Position: refs/heads/master@{#468239}

During the emulation of srgb for generateMipmap, we tried to generate all
levels of the original texture. But if the texture is immutable texture,
we can't generate mipmaps exceed the original range.
Also, when the width and height are not equal, they should be at least one
during the emulation.

BUG=712096
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2841503002
Cr-Commit-Position: refs/heads/master@{#468238}

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to "fix_gn_headers.py --remove", and
chose which matches to apply interactively.

8 missing headers in the build were fixed because they were moved.

BUG=716359

Review-Url: https://codereview.chromium.org/2849763002
Cr-Commit-Position: refs/heads/master@{#468237}

This changes some method names to make them more accurate, and splits
out ResizeAfterLayout from LayoutUpdated.  In a subsequent patch, these
two methods will be called independently through ChromeClient.

BUG=701575

Review-Url: https://codereview.chromium.org/2848043002
Cr-Commit-Position: refs/heads/master@{#468236}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/733cb1f1..bfd28fa6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2847373002
Cr-Commit-Position: refs/heads/master@{#468235}

BUG=577685

Review-Url: https://codereview.chromium.org/2643183002
Cr-Commit-Position: refs/heads/master@{#468234}

This method disallows PaintLayer creation inside a LayoutSVGHiddenContainer,
even for overflow-clipping elements that would normally require a PaintLayer.

This wreaks havoc in the layout code which assumes in numerous places that
HasOverflowClip() implies GetScrollableArea() != nullptr.

It was added in http://crrev.com/88e9d056 to fix a paint bug, but it seems
unnecessary now.  The svg/foreignObject layout tests all pass and the original
test case on http://wkbug.com/41386 still renders correctly after this change.

BUG=710087

Review-Url: https://codereview.chromium.org/2851763004
Cr-Commit-Position: refs/heads/master@{#468233}