GitLab

This macro is defined but never used, and appears to be a vestige of
landing https://bugs.webkit.org/show_bug.cgi?id=109369 that was never
cleaned up.

BUG=

Review URL: https://codereview.chromium.org/212733002

git-svn-id: svn://svn.chromium.org/blink/trunk@170087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
    Fix a ChickenAndEgg issue by delaying scroll until the
    next paint when the compositing layers are up to date.
    The amount scrolled but not painted is stored in
    ScrollView::m_pendingScrollDelta.
    
    Rearrange the code such that if there are fixed position
    elements, do the following before painting:
    
    1. Walk the tree and do updateLayerPosition
    2. Mark that we need to update compositing layers since
       layers may have changed as a result of scrolling if
         there are fixed elements.
    3. Update compositing layers.
    4. Invalidate fixed position elements.
    5. Update repaint rects for fixed position elements to
       reflect the new scroll position.
    
    Also, when calculating repaint rects for fixed elements,
    take into account both the scroll position and the
    scroll delta. This way we can invalidate the previous
    scroll position for the fixed element if it is
    promoted to a layer as a result of scrolling.

BUG=343766
BUG=343767

Review URL: https://codereview.chromium.org/191693002

git-svn-id: svn://svn.chromium.org/blink/trunk@170086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because these notifications only got sent if the corresponding AXObject
already existed, they were effectively never sent before the first
load complete notification. This change creates the AXObject for the
document element after the first layout, allowing future notifications too.

BUG=353067

Review URL: https://codereview.chromium.org/199693003

git-svn-id: svn://svn.chromium.org/blink/trunk@170085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=caseq@chromium.org
BUG=344238

Review URL: https://codereview.chromium.org/213263003

git-svn-id: svn://svn.chromium.org/blink/trunk@170084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=japhet@chromium.org
BUG=356777

Review URL: https://codereview.chromium.org/213173004

git-svn-id: svn://svn.chromium.org/blink/trunk@170082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The <compound-selector> argument may not be empty according to spec.

BUG=356578

Review URL: https://codereview.chromium.org/212383002

git-svn-id: svn://svn.chromium.org/blink/trunk@170081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

mediaPlayerRequestFullscreen() is only ever called from Chromium's
BrowserMediaPlayerManager::OnProtectedSurfaceRequested() when the
--disable-gesture-requirement-for-media-fullscreen flag is used.

Make this behavior explicit, limiting it to just this case instead of
disabling it even for script-initiated fullscreen requests.

This will allow removing the mediaFullscreenRequiresUserGesture setting
once Chromium has been updated.

BUG=355439
TEST=LayoutTests/media/media-player-request-fullscreen.html

Review URL: https://codereview.chromium.org/209693003

git-svn-id: svn://svn.chromium.org/blink/trunk@170080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Generate a user gesture when drop event is fired. This is useful for extensions
to call some user gesture based APIs during a drop event. Please see the bug
for a sample extension.

R=adamk@chromium.org,abarth@chromium.org
BUG=355269

Review URL: https://codereview.chromium.org/208853006

git-svn-id: svn://svn.chromium.org/blink/trunk@170079 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clean up blink_platform.gypi and remove references to files that are
no longer part of the build.

TBR=leviw@chromium.org
BUG=313423

Review URL: https://codereview.chromium.org/213163002

git-svn-id: svn://svn.chromium.org/blink/trunk@170078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GzMh_HfjUVc

This method is removed is from SVG2, uses the deprecated CSSValue and use counter data indicates it is little or not used.

Review URL: https://codereview.chromium.org/196173020

git-svn-id: svn://svn.chromium.org/blink/trunk@170077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dgozman
BUG=356743

Review URL: https://codereview.chromium.org/212883003

git-svn-id: svn://svn.chromium.org/blink/trunk@170076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Enabling DirectWrite requires the sandbox to have knowledge of whether
DirectWrite or GDI is used for font rendering, so it's now decided
in the browser. Don't do fallback behavior in the renderer any more.

Browser side is https://codereview.chromium.org/209163002/ .

R=jamesr@chromium.org
BUG=333029

Review URL: https://codereview.chromium.org/210243004

git-svn-id: svn://svn.chromium.org/blink/trunk@170075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since there's no reason that the MediaQueryTokenizer's codepoints array would be created dynamically, I've created it here as an initialized array.
I used the build scripts to do that.



BUG=

Review URL: https://codereview.chromium.org/209503003

git-svn-id: svn://svn.chromium.org/blink/trunk@170074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=285976

Review URL: https://codereview.chromium.org/210833004

git-svn-id: svn://svn.chromium.org/blink/trunk@170073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds an intra-priority level sorting value for finer grained
control of resource loading. The blink side of this patch sorts images by
estimated on screen real-estate, preferring to download images in order of
decreasing visual impact. Ie. On a page with a large banner, and dozens of
small icons, the large banner will most likely be scheduled ahead of the
others.

In the future, we can also use this to experiment with other signals, ie.
prioritize out of viewport images by their distance to viewport.

Will be followed up by https://codereview.chromium.org/146333004/.

In our tests, this was a nice win on speed-index for desktop, with a gain of 
about ~2-3%. 

This is first of 3 sided patch. Following pattern suggested on chromium-dev:

"
1) Add the new WebKit interface, preserving the old.
2) Change Chrome to use the new interface.
3) Modify WebKit to remove the old interface.
"

Review URL: https://codereview.chromium.org/153983004

git-svn-id: svn://svn.chromium.org/blink/trunk@170072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebGL spec requires that getExtension "Returns an object if, and only if,
name is an ASCII case-insensitive match [HTML] for one of the names
returned from getSupportedExtensions; otherwise, returns null." Respect
this requirement by always returning both unprefixed and prefixed names
from getSupportedExtensions in case they are supported by getExtension.

Functionality that is common to both getExtension and
getSupportedExtensions is refactored to separate helper functions so that
maintaining this becomes easier.

BUG=354454
TEST=WebGL conformance tests
R=bajones@chromium.org, kbr@chromium.org

Review URL: https://codereview.chromium.org/205903004

git-svn-id: svn://svn.chromium.org/blink/trunk@170071 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=356742
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/213153004

git-svn-id: svn://svn.chromium.org/blink/trunk@170070 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drive-by: Provide and handle a synthetic keyCode for synthetic KeyboardEvents.
This is required for handling of shortcuts forwarded from extension panels.

R=caseq

Review URL: https://codereview.chromium.org/212573006

git-svn-id: svn://svn.chromium.org/blink/trunk@170069 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TEST=LayoutTests/inspector/utilities.html
R=alph, pfeldman

Review URL: https://codereview.chromium.org/212863005

git-svn-id: svn://svn.chromium.org/blink/trunk@170068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change introduces HTMLImport::SyncMode for readability.

TEST=none
BUG=356257
R=dominicc@chromium.org

Review URL: https://codereview.chromium.org/211363004

git-svn-id: svn://svn.chromium.org/blink/trunk@170067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r168968 made us avoid full invalidations in repaintAfterLayoutIfNeeded
for shifted renderers. This is wrong as inserted / removed renderers
can shift content without marking them for layout.

The old logic would rely on the outline box to detect the previous
case and force a full invalidation but r168968 disabled the outline
box checks unless you have an outline.

This change brings back the full-invalidation-on-shifted-renderer,
which brings back some missing invalidations. The new baselines are
matching pre-r168968 baselines but we haven't completely reverted
the changes from r168968 so it's still an overall win.

BUG=353933

Review URL: https://codereview.chromium.org/210203005

git-svn-id: svn://svn.chromium.org/blink/trunk@170066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn the global Window into a garbage collected object.

R=haraken@chromium.org,ager@chromium.org,wibling@chromium.org,zerny@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/211373002

git-svn-id: svn://svn.chromium.org/blink/trunk@170065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/212703003

git-svn-id: svn://svn.chromium.org/blink/trunk@170064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, the media stream track will create one source provider and let WebAudio use it. But this does not work when there are more than 1 WebAudio AudioContexts connecting to the same media stream.
This Cl fixes the problem by creating one source provider for each CreateMediaStreamSource() call.

NOTRY=true

BUG=354468

Review URL: https://codereview.chromium.org/202923007

git-svn-id: svn://svn.chromium.org/blink/trunk@170063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove old functions. Now there are no 'SysEx' and 'sysEx' strings
in Web MIDI implementation after this change.

Here are a series of changes on this renaming. 
1. https://codereview.chromium.org/208243014/
2. https://codereview.chromium.org/210003002/
3. this change

BUG=349538
TEST=LayoutTests/webmidi

Review URL: https://codereview.chromium.org/208423016

git-svn-id: svn://svn.chromium.org/blink/trunk@170062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641

Review URL: https://codereview.chromium.org/205403004

git-svn-id: svn://svn.chromium.org/blink/trunk@170061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Steal a bit from RenderBlock to avoid descending through the same
stack of nested boxes multiple times while preparing to lay them out.


This CL creates a 4% improvement in the 
Performance/Layout/floats_*_nested.html tests.

Review URL: https://codereview.chromium.org/195363007

git-svn-id: svn://svn.chromium.org/blink/trunk@170060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey,eustas
BUG=178635
NOTRY=true

Review URL: https://codereview.chromium.org/212653002

git-svn-id: svn://svn.chromium.org/blink/trunk@170059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

clientBridgePtr->run() can allocate and is therefore not part of the
safe point.

TBR=haraken@chromium.org, vegorov@chromium.org
NOTRY=true
BUG=356307

Review URL: https://codereview.chromium.org/212573005

git-svn-id: svn://svn.chromium.org/blink/trunk@170058 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of pointing to actual console.log() call done from a framework wrapper function,
we should point to the user code.

BUG=231007
R=pfeldman

Review URL: https://codereview.chromium.org/211493002

git-svn-id: svn://svn.chromium.org/blink/trunk@170057 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes pretty-print functionality for VM scripts.

BUG=356269

Review URL: https://codereview.chromium.org/211243006

git-svn-id: svn://svn.chromium.org/blink/trunk@170056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add a setting which when enabled will append a time stamp to each
message in the console.

BUG=131714

Review URL: https://codereview.chromium.org/185713007

git-svn-id: svn://svn.chromium.org/blink/trunk@170055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes InspectorHistory::Action class to be refcounted. This
helps to get results of completed operations in InspectorHistory without
possibility of use-after-free (this patch fixes two of this cases).

BUG=

Review URL: https://codereview.chromium.org/208893007

git-svn-id: svn://svn.chromium.org/blink/trunk@170054 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add runtime feature and property names for unprefixed CSS Transforms (https://codereview.chromium.org/211033002/)

Reason for revert:
Breaks telemetry_unittests: 
http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/13762

Here is how you can run the tests after you build debug chrome: 
tools/telemetry/run_tests --browser=debug web_components.web_components_unittest

Original issue's description:
> Add runtime feature and property names for unprefixed CSS Transforms
> 
> Adds a runtime flag (enabled only for testing) and defines property names
> for each property defined in CSS Transforms[1]. Future patches will make
> these properties functional.
> 
> [1] http://www.w3.org/TR/css3-transforms/
> 
> NOTRY=true
> BUG=154772
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170005

TBR=eseidel@chromium.org,esprehn@chromium.org,dstockwell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=154772

Review URL: https://codereview.chromium.org/212563007

git-svn-id: svn://svn.chromium.org/blink/trunk@170053 bbb929c8-8fbe-4397-9dbb-9b2b20218538

{,un}setPendingActivity is deprecated. This CL replaces it with |hasPendingActivity()| override.

This also makes FileSystemCallbacks reference to the DOMFileSystem strong, as |addPendingCallbacks()| would no longer ref() DOMFileSystem.

TEST=fast/filesystem
BUG=354845

Review URL: https://codereview.chromium.org/212263002

git-svn-id: svn://svn.chromium.org/blink/trunk@170052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits (https://codereview.chromium.org/212763002/)

Reason for revert:
I don't think this was a reason of failures

Original issue's description:
> Revert of Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits (https://codereview.chromium.org/210573002/)
> 
> Reason for revert:
> This might have caused android tests failure: 
> http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/18266
> Speculatively reverting it.
> 
> Original issue's description:
> > Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits
> > 
> > Remove the unused m_emSizeInFontUnits field and emSizeInFontUnits
> > method from FontPlatformDataHarfBuzz.
> > 
> > BUG=355806
> > R=pdr@chromium.org
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169955
> 
> TBR=pdr@chromium.org,dglazkov@chromium.org,eae@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=355806
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170048

TBR=pdr@chromium.org,dglazkov@chromium.org,eae@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=355806

Review URL: https://codereview.chromium.org/212563005

git-svn-id: svn://svn.chromium.org/blink/trunk@170051 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Preserve autosizing multiplier on style recalc. (https://codereview.chromium.org/208393008/)

Reason for revert:
This might have caused android tests failure: 
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg...
Speculatively reverting it.

Original issue's description:
> Preserve autosizing multiplier on style recalc.
> 
> BUG=353309
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169961

TBR=pdr@chromium.org,esprehn@chromium.org,skobes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=353309

Review URL: https://codereview.chromium.org/212163006

git-svn-id: svn://svn.chromium.org/blink/trunk@170050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None
TBR=michaeln

Review URL: https://codereview.chromium.org/198913003

git-svn-id: svn://svn.chromium.org/blink/trunk@170049 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits (https://codereview.chromium.org/210573002/)

Reason for revert:
This might have caused android tests failure: 
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/18266
Speculatively reverting it.

Original issue's description:
> Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits
> 
> Remove the unused m_emSizeInFontUnits field and emSizeInFontUnits
> method from FontPlatformDataHarfBuzz.
> 
> BUG=355806
> R=pdr@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169955

TBR=pdr@chromium.org,dglazkov@chromium.org,eae@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=355806

Review URL: https://codereview.chromium.org/212763002

git-svn-id: svn://svn.chromium.org/blink/trunk@170048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org, tkent@chromium.org, vegorov@chromium.org
BUG=356307

Review URL: https://codereview.chromium.org/212553002

git-svn-id: svn://svn.chromium.org/blink/trunk@170047 bbb929c8-8fbe-4397-9dbb-9b2b20218538