GitLab

This function is not defined or used anywhere any more.

BUG=none
TEST=build


Review URL: http://codereview.chromium.org/10198008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133794 0039d316-1c4b-4281-b951-d872f2087c98

It's important to destroy the ResourceContext before we start destroying the URLRequestContext and the members it owns, because destroying the ResourceContext will cancel the pending URLRequests for that ResourceContext in the ResourceDispatcherHost. Those URLRequests may reference the URLRequestContexts in their destructors, so we need to make sure ResourceContext is destroyed first.

While doing this, I did some other cleanup:
  * discovered that we could eliminate HostContentSettingsMap from ProfileIOData, w00t!
  * reordered URLRequestContext after the members it points to, so it gets destroyed before they get destroyed
  * moved the virtuals in ProfileIOData::ResourceContext to be public, since the parent class changed them to be public

BUG=90971
TEST=none


Review URL: http://codereview.chromium.org/10174008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133793 0039d316-1c4b-4281-b951-d872f2087c98

before backoff starts due to failures, for use with captive
portal code.

R=joi@chroimium.org
BUG=87100, 115487

Review URL: http://codereview.chromium.org/10173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133792 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10207001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133791 0039d316-1c4b-4281-b951-d872f2087c98

The test fails on chrome-mac-10_7-qa. See bug for more info.

TEST=none
BUG=124886
Review URL: https://chromiumcodereview.appspot.com/10181014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133790 0039d316-1c4b-4281-b951-d872f2087c98

Now we ignore errors returned from FixupURLAndGetVisits() in all calls during ModelAssociation.

There is still a call in TypedURLChangeProcessor, but I haven't seen any errors reported from that one yet so I'm being conservative and letting that one continue to throw an unrecoverable error.

BUG=123219
TEST=Added new unit test.


Review URL: http://codereview.chromium.org/10140012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133789 0039d316-1c4b-4281-b951-d872f2087c98

Modified browser crash test. Used CrashBrowser from test_utils and RestartBrowser

BUG=none
TEST=This is a test

Review URL: https://chromiumcodereview.appspot.com/10134043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133785 0039d316-1c4b-4281-b951-d872f2087c98

Windows SendInput() API provides a flag callers can use to have the API do the conversion, which is more reliable than doing it manually with MapVirtualKeyEx().

BUG=124499
TEST=Manual. Verify that NumLock behaves as expected when connecting between two Windows hosts using Chromoting.

Review URL: https://chromiumcodereview.appspot.com/10162021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133784 0039d316-1c4b-4281-b951-d872f2087c98

See http://llvm.org/pr12645 for investigation / discussion.

TBR=cmp
Review URL: https://chromiumcodereview.appspot.com/10173013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133783 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117186
TEST=


Review URL: http://codereview.chromium.org/10217006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133782 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=none

R=vangelis@chromium.org


Review URL: http://codereview.chromium.org/10197002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133781 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124864
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10218002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133780 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103480
TEST=unit_test --gtest_filter=MetricsLogTest.*


Review URL: http://codereview.chromium.org/9702015

TBR=isherman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10169039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133779 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133778 0039d316-1c4b-4281-b951-d872f2087c98

constructed GURLs, but lacked some code from the constructors.

BUG=123810 
TEST=see bug


Review URL: http://codereview.chromium.org/10212006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133777 0039d316-1c4b-4281-b951-d872f2087c98

The commit r133754 introduced some errors.  That change made the tests
delete the session a bit more frequently, while some of the tests
maintained more pointers to its internal structures.

This change fixes all the affected tests and adds a member function to
the test framework class to try to prevent this from happening in the
future.

BUG=122033,123270
TEST=

Review URL: https://chromiumcodereview.appspot.com/10212008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133776 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103480
TEST=unit_test --gtest_filter=MetricsLogTest.*


Review URL: http://codereview.chromium.org/9702015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133773 0039d316-1c4b-4281-b951-d872f2087c98

Necessary to make it pass the try-bots, which don't support binary files.

When generating an android APK, it uses all the files in the res/ directory
and generates a R.java which contains resource IDs to be referenced in the
code, so a missing file will result in a missing ID reference and non-compiling
code.

BUG=118591
TEST=

Review URL: https://chromiumcodereview.appspot.com/10216003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133771 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to remove them in crrev.com/133644

BUG=chromium-os:29813
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10181013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133769 0039d316-1c4b-4281-b951-d872f2087c98

busted. Added the kTouchOptimizedUI switch to metro mode.

BUG=118641
R=cpu,sky
Review URL: https://chromiumcodereview.appspot.com/10211006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133768 0039d316-1c4b-4281-b951-d872f2087c98

This will allow using that class on the main NPAPI plugin thread in 
chromoting.

BUG=124728


Review URL: http://codereview.chromium.org/10140010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133767 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124683
TEST=./net_unittests


Review URL: http://codereview.chromium.org/10185007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133766 0039d316-1c4b-4281-b951-d872f2087c98

The functions ByteStringAsUTF8() and ByteStringFromUTF8() are no longer used.

BUG=none
TEST=build

Review URL: https://chromiumcodereview.appspot.com/10206009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133765 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=csilv

Review URL: https://chromiumcodereview.appspot.com/10219005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133764 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dpapad

Review URL: https://chromiumcodereview.appspot.com/10211009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133761 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111244
TEST=none
R=csilv

Review URL: https://chromiumcodereview.appspot.com/10210003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133759 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124705
TEST=

Review URL: http://codereview.chromium.org/10174013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133758 0039d316-1c4b-4281-b951-d872f2087c98

This just implements the proxy and IPC code for advance(), modeled after 
IDBCursor.continue().

BUG=90647


Review URL: http://codereview.chromium.org/10197001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133757 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/10205008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133756 0039d316-1c4b-4281-b951-d872f2087c98

R=garykac@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/10191002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133755 0039d316-1c4b-4281-b951-d872f2087c98

This change causes the syncer to exit from its download then commit
function if the download fails. This helps prevent the creation of
server-side conflicts, which would be more likely to happen if a
download failed but the following commit succeeded.

The main changes are as follows:
- Rather than proceed to the next step when a download updates failure
is detected, the syncer will exit. This should cause the
SyncScheduler to schedule a retry at a later time. 
- The definition of a download updates failure is now based on the
return code of the download attempt, rather than checking the contents
of the (possible non-existent) returned protobuf. This makes the error
detection logic used here more closely match the logic used to decide
whether or not to schedule retries.

This implementation has a side-effect on configure sync cycles. The old
behaviour was to handle failures by applying whatever updates we had
downloaded at that point. The new behaviour will leave updates
unapplied if any error occurs. This better matches a nearby comment's
assertion which states that we should not attempt to apply updates until
we have downloaded all of them. I believe the author of that comment
would approve of this change.

This change moves around some of the ExtensionActivityMonitor logic.
It's important that we not take the data from the extensions acitivity
monitor at the start of the cycle. Restoring that data is handled in
the commit building and response code, which might not be executed if we
need to break out early. This also fixes issue 123270.

Most of the diffs for this change are concentrated in the unit tests:
- Expose more of the SyncScheduler to the SyncerTest test harness.
- Add functions to SyncerTest for testing specific types of sync jobs.
- Add some functions that allow us to better control failures in
MockConnectionManager.
- Added tests for configure job success and failure.
- Added tests for update then commit job success and failure.
- Removed some redundant tests.
- Removed unused test infrastructure.

This change allows the integration tests to expose a bug that was
introduced back in r118572.  That commit assumed it was OK to not
retry a job that failed due to a MIGRATION_DONE response from the
server.  That is incorrect, and this error has been fixed.

BUG=122033, 123270
TEST=sync_unit_tests, specifically:
SyncerTest.UpdateThenCommit,
SyncerTest.UpdateFailsThenDontCommit,
SyncerTest.ConfigureDownloadsTwoBatchesSuccess,
SyncerTest.ConfigureFailsDontApplyUpdates


Review URL: http://codereview.chromium.org/10103017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133754 0039d316-1c4b-4281-b951-d872f2087c98

The source of the failures was not identified; there were no IDB
changes in range. Apparently they're passing again - re-enabling
to verify and catch regressions.

BUG=123045
TEST=python chrome/test/functional/indexeddb.py
R=nirnimesh@chromium.org


Review URL: http://codereview.chromium.org/10173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:25280
TEST=Manual inspection in comparison to r19.
TBR=zelidrag

Review URL: http://codereview.chromium.org/10206008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133752 0039d316-1c4b-4281-b951-d872f2087c98

WaitUntilNavigationCompletes() can be determined.

TEST=none
BUG=124877
Review URL: https://chromiumcodereview.appspot.com/10217005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133751 0039d316-1c4b-4281-b951-d872f2087c98

Fix all tests in chromeos_wifi_sanity.py except testToggleNetworkDevic. I'll look at that separately.

R=stanleyw@chromium.org
BUG=None
TEST=chromeos_wifi_sanity in pyauto_functional

Review URL: https://chromiumcodereview.appspot.com/10209007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133750 0039d316-1c4b-4281-b951-d872f2087c98

The corresponding CL:
https://chromiumcodereview.appspot.com/10163002/

BUG=113688
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10180002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133749 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a crash that shows up when terminating from the system tray popup.

BUG=105151,124310
TEST=WidgetObserverTest.DestroyBubble

Review URL: https://chromiumcodereview.appspot.com/10204014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133748 0039d316-1c4b-4281-b951-d872f2087c98

Previously it was an immutable struct that was passed around by making
dynamic allocations and passing pointers. We now just have a class with
only getters and no setters, but support for default copy and assign.

This cleans up some code and makes some future work easier to pass snapshots
around.

BUG=none
TEST=sync_unit_tests


Review URL: http://codereview.chromium.org/10197004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133747 0039d316-1c4b-4281-b951-d872f2087c98

This caused chromium os tests to fail, http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/1981/steps/unit_tests/logs/DefaultMigrationHomepageIsNTP

BUG=122936
TEST=Upgrade from 18 to 19
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10049005

TBR=tbreisacher@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10173007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133746 0039d316-1c4b-4281-b951-d872f2087c98

This broke the SelectFileDialogExtensionBrowserTest.SelectFileAndOpen test on linux chromiumos browser_tests.

BUG=chromium-os:26471
TEST=After entering the folder none of the files is selected.
Review URL: https://chromiumcodereview.appspot.com/10204015

TBR=oleg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10212005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133745 0039d316-1c4b-4281-b951-d872f2087c98