GitLab

On Linux, older versions of UPower did not have the GetDisplayDevice
method. Trying to call it generates log spam.

Modernize the modified file with base::MakeUnique while we are here.

BUG=695383

Review-Url: https://codereview.chromium.org/2795713003
Cr-Commit-Position: refs/heads/master@{#463358}

Without this the bots try to use ash_mus_unittests, which doesn't
exist.

BUG=705715
TEST=this is test change
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2802163004
Cr-Commit-Position: refs/heads/master@{#463357}

This reverts commit 1204d239.

This introduced one bug and exposed another.  Yay!

BUG=709884,709886
TBR=bauerb,peconn

Review-Url: https://codereview.chromium.org/2806373003
Cr-Commit-Position: refs/heads/master@{#463356}

In the mode where CCT only shows the page title, we should never have an
empty title displayed. Force this by checking the title even if there
are no title update after Toolbar creation since those updates might
have been missing while prerendering. If there is no title set yet, post
a callback to check this and fallback to showing the domain if there is
not title set after a second.

BUG=708957

Review-Url: https://codereview.chromium.org/2806593003
Cr-Commit-Position: refs/heads/master@{#463355}

Try to simplify coordinate handling in NGBlockLayoutAlgorithm::Layout by
using NGLogicalSize instead of raw LayoutUnits for the block/inline dir.

R=glebl@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2808863002
Cr-Commit-Position: refs/heads/master@{#463354}

Moved the timer task from per-renderer to per-frame in the following CL.
  https://codereview.chromium.org/2640293002/

At that time, the spec didn't mention it properly but it has become clear
recently. The spec says that we should use UserInteraction task source.

Related spec change:
  https://github.com/w3c/browser-payment-api/pull/405

BUG=none

Review-Url: https://codereview.chromium.org/2808573002
Cr-Commit-Position: refs/heads/master@{#463353}

When Crashpad self-monitoring is enabled, crashes in crashpad_handler
will be written to the crash report database and uploaded according to
the user's preference. Self-monitoring dedicates an additional
crashpad_handler process to serve as the handler for the original
instance. Having a dedicated process is somewhat expensive, so
self-monitoring is not enabled at all times.

An existing mechanism, the "fallback crash handler," is already in place
on Windows. The fallback crash handler does not create any additional
processes until a crashpad_handler crash occurs. The fallback handler
remains effective in cases where Crashpad's own self-monitoring is
disabled. The fallback handler and Crashpad self-monitoring have
different attributes, so there are no plans to move Windows entirely
onto Crashpad self-monitoring.

For branded Chrome, the dev channel gets Crashpad self-monitoring in 25%
of browser starts, and the beta channel gets it in 10% of browser
starts. On macOS, the stable channel gets self-monitoring in 1% of
browser starts, and the canary and Chromium builds get it all the time.
On Windows, the Chrome stable channel never gets self-monitoring because
the fallback crash handler is sufficient, and the canary and Chromium
builds get it 50% of the time, allowing for some use of the fallback
crash handler in those cases.

While reports will be collected for crashes that occur while Crashpad is
attempting to upload another report, it's unlikley that these reports
will be uploaded automatically under the current one-attempt-per-hour,
no-retry rate limiting strategy. See
https://crashpad.chromium.org/bug/23.

BUG=crashpad:143
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2799013002
Cr-Commit-Position: refs/heads/master@{#463352}

BUG=709930
R=dcheng@chromium.org,thakis@chromium.org,dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2808813002
Cr-Commit-Position: refs/heads/master@{#463351}

Add icon to the Data Saver footer, update the strings to the new spec,
and add a divider.

BUG=702799

Review-Url: https://codereview.chromium.org/2795653006
Cr-Commit-Position: refs/heads/master@{#463350}

https://skia.googlesource.com/skia.git/+log/b8ab7f7634fc..4482a14db9b1

$ git log b8ab7f763..4482a14db --date=short --no-merges --format='%ad %ae %s'
2017-04-10 mtklein fix -Fast bot
2017-04-10 bsalomon constexprify GrBlend.h and GrPorterDuffXferProcessor.cpp
2017-04-10 brianosman Remove Index_8 handling in cacherator heuristic code
2017-04-10 borenet Recipes: Remove depot_tools path hack

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: I41dee01fac1b0d0270b6f667ef92d0a9d10aabff
Reviewed-on: https://chromium-review.googlesource.com/473406Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463349}

This CL implements a TODO to use the original URL of the favicon
downloaded from the Google server as the key in the database.

BUG=644102

Review-Url: https://codereview.chromium.org/2810733002
Cr-Commit-Position: refs/heads/master@{#463348}

This change makes it safe to call HidConnection::Read from within the
callback passed to a previous call to this method. On macOS and Linux
this means moving protected input report filtering to before the report
is queued. On Windows this wasn't an issue but filtered input reports
would cause a callback to never be executed.

BUG=None

Review-Url: https://codereview.chromium.org/2804313005
Cr-Commit-Position: refs/heads/master@{#463347}

The method VideoCaptureDeviceFactory::EnumerateDeviceDescriptors()
is the asynchronous equivalent of method VideoCaptureDeviceFactory
::GetDeviceDescriptors(). Its current implementation delegates to
GetDeviceDescriptors() and invokes the callback synchronously.

This CL removes EnumerateDeviceDescriptors() and lets all clients
call GetDeviceDescriptors() directly.

BUG=708233

Review-Url: https://codereview.chromium.org/2805863002
Cr-Commit-Position: refs/heads/master@{#463346}

This CL is identical to https://codereview.chromium.org/2592143003,
except that RemoveObserver() works when called from any sequence
(existing code rely on that).

Previously, observers could only be added to an ObserverListThreadSafe
from single-threaded tasks. Observers were notified on the registration
thread.

With this CL, observers can also be added to an ObserverListThreadSafe
from sequenced tasks. They are notified on the registration sequence.

ObserverListThreadSafe behaves almost the same way as before when used
from single-threaded tasks. The following things changed:
- The order in which observers registered from the same thread
  are notified is no longer deterministic.
- One notification task is posted for each observer rather than one
  notification task per thread.
- If an observer is added to a NOTIFY_ALL ObserverListThreadSafe from
  a stack of notification dispatches, only the notification on top of
  the stack is sent to the newly added observer.

BUG=675631

Review-Url: https://codereview.chromium.org/2805933002
Cr-Commit-Position: refs/heads/master@{#463345}

Removes the promo_type_ field from notification_promo.h/.cc
and uses of it. It is unnecessary as the only promo type in use is the
MOBILE_NTP_WHATS_NEW_PROMO.

BUG=608525

Review-Url: https://codereview.chromium.org/2805443007
Cr-Commit-Position: refs/heads/master@{#463344}

Ensure the image has loaded before testing layout.

TBR=eae@chromium.org

BUG=707918

Review-Url: https://codereview.chromium.org/2807973004
Cr-Commit-Position: refs/heads/master@{#463343}

Payment manifest has been split in two:

   1. Payment method manifest. Example:

   {
    "default_applications": ["https://bobpay.com/app.json"],
    "supported_origins": ["https://alicepay.com"]
   }

   2. Web app manifest. Example:

   {
    "related_applications": [{
      "platform": "play",
      "id": "com.bobpay.app",
      "min_version": "1",
      "fingerprints": [{
        "type": "sha256_cert",
        "value": "59:5C:88:65:FF:C4:E8:20:CF:F7:3E:C8:64:D0:95:F0:06:19"
      }]
    }]
   }

Only "default_applications" is used in this patch. The
"supported_origins" field will be used in an upcoming patch.

Using these manifests is behind a flag:
chrome://flags/#android-payment-apps

Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/YlMpaO-E2mE/-_GgiMiRCgAJ

Design:
https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE

Explainer:
https://github.com/zkoch/zkoch.github.io/blob/master/pmi-v2.md

BUG=683329

Review-Url: https://codereview.chromium.org/2802043002
Cr-Commit-Position: refs/heads/master@{#463342}

Cleaning up before I head off into the sunset.

BUG=none
R=nparker@chromium.org

Review-Url: https://codereview.chromium.org/2810823002
Cr-Commit-Position: refs/heads/master@{#463341}

It is not being used in any IPC messages.

Review-Url: https://codereview.chromium.org/2806083002
Cr-Commit-Position: refs/heads/master@{#463340}

The settings button was unintentionally broken for Windows and
Linux users in 2799653004, as was gathering of some UMA. This
CL offers a slight refactoring that meets all goals.

BUG=706658

Review-Url: https://codereview.chromium.org/2807623002
Cr-Commit-Position: refs/heads/master@{#463339}

The reference to TextInputManager instance (owned by WebContentsImpl) in RenderWidgetHostView is alive as long as
  1) WebContents is alive,
  2) RenderWidgetHostView is registered with TextInputManager.

On Mac, WebContents destruction might not lead to immediate destruction of the RenderWidgetHostViewMac. Therefore,
there can be a period of time where (after WebContentsImpl is deleted) |text_input_manager_| is null. Then it is only
safe to check |text_input_manager_| before dereferencing it.

BUG=709864

Review-Url: https://codereview.chromium.org/2813493003
Cr-Commit-Position: refs/heads/master@{#463338}

Not finished implementing yet, but this will be the iOS version of remoting
client that ties the remoting/client common session to iOS.

BUG=652781

Review-Url: https://codereview.chromium.org/2805963002
Cr-Commit-Position: refs/heads/master@{#463337}

Initialization with a vector of SchedulerWorkerPoolParams is
deprecated.

BUG=690706

Review-Url: https://codereview.chromium.org/2794423002
Cr-Commit-Position: refs/heads/master@{#463336}

This CL adds some CHECKs to see if our assumptions on
SharedMemoryDataConsumerHandle hold.

BUG=704863
R=hiroshige@chromium.org

Review-Url: https://codereview.chromium.org/2799223002
Cr-Commit-Position: refs/heads/master@{#463335}

BUG=

Review-Url: https://codereview.chromium.org/2800033002
Cr-Commit-Position: refs/heads/master@{#463334}

ConsoleViewport's firstVisibleIndex() may throw an error if it calls
'lowerBound' while _cumulativeHeights is not defined. This scenario happens when
loading console after invalidating an empty viewport. Invalidate() deletes
_cumulativeHeights, the prompt text is changed, then firstVisibleIndex() is
called.

To make viewport's public functions less error prone, we can ensure that
_cumulativeHeights is always defined, using an empty typed array by default.

BUG=708845

Review-Url: https://codereview.chromium.org/2799043006
Cr-Commit-Position: refs/heads/master@{#463333}

Make setupConnection oneway/async. Add a ICallbackInt interface to
return the PID of the child process. The reply is then posted back to
launcher thread. Connection setup is already mostly async so only
involves moving related code to the reply callback.

One caveat is that getCallingPid no longer works and just returns 0
for oneway calls. The pid check is not strictly necessary, so dropped
the from setupConnection instead.

BUG=689758, 690118

Review-Url: https://codereview.chromium.org/2810433002
Cr-Commit-Position: refs/heads/master@{#463332}

BUG=627747

Review-Url: https://codereview.chromium.org/2814513002
Cr-Commit-Position: refs/heads/master@{#463331}

Since its always the default. Whenever there is a non-default blend
mode, render surface takes care of blending

BUG=709269
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2801383002
Cr-Commit-Position: refs/heads/master@{#463330}

A second SnackbarManager is used to display snackbars on top
of the bottom sheet.

BUG=704128

Review-Url: https://codereview.chromium.org/2806593004
Cr-Commit-Position: refs/heads/master@{#463329}

BUG=

Review-Url: https://codereview.chromium.org/2788733002
Cr-Commit-Position: refs/heads/master@{#463328}

No intended behavior change.

BUG=none

Review-Url: https://codereview.chromium.org/2810723003
Cr-Commit-Position: refs/heads/master@{#463327}

- Remove dependency on TestProject
- Support xctestrun file
- Support retries of xctests on devices

BUG=708859

Review-Url: https://codereview.chromium.org/2805133005
Cr-Commit-Position: refs/heads/master@{#463326}

In a previous mask tiling patch, there was a typo that incorrectly check
mask type when doing the tiled/non-tiled conversion.

This does not break anything as currently the flag is disabled. This
patch fixes this typo.

BUG=567293
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2809653002
Cr-Commit-Position: refs/heads/master@{#463325}

. Use SANDBOXED as the default argument to GpuProcessHost::Get(), since
  that's the most common use.
. Remove unused ash::GPUSupport::GetGpuProcessHandles().
. Remove unused content::GpuDataManager::GetGpuProcessHandles().
. Replace GpuProcessHost::GetProcessHandles() with GetHasGpuProcess(),
  since the only remaining user (RenderMessageFilter) cares only about
  the existence of a gpu process, and not about what those processes are.

BUG=417532, 709332

Review-Url: https://codereview.chromium.org/2810593003
Cr-Commit-Position: refs/heads/master@{#463324}

This CL adds ExecutionContext::from(ScriptState*) to eventually replace ScriptState::getExecutionContext. This is to remove a dependency to ExecutionContext from ScriptState.

BUG=682322

Review-Url: https://codereview.chromium.org/2805333002
Cr-Commit-Position: refs/heads/master@{#463323}

Adding user actions and a histogram so that, when the settings reset
prompt is not accepted, we can distinguish between cases when user
clicks the cancel button versus dismisses the prompt in some other
way.

BUG=

Review-Url: https://codereview.chromium.org/2800773003
Cr-Commit-Position: refs/heads/master@{#463322}

For mushrome, in order to have screen management in one process and
Ozone in another process we need a mojom::NativeDisplayDelegate and
implementation. The ForwardingDisplayDelegate will be created in ash and
will connect to mus-ws. In mus-ws ScreenManagerForwarding will own the
real NativeDisplayDelegate. A mojom::NativeDisplayObserver works in the
other direction.

This only implements the Ozone DRM parts of NativeDisplayDelegate. Most
of the other methods exist for the X11 implementation which isn't used.

BUG=706589

Review-Url: https://codereview.chromium.org/2805633004
Cr-Commit-Position: refs/heads/master@{#463321}

When running GetAllNodes, USS types post to the model thread to access
their processor/bridge. This means after they've gathered the nodes,
they need to return to the UI thread to give the results back to the
GetAllNodesRequestHelper.

Unfortunately I removed a wrapping BindToCurrentThread call in
https://codereview.chromium.org/2672493002/diff/80001/components/sync/driver/model_type_controller.cc
that did the jump back to the UI thread. This meant that non-UI USS
types (namely AUTOFILL) were updating GetAllNodesRequestHelper from a
different thread, through very non-thread safe code. To fix simply
added the BindToCurrentThread back.

Also added a added a thread checker to GetAllNodesRequestHelper in
hopes of stopping similar bugs from occurring again.

BUG=686172

Review-Url: https://codereview.chromium.org/2808113003
Cr-Commit-Position: refs/heads/master@{#463320}

We've been on git for a long time now, this code has been unused for years.
No intended behavior change.

BUG=none

Review-Url: https://codereview.chromium.org/2814503002
Cr-Commit-Position: refs/heads/master@{#463319}