- 31 May, 2017 40 commits
-
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e18c0f9c7950..32a3f0b8f49b $ git log e18c0f9c7..32a3f0b8f --date=short --no-merges --format='%ad %ae %s' 2017-05-30 rnephew [BattOr] Update BattOr agent Binary. 2017-05-30 simonhatch Pinpoint - Remove some unneeded files. 2017-05-30 ccraik Switch from printf to echo for tgid fixup 2017-05-30 ccraik Fix viewer html generation on windows 2017-05-30 dtu [pinpoint] Make Change.deps a frozenset. 2017-05-30 jbudorick [devil] Make devil.utils.cmd_helper work on Windows? 2017-05-30 dproy Fix markdown typo in cpu_time tree doc 2017-05-30 phsilva Implement the Ownership Diagnostic Class Created with: roll-dep src/third_party/catapult BUG=699581 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4502fff3bec2c407c5f82649a68b86d24a35f000 Reviewed-on: https://chromium-review.googlesource.com/518507 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#475759}
-
hanxi authored
Review-Url: https://codereview.chromium.org/2910243002 Cr-Commit-Position: refs/heads/master@{#475758}
-
dougt authored
This is another migration from BrowserAccessibility to AXPlatformNodeWin. In this installment, we're converting get_accRole. I have updated the AXPlatformNodeWin::MSAARole() to include many of the missing roles that the BrowserAccessibility code had. I also introduced a new method that allows get_accRole to return a string (overriding the default type value that MSAARole() returns). I have not dug into why we need to return the various values instead of just using the role number or html element name. Instead, I just added todos for me to follow up on. BUG=703369 Review-Url: https://codereview.chromium.org/2909853002 Cr-Commit-Position: refs/heads/master@{#475757}
-
kenrb authored
To prevent excessive IPC messages, a parent frame of an OOPIF only updates its remote viewport intersection rect when the intersection changes. However, a frame can navigate without the parent frame being aware of it, in which case the rect is lost without being resent. To address that problem, this CL caches the rect on CrossProcessFrameConnector in the browser process, and sends it to the renderer whenever RenderWidgetHostImpl::SendScreenRects() is called. This CL also moves the rect's storage in Blink from LocalFrameView to LocalFrame so that it persists across same-process navigations. BUG=720342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2910023002 Cr-Commit-Position: refs/heads/master@{#475756}
-
bsep authored
code that creates tutorial UI is never referenced anywhere. Review-Url: https://codereview.chromium.org/2899083003 Cr-Commit-Position: refs/heads/master@{#475755}
-
ccameron authored
BUG=723975 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2913083002 Cr-Commit-Position: refs/heads/master@{#475754}
-
kelvinp authored
This CL also fixes a BUILD file error so that JSCompiler can be run. BUG=727904 Review-Url: https://codereview.chromium.org/2913073002 Cr-Commit-Position: refs/heads/master@{#475753}
-
Stefan Zager authored
BUG=723406 R=eae@chromium.org,pdr@chromium.org Change-Id: Ia0fd51944a549f4ef6b8e704fc5101071ae22bf2 Reviewed-on: https://chromium-review.googlesource.com/518252 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#475752}
-
mtomasz authored
TEST=Tested manually with apps with popups out of task bounds. BUG=b/62088045 Review-Url: https://codereview.chromium.org/2909213003 Cr-Commit-Position: refs/heads/master@{#475751}
-
shaktisahu authored
Added DownloadStore which is a layer around a leveldb ProtoDatabase that stores download params, scheduling params, request headers and various metadata as protos. Callers of DownloadStore expect a list of Entry's, hence conversion utility methods were added to convert between Entry and protodb::Entry. Other details: 1- Moved NoopStore to download/internal/test/ 2- Replaced usage of OnceCallback with repeated Callback, since the proto database expects repeated Callback. In order to change ProtoDatabase to use OnceCallback, it probably requires a larger change invloving changing the client sites of ProtoDatabase. BUG=722705 Review-Url: https://codereview.chromium.org/2881173003 Cr-Commit-Position: refs/heads/master@{#475750}
-
Morten Stenshorne authored
In general there shouldn't really be any need for both. We could just remove AvoidsFloats() and keep CreatesNewFormattingContext(). But then again, it might be considered weird to say that replaced content creates a block formatting context. So let's keep the both of them for now. However, the following rule should always apply: If the object creates a new formatting context, it implies that it also avoids floats. That's the reason for declaring LayoutBlockFlow::AvoidsFloats() as final. Furthermore, the only kind of LayoutBlock-type objects that DOESN'T create a new formatting context, are certain LayoutBlockFlow (block container) objects. So move the checks over from LayoutBlock to LayoutBlockFlow. Keep a virtual true-returning CreatesNewFormattingContext() in LayoutBlock. We could actually consider removing this, but there are 2-3 call sites that currently need it. This CL causes a couple of minor rendering differences: Previously, HR elements were told to avoid floats, but not to establish block formatting contexts. Let's be consistent and return true for both. This makes us more compatible with Edge. Test included. Turning HR elements into true block formatting contexts also affects margin collapsing. Its top and bottom margins no longer collapse. Had to make a change to the default style sheet for HR inside SELECT because of this. Inside SELECT, HR loses its borders, so that its top and bottom margins would previously collapse, but not anymore, now that it establishes a block formatting context. To cancel out any rendering difference, reduce margins in this particular case. Similarly for RT (ruby text). LayoutRubyText objects are repositioned after layout, which essentially requires them to contain all child floats, i.e. establish a new block formatting context. Previously they achieved a quasi-formatting context by returning true from AvoidFloats(). The screenshot test fast/ruby/float-overhang-from-ruby-text.html would fail spectacularly if they exposed child floats to their sibling ruby base. That test expectation still requires a tiny update to its layout tree dump, though. This CL also makes CreatesNewFormattingContext() return true for tables, flexboxes, grids, and anything blocky that isn't LayoutBlockFlow. This shouldn't be a web-exposable change, though, since no non-LayoutBlockFlow types can contain float children (e.g. a float inside a table would have to be wrapped inside either a table-cell or a table-caption (which both establish a new block formatting context), and a float inside a flexbox would have to be wrapped inside a flex item (which establishes a new block formatting context)). BUG=460704 Change-Id: If60c1fc636db73a7ff241471ea7bf95adf996512 Reviewed-on: https://chromium-review.googlesource.com/512824Reviewed-by:
Robert Hogan <robhogan@gmail.com> Commit-Queue: Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#475749}
-
skym authored
This bug was discovered by the Kitchen Sync integration test BothClientsEnabledEncryptionAndChangedMultipleTimes_E2ETest. What was happening is that for a given client, it was mid PostTask "bounce" in TrySyncCycleJob, when a second nudge was scheduled. This was allowed to get through because the pending_wakeup_timer_ wasn't running. However, when TrySyncCycleJobImpl contacted the server, we hit an error, and the scheduler tried to call RestartWaiting(). This didn't have any effect, because now the pending_wakeup_timer_ has a imminent nudge, with a smaller delay time, and we had no way of knowing the priority of the pending wakeup tasks. The above is arguably all okay, but when the now pending nudge was run, it has low priority, but we're in an error state, and this no-ops. And at the end of PerformDelayedNudge we explicitly don't call RestartWaiting(), which seems to be wrong. BUG=721850 Review-Url: https://codereview.chromium.org/2911603003 Cr-Commit-Position: refs/heads/master@{#475748}
-
jbauman authored
This helps in creating a baseline for comparing other numbers against. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2908623006 Cr-Commit-Position: refs/heads/master@{#475747}
-
Takeshi Yoshino authored
Bug: Change-Id: Ifa455efd7634d553be8959e28f51f5dd11cc4485 Reviewed-on: https://chromium-review.googlesource.com/517808Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#475746}
-
neis authored
BUG=594639,723841 Review-Url: https://codereview.chromium.org/2845983002 Cr-Commit-Position: refs/heads/master@{#475745}
-
Benjamin Pastene authored
This includes: mojo_public_system_unittests mojo_public_bindings_unittests gl_tests events_unittests boringssl_crypto_tests ui_touch_selection_unittests ui_base_unittests gpu_ipc_service_unittests device_unittests libjingle_xmpp_unittests ui_android_unittests R=jbudorick@chromium.org Bug: 725672, 670879 Change-Id: I3d46bb883e6508fea63bc722a15809306e0662ba Reviewed-on: https://chromium-review.googlesource.com/518293Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#475744}
-
pauljensen authored
This can happen in testAndroidTestCaseSetupProperly(), see https://d.android.com/reference/android/test/AndroidTestCase.html#testAndroidTestCaseSetupProperly() which is an empty test case. Chromium avoids this but other test systems don't. Also, remove a redundant loadLibrary call. R=xunjieli@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2909223004 Cr-Commit-Position: refs/heads/master@{#475743}
-
aboxhall authored
BUG=726598 Review-Url: https://codereview.chromium.org/2914723002 Cr-Commit-Position: refs/heads/master@{#475742}
-
xunjieli authored
BUG=698403 Review-Url: https://codereview.chromium.org/2910463003 Cr-Commit-Position: refs/heads/master@{#475741}
-
Chris Watkins authored
MediaCodecVideoDecoder needs to decode using a MediaCodec on the MCVD thread while dequeued buffers are released back to the codec on the GPU thread. CodecWrapper supports this use case by vending CodecOutputBuffers which keep a reference to their backing wrapper, and a unique id so that CodecWrapper can keep track of which buffers are valid. Bug: 660942 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I798df44a7639071f9eb3f2803d018ced4b121137 Reviewed-on: https://chromium-review.googlesource.com/517351Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#475740}
-
kristipark authored
BUG=723871 Review-Url: https://codereview.chromium.org/2902673003 Cr-Commit-Position: refs/heads/master@{#475739}
-
martiw authored
screenshot: https://drive.google.com/file/d/0B1O0Z7eoZMuGOXYzTG5YN1ZDdW8/view BUG=725784 Review-Url: https://codereview.chromium.org/2901913003 Cr-Commit-Position: refs/heads/master@{#475738}
-
rdevlin.cronin authored
The extension action redesign has launched. Remove associated logic from the ToolbarActionsBar, ToolbarActionsModel, and associated tests (including ExtensionMesageBubbleBrowserTests). BUG=590321 Review-Url: https://codereview.chromium.org/2906723003 Cr-Commit-Position: refs/heads/master@{#475737}
-
rlanday authored
Currently TextIterator's constructor takes two Positions (start and end). It came up during review of https://codereview.chromium.org/2901213008 that it would be helpful to have another version of the constructor that instead takes an EphemeralRange. BUG= Review-Url: https://codereview.chromium.org/2913003003 Cr-Commit-Position: refs/heads/master@{#475736}
-
dewittj authored
This does not yet react to such messages but hooks up the plumbing so that we are ready for them Because the app handlers need to be registered before any GCM messages are received, this app handler is added upon construction of the GCMProfileService. BUG=701939 Review-Url: https://codereview.chromium.org/2864293003 Cr-Commit-Position: refs/heads/master@{#475735}
-
Tommy Nyquist authored
The unit test for SystemTimeProvider uses base::Time::FromLocalExploded() to create a hard coded time. However, this has the unfortunate side effect of creating a different number based on the local timezone. This CL changes the test to instead use base::Time::FromUTCExploded() which forces the timezone to be UTC, which fixes test errors. BUG=727916 Change-Id: I027ef0c5e100cb04ddad7472e8a8eaa7a3521a7f Reviewed-on: https://chromium-review.googlesource.com/517870Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#475734}
-
zhaobin authored
We are moving cast_channel related files from //extensions to //components and need to remove extensions dependencies. - Added internal enum class ::cast_channel::ReadyState, ::cast_channel::ChannelError, ::cast_channel::ChannelAuthType and type conversion util functions - Use internal enum class instead of enums in cast_channel.idl BUG=723944 Review-Url: https://codereview.chromium.org/2891923004 Cr-Commit-Position: refs/heads/master@{#475733}
-
tyoshino authored
Revert of [DMC #17] Make TextMatchMarkers constructible in single step (patchset #4 id:60001 of https://codereview.chromium.org/2905753002/ ) Reason for revert: This broke the build. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/201575 Original issue's description: > Make TextMatchMarkers constructible in single step > > Currently, we only construct instances of TextMatchMarker (previously > RenderedDocumentMarker) inside TextMatchMarkerListImpl, by calling > TextMatchMarker::Create() on an instance of DocumentMarker. This CL changes this > so callers directly construct instances of TextMatchMarker. This sets us up to > eventually move the storage and accessor methods for whether or not the marker > is active out of DocumentMarker and into TextMatchMarker. > > BUG=707867 > > Review-Url: https://codereview.chromium.org/2905753002 > Cr-Commit-Position: refs/heads/master@{#475724} > Committed: https://chromium.googlesource.com/chromium/src/+/6b0a494122ebe2fc48099a9549b0acbf0b28571d TBR=yosin@chromium.org,xiaochengh@chromium.org,rlanday@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707867 Review-Url: https://codereview.chromium.org/2912133003 Cr-Commit-Position: refs/heads/master@{#475732}
-
Ken Rockot authored
Consolidates and simplifies user message serialization within the EDK. Namely: * The ports layer no longer operates under the assumption that all events exist exclusively in serialized form. This eliminates the complexity of layered message allocation at the cost of a small amount of extra copying in some cases. * ports::Message is now more aptly named ports::Event, and different event types are subclasses. * Introduces a ports::UserMessage base class for ports embedder message types. These can be attached to ports::UserMessageEvent objects. * The MessageForTransit and PortsMessage types have been flattened into a single UserMessageImpl type, a subclass of ports::UserMessage. * Nearly all user message serialization and deserialization logic has been consolidated into UserMessageImpl. A few small pieces remain isolated in node_controller.cc and will eventually move elsewhere after additional refactoring. All of this work is a precursor to supporting lazy serialization. BUG=725321 Change-Id: Ib9e66cd0d5b88ac0e6dc898f248c958039078023 Reviewed-on: https://chromium-review.googlesource.com/516402 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#475731}
-
John Budorick authored
Checkstyle gets run on Java changes on chromium_presubmit, which uses a linux checkout. Bug: 727875 Change-Id: I640418439735e91fbf5b18b3d5f5a72e5c00648e Reviewed-on: https://chromium-review.googlesource.com/517978Reviewed-by:
Bo Liu <boliu@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#475730}
-
kojii authored
This patch supports minor follow up Blink Rename, and adds two LayoutNG commonly used classes. Tested on VS2015/2017 with natvis diagnostic messages turned on. Review-Url: https://codereview.chromium.org/2913743002 Cr-Commit-Position: refs/heads/master@{#475729}
-
kojii authored
This patch changes text-align to use the logical left of the line box to apply the CSS text-align property. This is set to the offset of NGPhysicalLineBoxFragment, which is then copiped to RootInlineBox::LogicalLeft. This way is more efficient to move, the same as what the legacy does, and better for painting since the line box does not have unused spaces. BUG=636993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2906233002 Cr-Commit-Position: refs/heads/master@{#475728}
-
davidben authored
BUG=436634 Review-Url: https://codereview.chromium.org/2916443002 Cr-Commit-Position: refs/heads/master@{#475727}
-
alokp authored
crrev.com/2cbd4fca moved CastAudioOutputStream along with CastAudioOutputStream::Backend to AudioThread, which is wrong. The backend need to run on CMA thread. In addition to fixing the threading model, this patch: - Lets AudioManager use MediaPipelineBackendFactory instead of BackendManager - Updates tests to use the threading model used in production - Adds another basic CastAudioManager test that creates AudioOutputStreamProxy, which is used in production. Review-Url: https://codereview.chromium.org/2879703003 Cr-Commit-Position: refs/heads/master@{#475726}
-
Yutaka Hirano authored
This CL moves a task runner setting logic from PingLoader to FrameFetchContext. In order to do that, this CL also introduces "keepalive" member to ResourceRequest and WebURLRequest. Bug: 695939 Change-Id: Id02e025d1d7e4bdfc4372e52b6c0fd4c72937520 Reviewed-on: https://chromium-review.googlesource.com/517450 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#475725}
-
rlanday authored
Currently, we only construct instances of TextMatchMarker (previously RenderedDocumentMarker) inside TextMatchMarkerListImpl, by calling TextMatchMarker::Create() on an instance of DocumentMarker. This CL changes this so callers directly construct instances of TextMatchMarker. This sets us up to eventually move the storage and accessor methods for whether or not the marker is active out of DocumentMarker and into TextMatchMarker. BUG=707867 Review-Url: https://codereview.chromium.org/2905753002 Cr-Commit-Position: refs/heads/master@{#475724}
-
tbansal authored
BUG=726773 Review-Url: https://codereview.chromium.org/2905423002 Cr-Commit-Position: refs/heads/master@{#475723}
-
xiaohuic authored
Now we use a proto message as parameter for the dbus interface to start ARC instances. BUG=b:37989086 TEST=locally build and flash, start ARC Review-Url: https://codereview.chromium.org/2869163002 Cr-Commit-Position: refs/heads/master@{#475722}
-
Stuart Langley authored
Bug: 712963 Change-Id: Ib2a85a23d3403f85c2f7c3abcc37a3d0bd84017c Reviewed-on: https://chromium-review.googlesource.com/517807 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#475721}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/9a505796f3fe..2c200030b55f $ git log 9a505796f..2c200030b --date=short --no-merges --format='%ad %ae %s' 2017-05-30 tsepez Fix small ordering issue in CFX_ProgressiveDecoder cleanup. 2017-05-30 tsepez Release unowned m_pTiffContext before deleting through it Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ib7f4543d0ada994b04b7dbe986de4ea6dc8b8838 Reviewed-on: https://chromium-review.googlesource.com/517681 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#475720}
-