- 19 Sep, 2018 40 commits
-
-
Stephen Martinis authored
The machines powering this builder are getting overloaded, and per my reading of crbug.com/855319 it doesn't need to run more than 4 builds at a time. Bug: 855319 Change-Id: I986ceb16e9b7795b61135c53701d20b374298ce6 Reviewed-on: https://chromium-review.googlesource.com/1235273Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#592608}
-
Kenneth Russell authored
We're finding that these configurations are frequently getting over-subscribed, so without more information, institute a threshold so the multi-dimemsion trigger script doesn't schedule jobs on these configurations *at all*. This will likely have side effects and require refinement, but will hopefully alleviate the immediate problem. Bug: 886985 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5ea4823920d7e7c0d8fc9509bb853a7de13c21ff Reviewed-on: https://chromium-review.googlesource.com/1234858Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592607}
-
rbpotter authored
Bug: 884739, 884632, 885043 Change-Id: I59303415e30a288c8adc2799a06500f33e60ddee Reviewed-on: https://chromium-review.googlesource.com/1231253 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592606}
-
Jia authored
BrightnessMonitor receives brightness change signals from powerd and sends out notifications if the change is requested by user. We use this class instead of powerd directly because we need final/stablized user brightness instead of intermediate values (that are individually emitted by powerd). In order to wait for brightness to stablize, we use a timer that starts when a user brightness is detected and times out after a period of time if there's no more user brightness detected, or if the next brightness change is not triggered by the user. BrightnessMonitor also notifies its observers as soon as a user brightness is detected so that an observer can decide what to do (e.g disable auto-adjustment). Bug: 881215 Change-Id: I2d9aefd8ff48eab37de9527d12657fd4dfeba793 Reviewed-on: https://chromium-review.googlesource.com/1226715Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592605}
-
Asanka Herath authored
Test is flaky. Bug: 884118 Change-Id: I0cd103f1340536eee94a28cafe579cf186804840 Reviewed-on: https://chromium-review.googlesource.com/1231157Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592604}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/299ed678d06b..91c7297741c9 Created with: gclient setdep -r src-internal@91c7297741c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib77e2f2e057aad3c224cad04419ffcafab79e991 Reviewed-on: https://chromium-review.googlesource.com/1234826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592603}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2e437a4c577..7f2ef8dd8ad7 git log e2e437a4c577..7f2ef8dd8ad7 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 bhthompson@google.com Promote auron_paine-paladin to non-experimental Created with: gclient setdep -r src/third_party/chromite@7f2ef8dd8ad7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic7743fea07c574a749f74736d252c80296cb8a32 Reviewed-on: https://chromium-review.googlesource.com/1234825Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592602}
-
Thomas Guilbert authored
This CL allows MediaRouteControllers to prevent routes from being shown in the MediaRouteChooserDialog, based off of some filtering from the MediaRouter.RouteInfo. This filtering mechanism will be used in downstream code. Bug: 109926233 Change-Id: Iee0c1fa44a94a0a5618164f185ddc4237934d018 Reviewed-on: https://chromium-review.googlesource.com/1234773 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592601}
-
Shuotao Gao authored
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ic537c720e32dffc9ade585a85a4b8d1afce4c001 Reviewed-on: https://chromium-review.googlesource.com/1231113Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#592600}
-
rajendrant authored
This CL implements support for the "lazyload" attribute on images, according to https://github.com/whatwg/html/pull/3752, and as part of the LazyLoad feature. The accepted values are: "off", which causes the browser to avoid lazily loading the <img> element "on" and "auto", activate the default behavior of lazily load the <img> element When the attribute is changed to "off", the deferred image loads immediately. Bug: 875080 Change-Id: I839926a9827d019f23aafc40f8315476fe1b3048 Reviewed-on: https://chromium-review.googlesource.com/1197782Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#592599}
-
Yuri Wiitala authored
A memory leak was identified in ui::Cursor::GetDefaultBitmap() on Aura platforms. This patch fixes that memory leak, and also removes the need to memory-manage the SkBitmaps returned by CreateSkBitmapFromHICON(). Note that SkBitmap internally manages a ref-counted pointer to its payload, and is also a movable type; and so there is no need for any code to treat SkBitmaps as "heavyweight" when passing them around. Bug: 873774 Change-Id: I11e7a98fcec42e27213b85d08d81fc47948d483e Reviewed-on: https://chromium-review.googlesource.com/1234372Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592598}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a5c578ff3d46..d89e81168423 git log a5c578ff3d46..d89e81168423 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 bungeman@google.com SkImageGeneratorCG.h to only expose factory method. 2018-09-19 michaelludwig@google.com Increase precision for two point gradient coordinates. 2018-09-19 halcanary@google.com SkPDF: draw persepctive text 2018-09-19 halcanary@google.com SkImageGeneratorWIC: make the header compile without src/. 2018-09-19 brianosman@google.com GrColor -> SkColor in one GM 2018-09-19 herb@google.com Clean up GPU strike sk_sp 2018-09-19 nodir@google.com Populate repo_path_map 2018-09-19 reed@google.com Revert "always optimize third_party code" Created with: gclient setdep -r src/third_party/skia@d89e81168423 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:884150,chromium:694348 TBR=reed@chromium.org Change-Id: I008043cc934cb833a7a9934714c6e9d17a99139f Reviewed-on: https://chromium-review.googlesource.com/1234823Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592597}
-
smut authored
Bug: 723130 Change-Id: I514683aa6441fbe0fd9b45761b684040586412f7 Reviewed-on: https://chromium-review.googlesource.com/1234796Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#592596}
-
Michael Spang authored
Move gpu::CreateVulkanImplementation() call after InitializeForGPU() so that it can work under ozone builds. Prior to InitializeForGPU(), there's no surface factory and attempting to initialize vulkan will simply crash. (2) gn gen out/linux_ozone_rel --args='use_ozone=true is_debug=false' (3) ./out/linux_ozone_rel/content_shell --enable-vulkan Bug: 861853 Test: (1) apply penghuang's WIP vulkan oop-d patches Change-Id: I85b04d1cb366afff075dc86c1698caa6e67f93f0 Reviewed-on: https://chromium-review.googlesource.com/1234222Reviewed-by:Antoine Labour <piman@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592595}
-
Dmitry Gozman authored
This should not make any difference, but will allow to call CommitNavigation directly from StartNavigation when needed. Bug: 855189 Change-Id: Icd7184404784fde750c3d013e02042007f3aa0a7 Reviewed-on: https://chromium-review.googlesource.com/1231830 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#592594}
-
Yue Cen authored
This reverts commit f76c19a8. Reason for revert: Re-enable in M71 Original change's description: > Disable fast app reinstall feature for M70 > > The plan is to ship the feature in M71. This CL will be merge to M70 and > reverted in M71. > > Bug: 835029 > Change-Id: I741c60ccbff2570a07fc9c3535b0acea6efa1ed8 > Reviewed-on: https://chromium-review.googlesource.com/1234966 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yue Cen <rsgingerrs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592550} TBR=xiyuan@chromium.org,rsgingerrs@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835029 Change-Id: Ib83098f9d8f57d5325c10e9bc3ca7c6f46adb0dd Reviewed-on: https://chromium-review.googlesource.com/1235126Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592593}
-
Brandon Wylie authored
Bug: 882967 Change-Id: I114ea70a7f5976d8600f81be22b0096606964dac Reviewed-on: https://chromium-review.googlesource.com/1225274 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#592592}
-
Yuly Novikov authored
Previously was only used in video->TexImageImpl() path, but other paths also require it, since they all end up calling TexImage2D or TexImage3D. Bug: angleproject:2567 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia15d1d55b8f2ba70e6b8bebd4f8c6eb42ad49ddc Reviewed-on: https://chromium-review.googlesource.com/1232579Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592591}
-
Chris Blume authored
SkGifCodec work was reverted as a suspected cause of a paint regression. But it may end up being unrelated. This is a revert of crrev.com/c/718918 Bug: 768878,778164,773548 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifb72574cf2012d417c223193cbd14b52ec644b9a Reviewed-on: https://chromium-review.googlesource.com/783647 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592590}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/21a51b392104..f837545214f5 git log 21a51b392104..f837545214f5 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 nodir@google.com [gclient] Remove patch_projects Created with: gclient setdep -r src/third_party/depot_tools@f837545214f5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:694348 TBR=agable@chromium.org Change-Id: I29b8d88fac7314f39da767295c48a1feaceb04da Reviewed-on: https://chromium-review.googlesource.com/1234824Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592589}
-
David Tseng authored
This reverts commit c996527a. Original change https://chromium-review.googlesource.com/c/chromium/src/+/1220687 Reason for revert Breaks speech on login screen. Various user reports from chromevox-discuss on Canary. TBR=dmazzoni@chromium.org Change-Id: I23e0002d94860a224423a1d4dd6bd39570569dfd Reviewed-on: https://chromium-review.googlesource.com/1235127 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592588}
-
Tim Zheng authored
This CL adds logic to check the app preference and to send app launch request with display scaled up if the preference is set to scaled display. BUG=chromium:839242 TEST=Manually tested on an eve device. Change-Id: I054d384161219a1596aee4366d9bc56962b87eb3 Reviewed-on: https://chromium-review.googlesource.com/1232754Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592587}
-
Giovanni Ortuño Urquidi authored
BluetoothSystem will only be implemented on Chrome OS. Bug: 870192 Change-Id: I0a16a15ee6f15653d19d30d76a7d109235f34e86 Reviewed-on: https://chromium-review.googlesource.com/1233313Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#592586}
-
Tim Zheng authored
This new property is used to record a user's preference for display window scaling. When it's true the app window will be scaled up. This is used to adjustment some older Linux apps that don't show well on HiDPI displays. BUG=chromium:839242 TEST=Unit tests added. Change-Id: I6bf49b814d4467f09af9143c237d5a4e3984168d Reviewed-on: https://chromium-review.googlesource.com/1232196Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592585}
-
Wenzhao Zang authored
Bug: 819404 Change-Id: I7b50cfa40ef33537b17a424e9f7d60061017993c Reviewed-on: https://chromium-review.googlesource.com/1222273 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592584}
-
David Black authored
See corresponding CL: https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/680536 Bug: b:113731926 Change-Id: If4fb1f6947115bec88956e0473dbefef5cfd92a7 Reviewed-on: https://chromium-review.googlesource.com/1229160 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592583}
-
Erik Luo authored
Before, TreeOutline's keydown handler had 'useCapture' and checked whether the target was the selected tree item. This was how nested TreeOutlines avoided conflict. Now, TreeOutlines with selection respond to keyboard navigation from any target. We now assume that nested TreeOutlines, inplace editors, etc will consume the event before it gets to an outer TreeOutline. Bug: 865674 Change-Id: I36af018b6da5a836269a8356a9e97db6c83d1c40 Reviewed-on: https://chromium-review.googlesource.com/1223186Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#592582}
-
qinmin authored
The code under this dir is not being used. The only file left is download_start_animation_mac.mm as it needs to provide mac specific download start animation BUG=881499,832676 Change-Id: I9f8e927da2487c519f329508a31816c5a5253415 Reviewed-on: https://chromium-review.googlesource.com/1234473 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592581}
-
Daniel Rubery authored
These never produced actionable results, and can be recreated in the backend if we need them again. Bug: 884862 Change-Id: Ia1ca37956fb7fe959c290c05c0f3d1650207ced5 Reviewed-on: https://chromium-review.googlesource.com/1229501Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#592580}
-
Michael Spang authored
This reverts commit f3c9ed0e. Reason for revert: breaks Linux Chromium OS ASan LSan Tests Bug: 887048 Original change's description: > ozone: Enable vulkan by default > > Vulkan is enabled by default on Linux desktop (X11) builds. Enable it on > ozone as well to make sure we have build coverage. > > Bug: 861853 > Test: compile > Change-Id: I7c15e365b2a4cfc7160847457ce9bf46a3f12f1e > Reviewed-on: https://chromium-review.googlesource.com/1229233 > Commit-Queue: Michael Spang <spang@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Chris Blume <cblume@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592451} TBR=spang@chromium.org,piman@chromium.org,cblume@chromium.org Change-Id: I6a95fdfdb742e4a876382c72b212bacd2b601c23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861853 Reviewed-on: https://chromium-review.googlesource.com/1235194 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592579}
-
gogerald authored
go/programmatic-autofill Change-Id: I5c9e7e3801c287a497fbd4c0cabae0086a20836c Reviewed-on: https://chromium-review.googlesource.com/1219771 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592578}
-
Chong Zhang authored
Count increased ~120 => ~370 due to the removal of asterisks. Bug: 881976 Change-Id: I3999b9d56f76a69c1284b17ca703f960c5078325 Reviewed-on: https://chromium-review.googlesource.com/1226135 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#592577}
-
Zhiqiang Zhang authored
Previously we always notify route termination upon route close, and only notify route close on error. This was because we rely on a separate disconnect_session message to update state in the Web sender SDK. Now as the Web sender SDK solely depend on the PresentationConnection state, we just notify the route state change. The method mapping of before -> after is: * onRouteClosed() -> onRouteTerminated * onRouteClosedWithError() -> onRouteClosed Non-CAF code doesn't have behavioral change. TBR=mlamouri@chromium.org Bug: 711860 Change-Id: I501b9c3b94aba4d4a2f900bf8eba9d8b8179ccab Reviewed-on: https://chromium-review.googlesource.com/1229194Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592576}
-
Sammie Quon authored
See bug for more information. TabletModeWindowManager is responsible for returning the window to its clamshell bounds, but it does not track window on a secondary user since those windows are not visible. They still get maximized because TabletModeWindowManager becomes aware of them when switching users. This approach adds all windows managed by MultiUserWindowManagerCros when tablet mode is started. Test: unit_tests MultiUserWindowManagerChromeOSTest.WindowBoundsAfterTabletMode Bug: 733639 Change-Id: I14c5e940fe1337789e987e19d8336f0a06e03735 Reviewed-on: https://chromium-review.googlesource.com/1229178Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#592575}
-
Erik Luo authored
This CL - Changes _messagesClicked's useCapture: true > false. - Hides gutter on Elements rendered outside ElementsTreeOutline. This affects two cases: A) Group with expandable objects (e.g. `console.group({x: 1})`), user clicks on the object. Now, clicking an object only expands the object, not the group. B) Element logged in Console (e.g. `document.body`), user clicks on "expand triangle", which overlaps with its gutter. Now that _messagesClicked does not capture, context menu would show upon clicking the gutter. This CL hides the gutter to allow expanding Elements in Console. Bug: 876162 Change-Id: I259f7f305d5ab975a4e8313d9200ff81d13eb9ec Reviewed-on: https://chromium-review.googlesource.com/1198422Reviewed-by:Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#592574}
-
Bill Orr authored
This change adds support to OpenVR and Oculus rendering to show browser-generated overlays on top of WebXR content. The overlays are not yet exposed by this change. BUG=819448 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic60f65607d03da48e1685d342aa6dd6c532efb29 Reviewed-on: https://chromium-review.googlesource.com/1232876 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#592573}
-
Dominic Mazzoni authored
Bug: 886965 Change-Id: Ic3e6eb01394e01343e4eb6da47b064ff6c7cad7d Reviewed-on: https://chromium-review.googlesource.com/1234325Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#592572}
-
Stefan Teodorescu authored
Display policies that might concern the end-user in a managed environment, like reporting device uptime or logged in users to the administrator. These are shown in the chrome://management page only when the device is managed. Bug: 879146 Change-Id: I375da41a7c943bce84e308e0cecdc20b17b224f9 Reviewed-on: https://chromium-review.googlesource.com/1210802 Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#592571}
-
Tom Anderson authored
_NET_WM_STATE holds the window state which may be eg: maximized, fullscreen, minimized, etc. In shutdown, Chrome queries this state so that it can restore browser windows to the correct state on the next launch. The problem is that Chrome queries this state (hundreds of times, in fact) after the window has already gone away. The EWMH spec requires window managers to delete the _NET_WM_STATE property when a window is unmapped [1], so the state that Chrome was getting was invalid. This CL saves the state when a window becomes unmapped, and includes some small cleanups. [1] https://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317598336 BUG=882258 R=sky Change-Id: Iacc43563cd54ade77ac83a580ed24434b6802c91 Reviewed-on: https://chromium-review.googlesource.com/1226645 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592570}
-
Wenzhao Zang authored
1) The screensaver app should be hidden because it doesn't make sense to let a user launch the screensaver. 2) The Web store and the Get Help app should be hidden per UI review. Bug: 883034, 885364 Change-Id: Ic4c481cb0cea0b535efde16997f0c4ad74c11b33 Reviewed-on: https://chromium-review.googlesource.com/1222347Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592569}
-