GitLab

RegisterUMAObserver is soon to be deprecated in PeerConnectionInterface
in WebRTC.

Bug: None
Change-Id: Iad9fe987ee9dcd1512c332a7084e2d1ae5cc4774
Reviewed-on: https://chromium-review.googlesource.com/1141173
Commit-Queue: Qingsi Wang <qingsi@google.com>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576160}

Jumbo isn't compatible with "using namespace" since those cause
compiler warnings unless in the top level file, but "using namespace"
is also prohibited by the code style guide (see:
https://google.github.io/styleguide/cppguide.html#Namespaces )

This makes the code a bit more verbose, but it also makes it
more self consistent since the gles2:: prefix was already
occasionally used.

Bug: 864986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7c2111e70407a7ddf65473cb83e7f63b70b18747
Reviewed-on: https://chromium-review.googlesource.com/1141882Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#576159}

R=fdoray@chromium.org

Bug: 848255
Change-Id: Ic47d338fb15e0bf3579ecd9d1acca67099c6d570
Reviewed-on: https://chromium-review.googlesource.com/1137849Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576158}

This reverts commit 62973d1b.

Reason for revert: results in more churn in
base::Time::ActivateHighResolutionTimer()
without much benefits (decreased 97th and 98th percentile of
Windows.HighResolutionTimerUsage from 100% to 97% and 99%
respectively). See crbug.com/863938

Original change's description:
> [MessageLoop] Disable hi-res timers when not sleeping
> 
> Time::ActivateHighResolutionTimer(bool activating) is a per-thread vote
> for a system-wide side-effect. For a given thread, hi-res timers are
> only useful when going to sleep (if it has pending hi-res tasks).
> 
> Deactivating a thread's vote while it's active will prevent other
> threads on the system which do not have hi-res requirements from
> being forced to use hi-res timers in that period.
> 
> Bug: 854237
> Change-Id: I1393e184cac6c9321d13b92b6077a38c62b1f590
> Reviewed-on: https://chromium-review.googlesource.com/1107110
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: kylechar <kylechar@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574259}

TBR=danakj@chromium.org,gab@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 854237, 863938
Change-Id: I7c26646cac8548ae7b02c90e045bc857ae890ce7
Reviewed-on: https://chromium-review.googlesource.com/1140753Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576157}

This enables the table-based Reading List UI to be released with the
rest of the Phase 1 UI Refresh features.

This CL also updates Reading List EGTests to use a11y identifiers for
toolbar buttons rather than labels.  In the UI Refresh, the toolbar
buttons are based on UIBarButtonItems, which are rendered using
multiple views with the same a11y label.  Since EGTests couldn't find
matchers for the label, IDs are used instead.

Bug: 864378
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I223469771314907b614120a6b98f9bb92ce40b25
Reviewed-on: https://chromium-review.googlesource.com/1139901
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576156}

This CL simplifies the threading of class VideoCaptureCamera2.java
and by doing so resolves potential issues caused by concurrent
access to member variables and Android video API calls.

See https://bugs.chromium.org/p/chromium/issues/detail?id=857530 for
details on issues.

The simplified model is to (still) have the constructor and public API
calls happen on a native thread, and to use a single dedicated thread
owned by the class instance to post to, do work on, and call back into
the native code.

This CL is part of a series, see Design Doc at
https://docs.google.com/document/d/1h1kva4VR1gaV3HVXaSYZFY41icfaB58j-WnHmJdyqc8/edit?usp=sharing

Bug: 857530
Change-Id: I75ffcc4a14f2395d833d80f300acef7b456676e8
Reviewed-on: https://chromium-review.googlesource.com/1117857
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576155}

This CL is a step toward unifying the canvas and OffscreenCanvas
presentation code paths by making WebGL contexts use CanvasResource
to pass frames for OffscreenCanvases

This change revamps mechanisms for triggering calls to PushFrame()
The mechanisms was change to reference OffscreenCanvas object instead
of rendering contexts.  This fixes a destruction race condition where
redereng contexts were failing to de-register themselves when their
host is disposed first.  We also stop requesting BeginFrames in
OffscreenCanvasDidDraw in cases where the draw happens from within
a rAF callback on a worker.

BUG=788439
TBR=zmo@chromium.org
NOTRY=true

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I36965c4a0a892484a9ede966b268c91c7a34548f
Reviewed-on: https://chromium-review.googlesource.com/1135637
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576154}

This is a refactor-only change that cleans up namespaces in
Select-to-Speak, for NodeUtils, ParagraphUtils, WordUtils, and RectUtils.

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iff4adaf10a2bee1f6c777505f1e0acadb1ab60d0
Reviewed-on: https://chromium-review.googlesource.com/1140893Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576153}

https://chromium.googlesource.com/catapult.git/+log/a824624071cc..941ac6857d71


git log a824624071cc..941ac6857d71 --date=short --no-merges --format='%ad %ae %s'
2018-07-18 dtu@chromium.org [pinpoint] Add android-go-perf and android-go_webview-perf bots.


Created with:
  gclient setdep -r src/third_party/catapult@941ac6857d71

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:863767
TBR=sullivan@chromium.org

Change-Id: I2e8c37e442665f03348b83ce6d4813d3a73159d1
Reviewed-on: https://chromium-review.googlesource.com/1142005Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576152}

This is to remove the last usage of NeedsManualRebaseline

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1bc7e63d41acf1f7813d8ac5fba4ae29f3b6691b

BUG: 865039, 621126
Change-Id: I1bc7e63d41acf1f7813d8ac5fba4ae29f3b6691b
Reviewed-on: https://chromium-review.googlesource.com/1142194
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576151}

Changes cast system gesture handling so that events which happen on
the side swipe margin are replayed when the finger is lifted before
leaving the margin area, allowing UI elements to be accessed in the
margin.

Note: A refactoring of the side swipe detection into an EventRewriter
was necessary to allow for the redispatching of the stashed
events. The side swipe detection was factored out into a separate
class, leaving the tap/press handling in the EventHandler.

Bug: internal b/111304882
Test: manual and unit tests
Change-Id: If446ed0d97bc9e5f127c311e98f0ed8289071dd3
Reviewed-on: https://chromium-review.googlesource.com/1141060Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576150}

Aligns values used for text with the ones requested by the spec.

Bug: chromium:863586
Change-Id: I0e9b4c32bd672e38ab2b6a7831fc62fdefe0f650
Reviewed-on: https://chromium-review.googlesource.com/1141359
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576149}

This CL is part of the effort to remove usage of iron-icons/* iconsets
to reduce size of resources loaded.

Bug: 855205
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ibc118f02603e735cc1f3adff66a4fb3fdaace2ce
Reviewed-on: https://chromium-review.googlesource.com/1135990
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576148}

Bug: 753416
Change-Id: If99e2fd12cec42eb3c6a6d464df98f67177ba746
Reviewed-on: https://chromium-review.googlesource.com/1142139Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576147}

BUG=853900

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7e53ddd44240c46e0de1742ece470827eb4fcc10
Reviewed-on: https://chromium-review.googlesource.com/1139016Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576146}

This Cl fixes the spacing between the grid cell title and the close
button. When setting a constant offset for a trailing anchor, a positive
constant results in the trailing anchor being further in the trailing
direction, so a negative constant is needed to ensure the trailing anchor is on
the leading side of the anchor it is constrained to.

Per UX, the offset between the label and the button is set to 4 points.

Bug: 862343
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I01fc0e927c281ea5b174af4126c7e44fd3fc4f7f
Reviewed-on: https://chromium-review.googlesource.com/1140316Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576145}

This CL changes the constructor for CountDownLatchImpl to use a DCHECK
to disallow initialization counts less than 0. An initialization count
of exactly 0 is still allowed, in which case countDown() will never
Signal() its WaitableEvent, and all calls to Await() will immediately
return.

Bug: 861813
Change-Id: Ic7807544c792be010f46ca58391a02f64ab1638e
Reviewed-on: https://chromium-review.googlesource.com/1141101
Commit-Queue: Kyle Qian <kyleqian@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576144}

Unfortunately some Linux apps don't abide to the desktop specification.
This change add some hard coded mapping so that those apps can be
identified.

BUG=chromium:854911
TEST=Manually tested on a eve device.

Change-Id: Id53c889d46337766b77802682d964d5e2bda85dd
Reviewed-on: https://chromium-review.googlesource.com/1141055
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576143}

The current implementation considers that a hover on the label or the
icon corresponds to a mouse exit event for the row, leading to the
current row being deselected. This CL fixes that by notifying the row
view on mouse enter/exit on child events as well.

Bug: 861996
Change-Id: If187048b2893afb7c779f91010b7b225d0da49d7
Reviewed-on: https://chromium-review.googlesource.com/1142035Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576142}

WebXRGamepadSupport remains unchanged because there are no API changes.

Bug: 864810

Change-Id: Ic3f3e37f90521781a199a27444f9e696c855c2dc
Reviewed-on: https://chromium-review.googlesource.com/1132385Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576141}

After http://crrev.com/575378 webrunner used --type=web-context argument
to distinguish between web::ContextProvider and web::Context processes.
This approach didn't work properly because there is a lot of code that
assumes that process_type is not set (or empty) in the browser
process, which corresponds to web::Context. This CL removes
--type=web-context. Instead webrunner uses presense of the Context
request handle in the startup info to distinguish between the two
process types.

Also updated ContextProviderMain() to initialize MessageLoop as it's
required on all threads that use FIDL.

Bug: 852145
Change-Id: I2d308c712530f5802a4783cbebcffa49fade326d
Reviewed-on: https://chromium-review.googlesource.com/1141174
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576140}

When building using jumbo, files gets merged and
variables with the same name may end up in the same
scope. This commit renames such varaibles to something
more descriptive or file specific.

Bug: 803406
Change-Id: Ia43af0d95b0693ce917722397bc23db655441c29
Reviewed-on: https://chromium-review.googlesource.com/1141579Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#576139}

Adds a class FakeV4L2Impl for replacing the actual V4L2 Apis in unit testing.
Adds a simple first test case for enumerating a single fake device.

This CL is part of a series, see Design Doc at
https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing

Test: capture_unittests --gtest_filter=VideoCaptureDeviceFactoryLinuxTest
Bug: 768887
Change-Id: I7db4bed17453c4636158b9660ad1a5da4d74781c
Reviewed-on: https://chromium-review.googlesource.com/1123021
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576138}

Specifying what subclass of NSView being called,
in this  case BubbleView.

Bug: 803406
Change-Id: Iabc0a02ab17a881993f34b9c120978ca7f45264c
Reviewed-on: https://chromium-review.googlesource.com/1141879Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#576137}

Changes:
 - String update for footer in privacy section
 - Minor string tweak for Autocomplete setting title
 - Update text for "turn off sync" confirmation dialogue
 - String tweak for activity and interactions

Bug: 864755, 864752, 863965, 863934
Change-Id: Idf94963717f54832be123f4c575178c9d2399298
Reviewed-on: https://chromium-review.googlesource.com/1141868
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576136}

This reverts commit b8738136.

Reason for revert: crbug.com/863795

Original change's description:
> overview: Fix crash with hiding title bars on entry.
> 
> Using OnCompositorStarted does not work for overview anymore. See stack
> trace in bug.
> 
> Test: manual
> Bug: 863795, 843851
> Change-Id: I3dc8965cbece03ac36f1dc404c9b19b7dcac5b5e
> Reviewed-on: https://chromium-review.googlesource.com/1138737
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575447}

TBR=oshima@chromium.org,sammiequon@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 863795, 843851
Change-Id: Ibc5965bc51a62e08b44d034a81f6954b8e799cad
Reviewed-on: https://chromium-review.googlesource.com/1142166Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576135}

By reviewing the results of build 8070.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I10cd2eeea7aa6098d868ebf858c68d1ddcde2ccc
Reviewed-on: https://chromium-review.googlesource.com/1142052
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576134}

This allows things like resolution, codec, and decoder changes to
avoid finalizing UMA watch time, while preserving a somewhat similar
finalization for UKM. This is becoming more important as we move
into a multi-codec world since we don't want every secondary property
change to cause a loss of UMA watch time (see linked bug).

Similar in the sense that secondary property updates will flush the
current watch time values outside of the normal timer driven updates
and skip the finalize step if one is pending. The next timer update
would finalize or update as normal, we've just added an extra update
in between.

Bug: 779192
Test: new unittests.
Change-Id: Ica4479e763ca3ea2cf51595bed24a3078ec199c6
Reviewed-on: https://chromium-review.googlesource.com/1123688
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576133}

Bug: 844947
Change-Id: Iab736aaeffc70816f803a30d09bf65d712802134
Reviewed-on: https://chromium-review.googlesource.com/1135591
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576132}

One of the tests starts a request that will repeatedly retry itself on
failures, with backoff. The test asserts that the delay has a certain
value, which is effectively the same as asserting that the request is
on a certain retry attempt, but sometimes the request has time to retry
more than once before the test assertion occurs. This changes to assert
to not expect a specific value, just one that's larger than the
default.

Bug: 864797
Change-Id: Ia8fced88b119f724bb2e2c93602ed6034b0b87d1
Reviewed-on: https://chromium-review.googlesource.com/1141299Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576131}

Fix some nits as well.

Change-Id: I8340ee189d751643a74841ef826fd2df2b8884b5
Reviewed-on: https://chromium-review.googlesource.com/1141107Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576130}

The 'text-justify' property was implemented under the runtime
flag but currently there are no active plans to ship.

This patch skips tests for the property.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iccbdf6087be326c934ab5dbdde965c9b2a12b4ac
Reviewed-on: https://chromium-review.googlesource.com/1142051
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576129}

Show Assistant UI on flow completion if relaunch parameter is set.

Bug: b/111406040, b/110847784
Test: Manual Test
Change-Id: I86c02bc90de7a4e797c1c57c7fd9fdab8b1b0cf0
Reviewed-on: https://chromium-review.googlesource.com/1139183
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576128}

This reverts commit 8025aa7e.

Reason for revert: Inadvertently affects the attached bookmarks bar.

Original change's description:
> Changed kBottomMargin of the detached bookmark bar from 4 to 2 pixels.
> 
> This makes the detached bookmarks items vertically centered.
> 
> Bug: 863697
> Change-Id: Icf6529ec0b33255dc8072d5bfacc2f32b0495f93
> Reviewed-on: https://chromium-review.googlesource.com/1139191
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Commit-Queue: Charlene Yan <cyan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575746}

TBR=bsep@chromium.org,cyan@chromium.org

Change-Id: I9381f0796b85cd658d2101981e3a1ef7071fb4ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863697
Reviewed-on: https://chromium-review.googlesource.com/1142168Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576127}

It looks like standalone apps will still show the
system UI (and should) so they will be blocked
by the Android OS from extending into the display
cutout.

Therefore, we should not give them default control
of the cutout

BUG=859241

Change-Id: Ie26d41fe983c1f45e4177676a3f936a03ca3a07c
Reviewed-on: https://chromium-review.googlesource.com/1134080
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576126}

Conditionally set IDEBundleInjection and libXCTestBundleInject.dylib based
on Xcode version.

Bug: 843236
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2a13fd1e93cbe87e80b045c1d3010f518a6ed862
Reviewed-on: https://chromium-review.googlesource.com/1141276Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576125}

+ Change color for icons from google_grey_600 to v2 Grey 800
+ Add custom attribute for tinting preference icons set from XML
+ Update icon color for Download spinner and location dialog

Bug: 834884, 863519
Change-Id: I7c9b61ad8983ef0fa01ad69065bdfe0b3baafa23
Reviewed-on: https://chromium-review.googlesource.com/1141128Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576124}

This CL fixes an undesired interaction between the rounded corners and
the scroll view in the new dropdown. Specifically, we observed that the
clipping path was not being respected on Mac when applied to the
contents of the scroll view. This is fixed by applying the existing
padding outside, rather than inside, the scroll view, so that the
region being clipped is guaranteed to be non-scrollable padding. (n.b.:
the padding calculation ensures this is at least as much as large as
the corner radius.)

This also introduces a minor visual change in the scrolling case only,
as the padding above and below the suggestions no longer scrolls along
with the suggestions. Besides fixing the clipping bug, on platforms
other than Mac this also ensures the top of the scrollbar does not get
partially clipped.

Change-Id: I6ef7319db094ec66b64859df64031f6330dd567c
Bug: 863930
Reviewed-on: https://chromium-review.googlesource.com/1140913
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576123}

The action happens whenever the DownloadActivity is resumed, which
can happen multiple times when it is triggered. This leads to the
dashboard being cluttered with many of these events, that are
not really helpful notions of user actions.

BUG=786102

Change-Id: I534d2fa8f147281b619f8f10085a0aab8e3815bf
Reviewed-on: https://chromium-review.googlesource.com/1138723Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576122}

This adds mojo/edk initialization to
media/gpu/video_decode_accelerator_unittest. This is necessary for
future changes that use mojo machinary for shared memory manipulation.

Bug: 849207
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6d04891a4d306f7c458eb2bb4ce3fd42a1b77759
Reviewed-on: https://chromium-review.googlesource.com/1122095
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576121}