- 06 Mar, 2018 40 commits
-
-
Charles Harrison authored
The WebContentsImpl is the only consumer of this information, and it only cares about the host. URLs can be huge (up to 2MB), while hosts are much much smaller. It isn't a good idea to copy the URL for every outgoing request to the UI thread every 250ms. Note: previously this code did some grouping by RVid (I think) before thread hopping. This would further alleviate copying issues when there are lots of requests. Probably we could just use two sets: 1. Global frame routing id -> LoadInfo for subresources 2. All navigation requests Bug: 813445 Change-Id: Ied3709fac7bba079d5e31694dc8e477d1c7f2f68 Reviewed-on: https://chromium-review.googlesource.com/951364Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#541189}
-
Khushal authored
Animating images in the compositor is now enabled by default. This change removes the feature flag and removes dead code in blink for driving animations in blink. As a part of this, tests have been updated as follows: 1) If the test verifies logic specifically pertaining to invalidation for non-svg animated image formats, they have been removed. Since invalidations for these images is driven by the compositor, these are unnecessary. 2) For tests which verify blink's paint invalidation for offscreen animated images, the logic under test is agnostic to the image format and also applies to animated svgs. If the test only used GIFs, it has been updated to use animated SVGs instead. 3) For tests, namely drawing an animated image on canvas and updating the animation policy, they have been switched to use a timeout instead of advancing the animation using the Internals API. This ensures they still serve as integration tests for these use-cases. R=chrishtr@chromium.org, piman@chromium.org Bug: 776216 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic0c5ea080e166aaa5732af81ce497cff6b2b6e4e Reviewed-on: https://chromium-review.googlesource.com/944968Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#541188}
-
Xianzhu Wang authored
The function took 15% of total PaintChunksToCcLayer::ConvertInto() time. There were two function calls: FloatRect::EnclosingIntRect() which in turn called IntRect::IntRect(const FloatRect&). Cluster-telemetry showed about 1~2.5% improvement of record times (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180306062045/html/index.html). Bug: 803867 Change-Id: If69f2c4c207ccc1025035f018c63e14c3b078462 Reviewed-on: https://chromium-review.googlesource.com/950104 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#541187}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d718df0c. With Chromium commits locally applied on WPT: 14350ac7 "[PE] Don't truncate table cell's padding" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13409 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler TBR=jsbell No-Export: true Change-Id: I17e5752e8977b22e534e0cc83ac93487c8d864b0 Reviewed-on: https://chromium-review.googlesource.com/951822 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#541186}
-
Andrew Grieve authored
It now lives at //third_party/android_ndk Bug: 755920 Change-Id: I8ba6ee6cfb97fdca3aed3e43005f26ba540b3d61 Reviewed-on: https://chromium-review.googlesource.com/949098Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#541185}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id50cf5499e8185f84b4f3d47231f21d37b8599bf Reviewed-on: https://chromium-review.googlesource.com/951802 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#541184}
-
Joshua Peraza authored
This change was included in https://chromium-review.googlesource.com/c/chromium/src/+/947745 and was reverted by https://chromium-review.googlesource.com/c/chromium/src/+/950343 but is still needed by https://chromium-review.googlesource.com/c/chromium/src/+/945049 Bug: chromium:817982, chromium:818376 Change-Id: I4f97d632ba9f86c17d3df55c404c0ae14e1d39c9 Reviewed-on: https://chromium-review.googlesource.com/950466Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#541183}
-
Stephen Martinis authored
Bug: 818832 Change-Id: Icad3529d4b143eb1798250d3e96f36a23dbd23c8 Reviewed-on: https://chromium-review.googlesource.com/950322Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#541182}
-
Lily Houghton authored
This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/857421 that renames the PROXY_SERVICE_* event types. Bug: 613637 Change-Id: Iabe3c5706952b45c9a3c253feed290d5a872f13b Reviewed-on: https://chromium-review.googlesource.com/944001Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#541181}
-
Nick Harper authored
TBR=elawrence@chromium.org Change-Id: Icb4071663ece23d57219ac395a1a4f785174f4fd Reviewed-on: https://chromium-review.googlesource.com/950318Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#541180}
-
Scott Violet authored
BUG=714018 TEST=none Change-Id: I29070e75f7040f50f8e4b2c0e4fd738913a4cf76 Reviewed-on: https://chromium-review.googlesource.com/949086Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#541179}
-
Xiaohui Chen authored
Bug: 807015 Test: run unittest Change-Id: I1938a5ec52869ca9097d58c32022c4f05520331d Reviewed-on: https://chromium-review.googlesource.com/946898 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541178}
-
Bin Zhao authored
We would like to collect media sink service status and include it in feedback report. Sending feedback is currently done at extension side. Extension will fetch media sink service status via GetMediaSinkServiceStatus() mojo call. - Added GetMediaSinkServiceStatus() to media_router.mojom - Added empty implementation to media_router_mojo_impl - Added MediaSinkServiceStatus class - Implemented GetMediaSinkServiceStatus() in media_router_desktop Bug: 687380 Change-Id: I2cbbf997912b6fc1af4897e929250235e70d7837 Reviewed-on: https://chromium-review.googlesource.com/884743 Commit-Queue: Bin Zhao <zhaobin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541177}
-
Jonathan Backer authored
- changed build_cmd_buffer_lib.py to handle C++ enums (including static_casts for enum class) - generated separate param validators for Raster than the validators for GLES2 and used them for glTexParameteri - created gpu/command_buffer/common:raster_sources to avoid adding a //components/viz/common:resource_format dependency on OS_NACL builds (this breaks the is_nacl build on transitive skia dependency). Moved this into gpu:gles2 component for now so that client and service can access it Bug: 789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idef2cf3a3ad23e630b792c1e12280b19fa485fdf Reviewed-on: https://chromium-review.googlesource.com/948725Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#541176}
-
Bruce Dawson authored
anti-virus -> antivirus Add instructions on running post_build_ninja_summary.py manually. Bug: 787983 Change-Id: I2f44b292fb80d1cac56d4c2b1cbe9d65ff6fd7e1 Reviewed-on: https://chromium-review.googlesource.com/949416Reviewed-by:
Xi Cheng <chengx@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#541175}
-
Boris Sazonov authored
This CL removes textColor and textColorLink from DialogWhenLarge, as theme textColor overrides textAppearance specified for TextView, prohibiting the usage of common text styles specified in styles.xml. To make sure this CL doesn't accidentally change colors for some TextViews, it adds a default textAppearance to DialogWhenLarge. Bug: 819191 Change-Id: Ib5c1a37baf6195b6c53d13d15ccf7b0173e72502 Reviewed-on: https://chromium-review.googlesource.com/951246Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#541174}
-
Mike West authored
Bug: 811440 Change-Id: I51253d721b30255f8270eacb67d5bcf629f90da1 Reviewed-on: https://chromium-review.googlesource.com/949046 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#541173}
-
Darren Shen authored
When we parse a custom property with an empty string, we hit a DCHECK that asserts that there's at least one token. We now throw a TypeError when given an empty string, since a custom property only matches one or more tokens [1]. [1] https://drafts.csswg.org/css-syntax-3/#typedef-declaration-value Bug: 819098 Change-Id: I2d5ef71fb36011d0e2efc5e1c3664cb3c8a69f6b Reviewed-on: https://chromium-review.googlesource.com/950624Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#541172}
-
Eugene But authored
This CL only adds UIView. The view will be integrated into Download Manager UI in a separate CL. There are no tests as testing view drawing is hard and not worth the effort. UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2b7a689b42_0_196 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9dba8b92726a9da6865866a49020f9bb0bc51c74 Reviewed-on: https://chromium-review.googlesource.com/949882 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541171}
-
Weidong Guo authored
This solves the issue: After the user taps or clicks outside the folder name, the text should be deactivated. Bug: 815071 Change-Id: Ic8b77fb171d16c59198ccc1112d1b5dcb07a701d Reviewed-on: https://chromium-review.googlesource.com/951718Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541170}
-
Dmitry Gozman authored
Otherwise you can only debug without switching to a different tab, and only with docked DevTools. Bug: 816202 Change-Id: I24b008cfccc9278b29236c78436da8ab78a91f5b Reviewed-on: https://chromium-review.googlesource.com/950003Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541169}
-
Yi Gu authored
Currently after commit we animate the following on the pending tree. - Flings - Page scale - Layer animations - Scrollbars - Browser controls However only layer animation is necessary. Bug: 551134 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8b8babb624389cad806b2d186bdecca5d8eba25c Reviewed-on: https://chromium-review.googlesource.com/946112Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#541168}
-
Saman Sami authored
Also rename RequestCopyOfSurface to RequestCopyOfOutput in CFSS to make it clear the CopyOutputRequest is not guaranteed to run on any particular surface. BUG=812059 TBR=khushalsagar@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I99c42b497f9985d37916a7cdbab0a8b2aa3e3f7d Reviewed-on: https://chromium-review.googlesource.com/949068Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#541167}
-
https://skia.googlesource.com/skia.git/+log/bd6525304d44..8bac928009b8 $ git log bd6525304..8bac92800 --date=short --no-merges --format='%ad %ae %s' 2018-03-06 robertphillips Fix .fp files 2018-03-05 bungeman Draw glyphs from paths if they have an empty path. 2018-03-06 reed check for valid inputs to shadows 2018-03-05 herb Add GetTypefaceOrDefault to SkPaintPriv 2018-03-06 caryclark use points instead of verbs for interpolate 2018-03-01 hcm Update Skia milestone to 67 2018-03-05 reed make compute helper for blurs private 2018-03-06 robertphillips Move internal calls from GrContext to GrContextPriv 2018-03-05 scroggo Fix drawing SkAnimatedImages with transparency Created with: roll-dep src/third_party/skia BUG=816763 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I9852eac848da96f9880bdbff53ac9e703af941fb Reviewed-on: https://chromium-review.googlesource.com/951712Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541166}
-
Yixin Wang authored
Bundle QUIC frames sent from consecutive synchronous operations in QuicHttpStream when sending a request. For example, this will bundle POST headers and body into one packet, or consecutive synchronous reads of QuicHttpStream::upload_data_stream into one packet, or multiple PRIORITY frames on a PUSH_PROMISE rendezvous (that causes the matched stream to update its priority). Bug: 18636638 Change-Id: Ide3abaf7a7c80a661239a2181718e10303d18144 Reviewed-on: https://chromium-review.googlesource.com/946905Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#541165}
-
Andrew Grieve authored
Bug: 818284 Change-Id: I19296691937df7d84e85d561608574010dd2c746 Reviewed-on: https://chromium-review.googlesource.com/951412Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#541164}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/598a80ed..c95cc11a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I551cbc33bdaa935236e5b3be6f5125d1da0dcdfc Reviewed-on: https://chromium-review.googlesource.com/951363Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#541163}
-
Sadrul Habib Chowdhury authored
HitTestAggregator creates a shared memory segment, and populates it with a list of AggregatedHitTestRegion objects. It then shares the memory with HitTestQuery, which sees this as read-only data. However, when using the gfx::Transform, which is backed by SkMatrix44, it can attempt to write to the read-only shared memory (because SkMatrix44 has a mutable attribute which can be changed during a const-method call), which causes failure (crash) in HitTestQuery. To avoid this failure, always make a copy of the gfx::Transform before using it in HitTestQuery. BUG=819291 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I97d23c25de7271e1813b1c4e0a4de05ce2cdc7c4 Reviewed-on: https://chromium-review.googlesource.com/950471 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541162}
-
Kevin McNee authored
In ScrollNestedLocalNonFastScrollableDiv and NestedLocalNonFastScrollableDivCoordsAreLocal, we wait for the compositor thread in the root, but the wheel events are going to the OOPIF. Since it's the compositor for the OOPIF that will receive the event, we should sync with that one instead. It seems like this would explain why the test goes on to wait for a timeout before sending the event. Also, we should be adding the InputEventAckWaiter before sending the event. Bug: None Change-Id: Iebc0fe377a4cd14fee65a0d45d9ff5f49fd89084 Reviewed-on: https://chromium-review.googlesource.com/949975Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#541161}
-
Matt Wolenetz authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/ef99a5d2520f..4468d4967f5d $ git log ef99a5d25..4468d4967 --date=short --no-merges --format='%ad %ae %s' 2018-03-05 wolenetz lavf/oggparseflac: Free flac extradata before reallocating. Created with: roll-dep src/third_party/ffmpeg BUG=789835 TBR=xhwang@chromium.org Change-Id: Ic056e574e67ecbb808cc70e91a8ee112afcffb0d Reviewed-on: https://chromium-review.googlesource.com/950066Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541160}
-
Xing Liu authored
This reverts commit a8a0539c. Reason for revert: failing on internal.client.clank/asan-clang-phone Bug:819230 Original change's description: > Enable NetworkServiceRestartBrowserTest on Android. > > This CL includes NetworkServiceRestartBrowserTest to run on Android > platform. > > TBR=jam@chromium.org,dtrainor@chromium.org > > Bug: 783374 > Change-Id: Ic4210f63a2586f7bcf20424cdd1dc759cea7b14d > Reviewed-on: https://chromium-review.googlesource.com/947471 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540899} TBR=jam@chromium.org,dtrainor@chromium.org,xingliu@chromium.org Change-Id: I64391e1bfe82b8978c7cd0d8afef653a5ba06fe2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783374 Reviewed-on: https://chromium-review.googlesource.com/951664Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#541159}
-
Yuke Liao authored
Now that code coverage script works on iOS platform no different from other platforms, it doesn't make sense to keep the iOS specific code coverage docs anymore. Bug: 800876 Change-Id: If9344e7283dae05255cc5518609dced2f4367593 Reviewed-on: https://chromium-review.googlesource.com/950469Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#541158}
-
stkhapugin@chromium.org authored
The floating cursor is the cursor moved by force touch on the system keyboard on iPhone or by double-finger swipe on iPad. When it appears, pre-edit label should be removed to allow the user to position the caret and select part of the text. Bug: 601934 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icdc7464e519bfa9e0adc23dd1e0b1e093841dc46 Reviewed-on: https://chromium-review.googlesource.com/951307Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541157}
-
Navid Zolghadr authored
Bug: 733774 Change-Id: Ic92388817ee3f1dc47a999564e7f16045ed9957f Reviewed-on: https://chromium-review.googlesource.com/951707Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541156}
-
Christopher Thompson authored
This adds histogram logging for the SecurityLevel of the WebContents that initiates a new download. The special case of a download being started in a new tab or window is not counted, as we don't have visibility into the "referring" WebContents in that case. Also adds browser tests for ordinary downloads as well as save page downloads to test that the correct SecurityLevels are logged. Bug: 803526 Change-Id: I183ff4b7b3434e219bf9cef0dd159fc3fd173fb2 Reviewed-on: https://chromium-review.googlesource.com/935369 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#541155}
-
Michael Thiessen authored
Prior to GVR 1.13, the DisplaySynchronizer would start resumed, but with 1.13 this behaviour was changed. This lead to the DisplaySynchronizer not picking up orientation changes and WebVR being rotated in landscape. Bug: 817889, 818750 Change-Id: I77202d2d0d7b6feb340483e87491e2b5c1009042 Reviewed-on: https://chromium-review.googlesource.com/951642 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#541154}
-
https://chromium.googlesource.com/angle/angle.git/+log/e05ffdd19837..d2cb7cec4f3e $ git log e05ffdd19..d2cb7cec4 --date=short --no-merges --format='%ad %ae %s' 2018-03-02 jiawei.shao ES31: Fix wrong method of computing combined interface blocks Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I03db388e345747ecbc0480e2ac12a5cc0818193f Reviewed-on: https://chromium-review.googlesource.com/951643 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541153}
-
Evan Stade authored
These are readability improvements I came across while trying to grok WindowSizer. There should be no behavioral changes here. - make WindowSizer ctors private - remove dead SetMaximizeFirstWindow function - replace else { if with else if Bug: 764009 Change-Id: I2594e31fee48a5f25cd00840d2aef3db1980b301 Reviewed-on: https://chromium-review.googlesource.com/950476 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#541152}
-
Gustav Sennton authored
mAdapterLock was meant to be used for glue adapter instances stored in WebViewChromiumFactoryProvider but using such a lock together with a lock for Chromium initialization caused deadlocks. In this CL we remove mAdapterLock since it's no longer used (either upstream or downstream). Bug: 807332 Change-Id: I7b736942ae7fcbdaefbf888c36d84228154706b8 Reviewed-on: https://chromium-review.googlesource.com/951782Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#541151}
-
Leonard Grey authored
Clean-up to address post-submit tapted@ comments on https://chromium-review.googlesource.com/c/chromium/src/+/919189 (Some are now moot, as profile switcher creation was refactored https://chromium-review.googlesource.com/c/chromium/src/+/935882) Bug: 565989 Change-Id: Id775d1dabcf96abdb22c02c33b9949befa148165 Reviewed-on: https://chromium-review.googlesource.com/949369 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#541150}
-