GitLab

The framework ran commands from the current working directory. Make it run commands from the framework's directory.

NOTRY=True 
BUG=264859
1) Uninstall Chrome (if it's installed.)
2) Build Chrome with Release mode and make sure that mini_installer.exe is created.
3) Go to src\chrome\test\mini_installer
4) Run "python test_installer.py config\config.config --build-dir=<build-dir> --target=Release" where <build-dir> is the path to main build directory (the parent of the Release directory). The test should pass.
5) Go to src\chrome\test
6) Run "python mini_installer\test_installer.py mini_installer\config\config.config --build-dir=<build-dir> --target=Release". The test should pass.

Review URL: https://chromiumcodereview.appspot.com/23557009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131612

Review URL: https://chromiumcodereview.appspot.com/23523019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221360 0039d316-1c4b-4281-b951-d872f2087c98

The --fake-cloud-policy-type flag has also been enabled for iOS, for testing
purposes.

BUG=285084

Review URL: https://chromiumcodereview.appspot.com/23475018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221359 0039d316-1c4b-4281-b951-d872f2087c98

 - remove the suppressions that won't be needed after https://codereview.chromium.org/23602005/ is landed
 - add a suppression for race in base::HistogramSamples::IncreaseSum
Suppress a race in media::TestInputCallback::OnData (issue 239359)

BUG=46840,239359
TBR=jar@chromium.org,timurrrr@chromium.org

Review URL: https://codereview.chromium.org/23477019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221357 0039d316-1c4b-4281-b951-d872f2087c98

This is preparation to start returning DriveIntegrationService always from
DriveIntegrationServiceFactory::{Get,Find}ForProfile.

BUG=284972
TEST=Ran unit_tests
R=kinaba@chromium.org, satorux@chromium.org

Review URL: https://codereview.chromium.org/23523022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221356 0039d316-1c4b-4281-b951-d872f2087c98

The user deserves a chance to override. Now that we've made the UI subtle,
it's not like users are going to hit the button by accident.

BUG=285376
R=thestig@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/23971005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221355 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=danakj@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23944006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221354 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to move them in crrev.com/221334.

BUG=273386
TEST=none
R=hidehiko@chromium.org

Review URL: https://codereview.chromium.org/23723005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221353 0039d316-1c4b-4281-b951-d872f2087c98

Changing the histogram names since the definition of the histogram changed in
https://codereview.chromium.org/23720005

BUG=246492
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23511012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221352 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 2a0ff283.

Reason: BuildBot Vista fails TokenServiceUpdateClearsCache test.

BUG=
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/23767004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221350 0039d316-1c4b-4281-b951-d872f2087c98

This is copied from chrome/browser/chromeos/extensions/file_manager.

Along the way, remove zork from chrome/browser/chromeos/drive/OWNERS,
as he's no longer working on this code.

BUG=none
TEST=none
R=hidehiko@chromium.org, kinaba@chromium.org

Review URL: https://codereview.chromium.org/23719011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221344 0039d316-1c4b-4281-b951-d872f2087c98

The old behavior was to delete all the shortcuts, which is rather user-hostile. With this change, the user-created shortcuts will be made to target the new system-level Chrome, to form a better transition experience.

- To determine whether or not a shortcut (to the user-level chrome.exe) is user-created, the heuristic we use is to test that the arguments of the shortcut are empty.
- The default shortcut to user-level chrome.exe is NOT retargeted, so it would get deleted (thus avoiding duplicate shortcut to the system-level Chrome).

Right now the "Chrome Apps" is not handled. This is a similar issue as http://crbug.com/238895 , and should be handled in a different CL.

BUG=235857

Review URL: https://chromiumcodereview.appspot.com/22382007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82582,170921
TEST=no functional change
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23947003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221342 0039d316-1c4b-4281-b951-d872f2087c98

During the fullscreen transition, on some sites Flash destroys and recreates its
context, which causes the RenderWidgetFullscreenPepper to switch back and forth
between composited and non-composited modes, recreating its compositor. That
causes it to send 2 successive frames with resources that have the same id (1)
but from different compositors (and different mailboxes).
Make sure we disambiguate those by recreating the DelegatedRendererLayer.

BUG=284821

Review URL: https://chromiumcodereview.appspot.com/23513012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221341 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221339 0039d316-1c4b-4281-b951-d872f2087c98

Problem scenario happened because destroying a tab was triggering
updating another tab. When the other tab updated various BrowserWindow
methods were called when BrowserView was in a bad state (part way
through destruction).

In theory if detaching tried to update state we would end up in the
same situation as this fixes, but that seems less likely.

BUG=236389
TEST=covered by test now
R=avi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23800003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221337 0039d316-1c4b-4281-b951-d872f2087c98

Previously, open_util.cc and file_tasks.cc had two separate
implementations of file task selection logic. The one in open_util.cc
was unclean had an issue with the download shelf (issue 279771).
Not to mention, having two separate implementations for doing the
same thing is not good for code health.

This patch replaces the unclean logic in open_util.cc with the one
in file_tasks.cc (FindAllTypesOfTasks()).

BUG=279771,278037,284194
TEST=See steps described in issue 279771
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23857004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221336 0039d316-1c4b-4281-b951-d872f2087c98

SpecialStoragePolicy is not required, so no need to log about it.

NOTRY=true
BUG=285570

Review URL: https://chromiumcodereview.appspot.com/23579008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221335 0039d316-1c4b-4281-b951-d872f2087c98

To separate binding code and non-binding code:

- chrome/browser/chromeos/extensions/file_manager: JS API bindings
- chrome/browser/chromeos/file_manager: The gut

Note that volume_manager* files are excluded as these are
now actively being changed.

BUG=273386
TEST=none
R=hidehiko@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/23945002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221334 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=./tools/perf/run_measurement --browser=release page_cycler tools/perf/page_sets/tough_layout_cases.json --page-filter=amar --pageset-repeat=2 --profiler=vtune

Review URL: https://chromiumcodereview.appspot.com/23536025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221333 0039d316-1c4b-4281-b951-d872f2087c98

Track libpeerconnection loading time.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23619017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221332 0039d316-1c4b-4281-b951-d872f2087c98

- Now we can notify demuxer ready as soon as the demuxer is ready. We don't need
  to wait for a key to be added if the stream is encrypted.
- QueueSeureInputBuffer() et al return MediaCodecStatus to pass detailed status.
- If no key is available the media pipeline pauses.
- After a key is added we try to resume the media pipeline playback.

BUG=277211,255781,281663
TEST=Start decoding without key is added and see no crash. After key is added
playback resumes.

R=acolwell@chromium.org, jschuh@chromium.org, qinmin@chromium.org

Review URL: https://codereview.chromium.org/23545029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221331 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=enne@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23658023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221330 0039d316-1c4b-4281-b951-d872f2087c98

- InstallTracker::Oberve() could trigger OnExtensionUninstalled() twice because NOTIFICATION_EXTENSION_UNLOADED notification with reason UNLOAD_REASON_UNINSTALL could be sent along with an additional NOTIFICATION_EXTENSION_UNINSTALLED.
- In ComponentLoader::UnloadComponent(), change reason back to UNLOAD_REASON_DISABLE.

Change how Apps Developer Tools is disabled:
- Use ExtensionService::UninstallExtension() instead of ComponentLoad::Remove() to remove Apps Developer Tools. It makes the codepath consistent with regular extension uninstall.

BUG=278393, 277897

Review URL: https://chromiumcodereview.appspot.com/23636002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221329 0039d316-1c4b-4281-b951-d872f2087c98

Currently chrome.usb.findDevices always yields new ids and there is no way to know the consistency among different calls.

chrome.usb.getDevices API will be introduced which yields stable ids for each device and remains unchanged until the device is unplugged.

API Proposal:
https://docs.google.com/a/chromium.org/document/d/16OJQRjW6ZRkIQqA3qIEVFBRY3tFLFnlNXlTGJ5pgPfg/edit

BUG=277139

Review URL: https://chromiumcodereview.appspot.com/22914023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221328 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=249018
TEST=gpu_unittests, webgl conformance tests

Review URL: https://chromiumcodereview.appspot.com/23534007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221326 0039d316-1c4b-4281-b951-d872f2087c98

Updated and/or duplicated (updated with copy renamed *ForLegacyShelfLayout) unit tests as required.

BUG=246279
TBR=jamescook@chromium.org, skuhne@chromium.org

Review URL: https://codereview.chromium.org/22793011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221325 0039d316-1c4b-4281-b951-d872f2087c98

PPB_NetworkList_Private was implemented before PP_ArrayOutput and PPB_NetAddress
was added. Refactor GetIPAddress() to use these new types.

Also removed in-process support because PPB_NetAddress doesn't support in-process mode.

BUG=281781
TBR=piman@chromium.org (trivial changes in content_renderer.gypi)

Review URL: https://chromiumcodereview.appspot.com/23806003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221324 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243013

Review URL: https://chromiumcodereview.appspot.com/23537017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221323 0039d316-1c4b-4281-b951-d872f2087c98

See original discussion at https://codereview.chromium.org/18656004/
Reverted as: https://codereview.chromium.org/23463010/

Added a new base::strings::SafeSPrintf() function that can
safely be called from all restricted (e.g. async-signal-safe)
environments. It is roughly equivalent to snprintf(). But
it is easier to use, as it uses C++ to be type-safe.

In release builds, this function is guaranteed to never call
any other library function nor any system calls. In debug
builds, we call RAW_CHECK() in some circumstances.

This code is needed for (at least) the seccomp sandbox and
to clean up code in the stack tracer. Those changes are
pending and will be submitted as separate CLs.

BUG=285499
TEST=base_unittests
TBR=willchan@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23777003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221322 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the tile management viewport to be the on-screen-visible
rect for the last hardware draw.  There are two problems I needed to solve:

1) Suppress UpdateTilePriorities from happening when the last draw was a
software draw, which is specified by the new
"viewport_valid_for_tile_management" bool.

2) In some cases, the clip rect is smaller than the WebView's visible
viewport -- for example when the Android Browser progress bar is forcing
redraws, the clip is only a small area at the top of the screen.  I
switched to using the visible viewport for UpdateDrawProperties +
glViewport, and introduce a separate "DeviceClip" to override glScissor.
(It's necessary to make the change at this level, rather than directly
plumbing the visible viewport to UpdateTilePriorities, because
UpdateTilePriorities also makes use of outputs from the draw properties
calculation.)

I also cleaned up all uses of device_viewport_size() to call DrawViewportSize()
instead, with the sole exception of UnscaledScrollableViewportSize() which
should continue to use the main-thread device_viewport_size_ in all cases
(because that's the viewport for scrolling, not drawing).

New tests: PictureLayerImplTest.SuppressUpdateTilePriorities,
           ExternalStencilPixelTest.DeviceClip

NOTRY=true
BUG=232844

Review URL: https://chromiumcodereview.appspot.com/23171014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221321 0039d316-1c4b-4281-b951-d872f2087c98

- Put FontConfigIPC creation in PreSandboxInit().
- Add a sanity check for being single threaded.

BUG=269816
R=markus@chromium.org

Review URL: https://codereview.chromium.org/23830004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221320 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the Activity Log was disabled by default unless a flag was set or a specific app was installed.

With this CL, events will be logged for everyone. However, we will only write to the database or stream to the API if the flag is set or the app is installed.

BUG=276501

Review URL: https://chromiumcodereview.appspot.com/23729005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=webgl conformance tests
R=bajones@chromium.org, kbr@chromium.org

Review URL: https://codereview.chromium.org/23464034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221316 0039d316-1c4b-4281-b951-d872f2087c98

BUG=236893
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23760003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221315 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=vollick@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23523027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221314 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285350

Review URL: https://chromiumcodereview.appspot.com/23620028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221313 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284547

Review URL: https://chromiumcodereview.appspot.com/23545023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221312 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276610

Review URL: https://chromiumcodereview.appspot.com/23537019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221311 0039d316-1c4b-4281-b951-d872f2087c98