- 28 Nov, 2019 40 commits
-
-
Alexandre Courbot authored
V4L2MemoryToString() returns a string constant, so change its type to const char* to save some processing and make it more generic. Bug: None Test: Chromium builds and runs for Kukui. Change-Id: I4cab66813e702493cbbce52a9956021dfdb4e818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939997 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719889}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGUseElement> and DynamicTo<SVGUseElement> as new downcast helper 2. Use IsA<SVGUseElement>(element) in place of IsSVGUseElement(element) Bug: 891908 Change-Id: Iaee4699208b6af8813ff110c385a729496b8e402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936688 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719888}
-
Yutaka Hirano authored
...due to flakiness Bug: 1029233 Change-Id: I40199a93dfe2ae3a344cc663930beeaebad87607 Tbr: karandeepb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941453Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#719887}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a5262fb3c246..a8ebb625d7f4 Created with: gclient setdep -r src-internal@a8ebb625d7f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I4b0e72e4a6f36ec04fbbadec9a977540024ecd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941085Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719886}
-
Alexandre Courbot authored
All operations on the V4L2 device should happen in the device thread. Make sure our reference to the V4L2 device is discarded there so its destructor can be called in the proper thread. Bug: None Test: VEA unittest builds and runs on Kukui in debug mode. Change-Id: I763389e7bd2946b6ff89f8dffd1e13d7fdd8211c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939995Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#719885}
-
Kuo Jen Wei authored
Remove usage of browser view which function as gallery app on non ChromeOS platform. Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I0f0c164e0a36385b4f843d2c11812e24773c492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939149 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#719884}
-
Jeremie Boulic authored
When the menu storage menu item had the focus, the color of the background was too similar to the color of the "available size" bar. Colors from UX: Used storage bar: Grey 600 #80868B Available storage bar: Grey 700 #5F6368 30% opacity Bug: 944747 Change-Id: I62c56e0388f3c9acb09d9046e0b7ab42ea2959c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940326Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#719883}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. Before this CL, ServiceWorkerContextCore manageed pairs of client UUID and a rawptr to ServiceWorkerProviderHost. This pairs were mainly used for collecting service worker client information. After this CL, ServiceWorkerContextCore manages pairs of client UUID and a rawptr to ServiceWorkerContainerHost. ServiceWorkerContainerHost is designed as a source of truth of a service worker client, and is more appropriate than ServiceWorkerProviderHost here. See the design doc for details. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Change-Id: I80fbf281c71670ef9edc12d5468ad27c9bd0b2c3 Bug: 931087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939157Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#719882}
-
Anand K. Mistry authored
Bug: 1007832 Change-Id: Icff60c942f7a0c7201f8b166e9b20d5a6d677737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930359Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#719881}
-
Jiewei Qian authored
Use flat_map::at() introduced in https://crrev.com/c/1933849 to replace find()->second, so the code reads easier. Change-Id: I4f4e04da30e6c7bb7b8f2a2f9a7e582755295b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939994 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#719880}
-
Yoshifumi Inoue authored
This patch makes {Next,Previous}OnLineInlineNG() for AXLayoutObject to utilize |NGInlineCursor| for preparation of migrating to |NGFragmentItem|. This patch also introduces |NGInlineCursor::CurrentMutableLayoutObject()| to reduce using |const_cast<LayoutObject*>()|. Bug: 982194 Change-Id: I36d5d76b266968824ecd029851737e45c740f839 Tbr: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930243 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719879}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/73beaaa48fcc..f4c5faa87b84 git log 73beaaa48fcc..f4c5faa87b84 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 663dcefa22ea..d6e903bdc9ef (4 commits) Created with: gclient setdep -r src/third_party/skia@f4c5faa87b84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: If976504affe80d43c2bdc75e13ff4f03f3b53e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941081Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719878}
-
Eric Willigers authored
BrowserNonClientFrameViewAsh::UpdateFrameColor() now includes a call to the base class implementation. On ChromeOS only, if a web app set a dark theme using HTML (as opposed to a web app manifest), web app toolbar controls such as the three dot menu did not appear as white - instead they remained dark and unreadable. Now we have consistency between platforms, and between using HTML or the manifest to set the theme color. Bug: 1028484 Change-Id: Ie222e5986cebfbca533a2cd053f9347336e2b724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940324 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#719877}
-
Greg Thompson authored
FakeAutocompleteProviderClient points an InMemoryURLIndex and a HistoryService at a ScopedTempDir that it owns. It must wait for each of them to fully process a Shutdown before it can reap the temp dir. BUG=546640 Change-Id: I4573fd3566bddbb75aec756c2ef57a2eb04e8d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940151 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719876}
-
Alexey Baskakov authored
Drive by changes: - Mark blocking I/O functions with ScopedBlockingCall objects. - Promote TaskPriority to USER_VISIBLE: icons are visible in UI. - Promote TaskShutdownBehavior to BLOCK_SHUTDOWN: Web Apps metadata is critical. This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Bug: 1029221 Change-Id: Iaec0bb4b6ec97181ec0dad2326bcd249fd6d0ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941449Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#719875}
-
Luciano Pacheco authored
Change search clear button from <span> to <cr-button> so it handles the click and key down events. Bug: 910068 Fixed: 910068 Change-Id: Ie4c19dfdfa749a502a17fbb12f873901a26acd50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939138 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#719874}
-
Anand K. Mistry authored
Fixed: 809382 Change-Id: Ibab208690072668a6527a93658e5b6f65198a378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939147Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#719873}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fa0def753f3e..dafa00edc4b3 git log fa0def753f3e..dafa00edc4b3 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 dberris@chromium.org Use the vendored node runner Created with: gclient setdep -r src/third_party/catapult@dafa00edc4b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029208 Tbr: rmhasan@google.com Change-Id: I07d209aa609257d07571ce15b0dffc6e2c655a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941431Reviewed-by:
-
Jeremie Boulic authored
browser_tests --gtest_filter="*fileDisplayLaunchOnLocalFolder" browser_tests --gtest_filter="*fileDisplayLaunchOnDrive" Bug: 1028907, 1028038 Test: Change-Id: I72e5e91a8bfc093807ccdaa4f7a29a38c73b2f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940320 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
David Benjamin authored
This is a speculative fix for the test failures in https://crbug.com/923166#c40 based on the stack in the logcat and code inspection. AndroidSystemProducer stores a raw const char* pointer passed in from many layers up the stack. In particular, the SetSystemProducerSocketAndChecksAsync function used in tests passes in producer_string.c_str() where producer_string is a std::string that was bound into a callback somewhere. This is a UAF and I suspect it is what's tripping the libc++ debugging assertion. Bug: 923166 Change-Id: Id9153009c34ef942a2d9a4b21c760c0394258f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924235 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#719870}
-
Koji Ishii authored
This reverts commit 957329b6. Reason for revert: r708894 fixed the case where hyphens are not rendered under certain conditions, but caused the infinite rewind loop in |NGLineBreaker| when there are negative margins on inline boxes. This patch reverts the fix. I will work on the new fix for the issue 1015297 after this revert. Original change's description: > [LayoutNG] Fix hyphens when rewinding occurs > > This patch removes |NGLineInfo::LineEndFragment|, which was > introduced to support hyphens and ellipsis with the single > code. However, ellipsis was changed to use different code, > and |LineEndFragment| ended up with non-optimal way to handle > hyphens. > > Although hyphens appear at most once in a line, storing this > to |NGLineInfo| makes harder to keep it in sync with the > hyphenated item. This patch changes it to a field in > |NGInlineItemResult|. > > Bug: 1015297 > Change-Id: I0706cf54bebfa967661dc40123c6dfd5887ff59c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868534 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708894} TBR=kojii@chromium.org,ikilpatrick@chromium.org Bug: 1015297, 1028817 Change-Id: I5f116288b935f3fd296f4c25c1bf0457779a8e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940323Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Noel Gordon authored
Bug: 1026943 Fixed: 1026943 Change-Id: If5241fafceb918cfeea5e317ecf1019e445cfe18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939812Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f31cb801f2cd..1bfe890bd8fc git log f31cb801f2cd..1bfe890bd8fc --date=short --first-parent --format='%ad %ae %s' 2019-11-28 tandrii@google.com bb: ask BB server to respond in JSONPB, which is much faster. Created with: gclient setdep -r src/third_party/depot_tools@1bfe890bd8fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028915,chromium:1028420,chromium:1028915 Tbr: agable@chromium.org Change-Id: I9dd24f7573a0406d89a93a7872dc69ec9189d7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941201Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 764f0674. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I02738470efadabe540449b8bd64003d7c5cb76c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941368Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719866}
-
Eric Willigers authored
The spacing around the Back and Reload buttons now matches mocks provided by UI team. When a profile indicator icon is present, we move the Back and Reload icons to the right of the profile indicator. Logic controlling the Back and Reload buttons is moved into a new nested class WebAppFrameToolbarView::NavigationButtonContainer. Bug: 1016663, 1028789 Change-Id: Ie404aa64a191228161e4590e430be2dfff4a5381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909057 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#719865}
-
Chih-Yu Huang authored
This CL moves the frame format checks from VaapiImageProcessor to ImageProcessor, because all IP implementation should verify frame format. Bug: 1028889 Test: Run image_processor_test on Kevin and Eve and no break new tests Test: Pass video_decode_accelerator on Kukui Change-Id: I3751f608785b0ee2a1087228d655405f56043c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939078 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#719864}
-
Anatoliy Potapchuk authored
Previously, you were able to do an escape via tabs.create api. Now it is not possible. Bug: 1024244 Change-Id: Ic81c202891cd504f08678db3bbf42b4a5ae1a28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914360 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719863}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I7382dc2bcb9db43e720293530949a9ea9af442ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940676Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719862}
-
Miguel Casas authored
This CL teaches EdidParser about the max, max_avg and min luminance values present in some EDID blobs, and extends the unittests accordingly. Bug: 1026688 Change-Id: Ia7051ba97852b1aca16b08dbfe82bd8f43e8b14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937660 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#719861}
-
Peter Kotwicz authored
This CL introduces a CCT/WebAPK specific RootUICoordinator - BaseCustomTabRootUiCoordinator BUG=1020324, 1015627 Change-Id: I5ec73d189cc0016cbfc73734fd27ba962d9d1fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938833 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#719860}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5abf580ff877..a5262fb3c246 Created with: gclient setdep -r src-internal@a5262fb3c246 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:995903,chromium:None Tbr: jbudorick@google.com Change-Id: Id3128b2a2ddceef3f8d520a4f8b7c63617a3a3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941202Reviewed-by:
-
Etienne Bergeron authored
This CL is adding a copy of text attributes in the layout phase. Previously, the code was keeping the styles in BreakList for |text_| and using the text indices to get them. This implies conversion between display_text_/layout_text -> text_ indices. To work correctly, the amount of codepoints need to stay the same. This assumptions is not well enforced (e.g. Eliding, Truncate, etc..). The advantage of adding the breaklist copy is that the layout styles will be kept with the same indices than the layout_text_. Also, there is no need anymore to use these functions: void ApplyCompositionAndSelectionStyles(...); void UndoCompositionAndSelectionStyles(); These functions were making a backup copy of the styles and then applying their own style modifications over it. This CL is proposing to directly applied their effects in the layout stage, therefore removing the needs of any Apply/Undo. Bug: 1025561 Change-Id: Ic664488a05a02f4d40b34b9b3eba60f6a2f59d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924954 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#719858}
-
Melissa Zhang authored
BUG=979186 Change-Id: Iae13b227d6db2276873560736b653e13def885cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940321Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719857}
-
Miyoung Shin authored
This CL converts DedicatedWorkerHostFactory mojom interface client in content and blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I3991c213428888c94b1922aabeaa1ce807e832b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935775 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#719856}
-
Leon Han authored
Because NDEFRecord#lang is supposed to be set to the document element's lang attribute in the original web page that constructs/writes this record, not in the current web page trying to construct an NDEFReadingEvent instance. This CL adds a wpt to guarantee that. BUG=520391 Change-Id: If609455d6411ee886b74ab7557292c37da41eed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930451Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#719855}
-
Austin Tankiang authored
Also some code style changes to make the code pass presubmit. Bug: 937251 Change-Id: I259d54bda0e5183c30999c6698f06761a4183e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939814Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#719854}
-
Eric Willigers authored
When a desktop PWA is launched in a window, we now record the display mode that was requested in the manifest. Bug: 1939127 Change-Id: I98b77e5eebd355add3cb38a97924fbcd457b99fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939082 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#719853}
-
Sadrul Habib Chowdhury authored
Report whether a scroll-begin/update caused the browser top-controls to move or not. Also report the end-to-end latency metrics separately for these two cases, so that it is possible to measure the impact of changing the height of the top-controls during scroll. BUG=1027129 Change-Id: I5084a439aa83999809da3a8e9419f30cd3d1a8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931922Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#719852}
-
Sergey Ulanov authored
Previously web_engine_integration_tests were using default WebEngine instance. This approach creates several issues. Particularly WebEngine that is being tested may not be the latest verstion installed on the test system. Updated the tests to use Launcher API to start a new instance of WebEngine. This approach will also allow to pass custom flags to WebEngine, which will be useful for some tests. Also fixed initialization order in ContextProviderMain Change-Id: Id6ffbd9a498fa42531193c5e9c6d01a932591ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938454 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719851}
-
Michael Spang authored
This reverts commit b7edadd9. Reason for revert: MSAN issue fixed Original change's description: > Revert "ozone: Build with xkbcommon by default on is_linux && !is_chromecast" > > This reverts commit 713420fb. > > Reason for revert: Causes MSAN failure > More details in crbug/1027853 > > Original change's description: > > ozone: Build with xkbcommon by default on is_linux && !is_chromecast > > > > This is necessary on Linux targets unless you don't want keyboard > > support or only need support for a hardcoded US layout. > > > > Noticed because the CQ broke after building for ozone locally. This > > reduces the number of flags needed to build as the Linux Ozone builder > > does. > > > > Bug: 1026476 > > > > Change-Id: I77352c133b1f7552301b6e1f252d40a4f2c72106 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925370 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org> > > Commit-Queue: Michael Spang <spang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718240} > > TBR=sky@chromium.org,spang@chromium.org,kpschoedel@chromium.org > > Change-Id: I4fa0de1881acbf1eaf7e70bfe4b24dbc84647f43 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1026476 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932436 > Reviewed-by: Tim Schumann <tschumann@chromium.org> > Commit-Queue: Tim Schumann <tschumann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718445} TBR=sky@chromium.org,spang@chromium.org,kpschoedel@chromium.org,tschumann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1026476, 1027853 Change-Id: I4f601a169bd5d18714a1a78ca8cacd0b43939afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941277Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719850}
-
